- 13 Oct, 2020 3 commits
-
-
Jonah Williams authored
All of the network requests from google cloud storage include an x-goog-hash header which contains an MD5 checksum. If present, use to validate that the downloaded binary is valid. This will rule out corrupt files as the cause of getting started crashers in the flutter_tool. #38980 This does not fully resolve the above issue, because while we can check if the checksum matches what was expected from cloud storage, this A) may not necessarily be present and B) may not match up to what should be uploaded as part of the engine build process. But when life gives you lemons you hash those lemons using an outdated hashing algorithm.
-
Jonah Williams authored
-
Jonah Williams authored
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation. A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered? (9a3a0dc1 caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
-
- 12 Oct, 2020 36 commits
-
-
Shi-Hao Hong authored
Migrates the following files to NNBD: * input_decorator_test.dart * list_tile_test.dart * localizations_test.dart * material_button_test.dart * material_state_property_test.dart * material_test.dart * mergeable_material_test.dart
-
Shi-Hao Hong authored
* Expose date symbols and patterns for en_US in framework
-
Jonah Williams authored
This reverts commit da58f5e6.
-
Miguel Beltran authored
-
Jonah Williams authored
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool (#67957)" (#67968) This reverts commit bd813879.
-
Jonah Williams authored
According to https://dart.dev/tools/pub/pubspec#name , uppercase is not permitted for package names.
-
Jonah Williams authored
Reland of #67669 The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. So that we can adjust/modify this logic, fold it into flutter and add some additional logging. caches the resolved executable per target directory, to avoid repeated look ups. Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found Accept files or symlinks for the executable path. user where/which to resolve path instead of package:process logic.
-
Jonah Williams authored
-
Dan Field authored
-
Hans Muller authored
-
Kate Lovett authored
-
Anurag Roy authored
Exposes contentPadding property for RadioListTile from its appropriate ListTile.
-
Michael Goderbauer authored
-
LongCatIsLooong authored
-
xubaolin authored
-
Jonah Williams authored
On every hot reload, the flutter tool must file stat each asset in the bundle. With a large number of assets or a slow file system, this can take 20 - 30 ms. Do this operation while the flutter tool is waiting for a response from the frontend_server. No tests updated since this is only a timing update. Any difference in behavior will be shown on benchmarks
-
Jonah Williams authored
This reverts commit 10c78c26.
-
Jonah Williams authored
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
-
Jonah Williams authored
Fixes #61772 tool exit if there is no file at the path provided when building/running with sksl
-
Jonah Williams authored
Work towards #39925 Currently flutter run will uninstall and reinstall if the initial install fails and the APK was previously installed. Allow drive to share this same logic by moving it into installApp and out of startApp. This should reduce the occurrence of the error in the devicelab.
-
Sergey Solodukhin authored
-
Darren Austin authored
-
nturgut authored
-
Michael Goderbauer authored
-
Jonah Williams authored
This failure has been happening for a while but was covered by the overly broad catch. Removing that revealed that newer intellij versions have a different plugins file. The tool still can't find the file, but it won't crash now Fixes #67918
-
Per Classon authored
-
Justin McCandless authored
Just another nnbd conversion PR.
-
Sam Rawlins authored
-
Jonah Williams authored
In case different powershell module is installed over the default name. Fixes #22896
-
nturgut authored
-
Jonah Williams authored
For historical reasons, the flutter tool uploads dill files to paths based on the entrypoint URI. This isn't actually necessary, and the tool can use specific files : main.dart.incremental.dill for incremental dills, and main.dart.dill/main.dart.swap.dill for full dills. This allows hot restarting applications with an entrypoint outside of lib/ and simplifies the devFS code. Fixes #63243
-
xubaolin authored
-
chunhtai authored
-
Jonah Williams authored
HACKTOBERFEST
-
xubaolin authored
* Fix ListTile assert when layout at zero size #66636
-
xubaolin authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-