1. 13 Oct, 2020 3 commits
    • Jonah Williams's avatar
      [flutter_tools] verify checksum of downloaded artifacts (#67839) · ac751cc5
      Jonah Williams authored
      All of the network requests from google cloud storage include an x-goog-hash header which contains an MD5 checksum. If present, use to validate that the downloaded binary is valid. This will rule out corrupt files as the cause of getting started crashers in the flutter_tool.
      
      #38980
      
      This does not fully resolve the above issue, because while we can check if the checksum matches what was expected from cloud storage, this A) may not necessarily be present and B) may not match up to what should be uploaded as part of the engine build process.
      
      But when life gives you lemons you hash those lemons using an outdated hashing algorithm.
      ac751cc5
    • Jonah Williams's avatar
      remove missing argument (#67974) · eb24393e
      Jonah Williams authored
      eb24393e
    • Jonah Williams's avatar
      [flutter_tools] attempt to stabilize hot restart benchmark the old fashioned way (#67971) · 5dfe7e6d
      Jonah Williams authored
      A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation.
      
      A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered?
      
      (9a3a0dc1 caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
      5dfe7e6d
  2. 12 Oct, 2020 36 commits
  3. 10 Oct, 2020 1 commit