Commits · ac50921309a2e8392658226ac6fc2df0afa71275 · abdullh.alsoleman / Front-End

16 Nov, 2023 7 commits

Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (#138546) · ac509213

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/2e9f0df868b3...0c57a50810e8

2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 5cccc24d127f to b512191e9612 (1 revision) (flutter/engine#48120)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ac509213

Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (#138543) · 53a57adc

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/8ab189b77b8d...2e9f0df868b3

2023-11-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AuDKY8ob6GrGwDlmk... to M0zM3CJLIrd5lb0u0... (flutter/engine#48115)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from AuDKY8ob6GrG to M0zM3CJLIrd5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53a57adc

Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (#138533) · 3b1b3cb3

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/622fa0614412...8ab189b77b8d

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 2642516e7de7 to 2fe70dd9cbf8 (1 revision) (flutter/engine#48114)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b1b3cb3

[flutter_tools] - Add `queries` section to Android manifest file (#137207) · dcdf72a6

Bruno Leroux authored Nov 16, 2023

## Description

This PR adds a new section to the Android manifest file.
This section is required for https://github.com/flutter/engine/pull/44579 (because it uses `PackageManager.queryIntentActivities` API ), see:

1. https://developer.android.com/training/package-visibility?hl=en
2. https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT
3. https://developer.android.com/reference/android/content/pm/PackageManager?hl=en#queryIntentActivities(android.content.Intent,%20android.content.pm.PackageManager.ResolveInfoFlags)

## Related Issue

Android manifest update for https://github.com/flutter/flutter/issues/107603

## Tests

This PR updates the integration tests and examples Android manifest files, this will help catch error or warning related to this change.

dcdf72a6

Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (#138532) · 76f7d2d9

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/8aff9c134b8f...622fa0614412

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from add865f891c8 to 2642516e7de7 (1 revision) (flutter/engine#48112)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

76f7d2d9

Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (#138529) · 396cd713

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/3cfcdebe8623...8aff9c134b8f

2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc6acfd7d57c to 5cccc24d127f (1 revision) (flutter/engine#48109)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 5d6bdbf69dea to add865f891c8 (1 revision) (flutter/engine#48108)
2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to cc6acfd7d57c (5 revisions) (flutter/engine#48100)
2023-11-16 matanlurey@users.noreply.github.com Make `fml/status_or.h` compatible with `.clang_tidy`. (flutter/engine#48002)
2023-11-16 dnfield@google.com [Impeller] Gate Vulkan selection on API 29 (flutter/engine#48089)
2023-11-16 chris@bracken.jp [macOS] Clean up allocations in menu plugin test (flutter/engine#48093)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `fml/...` compatible with `.clang_tidy` (flutter/engine#48030)
2023-11-15 ychris@google.com [ios] introduce weak_nsobject (flutter/engine#47947)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from e954d1a1972c to 5d6bdbf69dea (2 revisions) (flutter/engine#48094)
2023-11-15 jonahwilliams@google.com [Impeller] add async command submission for blit pass. (flutter/engine#48040)
2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/compositing/...` compatible with `.clang_tidy`. (flutter/engine#48001)
2023-11-15 godofredoc@google.com Remove the linux fuchsia v1 build. (flutter/engine#48085)
2023-11-15 mdebbar@google.com [web] Apply global styles before inserting the DOM element (flutter/engine#48027)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from b23074a79bda to e954d1a1972c (7 revisions) (flutter/engine#48092)
2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`." (flutter/engine#48083)
2023-11-15 41930132+hellohuanlin@users.noreply.github.com [ios]fix ios 16 auto correction highlight showing on top left corner (flutter/engine#47279)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from c42226314a4f to b23074a79bda (3 revisions) (flutter/engine#48081)
2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`. (flutter/engine#48000)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

396cd713

Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (#138515) · 9baa5392
engine-flutter-autoroll authored Nov 16, 2023

9baa5392

15 Nov, 2023 23 commits

Catch error for missing directory in `FontConfigManager` (#138496) · 04afff38

Elias Yishak authored Nov 15, 2023

Closes:
- https://github.com/flutter/flutter/issues/138434

We will catch any errors while attempting to clear the temp directories that don't exist for the `FontConfigManager` class

04afff38

Make `UnderlineInputBorder` consistent (#124153) · 2afec776

Bernardo Ferrari authored Nov 15, 2023

This was easy to implement. I like the result, I think `borderRadius.zero` -> `borderRadius.circular` makes a nice transition, and many places (like macOS) use an effect similar to this PR, while Google doesn't use anywhere (yet). I'm curious if it is going to break goldens or google testing.

<img width="954" alt="ttt" src="https://user-images.githubusercontent.com/351125/229918871-9f2ab851-6b41-44f5-80b9-c7928a8c0014.png">

What do you think? cc @HansMuller @gspencergoog. Is this something you want, should I ask the community, or do you prefer the current one?

Side effects:
- This makes strokeAlign work with `UnderlineInputBorder` (TODO: fix `drawLine` when borderRadius is zero).
- This is faster than the current implementation (clip is slow on Skia). ð 
- We could just call `BoxBorder._paintNonUniformBorder` (if it weren't private). Single LOC implementation.
- Web does this by default:
![image](https://user-images.githubusercontent.com/351125/233448671-90ce62ff-be91-40ca-8007-e82b57f3272e.png)
- Apparently no tests fail and most usages around (via code search) seem to be without a borderRadius.

2afec776

Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent`... · f796e62c
Greg Spencer authored Nov 15, 2023
```
Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent` from `RawKeyEvent`. (#136854)
```
f796e62c

Pin package:web 0.4.0 (#138428) · d8ffc739

Srujan Gaddam authored Nov 15, 2023

This version is needed so that dart:js_interop can move to extension
types. Also adds some code to handle some breaking changes:

- Body -> Response. Body was an IDL interface mixin type we exposed in
dart:html. Going forward, users should either use Request or Response.
- Casts to JSAny. These are temporary until we move package:web types to
extension types. Currently, package:web types can't implement JSObject
as JSObject will move to be an extension type itself.
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>

d8ffc739

Reverts "Reland VelocityTracker update (#132291)" (#138512) · 82a7a62b

auto-submit[bot] authored Nov 15, 2023

Reverts flutter/flutter#137381
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728

82a7a62b

[web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (#138498) · 46528858

Yegor authored Nov 15, 2023

Skipping the test due to
https://github.com/flutter/flutter/issues/137669. It's not clear which
PR started it, so we can't revert anything, and the fix is not yet clear
either. However, the flakiness is very high and is disruptive to the
Flutter team.

46528858

Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (#138502) · ca31aa17

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/7c2b8d520b3d...30327eae0802

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1f23a0b74619 to c42226314a4f (2 revisions) (flutter/engine#48075)
2023-11-15 gspencergoog@users.noreply.github.com Update keycode output (flutter/engine#47988)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca31aa17

Reland VelocityTracker update (#132291) (#137381) · 1ac73332

Kate Lovett authored Nov 15, 2023

This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728

1ac73332

Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (#138499) · 7f3f52f0

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/f58dac64ad1a...7c2b8d520b3d

2023-11-15 jason-simmons@users.noreply.github.com In the scenario game loop test, cancel the results writer task if the activity has been destroyed (flutter/engine#48051)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f3f52f0

Fix 2D tap to stop scrolling (#138442) · cf18d250

Kate Lovett authored Nov 15, 2023

Adopted from https://github.com/flutter/flutter/pull/133750
That PR was abandoned. This finishes it up so we can land it.
Fixes https://github.com/flutter/flutter/issues/133529

Moves the `PanGestureRecognizer` used to drag the content along both axis to the outer vertical `Scrollable` subclass instead of the inner horizontal `Scrollable` subclass.

- This solves the issue of the inner `Scrollable` gestures being disabled while the outer `Scrollable` is scrolling
- Enables the user to stop the scroll movement by dragging the content again

cf18d250

Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (#138494) · 47207506

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/d22d063ac9f6...f58dac64ad1a

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 3b7a62e2ac3f to 1f23a0b74619 (1 revision) (flutter/engine#48074)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1abce6b0a763 to 3b7a62e2ac3f (2 revisions) (flutter/engine#48071)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47207506

SemanticOwner should dispatch creation and disposal events (#138388) · 684980e9
Binni Goel authored Nov 15, 2023

684980e9

Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (#138489) · 0f42d194

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/ecaf9442034d...d22d063ac9f6

2023-11-15 zanderso@users.noreply.github.com Reverts Dart to 3.3.0-135.0.dev (flutter/engine#48070)
2023-11-15 mdebbar@google.com [web] Move `EmbeddingStrategy` and `DimensionsProvider` out of `FlutterViewEmbedder` (flutter/engine#48025)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from d0e4a53f56f5 to 1abce6b0a763 (3 revisions) (flutter/engine#48067)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 849fd6ccc339 to 002e66832465 (1 revision) (flutter/engine#48065)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to 849fd6ccc339 (1 revision) (flutter/engine#48060)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0f42d194

Roll Packages from 428ba3e24532 to 0cd23780741d (1 revision) (#138482) · cffa6549

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/packages/compare/428ba3e24532...0cd23780741d

2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter from f6621502 to e8c2bb13 (66 revisions) (flutter/packages#5399)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cffa6549

Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (#138472) · defa2b74

Flutter GitHub Bot authored Nov 15, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_android hot_mode_dev_cycle__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/138072 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20hot_mode_dev_cycle__benchmark%22).
This test can be marked as unflaky.

defa2b74

Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (#138468) · bf389357

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/a7a48a68e6f8...ecaf9442034d

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 2f2c74633e0f to d0e4a53f56f5 (1 revision) (flutter/engine#48059)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf389357

Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (#138463) · 35132072

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/976edd5192d1...a7a48a68e6f8

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from a701a64f1ba9 to 2f2c74633e0f (1 revision) (flutter/engine#48058)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f1322227bdf to 65819963fb17 (2 revisions) (flutter/engine#48056)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 5778a54af88d to a701a64f1ba9 (1 revision) (flutter/engine#48055)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35132072

Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (#138462) · 68633f70

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/a7f2267dd1f4...976edd5192d1

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 0d9175bb5cfa to 5778a54af88d (1 revision) (flutter/engine#48052)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68633f70

Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (#138459) · a930fd8e

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/bc5bbd3b9ebe...a7f2267dd1f4

2023-11-15 chris@bracken.jp [macOS] Clean up allocations in key responder tests (flutter/engine#48048)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a930fd8e

Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (#138457) · cfdc6c58

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/d7ca057b891f...bc5bbd3b9ebe

2023-11-15 ditman@gmail.com [web] JSConfig: Add multiViewEnabled value. (flutter/engine#47939)
2023-11-15 jonahwilliams@google.com [Impeller] Simplify convex tessellation (flutter/engine#47957)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cfdc6c58

Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (#138456) · 3f910e89

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/1347413470b7...d7ca057b891f

2023-11-15 jacksongardner@google.com Use flutter.js in the actual test harness. (flutter/engine#47670)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3f910e89

Roll Flutter Engine from c5a067b637f4 to 1347413470b7 (5 revisions) (#138452) · 961f955a

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/c5a067b637f4...1347413470b7

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 0f6a4e6a3b51 to 0d9175bb5cfa (1 revision) (flutter/engine#48045)
2023-11-15 godofredoc@google.com Migrate fuchsia to engine v2 builds. (flutter/engine#48042)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from bd8546dab41c to 0f6a4e6a3b51 (2 revisions) (flutter/engine#48043)
2023-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 6219f11bf0fb to 6f1322227bdf (6 revisions) (flutter/engine#48039)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 15a2577b12c1 to bd8546dab41c (1 revision) (flutter/engine#48037)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

961f955a

Reland [SingleChildScrollView] Correct the offset pixels if it is out of range... · c3f45240

xubaolin authored Nov 15, 2023

Reland [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (#136871)

Reland https://github.com/flutter/flutter/pull/136239 which was reverted by https://github.com/flutter/flutter/pull/136744
Fixes https://github.com/flutter/flutter/issues/105733
FIxes https://github.com/flutter/flutter/issues/135865

Do not merge before the customer finish the migration. @Piinks

c3f45240

14 Nov, 2023 10 commits

Add to TableCell docs (#138258) · 98827bb5

Kate Lovett authored Nov 14, 2023

Fixes https://github.com/flutter/flutter/issues/42523
Came across a trivial doc issue - now it will be fixed. ð

98827bb5

Roll Flutter Engine from f15b259fe98c to c5a067b637f4 (4 revisions) (#138441) · ec16ef78

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/f15b259fe98c...c5a067b637f4

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 650913eacd01 to 15a2577b12c1 (1 revision) (flutter/engine#48036)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 6feae2c274ce to 650913eacd01 (1 revision) (flutter/engine#48034)
2023-11-14 chris@bracken.jp [macOS] Eliminate unused OCMock includes (flutter/engine#48031)
2023-11-14 41930132+hellohuanlin@users.noreply.github.com [ios17][text_input]fix ios 17.0 keyboard freeze when switching languages (without relying on text affinity) (flutter/engine#47566)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ec16ef78

Bump dessant/lock-threads from 4.0.1 to 5.0.0 (#138437) · 39190892

dependabot[bot] authored Nov 14, 2023

Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 4.0.1 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<p>Learn more about this release from the <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/absolute-version/commit-and-tag-version">commit-and-tag-version</a> for commit guidelines.</p>
<h2><a href="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a> (2023-11-14)</h2>
<h3>â  BREAKING CHANGES</h3>
<ul>
<li>Discussions are also processed by default,
set the <code>process-only</code> input parameter to preserve the old behavior</li>
</ul>
<pre lang="yaml"><code>    steps:
      - uses: dessant/lock-threads@v5
        with:
          process-only: 'issues, prs'
</code></pre>
<ul>
<li>the action now requires Node.js 20</li>
</ul>
<h3>Features</h3>
<ul>
<li>lock discussions (<a href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764">0a0976f</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67">5a25b54</a>)</li>
</ul>
<h3><a href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a> (2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a href="https://github.com/dessant/lock-threads/commit/1618e91da69b9fe614fb9837ac673ea4600eb529">1618e91</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a> (2022-12-04)</h2>
<h3>â  BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="https://github.com/dessant/lock-threads/commit/38e918558115222435d26c0639870cdbe3572929">38e9185</a>)</li>
<li>update docs (<a href="https://github.com/dessant/lock-threads/commit/32986e26965060a85db09e98ef7e5958c961ae84">32986e2</a>)</li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0">3.0.0</a> (2021-09-27)</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dessant/lock-threads/commit/d42e5f49803f3c4e14ffee0378e31481265dda22"><code>d42e5f4</code></a> chore(release): 5.0.0</li>
<li><a href="https://github.com/dessant/lock-threads/commit/d8da6c1485cbe748b5b632f1a52cf2a52941cbf9"><code>d8da6c1</code></a> chore: update package</li>
<li><a href="https://github.com/dessant/lock-threads/commit/c1eab4b45f97073a922fbd226afab0e34a70cf5f"><code>c1eab4b</code></a> chore: update workflow</li>
<li><a href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764"><code>0a0976f</code></a> feat: lock discussions</li>
<li><a href="https://github.com/dessant/lock-threads/commit/53f3f0c0b9158bece84746885adc5f4bf2dd1ddc"><code>53f3f0c</code></a> chore: migrate package to ESM</li>
<li><a href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67"><code>5a25b54</code></a> fix: update dependencies</li>
<li>See full diff in <a href="https://github.com/dessant/lock-threads/compare/be8aa5be94131386884a6da4189effda9b14aa21...d42e5f49803f3c4e14ffee0378e31481265dda22">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dessant/lock-threads&package-manager=github_actions&previous-version=4.0.1&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

39190892

Bump github/codeql-action from 2.22.5 to 2.22.6 (#138438) · 72080e60

dependabot[bot] authored Nov 14, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.5 to 2.22.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/689fdc5193eeb735ecb2e52e819e3382876f93f4"><code>689fdc5</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1990">#1990</a> from github/update-v2.22.6-8c8c7b4d8</li>
<li><a href="https://github.com/github/codeql-action/commit/33bfd1de925b3298f55b5df9d048a50f99ec63ec"><code>33bfd1d</code></a> Update changelog for v2.22.6</li>
<li><a href="https://github.com/github/codeql-action/commit/8c8c7b4d80b1c936356d9e6eafb7622e3d5c07bd"><code>8c8c7b4</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1979">#1979</a> from github/aeisenberg/python-on-mac</li>
<li><a href="https://github.com/github/codeql-action/commit/64981bbb5a43eb8447be59c3b591d131e3d91f2d"><code>64981bb</code></a> Merge branch 'main' into aeisenberg/python-on-mac</li>
<li><a href="https://github.com/github/codeql-action/commit/e280207df7e8a23a01921824ff65d5e476d97df3"><code>e280207</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1978">#1978</a> from github/update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="https://github.com/github/codeql-action/commit/e46740a99e0ff2eb0aac8fa7674cdbdd0cef0716"><code>e46740a</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="https://github.com/github/codeql-action/commit/6abf8569a19e2664b102b72b0ef9dd9f9a57a6ab"><code>6abf856</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1984">#1984</a> from github/aeisenberg/fix-debug-integration-tests</li>
<li><a href="https://github.com/github/codeql-action/commit/59252d9bfb0e66fde481d0102f2920f096385899"><code>59252d9</code></a> Update setup-swift deficiency compensation</li>
<li><a href="https://github.com/github/codeql-action/commit/dcf348a0d38952308a445163e94992084ed53799"><code>dcf348a</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.2</li>
<li><a href="https://github.com/github/codeql-action/commit/82284f1b28654cb1dcfe26b6c02e0636ee633a07"><code>82284f1</code></a> Fix failing workflows</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/74483a38d39275f33fcff5f35b679b5ca4a26a99...689fdc5193eeb735ecb2e52e819e3382876f93f4">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.5&new-version=2.22.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

72080e60

Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (#138429) · dfa694ec

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/eba757803a6f...f15b259fe98c

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 63037925e344 to 6feae2c274ce (1 revision) (flutter/engine#48033)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dfa694ec

Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (#138425) · 3df477d0

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/603bdd48df8a...eba757803a6f

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 5fbacd5d68a5 to 63037925e344 (1 revision) (flutter/engine#48028)
2023-11-14 john@johnmccutchan.com Revert "Add an AndroidManifest.xml flag to disable ImageReader backend Platform Views (#46430)" (flutter/engine#48024)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from ce88be2adf67 to 5fbacd5d68a5 (1 revision) (flutter/engine#48026)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3df477d0

Unified analytics migration for `CodeSizeAnalysis` (#138351) · d5b67035

Elias Yishak authored Nov 14, 2023

Part of tracker issue:
- https://github.com/flutter/flutter/issues/128251

This migrates the event being sent when the "--analyze-size" is used in a flutter invocation

The only file that had this event being sent from is `packages/flutter_tools/lib/src/base/analyze_size.dart`

d5b67035

Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (#138421) · 44990867

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/777dcb99f6e0...603bdd48df8a

2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from a811132be321 to ce88be2adf67 (1 revision) (flutter/engine#48022)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44990867

Run all tests in examples/ (#138374) · 0a0adf7c

Michael Goderbauer authored Nov 14, 2023

https://github.com/flutter/flutter/pull/138253 demonstrated that the tests for the textures example weren't actually running on CI. This changes the testing script to execute the tests for everything inside the `examples` directory.

0a0adf7c

Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (#138420) · 7f6842cd

engine-flutter-autoroll authored Nov 14, 2023

https://github.com/flutter/engine/compare/1b3fd80812c3...777dcb99f6e0

2023-11-14 mdebbar@google.com [web] Explicit initialization of the implicit view (flutter/engine#47921)
2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from b7d581997f2b to a811132be321 (1 revision) (flutter/engine#48019)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f6842cd