1. 24 Jan, 2023 1 commit
  2. 31 Oct, 2022 1 commit
  3. 05 Aug, 2022 1 commit
  4. 31 May, 2022 1 commit
    • Greg Spencer's avatar
      Switch debugAssertNotDisposed to be a static (#104772) · 16b73481
      Greg Spencer authored
      This reverts part of the change made in #103456 to expose a debug check for subclasses of ChangeNotifier to avoid code duplication. Instead of making debugAssertNotDisposed a public instance function, it is now a public static function. It makes it harder to call, slightly, but it means that everyone who implemented ChangeNotifier instead of extending it doesn't get broken.
      16b73481
  5. 26 May, 2022 1 commit
  6. 19 May, 2022 1 commit
    • Greg Spencer's avatar
      Add ShortcutsRegistry (#103456) · f6c3ee31
      Greg Spencer authored
      This adds a ShortcutsRegistry for ShortcutActivator to Intent mappings that can be modified from its descendants.
      
      This is so that descendants can make shortcuts dynamically available to a larger portion of the app than just their descendants. This is a precursor needed by the new MenuBar, for instance, so that the menu bar itself can be placed where it likes, but the shortcuts it defines can be in effect for most, if not all, of the UI surface in the app. For example, the "Ctrl-Q" quit binding would need to work even if the focused widget wasn't a child of the MenuBar.
      
      This just provides the shortcut to intent mapping, the actions activated by the intent are described in the context where they make sense. For example, defining a "Ctrl-C" shortcut mapped to a "CopyIntent" should perform different functions if it happens while a TextField has focus vs when a drawing has focus, so those different areas would need to define different actions mapped to "CopyIntent". A hypothetical "QuitIntent" would probably be active for the entire app, so would be mapped in an Actions widget near the top of the hierarchy.
      f6c3ee31
  7. 14 Apr, 2022 1 commit
  8. 22 Feb, 2022 1 commit
  9. 03 Feb, 2022 1 commit
  10. 15 Dec, 2021 1 commit
  11. 04 Oct, 2021 1 commit
    • Greg Spencer's avatar
      Clean up examples, remove section markers and --template args (#91133) · fd9ce277
      Greg Spencer authored
      This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder.
      
      I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed.
      
      I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
      fd9ce277
  12. 15 Jul, 2021 1 commit
  13. 14 Jul, 2021 3 commits
  14. 13 Jul, 2021 2 commits
  15. 10 May, 2021 1 commit
  16. 31 Mar, 2021 2 commits
  17. 12 Mar, 2021 1 commit
  18. 06 Mar, 2021 1 commit
  19. 11 Dec, 2020 1 commit
  20. 12 Nov, 2020 1 commit
  21. 02 Nov, 2020 1 commit
  22. 21 Oct, 2020 1 commit
  23. 02 Oct, 2020 1 commit
  24. 15 Sep, 2020 1 commit
    • Alexandre Ardhuin's avatar
      Reland "Nnbd widgets" (#65528) · b007a81a
      Alexandre Ardhuin authored
      * Reland "Nnbd widgets (#64672)"
      
      This reverts commit 127e6790.
      
      * remove non-nullable enforcement on AsyncSnapshot
      
      * make data param non-nullable for AsyncSnapshot.withData
      
      * make some Text params non-nullable
      b007a81a
  25. 09 Sep, 2020 2 commits
    • Michael Goderbauer's avatar
      Revert "Nnbd widgets (#64672)" (#65488) · 127e6790
      Michael Goderbauer authored
      This reverts commit e682ec71.
      127e6790
    • Alexandre Ardhuin's avatar
      Nnbd widgets (#64672) · e682ec71
      Alexandre Ardhuin authored
      * migrate widget to nullsafety
      
      * remove double blank line after license
      
      * address review comments in actions.dart
      
      * nullable ObjectKey.value
      
      * use local variable oldElement
      
      * make State.build non-nullable
      
      * make State.context non-nullable
      
      * newline at eof
      
      * make ProxyWidget.child non-nullable
      
      * make _InactiveElements.debugContains non-nullable
      
      * make Element.depth non-nullable
      
      * make ProxyElement.build non-nullable
      
      * make StatefulElement.state non-nullable
      
      * remove 'Notice that'
      
      * avoid cast of list in RenderObjectElement.updateChildren
      
      * make IndexedSlot.value non-nullable
      
      * avoid cast of list in MultiChildRenderObjectElement.mount
      
      * make some WidgetsApp parameters non-nullable
      
      * hitTest take non-nullable position
      
      * make ScrollableState.position non-nullable
      
      * use _pixels instead of pixels
      
      * make ViewportOffset.pixels non-nullable
      
      * make param and return type of IndexedWidgetBuilder non-nullable
      
      * unused_import
      
      * make context param non-nullable for Builder in animated_list.dart
      
      * make ScrollMetrics.viewportDimension non-nullable
      
      * make ScrollMetrics.{min,max}ScrollExtent non-nullable
      
      * make _Location.file non-nullable
      
      * _WidgetForTypeTests.createElement throw UnimplementedError
      
      * update _NullWidget.build error message
      
      * make _ShortcutsState.manager non-nullable
      
      * Fix childCount issues for NNBD
      
      * fix childCount computation on web
      
      * increase max value on js side to compute childCount
      
      * make aspect parameter of dependOnInheritedWidgetOfExactType nullable
      
      * merge has{min,max}ScrollExtent into hasScrollExtents
      
      * update focus_manager.dart
      
      * address review comments in icon.dart
      
      * address review comments in image.dart
      
      * address review comments in routes.dart
      
      * address review comments in scroll_activity.dart
      
      * update doc comments
      
      * make UserScrollNotification.direction non-nullable and required
      
      * rename hasScrollExtents to hasContentDimensions
      
      * unnecessary late
      Co-authored-by: 's avatarIan Hickson <ian@hixie.ch>
      e682ec71
  26. 13 Aug, 2020 1 commit
  27. 11 Aug, 2020 1 commit
  28. 29 Jul, 2020 1 commit
  29. 28 Jul, 2020 1 commit
    • Michael Goderbauer's avatar
      Restoration Framework (#60375) · 175e5c9a
      Michael Goderbauer authored
      * state restoration
      
      * added example
      
      * typos and analyzer
      
      * whitespace
      
      * more typos
      
      * remove unnecessary import
      
      * whitespace
      
      * fix sample code
      
      * tests for restorationmanager and restorationid
      
      * ++
      
      * typo
      
      * tests for bucket, part1
      
      * rename tests
      
      * more tests
      
      * finished tests for service layer
      
      * remove wrong todo
      
      * ++
      
      * review comments
      
      * tests for Unmanaged and regular scope
      
      * RootRestorationScope tests
      
      * typo
      
      * whitespace
      
      * testing framework
      
      * tests for properties
      
      * last set of tests
      
      * analyzer
      
      * typo
      
      * dan review
      
      * whitespace
      
      * ++
      
      * refactor finalizers
      
      * ++
      
      * ++
      
      * dispose guard
      
      * ++
      
      * ++
      
      * dan review
      
      * add manager assert
      
      * ++
      
      * analyzer
      
      * greg review
      
      * fix typo
      
      * Ian & John review
      
      * ian review
      
      * RestorationID -> String
      
      * revert comment
      
      * Make primitives non-nullable in prep for NNBD
      175e5c9a