Commits · ab10e2b1dd1926a84f7dd35c0a8357074d84a28b · abdullh.alsoleman / Front-End

01 Mar, 2024 8 commits

Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (#144455) · ab10e2b1

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/76140bc9cec9...f68cc57cbe12

2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix leak of rectangle packer in typographer tests (flutter/engine#51113)
2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 01d9566c4db8 to 5961ed9c1d99 (13 revisions) (flutter/engine#51106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab10e2b1

Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (#144453) · 7d5dabab

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/f300ced56a4e...76140bc9cec9

2024-03-01 zanderso@users.noreply.github.com Run apple SDK finders as gclient hooks (flutter/engine#50957)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7d5dabab

Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (#144452) · af4d327a

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/34cf95c7bd82...f300ced56a4e

2024-03-01 matanlurey@users.noreply.github.com Add a basic e2e-test for `skia_gold_client`. (flutter/engine#51078)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

af4d327a

Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (#144450) · a78a0d59

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/0db468f7bae5...34cf95c7bd82

2024-03-01 john@johnmccutchan.com Add et run command (flutter/engine#51037)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a78a0d59

Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (#144448) · e601f047

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/6f8044436eb3...0db468f7bae5

2024-03-01 34871572+gmackall@users.noreply.github.com Add instructions for getting code coverage in Android Studio (flutter/engine#51105)
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 139461270500 to 01d9566c4db8 (1 revision) (flutter/engine#51093)
2024-02-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from fdf4a62bd07b to 728fcf0bcbca (3 revisions) (flutter/engine#51098)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e601f047

Remove master from API docs (#144425) · 52bb198f
Michael Goderbauer authored Mar 01, 2024

52bb198f
Enable missing-code-block-language (#144443) · 6995275b
Michael Goderbauer authored Mar 01, 2024

6995275b

Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (#144436) · 8e418d18

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/7e8fefe4a084...6f8044436eb3

2024-02-29 jonahwilliams@google.com [Impeller] use specific format for bootstrap texture. (flutter/engine#51082)
2024-02-29 jonahwilliams@google.com [Impeller] remove warning about device transient depth+stencil. (flutter/engine#51033)
2024-02-29 robert.ancell@canonical.com Refactor GL rendering to prepare for GTK4 (flutter/engine#50754)
2024-02-29 jacksongardner@google.com Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077)
2024-02-29 matej.knopp@gmail.com Revert "[macOS] Use CVDisplayLink to drive repaint (#49159)" (flutter/engine#51095)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e418d18

29 Feb, 2024 32 commits

Bump github/codeql-action from 3.24.5 to 3.24.6 (#144424) · fe56a356

dependabot[bot] authored Feb 29, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.5 to 3.24.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li>
<li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li>
</ul>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/8a470fddafa5cbb6266ee11b37ef4d8aae19c571"><code>8a470fd</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2176">#2176</a> from github/update-v3.24.6-158d0780d</li>
<li><a href="https://github.com/github/codeql-action/commit/d59eafb69b1bbf6ebc4592895da945a4cc588806"><code>d59eafb</code></a> Update changelog for v3.24.6</li>
<li><a href="https://github.com/github/codeql-action/commit/158d0780dc10ed5108b9fb567ea80a54c245dd67"><code>158d078</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2175">#2175</a> from github/henrymercer/fix-languages-init-success</li>
<li><a href="https://github.com/github/codeql-action/commit/2307ff547f1c8a003d306eede350ccff46e0e65d"><code>2307ff5</code></a> Add <code>languages</code> and <code>build_mode</code> to <code>init</code> <code>success</code> status report</li>
<li><a href="https://github.com/github/codeql-action/commit/ccd3f0254505d3abf6b996df24b8cc9a0d77c98f"><code>ccd3f02</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2173">#2173</a> from github/henrymercer/mark-third-party-limits-erro...</li>
<li><a href="https://github.com/github/codeql-action/commit/c0917251d4d0392e762284c11e2c9c1b82195af1"><code>c091725</code></a> Refactoring: Convert <code>ActionName</code> to enum</li>
<li><a href="https://github.com/github/codeql-action/commit/e12a8cc5eb90431cfed6096ac78c48448b5cf331"><code>e12a8cc</code></a> Use <code>isFirstPartyAnalysis</code> for a stronger check</li>
<li><a href="https://github.com/github/codeql-action/commit/888ab31e3edfe95e943195e117426658cc6a3802"><code>888ab31</code></a> Mark third-party SARIF limits errors as configuration errors</li>
<li><a href="https://github.com/github/codeql-action/commit/bd56a05133734527a524799b550f71febf4597b9"><code>bd56a05</code></a> Rename <code>InvalidRequestError</code> to <code>InvalidSarifUploadError</code></li>
<li><a href="https://github.com/github/codeql-action/commit/7bde9061b48b68e993ca909411613cf15bd12708"><code>7bde906</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2172">#2172</a> from github/henrymercer/fix-readme-typos</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/47b3d888fe66b639e431abf22ebca059152f1eea...8a470fddafa5cbb6266ee11b37ef4d8aae19c571">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.5&new-version=3.24.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

fe56a356

Reland [a11y] Fix date picker cannot focus on the edit field (#144198) · 14b914ab

hangyu authored Feb 29, 2024

reland https://github.com/flutter/flutter/pull/143117 


fixes: https://github.com/flutter/flutter/issues/143116
fixes: https://github.com/flutter/flutter/issues/141992

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

14b914ab

Reland "Use dartpad's main channel for master/main docs (#144329)" (#144431) · e41ffcb7

Michael Goderbauer authored Feb 29, 2024

Fix is in the second commit. The logic here went out of sync with the logic in the snippets generator from https://github.com/flutter/assets-for-api-docs, whose version was bumped as part of this change.

e41ffcb7

Make daemon server work on ipv6-only machines. (#144359) · f3ce9d2f
Lau Ching Jun authored Feb 29, 2024
```
Retry binding on ipv6 if binding on ipv4 failed.
```
f3ce9d2f

Remove deprecated `backgroundColor` from `ThemeData` (#144079) · ee6111a7

Qun Cheng authored Feb 29, 2024

This PR is to remove deprecated ThemeData.backgroundColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162.
Part of https://github.com/flutter/flutter/issues/143956

ee6111a7

Add stateful reordering test for TwoDimensionalViewport (#142375) · 60688913

Amir Panahandeh authored Feb 29, 2024

Adds a test to validate state is preserved after reordering in `TwoDimensionalViewport` (reference: https://github.com/flutter/flutter/pull/141504#pullrequestreview-1837501775).

- Fixes #130754

60688913

Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (#144423) · 203ec8b8
Jackson Gardner authored Feb 29, 2024
```
We should avoid hitting gstatic in the benchmarks and just use local canvaskit/skwasm instead.
```
203ec8b8

Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (#144419) · 90b956ce

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/bb6c6a01000f...7e8fefe4a084

2024-02-29 kevmoo@users.noreply.github.com [web] Drop noisy prints from bootstrapping logic (flutter/engine#51097)
2024-02-29 jacksongardner@google.com Fix a few issues rendering text with Skwasm. (flutter/engine#51074)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90b956ce

Fix a crash in remote device daemon. (#144358) · cfa011dd

Lau Ching Jun authored Feb 29, 2024

The daemon server is expecting the client to pass `deviceId` in `device.shutdownDartDevelopmentService` method.

https://github.com/flutter/flutter/blob/24a792dae105e281962a7e3e4c35cbfd9652ff0a/packages/flutter_tools/lib/src/commands/daemon.dart#L1239

cfa011dd

Reverts "Use dartpad's main channel for master/main docs (#144329)" (#144429) · b099bf0b

auto-submit[bot] authored Feb 29, 2024

Reverts flutter/flutter#144329
Initiated by: goderbauer
Reason for reverting: broke postsubmit doc generation.
Original PR Author: goderbauer

Reviewed By: {devoncarew, HansMuller, gspencergoog}

This change reverts the following previous change:
Original Description:
Dartpad doesn't have a "master" channel anymore, it got renamed to "main". Sadly, specifying "master" is now falling back to "stable" which breaks some of our examples in the docs that require a more current Flutter version, e.g. https://main-api.flutter.dev/flutter/material/TextButton-class.html

b099bf0b

Remove `toggleableActiveColor` from `ThemeData` (#144178) · 1349c591

Qun Cheng authored Feb 29, 2024

This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/97972.
Part of https://github.com/flutter/flutter/pull/111080

1349c591

Add `FocusNode.focusabilityListenable` (#144280) · 726e5d28

LongCatIsLooong authored Feb 29, 2024

This is for https://github.com/flutter/flutter/issues/127803: a text field should unregister from the scribble scope, when it becomes unfocusable. 

When a `FocusNode` has listeners and its `_canRequestFocus` flag is set to true, it adds `+1` to `_focusabilityListeningDescendantCount` of all ancestors until it reaches the first ancestor with `descendantsAreFocusable = false`. When the a `FocusNode`'s `descendantsAreFocusable` changes, all listeners that contributed to its `_focusabilityListeningDescendantCount` will be notified.

726e5d28

Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (#144416) · 1abc5cdf

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/1f24eaa4979d...bb6c6a01000f

2024-02-29 jonahwilliams@google.com [Impeller] test removal of submit batching. (flutter/engine#51094)
2024-02-29 zanderso@users.noreply.github.com Use RBE for mac_clang_tidy (flutter/engine#51083)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1abc5cdf

[devicelab] fix motog4 tests and update comment. (#144410) · ec8fcbce

Jonah Williams authored Feb 29, 2024

Fixes https://github.com/flutter/flutter/issues/144406

The A02 have also been running Vulkan for quite a while.

ec8fcbce

Bump dartdocs to 8.0.6 (#144413) · 24a792da
Michael Goderbauer authored Feb 29, 2024

24a792da

Use dartpad's main channel for master/main docs (#144329) · 41eeb2bb

Michael Goderbauer authored Feb 29, 2024

Dartpad doesn't have a "master" channel anymore, it got renamed to "main". Sadly, specifying "master" is now falling back to "stable" which breaks some of our examples in the docs that require a more current Flutter version, e.g. https://main-api.flutter.dev/flutter/material/TextButton-class.html

41eeb2bb

Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (#144405) · bcb0f901

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/7b3ef43fa7e6...1f24eaa4979d

2024-02-29 dnfield@google.com Reapply "Bump everything to Android 21" (#51056) (flutter/engine#51070)
2024-02-29 737941+loic-sharma@users.noreply.github.com [Windows] Add view ID runner APIs (flutter/engine#51020)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bcb0f901

Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (#144399) · ab4bf7c1

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/7dd404724c50...7b3ef43fa7e6

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 05a8d57f0e61 to 139461270500 (1 revision) (flutter/engine#51091)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab4bf7c1

Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (#144395) · df668ed7

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/8179b0ed778e...7dd404724c50

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from ffbe23b3b3b9 to 05a8d57f0e61 (1 revision) (flutter/engine#51090)
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 0d00c9f3852a to ffbe23b3b3b9 (2 revisions) (flutter/engine#51089)
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from ef2511b0a6f2 to 0d00c9f3852a (2 revisions) (flutter/engine#51086)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

df668ed7

Roll Packages from 353086c9a61e to 6d02f0359368 (14 revisions) (#144393) · 8a11703c

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/packages/compare/353086c9a61e...6d02f0359368

2024-02-28 engine-flutter-autoroll@skia.org Manual roll Flutter from c30f998e to d00bfe82 (32 revisions) (flutter/packages#6222)
2024-02-28 stuartmorgan@google.com [google_maps_flutter] Add `style` to widget (flutter/packages#6192)
2024-02-28 58529443+srujzs@users.noreply.github.com Add library annotations for js interop (flutter/packages#6216)
2024-02-28 stuartmorgan@google.com [google_map_flutter] Add style to widget - platform impls (flutter/packages#6205)
2024-02-28 brackenavaron@gmail.com [google_maps_flutter_web] Migrate to package:web (flutter/packages#5254)
2024-02-28 737941+loic-sharma@users.noreply.github.com [pigeon] Remove heap allocation in generated C++ code (flutter/packages#6196)
2024-02-27 tarrinneal@gmail.com [pigeon] Allows kotlin generator to skip error class generation (flutter/packages#6183)
2024-02-27 43054281+camsim99@users.noreply.github.com [camerax] Implements `setExposureMode` (flutter/packages#6110)
2024-02-27 engine-flutter-autoroll@skia.org Roll Flutter from b77560e9 to c30f998e (12 revisions) (flutter/packages#6211)
2024-02-26 pageli328@gmail.com Add `InkResponse`, `Material` and fix `Opacity` (flutter/packages#6199)
2024-02-26 cepadilla@google.com [url_launcher] Add explicit imports of UIKit (flutter/packages#6208)
2024-02-26 737941+loic-sharma@users.noreply.github.com [pigeon] Fix tool hangs on verbose sub-processes (flutter/packages#6198)
2024-02-26 stuartmorgan@google.com [tool] Ignore GeneratedPluginRegistrant.swift for `format` (flutter/packages#6195)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter from 1e8dd1e4 to b77560e9 (8 revisions) (flutter/packages#6207)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8a11703c

Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (#144378) · 8fa0a208

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/d068d980f952...8179b0ed778e

2024-02-29 matanlurey@users.noreply.github.com The `adb logcat` filtering will continue until morale improves. (flutter/engine#51069)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8fa0a208

[flutter_tools] Update external link in Android manifest template (#144302) · e92bca3f

Bruno Leroux authored Feb 29, 2024

## Description

This PR simplifies one external link in a commented section of the Android manifest template.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144249

## Tests

Documentation only PR.

e92bca3f

Roll Flutter Engine from 232217f39c3c to d068d980f952 (1 revision) (#144369) · 62cf7cfa

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/232217f39c3c...d068d980f952

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from f0a60bfe98e0 to ef2511b0a6f2 (2 revisions) (flutter/engine#51075)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62cf7cfa

Roll Flutter Engine from 9e1876141be8 to 232217f39c3c (1 revision) (#144366) · 2ccf375c

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/9e1876141be8...232217f39c3c

2024-02-29 robert.ancell@canonical.com Update Linux embedder to latest semantics API (flutter/engine#51030)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ccf375c

Roll Flutter Engine from 61510db94a1c to 9e1876141be8 (1 revision) (#144362) · 71bb9125

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/61510db94a1c...9e1876141be8

2024-02-29 jonahwilliams@google.com [Impeller] switch fallback default from ImpellerVulkan to SkiaOpenGLES (flutter/engine#51071)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

71bb9125

Roll Flutter Engine from 10331db8f748 to 61510db94a1c (5 revisions) (#144355) · 52d45c41

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/10331db8f748...61510db94a1c

2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (flutter/engine#51068)
2024-02-28 chillers@google.com Prefix flutter in flutter_vma.h import (flutter/engine#51065)
2024-02-28 jonahwilliams@google.com [Impeller] Cache entire render target and not just allocations. (flutter/engine#50990)
2024-02-28 matanlurey@users.noreply.github.com Test the `SurfaceTextureSurfaceProducer`-branch in the Android `scenario_app` (flutter/engine#51061)
2024-02-28 jacksongardner@google.com Revert "[skwasm] Clip pictures if they go beyond the bounds of the window. (#50887)" (flutter/engine#51067)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

52d45c41

Docs on the interaction between Shortcuts and text input (#144328) · ac66b295

Justin McCandless authored Feb 29, 2024

I was talking with @tvolkert about the complex behavior of Shortcuts when a text field is focused.  I created [this dartpad](https://dartpad.dev/?id=0b5c08fa85637422baa84927b7f1ee5f) to illustrate the problem, which shows a key being stolen from a text field by Shortcuts, and how to prevent that using DoNothingAndStopPropagationIntent.

This PR adds a section in the docs explaining how all of this works and how to override this "stealing" problem.

ac66b295

Use robolectric/AndroidJUnit4 for integration test tests (#144348) · 835112de

Dan Field authored Feb 29, 2024

This allows relanding https://github.com/flutter/engine/pull/51056. The patch introduced a change where a static member is initialized from `View.generateViewId()` instead of conditionally using that API. Without an implementation for that in android.jar, the test will fail. The test in here currently is using a fake implementation that creates errors seen below.

See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8754827734484522225/+/u/run_plugin_test/stdout#L46564_2 for failure. More detailed failure information is available locally in the `build` folder:

```
Mockito cannot mock this class: class io.flutter.embedding.android.FlutterActivity.

If you're not sure why you're getting this error, please open an issue on GitHub.

Java : 17
JVM vendor name : JetBrains s.r.o.
JVM vendor version : 17.0.7+0-17.0.7b1000.6-10550314
JVM name : OpenJDK 64-Bit Server VM
JVM version : 17.0.7+0-17.0.7b1000.6-10550314
JVM info : mixed mode
OS name : Mac OS X
OS version : 14.3.1

You are seeing this disclaimer because Mockito is configured to create inlined mocks.
You can learn about inline mocks and their limitations under item #39 of the Mockito class javadoc.

Underlying exception : org.mockito.exceptions.base.MockitoException: Cannot instrument class io.flutter.embedding.android.FlutterActivity because it or one of its supertypes could not be initialized
at app//dev.flutter.plugins.integration_test.FlutterDeviceScreenshotTest.getFlutterView_returnsFlutterViewForFlutterActivity(FlutterDeviceScreenshotTest.java:32)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/java.lang.reflect.Method.invoke(Unknown Source)
at app//org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at app//org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at app//org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at app//org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at app//org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at app//org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at app//org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at app//org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at app//org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at app//org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at app//org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at app//org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/java.lang.reflect.Method.invoke(Unknown Source)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at jdk.proxy1/jdk.proxy1.$Proxy2.processTestClass(Unknown Source)
at org.gradle.api.internal.tasks.testing.worker.TestWorker$2.run(TestWorker.java:176)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:133)
at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
Caused by: org.mockito.exceptions.base.MockitoException: Cannot instrument class io.flutter.embedding.android.FlutterActivity because it or one of its supertypes could not be initialized
at app//net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:168)
at app//net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:399)
at app//net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:190)
at app//net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:410)
... 44 more
Caused by: java.lang.RuntimeException: Method generateViewId in android.view.View not mocked. See http://g.co/androidstudio/not-mocked for details.
at android.view.View.generateViewId(View.java)
at io.flutter.embedding.android.FlutterActivity.<clinit>(FlutterActivity.java:218)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Unknown Source)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.assureInitialization(InlineBytecodeGenerator.java:236)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.triggerRetransformation(InlineBytecodeGenerator.java:261)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.mockClass(InlineBytecodeGenerator.java:218)
at org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.lambda$mockClass$0(TypeCachingBytecodeGenerator.java:47)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:168)
at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:399)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:190)
at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:410)
at org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.mockClass(TypeCachingBytecodeGenerator.java:40)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.createMockType(InlineDelegateByteBuddyMockMaker.java:396)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.doCreateMock(InlineDelegateByteBuddyMockMaker.java:355)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.createMock(InlineDelegateByteBuddyMockMaker.java:334)
at org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker.createMock(InlineByteBuddyMockMaker.java:56)
at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:99)
at org.mockito.internal.MockitoCore.mock(MockitoCore.java:88)
at org.mockito.Mockito.mock(Mockito.java:2087)
at org.mockito.Mockito.mock(Mockito.java:2002)
... 44 more
```

835112de

Reland "Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207)" (#144330) · dddbd047

LongCatIsLooong authored Feb 29, 2024

The [internal test failure](https://github.com/flutter/flutter/pull/144207#issuecomment-1968236339) was caused by `Focus.withExternalFocusNode` modifying the external node's attributes. The extra changes are in this commit:  https://github.com/flutter/flutter/commit/e53d98b06c6e2ae65271681c4b40b28b2d02ad04

CL with (almost) passing TGP: cl/611157582

dddbd047

Roll Flutter Engine from 455c814fe5de to 10331db8f748 (7 revisions) (#144345) · 7f65c9ef

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/455c814fe5de...10331db8f748

2024-02-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR... (flutter/engine#51066)
2024-02-28 chris@bracken.jp Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (flutter/engine#51062)
2024-02-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (flutter/engine#51064)
2024-02-28 jason-simmons@users.noreply.github.com [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (flutter/engine#51063)
2024-02-28 jonahwilliams@google.com [Impeller] fix render pass depth descriptor. (flutter/engine#51031)
2024-02-28 flar@google.com Make Skia object ostream operators work with unit tests (flutter/engine#51041)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from T1xAi_ww_mWE to ujOkbeYbrC8l

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f65c9ef

ReportTiming callback should record the sendFrameToEngine when it was scheduled (#144212) · e3160222
Tong Mu authored Feb 29, 2024
```
Fixes https://github.com/flutter/flutter/issues/144261
```
e3160222

Disable flaky golden file test (#144351) · a185ff90

Kate Lovett authored Feb 29, 2024

Filed https://github.com/flutter/flutter/issues/144350 for follow up.
This test has become flaky and is breaking the tree.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

a185ff90