- 05 Oct, 2020 2 commits
-
-
Tong Mu authored
-
Dan Field authored
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (https://github.com/flutter/flutter/pull/67176) - Fix CanvasKit dispose impl (https://github.com/flutter/engine/pull/21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d9.
-
- 03 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 02 Oct, 2020 2 commits
-
-
Tong Mu authored
* PointerEvent.local* properties are calculated lazily; other properties are delegated to original. * Transformed PointerEvent becomes a subclass of its original class. * Unnamed constructors no longer accepts transform and origin.
-
Jason Simmons authored
-
- 01 Oct, 2020 2 commits
-
-
Dan Field authored
* Dispose of images after using them Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf. Makes all stateful holders of ui.Image objects properly clone and dispose of them. Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created. Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
- 24 Sep, 2020 1 commit
-
-
Jonah Williams authored
Registering the service worker immediately after the documented has loaded may cause SW initialization to compete with framework initialization. It was recommended to us that we defer the service worker setup until after the framework is done with setup, which should be sometime after the first frame. To implement this, I augmented the binding setup to dispatch an event on the document after the binding has initialized. I don't see any obvious risks with this setup. Fixes #66066
-
- 23 Sep, 2020 1 commit
-
-
LongCatIsLooong authored
-
- 22 Sep, 2020 1 commit
-
-
Dan Field authored
Remove fake image implementations, add createTestImage to flutter_test
-
- 16 Sep, 2020 1 commit
-
-
Michael R Fairhurst authored
-
- 15 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* Reland "Nnbd widgets (#64672)" This reverts commit 127e6790. * remove non-nullable enforcement on AsyncSnapshot * make data param non-nullable for AsyncSnapshot.withData * make some Text params non-nullable
-
- 09 Sep, 2020 3 commits
-
-
Anatoly Pulyaevskiy authored
-
Michael Goderbauer authored
This reverts commit e682ec71.
-
Alexandre Ardhuin authored
* migrate widget to nullsafety * remove double blank line after license * address review comments in actions.dart * nullable ObjectKey.value * use local variable oldElement * make State.build non-nullable * make State.context non-nullable * newline at eof * make ProxyWidget.child non-nullable * make _InactiveElements.debugContains non-nullable * make Element.depth non-nullable * make ProxyElement.build non-nullable * make StatefulElement.state non-nullable * remove 'Notice that' * avoid cast of list in RenderObjectElement.updateChildren * make IndexedSlot.value non-nullable * avoid cast of list in MultiChildRenderObjectElement.mount * make some WidgetsApp parameters non-nullable * hitTest take non-nullable position * make ScrollableState.position non-nullable * use _pixels instead of pixels * make ViewportOffset.pixels non-nullable * make param and return type of IndexedWidgetBuilder non-nullable * unused_import * make context param non-nullable for Builder in animated_list.dart * make ScrollMetrics.viewportDimension non-nullable * make ScrollMetrics.{min,max}ScrollExtent non-nullable * make _Location.file non-nullable * _WidgetForTypeTests.createElement throw UnimplementedError * update _NullWidget.build error message * make _ShortcutsState.manager non-nullable * Fix childCount issues for NNBD * fix childCount computation on web * increase max value on js side to compute childCount * make aspect parameter of dependOnInheritedWidgetOfExactType nullable * merge has{min,max}ScrollExtent into hasScrollExtents * update focus_manager.dart * address review comments in icon.dart * address review comments in image.dart * address review comments in routes.dart * address review comments in scroll_activity.dart * update doc comments * make UserScrollNotification.direction non-nullable and required * rename hasScrollExtents to hasContentDimensions * unnecessary late Co-authored-by:
Ian Hickson <ian@hixie.ch>
-
- 31 Aug, 2020 2 commits
-
-
Chris Bracken authored
Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from the `matcher` package: * It emits the epsilon value in the test result on failure. * It uses a named parameter for epsilon, which improves readability at the call site. * It has a reasonable default for epsilon in cases where something more specific isn't required. Using it also has the nice property that it aids in its own discovery when when people go looking for such functionality in new tests. This change also includes a couple unrelated whitespace formatting cleanups.
-
Chris Bracken authored
Several of our tests make use of numbers without an exact floating point representation (frequently 0.x where x!=5) which, when scaled, also scale the error. The end result is that some of these tests currently implicitly rely on an implementation detail of floating point math and are sensitive to differences in the ~15th decimal place. This patch reduces the sensitivity of some of these tests, checking values using `moreOrLessEquals` from the flutter_test package rather than requiring en exact match.
-
- 29 Aug, 2020 1 commit
-
-
LongCatIsLooong authored
Reland "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" reverted in #64091 (#64513)
-
- 27 Aug, 2020 1 commit
-
-
Ian Hickson authored
-
- 25 Aug, 2020 3 commits
-
-
LongCatIsLooong authored
This reverts commit 0ab5ecc8.
-
chunhtai authored
-
LongCatIsLooong authored
-
- 24 Aug, 2020 1 commit
-
-
LongCatIsLooong authored
-
- 20 Aug, 2020 1 commit
-
-
Tong Mu authored
* Redesigns the interface between MouseTracker and RendererBinding&RenderView. * Simplifies the structure of RenderMouseRegion. * Extracts the common utility code between mouse_tracker_test and mouse_tracker_cursor_test.
-
- 18 Aug, 2020 2 commits
-
-
Mehmet Fidanboylu authored
Revert "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" (#64091) This reverts commit 64d76f2f.
-
Mehmet Fidanboylu authored
This reverts commit 72619b86.
-
- 14 Aug, 2020 1 commit
-
-
LongCatIsLooong authored
Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)
-
- 12 Aug, 2020 1 commit
-
-
chunhtai authored
-
- 08 Aug, 2020 1 commit
-
-
chunhtai authored
-
- 06 Aug, 2020 1 commit
-
-
Nolan Scobie authored
* Add punctuation for unterminated sentences in doc comments * Addressing review nit
-
- 04 Aug, 2020 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
- 29 Jul, 2020 1 commit
-
-
Tong Mu authored
-
- 20 Jul, 2020 1 commit
-
- 16 Jul, 2020 1 commit
-
-
chunhtai authored
-
- 15 Jul, 2020 1 commit
-
-
- 13 Jul, 2020 1 commit
-
-
Tong Mu authored
-
- 09 Jul, 2020 1 commit
-
-
Kate Lovett authored
-
- 08 Jul, 2020 1 commit
-
-
Jason Simmons authored
-
- 23 Jun, 2020 1 commit
-
-
Justin McCandless authored
Use Dart's characters package to fix user-facing grapheme cluster bugs.
-