1. 05 Oct, 2020 2 commits
  2. 03 Oct, 2020 1 commit
  3. 02 Oct, 2020 2 commits
  4. 01 Oct, 2020 2 commits
    • Dan Field's avatar
      Revert dispose images when done (#67100) · 473358d9
      Dan Field authored
      * Revert "docs for image disposal (#67066)"
      
      This reverts commit bcb2ac5a.
      
      * Revert "Dispose of images after using them (#66688)"
      
      This reverts commit a7954691.
      473358d9
    • Dan Field's avatar
      Dispose of images after using them (#66688) · a7954691
      Dan Field authored
      * Dispose of images after using them
      Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
      Makes all stateful holders of ui.Image objects properly clone and dispose of them.
      Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
      Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
      a7954691
  5. 24 Sep, 2020 1 commit
    • Jonah Williams's avatar
      [flutter_tools] register service worker after first frame event (#66082) · 90d83e37
      Jonah Williams authored
      Registering the service worker immediately after the documented has loaded may cause SW initialization to compete with framework initialization. It was recommended to us that we defer the service worker setup until after the framework is done with setup, which should be sometime after the first frame.
      
      To implement this, I augmented the binding setup to dispatch an event on the document after the binding has initialized. I don't see any obvious risks with this setup.
      
      Fixes #66066
      90d83e37
  6. 23 Sep, 2020 1 commit
  7. 22 Sep, 2020 1 commit
  8. 16 Sep, 2020 1 commit
  9. 15 Sep, 2020 1 commit
    • Alexandre Ardhuin's avatar
      Reland "Nnbd widgets" (#65528) · b007a81a
      Alexandre Ardhuin authored
      * Reland "Nnbd widgets (#64672)"
      
      This reverts commit 127e6790.
      
      * remove non-nullable enforcement on AsyncSnapshot
      
      * make data param non-nullable for AsyncSnapshot.withData
      
      * make some Text params non-nullable
      b007a81a
  10. 09 Sep, 2020 3 commits
    • Anatoly Pulyaevskiy's avatar
    • Michael Goderbauer's avatar
      Revert "Nnbd widgets (#64672)" (#65488) · 127e6790
      Michael Goderbauer authored
      This reverts commit e682ec71.
      127e6790
    • Alexandre Ardhuin's avatar
      Nnbd widgets (#64672) · e682ec71
      Alexandre Ardhuin authored
      * migrate widget to nullsafety
      
      * remove double blank line after license
      
      * address review comments in actions.dart
      
      * nullable ObjectKey.value
      
      * use local variable oldElement
      
      * make State.build non-nullable
      
      * make State.context non-nullable
      
      * newline at eof
      
      * make ProxyWidget.child non-nullable
      
      * make _InactiveElements.debugContains non-nullable
      
      * make Element.depth non-nullable
      
      * make ProxyElement.build non-nullable
      
      * make StatefulElement.state non-nullable
      
      * remove 'Notice that'
      
      * avoid cast of list in RenderObjectElement.updateChildren
      
      * make IndexedSlot.value non-nullable
      
      * avoid cast of list in MultiChildRenderObjectElement.mount
      
      * make some WidgetsApp parameters non-nullable
      
      * hitTest take non-nullable position
      
      * make ScrollableState.position non-nullable
      
      * use _pixels instead of pixels
      
      * make ViewportOffset.pixels non-nullable
      
      * make param and return type of IndexedWidgetBuilder non-nullable
      
      * unused_import
      
      * make context param non-nullable for Builder in animated_list.dart
      
      * make ScrollMetrics.viewportDimension non-nullable
      
      * make ScrollMetrics.{min,max}ScrollExtent non-nullable
      
      * make _Location.file non-nullable
      
      * _WidgetForTypeTests.createElement throw UnimplementedError
      
      * update _NullWidget.build error message
      
      * make _ShortcutsState.manager non-nullable
      
      * Fix childCount issues for NNBD
      
      * fix childCount computation on web
      
      * increase max value on js side to compute childCount
      
      * make aspect parameter of dependOnInheritedWidgetOfExactType nullable
      
      * merge has{min,max}ScrollExtent into hasScrollExtents
      
      * update focus_manager.dart
      
      * address review comments in icon.dart
      
      * address review comments in image.dart
      
      * address review comments in routes.dart
      
      * address review comments in scroll_activity.dart
      
      * update doc comments
      
      * make UserScrollNotification.direction non-nullable and required
      
      * rename hasScrollExtents to hasContentDimensions
      
      * unnecessary late
      Co-authored-by: 's avatarIan Hickson <ian@hixie.ch>
      e682ec71
  11. 31 Aug, 2020 2 commits
    • Chris Bracken's avatar
      Prefer moreOrLessEquals over closeTo (#64915) · c0ea00ed
      Chris Bracken authored
      Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
      the `matcher` package:
      
         * It emits the epsilon value in the test result on failure.
         * It uses a named parameter for epsilon, which improves readability
           at the call site.
         * It has a reasonable default for epsilon in cases where something
           more specific isn't required.
      
      Using it also has the nice property that it aids in its own discovery
      when when people go looking for such functionality in new tests.
      
      This change also includes a couple unrelated whitespace formatting cleanups.
      c0ea00ed
    • Chris Bracken's avatar
      Match lerped values using moreOrLessEquals (#64908) · 8fa5c55e
      Chris Bracken authored
      Several of our tests make use of numbers without an exact floating point
      representation (frequently 0.x where x!=5) which, when scaled, also
      scale the error. The end result is that some of these tests currently
      implicitly rely on an implementation detail of floating point math and
      are sensitive to differences in the ~15th decimal place.
      
      This patch reduces the sensitivity of some of these tests, checking
      values using `moreOrLessEquals` from the flutter_test package
      rather than requiring en exact match.
      8fa5c55e
  12. 29 Aug, 2020 1 commit
  13. 27 Aug, 2020 1 commit
  14. 25 Aug, 2020 3 commits
  15. 24 Aug, 2020 1 commit
  16. 20 Aug, 2020 1 commit
  17. 18 Aug, 2020 2 commits
  18. 14 Aug, 2020 1 commit
  19. 12 Aug, 2020 1 commit
  20. 08 Aug, 2020 1 commit
  21. 06 Aug, 2020 1 commit
  22. 04 Aug, 2020 2 commits
  23. 29 Jul, 2020 1 commit
  24. 20 Jul, 2020 1 commit
  25. 16 Jul, 2020 1 commit
  26. 15 Jul, 2020 1 commit
  27. 13 Jul, 2020 1 commit
  28. 09 Jul, 2020 1 commit
  29. 08 Jul, 2020 1 commit
  30. 23 Jun, 2020 1 commit