- 17 Oct, 2018 1 commit
-
- 05 Oct, 2018 2 commits
-
-
Yegor authored
* first pass * revert WidgetsBindingObserver * disable prefer_mixin * docs and more mixins * newer engine; binding fixes * upgrade dependencies * fix test binding * remove whitespace * remove the obsolete `enableSuperMixins: true` * upgrade dartdoc to 0.22.0 * temporarily use git version of dartdoc * fix pub global activate syntax * use dartdoc 0.23.0
- 14 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Sep, 2018 1 commit
-
-
liyuqian authored
In my local tests, this should finally fix https://github.com/flutter/flutter/issues/21617
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 1 commit
-
-
Jacob Richman authored
Revert "Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)" (#21448) This reverts commit 5b5a5b82.
-
- 04 Sep, 2018 2 commits
-
-
Jonah Williams authored
This reverts commit 3306fc10.
-
Jacob Richman authored
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector. Key functionality is in the added _ScreenshotPaintingContext class.
-
- 09 Aug, 2018 1 commit
-
-
liyuqian authored
This fixes https://github.com/flutter/flutter/issues/18057
-
- 03 Aug, 2018 1 commit
-
-
liyuqian authored
See details in our proposal for this breaking API change and #18057. This PR setup all code paths to allow the change but doesn't change the clip behavior by itself. We'll change `defaultClipBehavior` from `Clip.antiAlias` to `Clip.none` in the following PR to change the clip behavior and update tests.
-
- 31 Jul, 2018 1 commit
-
-
Jonah Williams authored
-
- 11 Jul, 2018 1 commit
-
-
Michael Goderbauer authored
Instead, if the surface is 0x0 semantics will just generate one root semantics node with size of 0x0. The node will have no children because all children are invisible and (except for the root node with this change) invisible children are dropped.
-
- 21 Jun, 2018 2 commits
-
-
Yegor authored
-
liyuqian authored
This is a follow up on https://github.com/flutter/engine/pull/5420 and https://github.com/flutter/flutter/issues/18057 As you can see from the diff, we also mistakenly saveLayer before the clip at some places previously.
-
- 14 Jun, 2018 1 commit
-
-
xster authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 07 Jun, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 05 Jun, 2018 2 commits
-
-
Michael Goderbauer authored
-
Alexandre Ardhuin authored
-
- 30 May, 2018 2 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
- 26 May, 2018 1 commit
-
-
Jonah Williams authored
-
- 04 May, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 03 May, 2018 2 commits
-
-
Chris Bracken authored
Revert longPress/Tap and Gallery changes
-
Jonah Williams authored
-
- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2018 1 commit
-
-
Jason Simmons authored
-
- 09 Mar, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 28 Feb, 2018 1 commit
-
-
najeira authored
-
- 06 Feb, 2018 2 commits
-
-
Greg Spencer authored
This adds an API for defining the semantic node traversal order. It adds a sortOrder argument to the Semantics widget, which is a class that can define a list of sort keys to sort on. The keys are sorted globally so that an order that doesn't have to do with the current widget hierarchy may be defined. It also adds a shortcut sortKey argument to the Semantics widget that simply sets the sortOrder to just contain that key. The platform side (flutter/engine#4540) gets an additional member in the SemanticsData object that is an integer describing where in the overall order each semantics node belongs. There is an associated engine-side change that takes this integer and uses it to order widgets for the platform's accessibility services.
-
Alexandre Ardhuin authored
-
- 02 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Jan, 2018 1 commit
-
-
Jason Simmons authored
The picture may need to draw outside the bounds (specifically for shadows) Fixes https://github.com/flutter/flutter/issues/12618
-
- 10 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
* Do not crash when toggeling Semantics on, off, on * review comments
-
- 09 Jan, 2018 2 commits
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
Ian Hickson authored
Fixes the last bits of #5759.
-
- 22 Dec, 2017 1 commit
-
-
Michael Goderbauer authored
**tl;dr:** A `RenderObject` can only be an effective semantics boundary if it actually owned a `SemanticsNode` in the previous tree generation. When using the `BlockSemantics` widget it is possible to introduce `RenderObject`s that are configured to be a semantics boundary, but because their semantics are blocked by `BlockSemantics` they will not (immediately) end up owning a `SemanticsNode`. When now a descendant of such a node-less semantics boundary marks itself as needing a semantics update we walk up the tree until we find the closest semantics boundary (which is our node-less `RenderObject`). We now incorrectly assume that this semantics boundary has a valid `SemanticsNode` and only regenerate the semantics subtree below this node. However, because the identified semantics boundary doesn't actually own a valid `SemanticsNode` asserts are throwing (e.g. `Child with id xx is invisible and should not be added to tree.`). To fix this problem, we can just abort the walk if we reach a semantics boundary without a semantics node because (for now) we know that the semantics information of this branch will not make it into the final semantics tree. If the semantics block is ever removed, the current algorithm re-generates the semantics for the entire branch and the semantics will be up-to-date then despite the abort. I've added a test to verify this to make sure it continues to work even when we change the algorithm. Fixes https://github.com/flutter/flutter/issues/13326. /cc @gavindoughtie FYI
-
- 21 Dec, 2017 1 commit
-
-
Ian Hickson authored
This is a collection of fixes I've run into recently.
-