- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 01 Feb, 2023 1 commit
-
-
Callum Moffat authored
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 06 Dec, 2022 1 commit
-
-
Pierre-Louis authored
* Introduce flag to maximally apply CupertinoTheme * add missing docs * add tests * fix docs * fix test
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 09 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 08 Sep, 2021 2 commits
-
-
Zachary Anderson authored
This reverts commit bf8e1270.
-
jacobsimionato authored
This fixes #71222 * Implement operator = and hashcode for CupertinoThemeData and CupertinoTextThemeData which CupertinoThemeData depends on. * Add basic tests for CupertinoThemeData equality and hashcode. I also manually tested the case mentioned in #71222, e.g. equality of ThemeData(cupertinoOverrideTheme: someTheme) Co-authored-by:
Jacob Simionato <jsimionato@google.com>
-
- 03 Nov, 2020 1 commit
-
-
Greg Spencer authored
* Remove nullOk from cupertino color resolution * Add CupertinoDynamicColor.maybeResolveFrom * Remove CupertinoDynamicColor.maybeResolveFrom again
-
- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 28 Oct, 2020 1 commit
-
-
Greg Spencer authored
Adds MediaQuery.maybeOf to replace calling MediaQuery.of(context, nullOk: true), and removes the nullOk parameter. Also changes MediaQuery.of to return a non-nullable value, and removes many instances of the ! operator, reducing the possible places where a null dereference could occur.
-
- 22 Sep, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 16 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Aug, 2020 1 commit
-
-
xubaolin authored
* fix bug when tap ListTitle when tristate enable #63846 * fix bug when tap ListTitle when tristate enable #63846 * code style * improve the unit test case * bow to convention
-
- 28 Jul, 2020 1 commit
-
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 11 Mar, 2020 1 commit
-
-
Greg Spencer authored
This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class. It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
-
- 22 Jan, 2020 1 commit
-
-
LongCatIsLooong authored
-
- 05 Dec, 2019 1 commit
-
-
Greg Spencer authored
This normalizes all of the "See also" blocks in comments so that they conform in style. They all look like this now: /// See also: /// /// * [MyFavoriteWidget], because it's cool. class Foo {} I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references. This is my penance for adding so many bullets that are "-" instead of "*". :-)
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 22 Nov, 2019 2 commits
-
-
Greg Spencer authored
No code changes, just comments: I spell-checked all the comments in the repo.
-
Alexandre Ardhuin authored
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic * make BuildContext.inheritFromWidgetOfExactType generic * make BuildContext.ancestorInheritedElementForWidgetOfExactType generic * make BuildContext.ancestorWidgetOfExactType generic * fix snippet * bump scoped_model on temp version * update names * Revert "bump scoped_model on temp version" This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0. * address review comments * fix ci * address review comments * repeat the deprecation notice * fix uppercase * use of recommanded deprecation syntax * address review comment
-
- 07 Nov, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 28 Oct, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 24 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Sep, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 22 Aug, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 13 Jun, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 05 Apr, 2019 1 commit
-
-
LongCatIsLooong authored
-* Inserted an `IconTheme` widget under `CupertinoTheme` to provide a default icon color when using `CupertinoTheme`. * Changed `CupertinoTheme` to a `StatelessWidget`, to match the implementation of `Theme` * Changed the nesting order of `Theme`'s sub widgets, to let `Theme.iconTheme` take precedence, so that `Theme`'s behavior is kept as is.
-
- 06 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* fix some formatting issues * address review comments * fix indent
-
- 19 Dec, 2018 1 commit
-
-
xster authored
-