1. 19 Aug, 2019 3 commits
  2. 10 Aug, 2019 1 commit
  3. 09 Aug, 2019 1 commit
  4. 06 Aug, 2019 2 commits
  5. 05 Aug, 2019 3 commits
  6. 31 Jul, 2019 1 commit
  7. 26 Jul, 2019 2 commits
  8. 19 Jul, 2019 3 commits
  9. 18 Jul, 2019 1 commit
  10. 16 Jul, 2019 1 commit
    • liyuqian's avatar
      Fix flaky peer connection (#36089) · 180aa0c0
      liyuqian authored
      Fixes https://github.com/flutter/flutter/issues/36091.
      
      Previously, a sendRequest will be sent even if the peer is closed during
      a driver test. That will cause a time out without any error information.
      Such issue is unreproducible on my Mac Book Pro, but 100% reproducible
      on our new Mac mini (2018).
      
      The closing issue is tracked in https://github.com/flutter/flutter/issues/36268
      
      Additional to this fix, we should also patch the jason_rpc_2 so the peer
      will throw exception if sendRequest is attempted while the connection is
      closed.
      
      **Test**:
      tiles_scroll_perf_iphonexs__timeline_summary failed without this patch.
      It will pass after this patch.
      
      I'm not sure how to add a unit test for this. Please let me know if you have
      some ideas.
      
      This patch will generate the following warning log on the new Mac Mini
      ```
      flutter: Observatory listening on http://127.0.0.1:50192/cZPDF4sW7MM=/  
      Installing and launching...                                        10.2s
      00:00 +0: scrolling performance test (setUpAll)
      [info ] FlutterDriver: Connecting to Flutter application at http://127.0.0.1:1069/cZPDF4sW7MM=/
      [trace] FlutterDriver: Isolate found with number: 3684677742843303
      [trace] FlutterDriver: Isolate is paused at start.
      [trace] FlutterDriver: Attempting to resume isolate
      [trace] FlutterDriver: Waiting for service extension
      [info ] FlutterDriver: Connected to Flutter application.
      00:00 +0: scrolling performance test complex_layout_scroll_perf
      [warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
      [warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
      00:10 +1: scrolling performance test tiles_scroll_perf
      [warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
      [warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
      00:20 +2: scrolling performance test (tearDownAll)
      00:20 +2: All tests passed!
      Stopping application instance.
      ```
      180aa0c0
  11. 10 Jul, 2019 1 commit
  12. 04 Jul, 2019 1 commit
  13. 02 Jul, 2019 1 commit
  14. 28 Jun, 2019 1 commit
  15. 27 Jun, 2019 1 commit
  16. 19 Jun, 2019 1 commit
  17. 04 Jun, 2019 1 commit
  18. 01 Jun, 2019 2 commits
  19. 31 May, 2019 1 commit
  20. 30 May, 2019 2 commits
  21. 29 May, 2019 3 commits
  22. 22 May, 2019 2 commits
  23. 21 May, 2019 1 commit
  24. 20 May, 2019 3 commits
  25. 14 May, 2019 1 commit