Commits · a899e04bef12fe4b185b244c89975d83fdaf0879 · abdullh.alsoleman / Front-End

15 Dec, 2023 9 commits

Roll Flutter Engine from 46ff5c08a905 to cde1a596432d (1 revision) (#140200) · a899e04b

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/46ff5c08a905...cde1a596432d

2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from f1e37ed8917e to bb1b67b78b8d (1 revision) (flutter/engine#49073)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a899e04b

Roll Flutter Engine from a17bb0a63b7e to 46ff5c08a905 (1 revision) (#140198) · ffe780c2

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/a17bb0a63b7e...46ff5c08a905

2023-12-15 matanlurey@users.noreply.github.com Move `third_party/json` to `flutter/third_party/json`. (flutter/engine#48844)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ffe780c2

Roll Flutter Engine from 4cb3ba7a85f6 to a17bb0a63b7e (1 revision) (#140196) · d69653c9

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/4cb3ba7a85f6...a17bb0a63b7e

2023-12-15 matanlurey@users.noreply.github.com Automatically fix header guards in the rest of the `flutter/engine` repo. (flutter/engine#49059)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d69653c9

Roll Flutter Engine from 0e7248d43251 to 4cb3ba7a85f6 (14 revisions) (#140195) · 09dc01fc

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/0e7248d43251...4cb3ba7a85f6

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (flutter/engine#49069)
2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065)
2023-12-15 dnfield@google.com [Impeller] impellerc: delete unused code (flutter/engine#49061)
2023-12-15 30870216+gaaclarke@users.noreply.github.com [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050)
2023-12-15 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] Turned on new blur." (flutter/engine#49062)
2023-12-14 matanlurey@users.noreply.github.com Fix header-guard naming convention in `shell/`. (flutter/engine#49006)
2023-12-14 jason-simmons@users.noreply.github.com Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054)
2023-12-14 matanlurey@users.noreply.github.com Rename `font-subset` to `font_subset`. (flutter/engine#49051)
2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056)
2023-12-14 chingjun@google.com Suppress warning for the new Activity library. (flutter/engine#49046)
2023-12-14 jonahwilliams@google.com [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038)
2023-12-14 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/engine#48994)
2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on new blur. (flutter/engine#48472)
2023-12-14 103135467+sealesj@users.noreply.github.com Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09dc01fc

Increase versions of leak tracker libraries. (#140018) · 6a856848
Polina Cherkasova authored Dec 15, 2023
```
Contributes to https://github.com/flutter/flutter/issues/135856
```
6a856848

Set compile test iOS app target version to not embed Swift runtime (#140188) · 0cd2ea96

Jenn Magder authored Dec 15, 2023

ObjC->Swift plugin migration caused a size regression in the gallery app because the Swift runtime was also pulled in.  

The gallery app minimum target version is iOS 11.0, which predates Swift ABI compatibility.  Pre iOS 12.2 apps embedded the Swift runtime since there wasn't one available to use in the OS.  

Add  `FLUTTER_XCODE_IPHONEOS_DEPLOYMENT_TARGET` to the compile perf test environment, which gets translated by the tool to an Xcode build setting:
```
[2023-12-14 15:52:14.797318] [STDOUT] stdout:                IPHONEOS_DEPLOYMENT_TARGET = 12.2
```

On my machine on main
```
    "release_size_bytes": 43717389,
```
becomes
```
    "release_size_bytes": 40679432,
```

Fixes https://github.com/flutter/flutter/issues/139605

0cd2ea96

Cupertino text clear label (#129727) · f0051d8b

Mitchell Goodwin authored Dec 15, 2023

Fixes #123107

Adds a customizable semantic label so that the clear button on the Cupertino text field will be picked up by screen readers.

https://github.com/flutter/flutter/assets/58190796/de31d9dd-923c-402f-a55b-e5cc77ea68bb

f0051d8b

[github actions] use token from real user flutter mirror bot (#140191) · 8c1d723d

Xilai Zhang authored Dec 15, 2023

sir @godofredoc pointed out that we should use a real user to create PRs with, and we already have one account with such credentials -- the mirror bot.

8c1d723d

Reverts "Roll Flutter Engine from 0e7248d43251 to 0b0fab821536 (4 revisions)" (#140194) · 13b81068

auto-submit[bot] authored Dec 15, 2023

Reverts flutter/flutter#140180
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/0e7248d43251...0b0fab821536

2023-12-14 jonahwilliams@google.com [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038)
2023-12-14 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/engine#48994)
2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on new blur. (flutter/engine#48472)
2023-12-14 103135467+sealesj@users.noreply.github.com Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

13b81068

14 Dec, 2023 31 commits

Roll Flutter Engine from 0e7248d43251 to 0b0fab821536 (4 revisions) (#140180) · 0b6da5b4

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/0e7248d43251...0b0fab821536

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b6da5b4

feat: Add onTapAlwaysCalled in TextFormField (#140089) · 703ae778

lsaudon authored Dec 14, 2023

Add onTapAlwaysCalled in TextFormField

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

703ae778

Bump actions/upload-artifact from 3.1.3 to 4.0.0 (#140177) · ea1e2dfa

dependabot[bot] authored Dec 14, 2023

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.</p>
<p>For more information, see the <a href="https://github.com/actions/toolkit/tree/main/packages/artifact"><code>@âactions/artifact</code></a> documentation.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/vmjoseph"><code>@âvmjoseph</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/464">actions/upload-artifact#464</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v4.0.0">https://github.com/actions/upload-artifact/compare/v3...v4.0.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/upload-artifact/commit/c7d193f32edcb7bfad88892161225aeda64e9392"><code>c7d193f</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/466">#466</a> from actions/v4-beta</li>
<li><a href="https://github.com/actions/upload-artifact/commit/13131bb095770b4070a7477c3cd2d96e1c16d9f4"><code>13131bb</code></a> licensed cache</li>
<li><a href="https://github.com/actions/upload-artifact/commit/4a6c273b9834f66a1d05c170dc3f80f9cdb9def1"><code>4a6c273</code></a> Merge branch 'main' into v4-beta</li>
<li><a href="https://github.com/actions/upload-artifact/commit/f391bb91a3d3118aeca171c365bb319ece276b37"><code>f391bb9</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/465">#465</a> from actions/robherley/v4-documentation</li>
<li><a href="https://github.com/actions/upload-artifact/commit/9653d03c4b74c32144e02dae644fea70e079d4b3"><code>9653d03</code></a> Apply suggestions from code review</li>
<li><a href="https://github.com/actions/upload-artifact/commit/875b63076402f25ef9d52c294c86ba4f97810575"><code>875b630</code></a> add limitations section</li>
<li><a href="https://github.com/actions/upload-artifact/commit/ecb21463e93740a6be75c3116242169bfdbcb15a"><code>ecb2146</code></a> add compression example</li>
<li><a href="https://github.com/actions/upload-artifact/commit/5e7604f84a055838f64ed68bb9904751523081ae"><code>5e7604f</code></a> trim some repeated info</li>
<li><a href="https://github.com/actions/upload-artifact/commit/d6437d07581fe318a364512e6cf6b1dca6b4f92c"><code>d6437d0</code></a> naming</li>
<li><a href="https://github.com/actions/upload-artifact/commit/1b561557037b4957d7d184e9aac02bec86c771eb"><code>1b56155</code></a> s/v4-beta/v4/g</li>
<li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/a8a3f3ad30e3422c9c7b888a15615d19a852ae32...c7d193f32edcb7bfad88892161225aeda64e9392">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3.1.3&new-version=4.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

ea1e2dfa

Roll Flutter Engine from 2140942444ea to 0e7248d43251 (2 revisions) (#140176) · 497dd81e

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/2140942444ea...0e7248d43251

2023-12-14 31859944+LongCatIsLooong@users.noreply.github.com Fix a bug in the HTML render's `getClosestGlyphInfo` implementation (flutter/engine#48774)
2023-12-14 magder@google.com Fix `NSPrivacyCollectedDataTypes` array in privacy manifest (flutter/engine#49041)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

497dd81e

fix reorderable_list drop animation (#139362) · 4752b863
yim authored Dec 14, 2023
```
This PR fixes reorderable_list drop animation.

Fixes #138994
```
4752b863

Roll Flutter Engine from 997d3dfa1e74 to 2140942444ea (4 revisions) (#140171) · 12e883eb

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/997d3dfa1e74...2140942444ea

2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 5353de0c25b9 to 92935b91193a (1 revision) (flutter/engine#49044)
2023-12-14 jason-simmons@users.noreply.github.com Reland manual roll of Dart SDK from 82c4571bb2de to a677378ae254 (flutter/engine#49034)
2023-12-14 737941+loic-sharma@users.noreply.github.com [Windows] Remove header guard from generated key map (flutter/engine#48993)
2023-12-14 flar@google.com [Impeller] Round rects with circular ends should not generate ellipses (flutter/engine#49021)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12e883eb

Fix BottomNavigationBarItem label overflow (#120206) · cf3ed1ee

Shashi authored Dec 14, 2023

This PR wraps the `label` with `IntrinsicWidth` and then `Flexible` which allows DefaulTextStyle `TextOverflow.ellipsis` to work. Wrapping `label` directly with `Flexible` brings more space between `icon` and `label`. `IntrinsicWidth` fixes this by giving reasonable width.

Fixes #112163

cf3ed1ee

Roll Flutter Engine from a565cea256c7 to 997d3dfa1e74 (2 revisions) (#140170) · 660c5741

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/a565cea256c7...997d3dfa1e74

2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 0d5356a0f3cb to 5353de0c25b9 (1 revision) (flutter/engine#49040)
2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 4170fba2d89f to 0d5356a0f3cb (1 revision) (flutter/engine#49036)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

660c5741

Revert "Dynamic view sizing" (#140165) · d24c01bd

Lau Ching Jun authored Dec 14, 2023

Reverts flutter/flutter#138648

This caused the app to be stuck in the splash screen on certain phone models.

Context: b/316244317

d24c01bd

🎨

: fix cupertionActionSheet design (#134345) · f8ddd4b6

Akito Nishiyama authored Dec 14, 2023

## Overview
Fixed the implementation of CupertionActionSheet based on [Apple Design Resource](https://www.figma.com/community/file/1248375255495415511).
I also deleted devicePixelRatio because Flutter uses logical pixels based on https://api.flutter.dev/flutter/dart-ui/FlutterView/devicePixelRatio.html.

ISSUE: #134539 

UPDATED GOLDEN: https://flutter-gold.skia.org/search?issue=134345&crs=github&patchsets=3&corpus=flutter

### Before
<img src="https://github.com/flutter/flutter/assets/40790076/8492fe5f-582f-4623-86eb-c60cb88d81a1" width=300>

### After
<img src="https://github.com/flutter/flutter/assets/40790076/fcdd7f7e-6ab5-4b68-a7b0-27a6fc2975b8" width=300>

f8ddd4b6

Make improvements to existing new issue templates (#140142) · 7bebdd3f

huycozy authored Dec 14, 2023

Closes https://github.com/flutter/flutter/issues/139558

In this PR:
- Use `<details open>` to create opened collapsible sections (still be expanded if needed)
- Change checkboxes (at the top of the issue, namely `I have searched the existing issues` and `I have read the guide to filing a bug`) to text only.

### Demo filed issues for `opened collapsible sections`

- [I am having difficulty installing Flutter or getting it to work](https://github.com/huycozy/flutter/issues/8)
- [Report a bug](https://github.com/huycozy/flutter/issues/9)
- [Report a bug in one of Flutter's first-party packages](https://github.com/huycozy/flutter/issues/11)
- [My app is slow or missing frames](https://github.com/huycozy/flutter/issues/12)
- [My app has some non-speed performance issues](https://github.com/huycozy/flutter/issues/10) 

### Demo for `checkboxes to text`

![Screenshot 2023-12-14 at 17 54 44](https://github.com/flutter/flutter/assets/104349824/1472b3bf-6245-4ec9-b7e8-d7ddf3d5a579)

- [I am having difficulty installing Flutter or getting it to work](https://github.com/huycozy/flutter/issues/new?assignees=&labels=&projects=&template=1_activation.yml)
- [Report a bug](https://github.com/huycozy/flutter/issues/new?assignees=&labels=&projects=&template=2_bug.yml)
- [Feature request](https://github.com/huycozy/flutter/issues/new?assignees=&labels=&projects=&template=3_feature_request.yml)
- [The CI infrastructure used by Flutter has a problem](https://github.com/huycozy/flutter/issues/new?assignees=&labels=team-infra&projects=&template=6_infrastructure.yml)
- [Report a bug in one of Flutter's first-party packages](https://github.com/huycozy/flutter/issues/new?assignees=&labels=&projects=&template=9_first_party_packages.yml)

7bebdd3f

Roll Flutter Engine from caf33276468b to a565cea256c7 (1 revision) (#140163) · 14541050

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/caf33276468b...a565cea256c7

2023-12-14 leroux_bruno@yahoo.fr [Windows] Expose channel buffers 'resize' and 'overflow' control commands exposed by the control channel. (flutter/engine#47158)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14541050

Expand and update a few release.yml categories (#140120) · a591cc4f

Parker Lougheed authored Dec 14, 2023

Updates to the current Material Design label, updates MacOS to macOS, and adds a few other DevTools related labels.

a591cc4f

Roll Flutter Engine from 223f4b2465dd to caf33276468b (1 revision) (#140156) · a51e33ac

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/223f4b2465dd...caf33276468b

2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 9746c141d66b to 4170fba2d89f (1 revision) (flutter/engine#49031)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a51e33ac

Roll Packages from b5958e2a8b49 to 1151191c8c13 (10 revisions) (#140154) · 3a20f9ca

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/packages/compare/b5958e2a8b49...1151191c8c13

2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674)
2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669)
2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` filesâ¦ (flutter/packages#5567)
2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634)
2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628)
2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660)
2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522)
2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521)
2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478)
2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3a20f9ca

Roll Flutter Engine from a3f9393f9591 to 223f4b2465dd (1 revision) (#140151) · 625b8017

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/a3f9393f9591...223f4b2465dd

2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 47f84c5cf15d to 9746c141d66b (1 revision) (flutter/engine#49029)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

625b8017

Roll Flutter Engine from 913446eca57c to a3f9393f9591 (2 revisions) (#140144) · e1f954f4

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/913446eca57c...a3f9393f9591

2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 6c2b3d8cecf1 to 47f84c5cf15d (1 revision) (flutter/engine#49020)
2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 89ecb7c9cd2a to 6c2b3d8cecf1 (1 revision) (flutter/engine#49017)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1f954f4

Roll Flutter Engine from 923f9e29d4b5 to 913446eca57c (1 revision) (#140132) · 70828edc

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/923f9e29d4b5...913446eca57c

2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 188515347032 to 89ecb7c9cd2a (2 revisions) (flutter/engine#49016)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70828edc

Roll Flutter Engine from 9f7004e3e30e to 923f9e29d4b5 (7 revisions) (#140130) · 3fda9be6

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/9f7004e3e30e...923f9e29d4b5

2023-12-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Move to `FlutterCompositor` for rendering" (flutter/engine#49015)
2023-12-14 magder@google.com Add xcprivacy privacy manifest to iOS framework (flutter/engine#48951)
2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Made the new blur support 1D blurs (flutter/engine#49001)
2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 69c02c9d56b2 to 188515347032 (1 revision) (flutter/engine#49005)
2023-12-14 bdero@google.com [Impeller] Add golden for clipped+transformed blur. (flutter/engine#48886)
2023-12-14 bdero@google.com [Flutter GPU] Runtime shader import. (flutter/engine#48875)
2023-12-13 737941+loic-sharma@users.noreply.github.com [Windows] Move to `FlutterCompositor` for rendering (flutter/engine#48849)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3fda9be6

Add self back to CODEOWNERS (#140080) · b33b872d

Jenn Magder authored Dec 14, 2023

I'm back from leave.  Revert https://github.com/flutter/flutter/pull/125337 but don't take back the `CODEOWNERS` file itself.

b33b872d

Adapt wording for required Android SDK for plugins (#140043) · fc77dd90
Gustl22 authored Dec 14, 2023
```
Solves https://github.com/flutter/flutter/pull/137115#discussion_r1388251047
```
fc77dd90
[reland] Support conditional bundling of assets based on `--flavor` (#139834) · 935775cb
Andrew Kolos authored Dec 14, 2023
```
Reland of https://github.com/flutter/flutter/pull/132985. Fixes the path to AssetManifest.bin in flavors_test_ios
```
935775cb

Reverts "Roll Flutter Engine from 9f7004e3e30e to 45b95f264d63 (1 revision)" (#140123) · f5050cf4

auto-submit[bot] authored Dec 14, 2023

Reverts flutter/flutter#140108
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/9f7004e3e30e...45b95f264d63

2023-12-13 737941+loic-sharma@users.noreply.github.com [Windows] Move to `FlutterCompositor` for rendering (flutter/engine#48849)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5050cf4

[deps] update Android SDK to 34 (#138183) · 3b370c85

Daco Harkes authored Dec 14, 2023

Update Android SDK from 33 to 34.

Following the engine update:

* https://github.com/flutter/engine/pull/47839

3b370c85

Roll Flutter Engine from 9f7004e3e30e to 45b95f264d63 (1 revision) (#140108) · 1ff76863

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/9f7004e3e30e...45b95f264d63

2023-12-13 737941+loic-sharma@users.noreply.github.com [Windows] Move to `FlutterCompositor` for rendering (flutter/engine#48849)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1ff76863

Catch `Stopwatch` with static analysis (#140019) · f2c6f03c

LongCatIsLooong authored Dec 14, 2023

I did not include the `'// flutter_ignore_for_file: stopwatch (see analyze.dart)'` directive since it's currently not used, and adding that shouldn't be too difficult.

f2c6f03c

Overlay supports unconstrained environments (#139513) · 41622725

Michael Goderbauer authored Dec 14, 2023

Fixes https://github.com/flutter/flutter/issues/137875.

Unfortunately, we cannot auto-detect which OverlayEntry should be sizing the Overlay in unconstrained environment. So, this PR adds a special flag to annotate the Overlay Entry that should be used.

41622725

Bump github/codeql-action from 2.22.10 to 3.22.11 (#140087) · cea2726b

dependabot[bot] authored Dec 14, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.10 to 3.22.11.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/b374143c1149a9115d881581d29b8390bbcbb59c"><code>b374143</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2034">#2034</a> from github/update-v3.22.11-64e61baea</li>
<li><a href="https://github.com/github/codeql-action/commit/e2b5cc75ce46a4a33dbafa57e19019d6bd5a67be"><code>e2b5cc7</code></a> Update changelog for v3.22.11</li>
<li><a href="https://github.com/github/codeql-action/commit/64e61baeac852f409b48440cebec029a2d978f90"><code>64e61ba</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2006">#2006</a> from github/nickfyson/node-20</li>
<li><a href="https://github.com/github/codeql-action/commit/c757f9f6de6bebddbc274b26f9282d0199ab0512"><code>c757f9f</code></a> Apply suggestions from code review</li>
<li><a href="https://github.com/github/codeql-action/commit/7898bc2041d7b0bc5e6f97169b127ff75eee02f2"><code>7898bc2</code></a> add pr check for node version consistency</li>
<li><a href="https://github.com/github/codeql-action/commit/6b5b95806324a3ee7e164709fbfc152595556fe9"><code>6b5b958</code></a> remove dedundant single quotes from node version strings</li>
<li><a href="https://github.com/github/codeql-action/commit/ea1e72c6697fe8b190253b561a93508e587ea209"><code>ea1e72c</code></a> Update .github/workflows/pr-checks.yml</li>
<li><a href="https://github.com/github/codeql-action/commit/b974542e9f06e790793093fb5d47fc462c0d20bf"><code>b974542</code></a> Merge branch 'main' into nickfyson/node-20</li>
<li><a href="https://github.com/github/codeql-action/commit/b995212303c9b90cac695cf6c0b558f54fb613f6"><code>b995212</code></a> Bump the actions group with 2 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2024">#2024</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/3c1878d8f9d642687f3f2ba76af5406aa16ce232"><code>3c1878d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2029">#2029</a> from github/mergeback/v2.22.10-to-main-305f6546</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/305f6546310b9203e892c28c1484e82977f4f63d...b374143c1149a9115d881581d29b8390bbcbb59c">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.10&new-version=3.22.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

cea2726b

Remove deprecated `ThemeData.selectedRowColor` (#139080) · 5be1918b
Renzo Olivares authored Dec 14, 2023
```
Part of: https://github.com/flutter/flutter/issues/139243
```
5be1918b

Unpin mac_toolchain version (#139938) · 0c280d47

Victoria Ashworth authored Dec 14, 2023

mac_toolchain has been updated to no longer have 2 minute slowdown (https://github.com/flutter/flutter/issues/138109), so unpin to use the latest version.

0c280d47

Optimize file transfer when using proxied devices. (#139968) · c1caa24a

Lau Ching Jun authored Dec 14, 2023

List of changes:
1. Optimizations in FileTransfer. a. Use `stream.forEach` instead of `await for`. b. Type cast `List<int>` to `Uint8List` instead of using `Uint8List.fromList` results in (presumably) fewer copy and faster execution. c. Iterate through `Uint8List` with regular for loop instead of for-in loop.
2. Precache the block hashes of a file, and reuse it on subsequent runs.

c1caa24a