1. 08 Nov, 2017 1 commit
  2. 30 Oct, 2017 1 commit
  3. 26 Sep, 2017 1 commit
    • Todd Volkert's avatar
      Run command validation on all commands. (#12246) · a08b5e00
      Todd Volkert authored
      This makes command validation happen as part of `verifyThenRunCommand()`,
      using a newly introduced protected method (`validateCommand()`) rather than
      a `commandValidator` property (that subclasses were responsible for manually
      invoking).
      a08b5e00
  4. 23 Aug, 2017 1 commit
  5. 22 Aug, 2017 2 commits
  6. 19 Jul, 2017 1 commit
  7. 29 Jun, 2017 2 commits
  8. 28 Jun, 2017 1 commit
  9. 24 Jun, 2017 1 commit
  10. 23 Jun, 2017 1 commit
    • Ian Hickson's avatar
      Deep linking: automatically push the route hiearchy on load. (#10894) · 9adb4a78
      Ian Hickson authored
      The main purpose of this PR is to make it so that when you set the
      initial route and it's a hierarchical route (e.g. `/a/b/c`), it
      implies multiple pushes, one for each step of the route (so in that
      case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those
      routes don't exist, it falls back to '/'.
      
      As part of doing that, I:
      
       * Changed the default for MaterialApp.initialRoute to honor the
         actual initial route.
      
       * Added a MaterialApp.onUnknownRoute for handling bad routes.
      
       * Added a feature to flutter_driver that allows the host test script
         and the device test app to communicate.
      
       * Added a test to make sure `flutter drive --route` works.
         (Hopefully that will also prove `flutter run --route` works, though
         this isn't testing the `flutter` tool's side of that. My main
         concern is over whether the engine side works.)
      
       * Fixed `flutter drive` to output the right target file name.
      
       * Changed how the stocks app represents its data, so that we can
         show a page for a stock before we know if it exists.
      
       * Made it possible to show a stock page that doesn't exist. It shows
         a progress indicator if we're loading the data, or else shows a
         message saying it doesn't exist.
      
       * Changed the pathing structure of routes in stocks to work more
         sanely.
      
       * Made search in the stocks app actually work (before it only worked
         if we happened to accidentally trigger a rebuild). Added a test.
      
       * Replaced some custom code in the stocks app with a BackButton.
      
       * Added a "color" feature to BackButton to support the stocks use case.
      
       * Spaced out the ErrorWidget text a bit more.
      
       * Added `RouteSettings.copyWith`, which I ended up not using.
      
       * Improved the error messages around routing.
      
      While I was in some files I made a few formatting fixes, fixed some
      code health issues, and also removed `flaky: true` from some devicelab
      tests that have been stable for a while. Also added some documentation
      here and there.
      9adb4a78
  11. 16 Jun, 2017 1 commit
  12. 26 Apr, 2017 1 commit
    • Todd Volkert's avatar
      Switch many `Device` methods to be async (#9587) · 60c5ffc1
      Todd Volkert authored
      `adb` can sometimes hang, which will in turn hang the Dart isolate if
      we're using `Process.runSync()`. This changes many of the `Device` methods
      to return `Future<T>` in order to allow them to use the async process
      methods. A future change will add timeouts to the associated calls so
      that we can properly alert the user to the hung `adb` process.
      
      This is work towards #7102, #9567
      60c5ffc1
  13. 17 Mar, 2017 1 commit
  14. 10 Mar, 2017 1 commit
  15. 04 Mar, 2017 1 commit
  16. 23 Feb, 2017 1 commit
  17. 21 Feb, 2017 1 commit
  18. 14 Feb, 2017 2 commits
  19. 13 Feb, 2017 1 commit
  20. 27 Jan, 2017 4 commits
  21. 23 Jan, 2017 1 commit
  22. 19 Jan, 2017 1 commit
  23. 06 Jan, 2017 1 commit
  24. 17 Nov, 2016 1 commit
    • Todd Volkert's avatar
      Allow for application-specific log readers. (#6898) · 9cb914df
      Todd Volkert authored
      * Allow for application-specific log readers.
      
      When running with prebuilt application binaries, those applications
      aren't guaranteed to be named "Runner" (as it is when we build
      the app locally in Flutter tools)
      9cb914df
  25. 14 Nov, 2016 2 commits
    • Dan Rubel's avatar
      Refactor flutter command exit code - part 3 of 3 (#6838) · 34e466f1
      Dan Rubel authored
      * Remove the workaround that pinned args to v0.13.6
      This reverts most of the changes in commit 6331b6c8
      * throw exception if exit code is not an integer
      * rework command infrastructure to throw ToolExit when non-zero exitCode
      * convert commands to return Future<Null>
      * cleanup remaining commands to use throwToolExit for non-zero exit code
      * remove isUnusual exception message
      * add type annotations for updated args package
      34e466f1
    • Dan Rubel's avatar
      Refactor flutter command exit code - part 2 (#6817) · e384c0d9
      Dan Rubel authored
      * convert pubGet to throw ToolExit on non-zero exit code
      * convert commandValidator to throw ToolExit for non-zero exit code
      * convert flutter commands to throw ToolExit for non-zero exit code
      * use convenience method throwToolExit
      * only show "if this problem persists" for unusual exceptions
      e384c0d9
  26. 17 Oct, 2016 1 commit
  27. 16 Sep, 2016 1 commit
    • Dan Rubel's avatar
      Refactor flutter command execution (#5892) · 18212382
      Dan Rubel authored
      * refactor _run to runCmd
      
      * replace requiresProjectRoot getter with call to commandValidator
      
      * replace requiresDevice getter with call to findTargetDevice
      
      * trace command requires a debug connection, not a device
      
      * inline androidOnly getter
      
      * rename command methods to verifyTheRunCmd and runCmd
      
      * move common verification into BuildSubCommand
      
      * rename deviceForCommand to device
      
      * rename methods to verifyThenRunCommand and runCommand
      18212382
  28. 09 Sep, 2016 3 commits
  29. 01 Sep, 2016 1 commit
  30. 05 Aug, 2016 1 commit
  31. 25 Jul, 2016 1 commit