Commits · a628814ebd25bb7617aae636031ca880b9e25a57 · abdullh.alsoleman / Front-End

13 Feb, 2024 6 commits

Allow deprecated members from the Dart SDK and Flutter Engine to roll in (#143347) · a628814e

Matan Lurey authored Feb 13, 2024

Namely, without breaking the tree. This is a deliberate policy decision
change.

See https://github.com/flutter/flutter/issues/143312.

a628814e

[Re-re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions (#143341) · 8ba086a2

Gray Mackall authored Feb 13, 2024

This is a direct revert of (the revert of (the reland of (the policy pr))): https://github.com/flutter/flutter/pull/143132.

The only change is:
1. to put a conditional all on one line, because the packages repository has a test that uses an old flutter project to make sure nothing regresses. The old project uses an old gradle version, and the old gradle version bundles an old groovy version, and the old groovy version has a bug where lines that start with `&&` don't always work: https://issues.apache.org/jira/browse/GROOVY-7218 (I enjoy that the revert reason ends up providing another strong justification to go forward with the policy). Also thanks to @reidbaker for pointing out this bug.
2. I also made a slight formatting change to the messages that print when out of the support bounds, which I think looks slightly better.

I tested this with on a branch that included a revert of https://github.com/flutter/flutter/pull/142008, and was able to recreate the failure and verify that it was resolved by 1).

8ba086a2

Roll Packages from 0a692590a885 to 9385bbb3cf46 (7 revisions) (#143366) · 634fcc71

engine-flutter-autoroll authored Feb 13, 2024

https://github.com/flutter/packages/compare/0a692590a885...9385bbb3cf46

2024-02-13 louisehsu@google.com Convert startProductRequest(), finishTransaction(), restoreTransactions(), presentCodeRedemptionSheet() to pigeon (flutter/packages#6032)
2024-02-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20231013 to 20240205 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6096)
2024-02-12 stuartmorgan@google.com [local_auth] Rename iOS classes (flutter/packages#6108)
2024-02-12 jakubwalusiak@gmail.com [video_player_android] Handle BehindLiveWindowException (flutter/packages#5869)
2024-02-12 reidbaker@google.com [in_app_purchase] Add alternative billing apis for android (flutter/packages#6056)
2024-02-12 stuartmorgan@google.com [webview_flutter] Update compileSdk to 34 (flutter/packages#6106)
2024-02-12 37270954+foxtrotravi@users.noreply.github.com [cupertino_icons] Add example to cupertino icons (flutter/packages#5312)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

634fcc71

Fix `InputDecorator`s `suffix` and `prefix` widgets are tappable when hidden (#143308) · 1f8d110b

Taha Tesser authored Feb 13, 2024

fixes [The InputDecoration's suffix and prefix widget can be tapped even if it does not appear](https://github.com/flutter/flutter/issues/139916)

This PR also updates two existing tests to pass the tests for this PR. These tests are trying to tap prefix and  suffix widgets when they're hidden. While the linked issue had visible prefix and suffix widgets https://github.com/flutter/flutter/issues/39376 for reproduction.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(MainApp());
}

class MainApp extends StatelessWidget {
  final _messangerKey = GlobalKey<ScaffoldMessengerState>();

  MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      scaffoldMessengerKey: _messangerKey,
      home: Scaffold(
        body: Container(
          alignment: Alignment.center,
          padding: const EdgeInsets.all(16.0),
          child: TextField(
            decoration: InputDecoration(
              labelText: 'Something',
              prefix: GestureDetector(
                onTap: () {
                  _messangerKey.currentState?.showSnackBar(
                      const SnackBar(content: Text('A tap has occurred')));
                },
                child: const Icon(Icons.search),
              ),
              suffix: GestureDetector(
                onTap: () {
                  _messangerKey.currentState?.showSnackBar(
                      const SnackBar(content: Text('A tap has occurred')));
                },
                child: const Icon(Icons.search),
              ),
            ),
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before
![ScreenRecording2024-02-12at18 40 34-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/c101e0d6-ce5a-4b28-9626-28bcb83d2a5c)

### After
![ScreenRecording2024-02-12at18 40 10-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/923b348e-8adf-4d64-9dc3-e75d30e3e2fb)

1f8d110b

Pass-Through `inputFormatters` in `DropdownMenu` (#143250) · e93a10d1
Tirth authored Feb 13, 2024
```
Pass-Through `inputFormatters` in `DropdownMenu`.

Fixes: #142374
```
e93a10d1
Fix `insetPadding` parameter nullability for dialogs (#143305) · d271791e
Taha Tesser authored Feb 13, 2024
```
fixes [`insetPadding` should be nullable in dialogs](https://github.com/flutter/flutter/issues/117125)
```
d271791e

12 Feb, 2024 15 commits

Revert "Migrate integration_test plugin to Gradle Kotlin DSL (#142008)" (#143329) · 0650b768
Camille Simon authored Feb 12, 2024
```
This reverts https://github.com/flutter/flutter/pull/142008 because it broke the Flutter --> packages roller.
```
0650b768
Badge class doc typo - missing [ (#143318) · 525cffd7
Ross Llewallyn authored Feb 12, 2024
```
Doc typo fix

No issue made
```
525cffd7

Reverts "Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (#143322)" (#143338) · 0377bc3a

auto-submit[bot] authored Feb 12, 2024

Reverts flutter/flutter#143322

Initiated by: zanderso

Reason for reverting: The tree is red.

Original PR Author: engine-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/1c3ecee77350...a19077503a0c

2024-02-12 737941+loic-sharma@users.noreply.github.com [Windows] Make the view own its EGL surface (flutter/engine#50421)
2024-02-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 5c9e79e66364 to dca13675e65e (1 revision) (flutter/engine#50559)
2024-02-12 1889916+miguelfrde@users.noreply.github.com [fuchsia] Update Inspect library usage (flutter/engine#50467)
2024-02-12 zanderso@users.noreply.github.com Initializes RBE in the build config runner (flutter/engine#50543)
2024-02-12 tugorez@users.noreply.github.com Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward] (flutter/engine#50533)
2024-02-12 dnfield@google.com Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests (flutter/engine#50540)
2024-02-12 30870216+gaaclarke@users.noreply.github.com [Impeller] deleted the old blur (flutter/engine#50470)
2024-02-12 kjlubick@users.noreply.github.com Update codec defines for Skia (flutter/engine#50554)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0377bc3a

Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (#143322) · 1e6a9024

engine-flutter-autoroll authored Feb 12, 2024

https://github.com/flutter/engine/compare/1c3ecee77350...a19077503a0c

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e6a9024

[web] Move JS interop to extension types (#143274) · e1645b15
Kevin Moore authored Feb 12, 2024
```
Now that we can bump the min SDK to latest.
```
e1645b15
Add documentation for best practices for `StreamBuilder` like `FutureBuilder` (#143295) · 52f923c3
Valentin Vignal authored Feb 12, 2024
```
Fixes https://github.com/flutter/flutter/issues/142189
```
52f923c3

Roll Flutter Engine from 8806987182a3 to 1c3ecee77350 (1 revision) (#143315) · cf2c6841

engine-flutter-autoroll authored Feb 12, 2024

https://github.com/flutter/engine/compare/8806987182a3...1c3ecee77350

2024-02-12 zanderso@users.noreply.github.com Remove host_debug_unopt build from linux_host_engine.json (flutter/engine#50555)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cf2c6841

Fix dual focus issue in CheckboxListTile, RadioListTile and SwitchListTile (#143213) · 49f620d8
Nitesh Sharma authored Feb 12, 2024
```
These widgets can now only receive focus once when tabbing through the focus tree.
```
49f620d8
Revert "[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (#143314) · ace3e58f
Reid Baker authored Feb 12, 2024
```
Reverts flutter/flutter#143132
```
ace3e58f

Update integration_test iOS FTL README script to remove targeted version (#143248) · 1d25b0c7

Jenn Magder authored Feb 12, 2024

1. Remove `dev_target` from suggested Firebase Test Lab iOS script and use wildcard instead.
2. First run `flutter clean` before building to avoid collisions between runs.
3. Use `zip --must-match` in case the xctestrun or `Release-iphoneos` directories are missing (like ran with `--profile` instead of `--release` on purpose) to fail instead of zipping up only part of what's needed.

This came out of a discussion with FTL about these instructions and I tried to run them locally and avoided setting `dev_target`.

See also #74428

1d25b0c7

Remove unnecessary 'debugLabel: null'. (#143253) · 5a649aa8

Konstantin Scheglov authored Feb 12, 2024

There was a change https://dart-review.googlesource.com/c/sdk/+/350920 to the analyzer that caused reporting this lint.

https://github.com/flutter/flutter/issues/143254

5a649aa8

Introduce `iconAlignment` for the buttons with icon (#137348) · 10442399

Tirth authored Feb 12, 2024

Adds `iconAlignment` property to `ButtonStyleButton` widget.

Fixes #89564

### Example

https://github.com/flutter/flutter/assets/13456345/1b5236c4-5c60-4915-b3c6-0a56c43f8a19

10442399

Roll Packages from 11152d2bc8f3 to 0a692590a885 (4 revisions) (#143306) · 82668f16

engine-flutter-autoroll authored Feb 12, 2024

https://github.com/flutter/packages/compare/11152d2bc8f3...0a692590a885

2024-02-09 everythingoutdated@gmail.com [local_auth]: Renamed `local_auth_ios` to `local_auth_darwin` (flutter/packages#5809)
2024-02-09 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (flutter/packages#3444)
2024-02-09 David.Chopin@wwt.com [go_router] Expose full `Uri` on `GoRouterState` in `GoRouterRedirect` (flutter/packages#5742)
2024-02-09 stuartmorgan@google.com [webview_flutter] Minor test cleanup (flutter/packages#6031)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82668f16

Roll Flutter Engine from 4f119619dfa8 to 8806987182a3 (1 revision) (#143304) · 75784a20

engine-flutter-autoroll authored Feb 12, 2024

https://github.com/flutter/engine/compare/4f119619dfa8...8806987182a3

2024-02-12 skia-flutter-autoroll@skia.org Roll Dart SDK from efc514815312 to 5c9e79e66364 (1 revision) (flutter/engine#50552)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

75784a20

Roll Flutter Engine from b0753c0e25f8 to 4f119619dfa8 (1 revision) (#143291) · e1752040

engine-flutter-autoroll authored Feb 12, 2024

https://github.com/flutter/engine/compare/b0753c0e25f8...4f119619dfa8

2024-02-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uoByvKUBgYXArsFGL... to RVHAIKU50ogkiV-Lj... (flutter/engine#50546)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uoByvKUBgYXA to RVHAIKU50ogk

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1752040

11 Feb, 2024 3 commits

Roll Flutter Engine from 936495d94cc6 to b0753c0e25f8 (1 revision) (#143282) · dbb3c16a

engine-flutter-autoroll authored Feb 11, 2024

https://github.com/flutter/engine/compare/936495d94cc6...b0753c0e25f8

2024-02-11 skia-flutter-autoroll@skia.org Roll Dart SDK from c64c3d6bae2f to efc514815312 (1 revision) (flutter/engine#50544)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbb3c16a

Roll Flutter Engine from b06b3e0d75ad to 936495d94cc6 (1 revision) (#143280) · 8533d276

engine-flutter-autoroll authored Feb 11, 2024

https://github.com/flutter/engine/compare/b06b3e0d75ad...936495d94cc6

2024-02-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from H1cNBBNhq0bEpcyPs... to uoByvKUBgYXArsFGL... (flutter/engine#50542)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from H1cNBBNhq0bE to uoByvKUBgYXA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8533d276

Roll Flutter Engine from 1478f4e75dd9 to b06b3e0d75ad (1 revision) (#143275) · d0061840

engine-flutter-autoroll authored Feb 11, 2024

https://github.com/flutter/engine/compare/1478f4e75dd9...b06b3e0d75ad

2024-02-10 matanlurey@users.noreply.github.com Remove legacy references to `Cirrus` and suspected dead-code. (flutter/engine#50442)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0061840

10 Feb, 2024 10 commits

Fix text painter longest line resizing logic for `TextWidthBasis.longestLine` (#143024) · bc49cf80
LongCatIsLooong authored Feb 10, 2024
```
Fixes https://github.com/flutter/flutter/issues/142309.
```
bc49cf80

Roll Flutter Engine from e6ceb3504f50 to 1478f4e75dd9 (1 revision) (#143273) · 4fdfe785

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/e6ceb3504f50...1478f4e75dd9

2024-02-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 0119704af522 to c64c3d6bae2f (1 revision) (flutter/engine#50538)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4fdfe785

Move Windows arm64 tests to bringup true (#143272) · 9f832218
Zachary Anderson authored Feb 10, 2024
```
For https://github.com/flutter/flutter/issues/143271
```
9f832218

Roll Flutter Engine from 3c5149ccde38 to e6ceb3504f50 (1 revision) (#143267) · 7ad7d3ac

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/3c5149ccde38...e6ceb3504f50

2024-02-10 skia-flutter-autoroll@skia.org Roll Dart SDK from ed5730124fd1 to 0119704af522 (1 revision) (flutter/engine#50527)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7ad7d3ac

Roll Flutter Engine from c587bd69985f to 3c5149ccde38 (2 revisions) (#143266) · 581ec63d

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/c587bd69985f...3c5149ccde38

2024-02-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 10ca8dc7d2b4 to ed5730124fd1 (1 revision) (flutter/engine#50523)
2024-02-10 zanderso@users.noreply.github.com Update build/rbe CIPD hash (flutter/engine#50524)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

581ec63d

Roll Flutter Engine from e08b6c899c42 to c587bd69985f (1 revision) (#143265) · bb3374f2

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/e08b6c899c42...c587bd69985f

2024-02-10 zanderso@users.noreply.github.com Adds a runner to engine_build_configs (flutter/engine#50342)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb3374f2

Roll Flutter Engine from 1b8f23bbd099 to e08b6c899c42 (2 revisions) (#143264) · f3e367be

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/1b8f23bbd099...e08b6c899c42

2024-02-10 dnfield@google.com Clean up additional NDK helper related code (flutter/engine#50518)
2024-02-09 tugorez@users.noreply.github.com Make the web engine publish view forward focus and unfocus events (flutter/engine#50177)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f3e367be

Roll Flutter Engine from 41daa5b913b9 to 1b8f23bbd099 (2 revisions) (#143261) · ee8d3f5e

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/41daa5b913b9...1b8f23bbd099

2024-02-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RK2irywND2DKT4l6C... to H1cNBBNhq0bEpcyPs... (flutter/engine#50517)
2024-02-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 444f7a422da4 to 10ca8dc7d2b4 (1 revision) (flutter/engine#50516)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RK2irywND2DK to H1cNBBNhq0bE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ee8d3f5e

Roll Flutter Engine from f969c52f133a to 41daa5b913b9 (1 revision) (#143258) · 923c6ed3

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/f969c52f133a...41daa5b913b9

2024-02-09 chinmaygarde@google.com [Impeller] Add --enable-impeller-vulkan-playgrounds to ./flutter/tools/gn (flutter/engine#50477)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

923c6ed3

Roll Flutter Engine from 6a3b0216ff5b to f969c52f133a (3 revisions) (#143256) · e38e7d78

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/6a3b0216ff5b...f969c52f133a

2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Remove the unused Vulkan queue submit task runner (flutter/engine#50511)
2024-02-09 zanderso@users.noreply.github.com Make .style.yapf and .pylintrc agree on line length (flutter/engine#50510)
2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Call vkQueuePresentKHR through the ContextVK's synchronized graphics queue wrapper (flutter/engine#50509)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e38e7d78

09 Feb, 2024 6 commits

Roll Flutter Engine from 8c521eb24171 to 6a3b0216ff5b (4 revisions) (#143251) · d385d027

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/8c521eb24171...6a3b0216ff5b

2024-02-09 30870216+gaaclarke@users.noreply.github.com [Impeller] cleaned up StrokePathGeometry and removed runtime polymorphism (flutter/engine#50506)
2024-02-09 ditman@gmail.com [web] Fix HtmlViewEmbedder.dispose (flutter/engine#50482)
2024-02-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 03130d49f214 to 444f7a422da4 (6 revisions) (flutter/engine#50502)
2024-02-09 jonahwilliams@google.com [Impeller] improve performance of polyline and stroke generation by reducing allocation and lambda usage. (flutter/engine#50379)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d385d027

Upgrade leak_tracker. (#143236) · b48dfca3
Polina Cherkasova authored Feb 09, 2024

b48dfca3

Fix: performance improvement on golden test comparison (#142913) · 2f117c54

Kris Pypen authored Feb 09, 2024

During golden test image comparison 2 lists of a different type are compared with the method "identical", so this will never be true. The test image is a _Uint8ArrayView while the master image is an Uint8List. So that results in always a heavy computation to get the difference between the test and the master image.

When you run this test snippet I go from 51 seconds to 14 seconds:
```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  for (int i = 0; i < 100; i++) {
    testWidgets('Small test', (WidgetTester tester) async {
      await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Text('jo')));
      await expectLater(find.byType(Text), matchesGoldenFile('main.png'));
    });
  }
}
```

2f117c54

Implementing `switch` expressions in `lib/src/material/` (#142793) · 1887bc41

Nate authored Feb 09, 2024

This PR is the 6áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634)

The current focus is on `packages/flutter/lib/src/material/`. The previous 2 PRs covered files in this directory starting with letters `a-m`; this one takes care of everything else.

1887bc41

Add position data to `OnDragEnd` callback (#140378) · fa71e802

Henry Riehl authored Feb 09, 2024

This PR adds localPosition/globalPosition data to the `DragEndDetails`
argument of the `onDragEnd` callback.

fa71e802

Roll Flutter Engine from 1232d598f7c4 to 8c521eb24171 (2 revisions) (#143237) · ed02cf2f

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/1232d598f7c4...8c521eb24171

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from fbe1d2265637 to 4081496b7693 (1 revision) (flutter/engine#50499)
2024-02-09 zanderso@users.noreply.github.com Supports building with RBE on a Windows host. (flutter/engine#49877)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ed02cf2f