1. 12 Sep, 2023 1 commit
  2. 27 Jun, 2023 1 commit
    • Ben Konyi's avatar
      Reland "Fix issue where DevTools would not be immediately available when using... · 5ea2be69
      Ben Konyi authored
      Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (#129368)
      
      **Original Description:**
      
      > Service extensions are unable to handle requests when the isolate they
      were registered on is paused. The DevTools launcher logic was waiting
      for some service extension invocations to complete before advertising
      the already active DevTools instance, but when --start-paused was
      provided these requests would never complete, preventing users from
      using DevTools to resume the paused isolate.
      > 
      > Fixes https://github.com/flutter/flutter/issues/126691
      
      **Additional changes in this PR:**
      
      The failures listed in https://github.com/flutter/flutter/pull/128117
      appear to be related to a shutdown race. It's possible for the test to
      complete while the tool is in the process of starting and advertising
      DevTools, so we need to perform a check of `_shutdown` in
      `FlutterResidentDevtoolsHandler` before advertising DevTools.
      
      Before the original fix, this check was being performed immediately
      after invoking the service extensions, which creates an asynchronous gap
      in execution. With #126698, the callsite of the service extensions was
      moved and the `_shutdown` check wasn't, allowing for the tool to attempt
      to advertise DevTools after the DevTools server had been cleaned up.
      
      ---------
      Co-authored-by: 's avatarZachary Anderson <zanderso@users.noreply.github.com>
      5ea2be69
  3. 02 Jun, 2023 1 commit
    • Zachary Anderson's avatar
      Revert "Fix issue where DevTools would not be immediately available when using... · fdb71de7
      Zachary Anderson authored
      Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (#128117)
      
      Reverts flutter/flutter#126698
      
      There are a bunch of tool crashes on CI that start with this commit. I'm
      not sure this PR is the cause because there is no backtrace from the
      tool on the crashes. The only error message is `Oops; flutter has exited
      unexpectedly: "Null check operator used on a null value`.
      fdb71de7
  4. 01 Jun, 2023 1 commit
  5. 28 Feb, 2023 1 commit
  6. 27 Feb, 2023 2 commits
  7. 17 Feb, 2023 1 commit
  8. 13 Feb, 2023 1 commit
  9. 06 Feb, 2023 1 commit
  10. 01 Feb, 2023 1 commit
  11. 30 Jan, 2023 1 commit
  12. 27 Jan, 2023 1 commit
  13. 25 Jan, 2023 1 commit
  14. 15 Jun, 2022 1 commit
  15. 07 May, 2022 1 commit
  16. 06 May, 2022 1 commit
  17. 27 Apr, 2022 1 commit
  18. 10 Dec, 2021 1 commit
  19. 24 Jun, 2021 1 commit
  20. 04 Jun, 2021 1 commit
  21. 18 May, 2021 1 commit
  22. 13 May, 2021 1 commit
  23. 29 Apr, 2021 1 commit
  24. 18 Apr, 2021 1 commit
  25. 15 Apr, 2021 1 commit
  26. 10 Mar, 2021 1 commit
  27. 24 Feb, 2021 1 commit
  28. 11 Feb, 2021 1 commit
  29. 09 Feb, 2021 1 commit