1. 10 Sep, 2019 1 commit
  2. 26 Jul, 2019 1 commit
  3. 25 Jun, 2019 1 commit
  4. 24 Apr, 2019 2 commits
    • Anthony's avatar
      [Material] Adaptive Slider constructor (#30572) · 0572f158
      Anthony authored
      Adds an adaptive constructor for the Material Slider. An adaptive widget is one that renders itself as Material on Android, and Cupertino on iOS. This work is based off of a similar feature on Switches: bbb080b3#diff-fe2bb980c6207699cbf45538fe927afa.
      
      The motivation for this change is that we should provide adaptive constructors for as many widgets as necessary in the Material library. In Material, it is suggested that the slider is an iOS-style slider.
      0572f158
    • Anthony's avatar
      [Material] Update slider and slider theme with new sizes, shapes, and color... · 96f15c74
      Anthony authored
      [Material] Update slider and slider theme with new sizes, shapes, and color mappings (2nd attempt) (#31564)
      
      #30390 was rolled back. This PR will re-roll it forward.
      
      This PR makes a number of changes to the visual appearance of material sliders:
      
      Sizes/Shapes
      ** enabled thumb radius from 6 to 10
      ** disabled thumb radius from 4 to 10 with no gap
      ** default track shape is a rounded rect rather than a rect
      **
      Colors
      ** all of the colors now use the new color scheme
      ** overlay opacity has been reduce from 16% to 12%
      ** value indicator text color now respects the indicator it is on by using onPrimary
      ** disabledThumb color no respects the surface it is on by using onSurface
      The slider theme is also now constructed consistently with other theme objects within the ThemeData. By default, all values are null, and have default values that are resolved in the slider itself, rather than in the slider theme.
      96f15c74
  5. 20 Apr, 2019 1 commit
  6. 18 Apr, 2019 1 commit
    • Anthony's avatar
      [Material] Update slider and slider theme with new sizes, shapes, and color mappings (#30390) · b1039f0f
      Anthony authored
      This PR makes a number of changes to the visual appearance of material sliders:
      
      Sizes/Shapes
      ** enabled thumb radius from 6 to 10
      ** disabled thumb radius from 4 to 10 with no gap
      ** default track shape is a rounded rect rather than a rect
      **
      Colors
      ** all of the colors now use the new color scheme
      ** overlay opacity has been reduce from 16% to 12%
      ** value indicator text color now respects the indicator it is on by using onPrimary
      ** disabledThumb color no respects the surface it is on by using onSurface
      The slider theme is also now constructed consistently with other theme objects within the ThemeData. By default, all values are null, and have default values that are resolved in the slider itself, rather than in the slider theme.
      b1039f0f
  7. 06 Mar, 2019 1 commit
  8. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  9. 26 Feb, 2019 1 commit
  10. 15 Feb, 2019 1 commit
  11. 06 Feb, 2019 1 commit
  12. 01 Feb, 2019 2 commits
  13. 18 Dec, 2018 1 commit
  14. 08 Nov, 2018 1 commit
  15. 05 Nov, 2018 1 commit
    • Greg Spencer's avatar
      Rewrite the analyze-sample-code script to also analyze snippets (#23893) · 202b045b
      Greg Spencer authored
      This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
      
      It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
      
      I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
      
      For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
      202b045b
  16. 25 Oct, 2018 1 commit
  17. 23 Sep, 2018 1 commit
  18. 14 Sep, 2018 1 commit
  19. 12 Sep, 2018 1 commit
  20. 07 Sep, 2018 1 commit
  21. 21 Aug, 2018 1 commit
  22. 02 Aug, 2018 1 commit
  23. 27 Jul, 2018 1 commit
  24. 23 Jul, 2018 1 commit
  25. 16 Jul, 2018 2 commits
  26. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  27. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  28. 07 Jun, 2018 1 commit
  29. 05 Jun, 2018 1 commit
  30. 11 May, 2018 1 commit
    • Greg Spencer's avatar
      Add onChangeStart and onChangeEnd to slider. (#17298) · c2c64a5a
      Greg Spencer authored
      This fixes #17169 by adding onChangeStart and onChangeEnd to the slider. These will be called when the user starts a change, and when they end a change, regardless of whether that change is a tap or a drag.
      
      These differ from onChanged, in that they only report when the user starts and ends an interaction, not at every slight change.
      c2c64a5a
  31. 03 May, 2018 1 commit
  32. 12 Apr, 2018 1 commit
  33. 25 Mar, 2018 1 commit
  34. 20 Mar, 2018 1 commit
  35. 19 Mar, 2018 1 commit
  36. 13 Mar, 2018 1 commit
  37. 09 Mar, 2018 1 commit
    • Greg Spencer's avatar
      Adding edge avoidance, painting tests, general cleanup (#15078) · 7fab7f6d
      Greg Spencer authored
      Fixed the real repaint problem the Slider had (missing addListener), and added tests for it.
      
      Added GlobalKey reparenting test.
      
      Added the ability for the value indicator to slide left and right to avoid falling off the edge of the screen.
      It only shifts as much as it can without deforming, but even at large text scales, that is enough to keep the text on the screen.
      
      Updated the formatting on theme_data.dart and others to use longer line length.
      
      Also, removed a color tween that faded the value indicator in as it scaled, since that wasn't to spec.
      7fab7f6d