1. 27 Jul, 2018 1 commit
  2. 23 Jul, 2018 1 commit
  3. 16 Jul, 2018 2 commits
  4. 21 Jun, 2018 1 commit
    • amirh's avatar
      Move the notch computation from the FAB to the BAB. (#18372) · c39f2f26
      amirh authored
      Move the notch computation from the FAB to the BAB.
      
      The notch in the BAB (bottom action bar) for the FAB (floating action button) was previously kept as part of the FAB's implementation. This was done to keep the shape of the FAB and the shape of the notch coupled.
      That approach resulted in a somewhat complex and 'non Fluttery' mechanism for propagating the notch computation from the FAB to the BAB.
      
      This CL uncouples the FAB and the notch computation.
      With the new API the BAB computes its overall shape including the notch using a NotchedShape delegate.
      
      This includes multiple breaking changes:
        * Scaffold.setFloatingActionButtonNotchFor is deleted.
        * The ComputeNotch type is deleted.
        * The hasNotch property of BottomAppBar is deleted.
        * The notchMargin property of FloatingActionButton is deleted.
      
      Quick migration guide from the previous API:
      
      | Previous API | New API |
      | ------------------|-------------|
      | BottomAppBar(hasNotch: false) | BottomAppBar() |
      | Using a FloatingActionButton with: BottomAppBar() / BottomAppBar(hasNotch: true) | BottomAppBar(shape: CircularNotchedRectangle()) |
      | Scaffold.setFloatingActionButtonNotchFor(..) | No longer supported |
      c39f2f26
  5. 06 Jun, 2018 1 commit
    • amirh's avatar
      _markNeedsClip() when clipper type has changed. (#18248) · 0a26ac09
      amirh authored
      A bug in _RenderCustomClip was compaeing the type of oldClipper to
      itself instead to the type of newClipper.
      
      This was the root cause for the crash #14937 worked around.
      This also reverts the workaround introduced in #14937.
      0a26ac09
  6. 05 Jun, 2018 1 commit
  7. 08 May, 2018 1 commit
  8. 21 Apr, 2018 1 commit
  9. 28 Feb, 2018 1 commit
  10. 26 Feb, 2018 1 commit
  11. 24 Feb, 2018 1 commit
  12. 23 Feb, 2018 1 commit
  13. 22 Feb, 2018 1 commit
  14. 21 Feb, 2018 1 commit
    • amirh's avatar
      Initial implementation of BottomAppBar (#14713) · 7996d7fb
      amirh authored
      * add a FAB NotchMaker to ScaffoldGeometry
      
      * add a notchMaker to FloatingActionButton
      
      * Initial implementation of BottomAppBar
      
      Mainly includes the notch making logic.
      Not yet tested as currently there is no way to make the FAB and the BAB
      overlap, once #14368 to lands we could add unit tests to the
      BottomAppBar as well.
      
      * use a closeable for clearing the FAB notchmaker
      7996d7fb