- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
- 21 Jun, 2018 1 commit
-
-
amirh authored
Move the notch computation from the FAB to the BAB. The notch in the BAB (bottom action bar) for the FAB (floating action button) was previously kept as part of the FAB's implementation. This was done to keep the shape of the FAB and the shape of the notch coupled. That approach resulted in a somewhat complex and 'non Fluttery' mechanism for propagating the notch computation from the FAB to the BAB. This CL uncouples the FAB and the notch computation. With the new API the BAB computes its overall shape including the notch using a NotchedShape delegate. This includes multiple breaking changes: * Scaffold.setFloatingActionButtonNotchFor is deleted. * The ComputeNotch type is deleted. * The hasNotch property of BottomAppBar is deleted. * The notchMargin property of FloatingActionButton is deleted. Quick migration guide from the previous API: | Previous API | New API | | ------------------|-------------| | BottomAppBar(hasNotch: false) | BottomAppBar() | | Using a FloatingActionButton with: BottomAppBar() / BottomAppBar(hasNotch: true) | BottomAppBar(shape: CircularNotchedRectangle()) | | Scaffold.setFloatingActionButtonNotchFor(..) | No longer supported |
-
- 06 Jun, 2018 1 commit
-
-
amirh authored
A bug in _RenderCustomClip was compaeing the type of oldClipper to itself instead to the type of newClipper. This was the root cause for the crash #14937 worked around. This also reverts the workaround introduced in #14937.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 May, 2018 1 commit
-
-
Peter Etelej authored
Minor typo fix for BottomAppBar doc
-
- 21 Apr, 2018 1 commit
-
-
xster authored
-
- 28 Feb, 2018 1 commit
-
-
amirh authored
The downcast was crashing when toggling hasNotch for BottomAppBar.
-
- 26 Feb, 2018 1 commit
-
-
amirh authored
-
- 24 Feb, 2018 1 commit
-
-
amirh authored
-
- 23 Feb, 2018 1 commit
-
-
amirh authored
The Floating Action Button adds some margin around it for the notch. So we need to compute a notch even when the FAB and the Bottom App Bar doe not overlap.
-
- 22 Feb, 2018 1 commit
-
-
amirh authored
-
- 21 Feb, 2018 1 commit
-
-
amirh authored
* add a FAB NotchMaker to ScaffoldGeometry * add a notchMaker to FloatingActionButton * Initial implementation of BottomAppBar Mainly includes the notch making logic. Not yet tested as currently there is no way to make the FAB and the BAB overlap, once #14368 to lands we could add unit tests to the BottomAppBar as well. * use a closeable for clearing the FAB notchmaker
-