- 29 Oct, 2020 1 commit
-
-
Greg Spencer authored
This removes the nullOk parameter from Focus.of, FocusTraversalOrder.of and FocusTraversalGroup.of, and creates maybeOf equivalents for each. The of methods now return non-nullable values, and the maybeOf equivalents return nullable values.
-
- 28 Oct, 2020 2 commits
-
-
Michael Goderbauer authored
-
Greg Spencer authored
Adds MediaQuery.maybeOf to replace calling MediaQuery.of(context, nullOk: true), and removes the nullOk parameter. Also changes MediaQuery.of to return a non-nullable value, and removes many instances of the ! operator, reducing the possible places where a null dereference could occur.
-
- 14 Oct, 2020 1 commit
-
-
xubaolin authored
-
- 13 Oct, 2020 1 commit
-
-
Kate Lovett authored
-
- 21 Jul, 2020 2 commits
-
-
xubaolin authored
- 16 Jul, 2020 1 commit
-
-
Pedro Massango authored
-
- 24 Jun, 2020 1 commit
-
-
chunhtai authored
* Add semantics sort key for modal scope and modal barrier * fix test * fix test * fix test * fix space * fix more tests * addressing comments
-
- 17 Jun, 2020 1 commit
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 31 May, 2020 1 commit
-
-
Mehmet Fidanboylu authored
This reverts commit cd593dae.
-
- 29 May, 2020 1 commit
-
-
liyuqian authored
* Add clipBehavior to RenderFlex * Add clipBehavior to FittedBox * Add clipBehavior to Flex and FittedBox * Add clipBehavior to UnconstrainedBox * Add clipBehavior to Stack and Wrap * Add clipBehavior to TextEditable * Add clipBehavior to ListWheelScrollView * Add clipBehavior to SingleChildScrollView * Add clipBehavior to RenderViewportBase's widgets Those widgets are NestedScrollView and ShrinkWrappingViewport. * Fix tests * Remove enum Overflow and fix typo * Remove clipToSize * Analyze fix * Remove Mixin and other small fixes * Fix tests and respect Stack's default clipBehavior * Add Overflow back to make it non-breaking * Restore clipBehavior to make it non-breaking * Small fixes * Fix rebase
-
- 22 Apr, 2020 1 commit
-
-
Kate Lovett authored
-
- 21 Apr, 2020 1 commit
-
-
Greg Spencer authored
-
- 02 Apr, 2020 1 commit
-
-
impure authored
-
- 30 Mar, 2020 2 commits
-
-
Shi-Hao Hong authored
* Implement DropdownMenuItem.onTap
-
Shi-Hao Hong authored
-
- 18 Mar, 2020 1 commit
-
-
Yegor authored
* Fix web test flakiness; enable web golden tests The fix is three-part: - Only allow one test to load _and_ test at any point in time. - Use a fresh Chrome instance for each test file. - Increase Cirrus resources. The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests. Other minor changes: - Remove test batching (it's no longer necessary) - Fix the Chrome class, which was using the wrong Completer.
-
- 11 Feb, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Feb, 2020 1 commit
-
-
Shi-Hao Hong authored
-
- 07 Feb, 2020 1 commit
-
-
jimshepherd authored
The current implementation of DropdownButtonFormField does not pass the initial value to _DropdownButtonFormFieldState. As a result changes made through the child DropdownButton are not made to the FormFieldState and the widget is not updated unless a onChanged function is provided to the DropdownButtomFormField constructor. This change modifies DropdownButtonFormField to behave more consistently with other FormField widgets in how the Form state is handled.
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add key to constructors of public widgets * fix a test * fix a test
-
- 21 Dec, 2019 1 commit
-
-
Lau Ching Jun authored
-
- 16 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Dec, 2019 1 commit
-
-
Lau Ching Jun authored
* Make golden test timeout longer, some tests are flaky if the timeout is too short * Enable some golden tests for web
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 08 Nov, 2019 1 commit
-
-
Greg Spencer authored
As it stands, dropdowns currently do not focus the item that is selected, so if you select something on a dropdown, and then close it, and re-open it, then the new item is not auto-focused. This PR changes that so that selected value is focused by default when the dropdown is re-opened.
-
- 30 Oct, 2019 2 commits
-
-
Shi-Hao Hong authored
* Separate DropdownButtonFormField and DropdownButton test files
-
Greg Spencer authored
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213), with fixes for the web tests that weren't enabled in the master that it was synced to when I first landed it.
-
- 28 Oct, 2019 2 commits
-
-
Shi-Hao Hong authored
- Adds an assert message checking for exactly one unique value for `DropdownItem`s
-
Shi-Hao Hong authored
* Fix DropdownButton disabledHint behavior * Fix hint behavior when selectedItemBuilder is null * Improve variable names, some formatting updates * Create _DropdownMenuItemContainer widget * Improve API docs to be consistent with hint/disabledHint actual behavior
-
- 25 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 22 Oct, 2019 1 commit
-
-
Kate Lovett authored
This reverts commit 8df0d655.
-
- 21 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 18 Oct, 2019 1 commit
-
-
Greg Spencer authored
This adds a Focus node to the DropdownButton widget, allowing it to receive keyboard focus, and to show a focus highlight. In addition, I added the ability to activate the dropdown using the "enter" key binding (which is bound to ActivateAction in the WidgetsApp). Related Issues Fixes #42646 Fixes #43008 Fixes #42511
-
- 14 Oct, 2019 1 commit
-
-
Greg Spencer authored
This changes the DropDownButton so that instead of dismissing itself when any metrics change occurs, it only dismisses itself when the orientation changes. This gets around the fact that we can't currently have a dropdown and a text field on the same page because the keyboard disappearing when the dropdown gets focus causes a metrics change, and the dropdown immediately disappears when activated. It still will cause the keyboard to jump up and down between controls, but that's a larger issue. At least now we can use the two together again.
-
- 10 Oct, 2019 1 commit
-
-
Greg Spencer authored
This attempts to reland #40186 and #41220, that were reverted in #41945. The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed. I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...) Fixes #40101
-
- 09 Oct, 2019 1 commit
-
-
Shi-Hao Hong authored
* Fix DropdownButton crash when hint and selectedItemBuilder are simultaneously defined
-