Commits · a353826b70302d47a68afc1f53a2eb0735eb2136 · abdullh.alsoleman / Front-End

04 Aug, 2023 6 commits

Roll Flutter Engine from e3f75650ac5f to de0ec1c971ab (2 revisions) (#131910) · a353826b

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/e3f75650ac5f...de0ec1c971ab

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from a3d2051afa4a to 1f884c208390 (5 revisions) (flutter/engine#44369)
2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qo3dJIXjK-Ia8j42J... to FAGt3OEY8Yi1-SaFj... (flutter/engine#44366)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Qo3dJIXjK-Ia to FAGt3OEY8Yi1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a353826b

make `--dart-define` override redundant values in `--dart-define-from-file` (#131088) · 30692ee4
Andrew Kolos authored Aug 04, 2023
```
Fixes #130604
```
30692ee4

Roll Flutter Engine from ca8d852eddfc to e3f75650ac5f (1 revision) (#131907) · b2381348

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/ca8d852eddfc...e3f75650ac5f

2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from e3d2b4a190aa to eb7670788799 (1 revision) (flutter/engine#44363)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2381348

Roll Flutter Engine from 098ec489585e to ca8d852eddfc (2 revisions) (#131905) · f7b68919

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/098ec489585e...ca8d852eddfc

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 0a376550f218 to a3d2051afa4a (4 revisions) (flutter/engine#44362)
2023-08-03 ychris@google.com Revert "Build iOS unittest target in unopt builds" (flutter/engine#44356)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7b68919

Roll Flutter Engine from 4c62dd81d136 to 098ec489585e (2 revisions) (#131903) · 821a825e

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/4c62dd81d136...098ec489585e

2023-08-03 dnfield@google.com [Impeller] Fail loudly if --enable-software-rendering is used. (flutter/engine#44346)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 3b3c1a617544 to 0a376550f218 (3 revisions) (flutter/engine#44353)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

821a825e

Roll Flutter Engine from 0c1de9b8afba to 4c62dd81d136 (4 revisions) (#131902) · cfdf7295

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/0c1de9b8afba...4c62dd81d136

2023-08-03 matanlurey@users.noreply.github.com [Impeller] Run clangd tidy, opting out in 2 cases. (flutter/engine#44351)
2023-08-03 1961493+harryterkelsen@users.noreply.github.com Reland "[web] Update text editing test skips" (flutter/engine#37655)
2023-08-03 jason-simmons@users.noreply.github.com [Impeller] Discard invalid command buffer handles after destroying a command pool (flutter/engine#44194)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from bae32428c1c7 to 3b3c1a617544 (1 revision) (flutter/engine#44345)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cfdf7295

03 Aug, 2023 15 commits

Roll Flutter Engine from b08e1410a06a to 0c1de9b8afba (9 revisions) (#131897) · fd000dcd

engine-flutter-autoroll authored Aug 03, 2023

https://github.com/flutter/engine/compare/b08e1410a06a...0c1de9b8afba

2023-08-03 yjbanov@google.com [web] fix clicks on merged semantic nodes
(flutter/engine#43620)
2023-08-03 john@johnmccutchan.com Remove WARNINGs from JNI load path as
we can't suppress them (flutter/engine#44348)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 872dc53233cf to
bae32428c1c7 (3 revisions) (flutter/engine#44341)
2023-08-03 ychris@google.com Build iOS unittest target in unopt builds
(flutter/engine#44301)
2023-08-03 chris@bracken.jp [darwin] Move common targets to
common/BUILD.gn (flutter/engine#44335)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 2babe68de295 to
872dc53233cf (2 revisions) (flutter/engine#44339)
2023-08-03 kjlubick@users.noreply.github.com Migrate GL calls of
GrBackend* (flutter/engine#44334)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 36072a994f11 to
2babe68de295 (1 revision) (flutter/engine#44336)
2023-08-03 skia-flutter-autoroll@skia.org Roll Clang from 07c592048780
to 020d2fb7711d (flutter/engine#44332)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

fd000dcd

Fix TimePicker token issue link (#131863) · 0192f883

Taha Tesser authored Aug 03, 2023

Fix issue reference for https://github.com/flutter/flutter/issues/131247 (it was added in the bug fix PR https://github.com/flutter/flutter/pull/131253)

0192f883

[Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan... · f0e39349

gaaclarke authored Aug 03, 2023

[Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan and opengles (#131864)

issue: https://github.com/flutter/flutter/issues/131784

f0e39349

Revert "Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions)" (#131896) · 94890097
Zachary Anderson authored Aug 03, 2023
```
Reverts flutter/flutter#131880
```
94890097

Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions) (#131880) · 8f85bb35

engine-flutter-autoroll authored Aug 03, 2023

Manual roll requested by jacksongardner@google.com

https://github.com/flutter/engine/compare/4cc0b3dab001...b08e1410a06a

2023-08-03 john@johnmccutchan.com Add @Keep annotations to avoid dead code elimination of classes only referenced by JNI (flutter/engine#44337)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from bd3ee535e246 to 36072a994f11 (2 revisions) (flutter/engine#44329)
2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from dcd09f5726b7 to e3d2b4a190aa (1 revision) (flutter/engine#44330)
2023-08-03 30870216+gaaclarke@users.noreply.github.com [Impeller] updated validation layers documentation (flutter/engine#44328)
2023-08-03 41930132+hellohuanlin@users.noreply.github.com [ios]make the screenIfViewLoaded and windowSceneIfLoaded helpers reusable (flutter/engine#44303)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 768050436c0a to bd3ee535e246 (2 revisions) (flutter/engine#44327)
2023-08-03 john@johnmccutchan.com Re-Re-Land Support for rendering Android Platform Views into a HardwareBuffer backed texture (flutter/engine#44326)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 8a377a9545b8 to 768050436c0a (1 revision) (flutter/engine#44320)
2023-08-03 bdero@google.com [Flutter GPU] Export symbols from engine, stub for testing on CI. (flutter/engine#44280)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8f85bb35

Added new gallery benchmark test that forces opengles. (#131796) · 4247e1ef

gaaclarke authored Aug 03, 2023

fixes https://github.com/flutter/flutter/issues/131782

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Xilai Zhang <xilaizhang@google.com>

4247e1ef

Roll Packages from 4e4961a24b3d to d00c1f9eb01c (10 revisions) (#131866) · 4f9a7e29

engine-flutter-autoroll authored Aug 03, 2023

https://github.com/flutter/packages/compare/4e4961a24b3d...d00c1f9eb01c

2023-08-03 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.1 to 2.21.2 (flutter/packages#4637)
2023-08-03 engine-flutter-autoroll@skia.org Roll Flutter from b3f99ffe to c00d2419 (12 revisions) (flutter/packages#4640)
2023-08-03 jpnurmi@gmail.com [path_provider] Add getApplicationCachePath() - implementations (flutter/packages#4619)
2023-08-03 109253501+pdblasi-google@users.noreply.github.com [various] Removed references to deprecated `TestWindow` APIs (flutter/packages#4558)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.3.0 (flutter/packages#4432)
2023-08-02 jhy03261997@gmail.com [go_router_builder] Add go_router StatefulShellRoute support to go_router_builder (flutter/packages#4238)
2023-08-02 reidbaker@google.com [Tooling] Add google owned cache for dependencies as an option in ci (flutter/packages#4567)
2023-08-02 engine-flutter-autoroll@skia.org Roll Flutter from 1d59196b to b3f99ffe (32 revisions) (flutter/packages#4634)
2023-08-02 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Support `ShellRouteData` without `const` constructor (flutter/packages#4627)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.0 to 2.21.1 (flutter/packages#4573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4f9a7e29

manual pub package roll (#131804) · 0d628b0f
Christopher Fujino authored Aug 03, 2023
```
manually ran `flutter update-packages --force-upgrade`
```
0d628b0f

remove Mac_ios ios_app_with_extensions_test (#131806) · 13ff16cb

Chris Yang authored Aug 03, 2023

Removing the extension test that unnecessarily running with devices.

The new hostonly tests were added in https://github.com/flutter/flutter/pull/131441

13ff16cb

Roll Flutter Engine from 46f3e099ad04 to 4cc0b3dab001 (3 revisions) (#131854) · 4df8d23e

engine-flutter-autoroll authored Aug 03, 2023

https://github.com/flutter/engine/compare/46f3e099ad04...4cc0b3dab001

2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from b81084128325 to 8a377a9545b8 (1 revision) (flutter/engine#44319)
2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from fac111d4acb3 to dcd09f5726b7 (1 revision) (flutter/engine#44317)
2023-08-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WwFjJuQF_rpToCYPJ... to Qo3dJIXjK-Ia8j42J... (flutter/engine#44316)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WwFjJuQF_rpT to Qo3dJIXjK-Ia

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4df8d23e

Adds a11y assessment sample app (#131716) · 3d74b0b7

chunhtai authored Aug 03, 2023

This app will be use for a11y assessments. See [design doc](http://go/flutter-gar-reporting-q3-2023)    (internal only)

3d74b0b7

Remove target Staging_build_linux framework_tests_misc (#126959) · 22f029e5

Mahmoud Zayad authored Aug 03, 2023

I deleted the target mentioned in the issue listed below. This is my first time contributing to open source please explain if I did anything wrong in the process or wrong with the changes. 

Best

*List which issues are fixed by this PR. You must list at least one issue.*
Resolves [#126278](https://github.com/flutter/flutter/issues/126278)

22f029e5

Manual roll Flutter Engine from 4c1157b9da54 to 46f3e099ad04 (3 revisions) (#131848) · b4c75017

engine-flutter-autoroll authored Aug 03, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/4c1157b9da54...46f3e099ad04

2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3b9af2825d47 to fac111d4acb3 (2 revisions) (flutter/engine#44315)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from d9d5ef855d75 to b81084128325 (2 revisions) (flutter/engine#44313)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from c0956a252f30 to d9d5ef855d75 (2 revisions) (flutter/engine#44311)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b4c75017

Manual roll Flutter Engine from 9304c0074d29 to 4c1157b9da54 (24 revisions) (#131830) · c00d2419

engine-flutter-autoroll authored Aug 03, 2023

Manual roll requested by jacksongardner@google.com

https://github.com/flutter/engine/compare/9304c0074d29...4c1157b9da54

2023-08-03 jacksongardner@google.com Revert Android Hardware Texture PRs (flutter/engine#44310)
2023-08-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 87df1bbcea5e to 3b9af2825d47 (2 revisions) (flutter/engine#44308)
2023-08-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Hx7ap5qcoqRIknnnG... to WwFjJuQF_rpToCYPJ... (flutter/engine#44306)
2023-08-03 jason-simmons@users.noreply.github.com Check whether the lookup of android.hardware.HardwareBuffer found a class (flutter/engine#44304)
2023-08-02 bdero@google.com [Impeller] Add placeholder filter input. (flutter/engine#44290)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 6c1bab070220 to 6a09e41ce6ea (1 revision) (flutter/engine#44300)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from fd5bd67d532f to c0956a252f30 (1 revision) (flutter/engine#44296)
2023-08-02 chris@bracken.jp [iOS] Fix use-after-free in setBinaryMessenger (flutter/engine#44294)
2023-08-02 louiseh0313@gmail.com Add Search Web to selection controls on iOS (flutter/engine#43324)
2023-08-02 jason-simmons@users.noreply.github.com Improve logging in the clang-tidy script (flutter/engine#44228)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 335c6b86d70b to 6c1bab070220 (1 revision) (flutter/engine#44291)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 25f5a32367ad to fd5bd67d532f (2 revisions) (flutter/engine#44289)
2023-08-02 john@johnmccutchan.com Be sure to clear exceptions after a failed JNI lookup (flutter/engine#44293)
2023-08-02 derekx@google.com Handle deprecation of Dart_TimelineEvent Embedder API (flutter/engine#42497)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from ccc17f784e5d to 25f5a32367ad (4 revisions) (flutter/engine#44283)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 01ee134bb223 to 335c6b86d70b (2 revisions) (flutter/engine#44287)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 7104d0e8863f to ccc17f784e5d (2 revisions) (flutter/engine#44279)
2023-08-02 41930132+hellohuanlin@users.noreply.github.com [ios][autocorrection]disable auto-correction highlight in iOS 17 (flutter/engine#44176)
2023-08-02 john@johnmccutchan.com Reland Introduce TextureRegistry.ImageTexture and HardwareBufferExternalTextureGL (flutter/engine#44278)
2023-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from afbaf4216fc8 to 87df1bbcea5e (1 revision) (flutter/engine#44276)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 93764a98b866 to 7104d0e8863f (4 revisions) (flutter/engine#44273)
2023-08-02 jason-simmons@users.noreply.github.com [Impeller] Fix leak of wrapped TextureMTL objects in the Metal embedder API (flutter/engine#44245)
2023-08-02 737941+loic-sharma@users.noreply.github.com Revert "Listen to window notifications to update application lifecycle" (flutter/engine#44275)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 514c66ce0471 to 93764a98b866 (1 revision) (flutter/engine#44270)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Hx7ap5qcoqRI to WwFjJuQF_rpT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c00d2419

Assert against infinite values of control points in CatmullRomSpline (#131820) · b3a4decd

Kate Lovett authored Aug 03, 2023

When providing infinite values for the control points of CatmullRomSpline, a StackOverflowError occurs. This asserts against that and provides a helpful error message. 

Fixes https://github.com/flutter/flutter/issues/131246

b3a4decd

02 Aug, 2023 19 commits

Update stack_frame.dart to parse unexpected error format to null. (#131786) · 0ad45f24

Polina Cherkasova authored Aug 02, 2023

Fixes https://github.com/flutter/flutter/issues/131627

Originally this code sometimes was returning null and sometimes was failing, when stack frame is in unexpected format.

This PR updates for one of the code paths from failing to returning null.

0ad45f24

Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus (#130164) · 9cda3092
Justin McCandless authored Aug 02, 2023
```
Simplifying the TextField API.
```
9cda3092
Mention that the widget tree is not disposed on exit (#131637) · 47b188ec
Ian Hickson authored Aug 02, 2023

47b188ec

[framework] Add Look Up to selection controls for iOS (#131798) · f0197895

LouiseHsu authored Aug 02, 2023

This PR adds framework support for the Look Up feature in iOS.

https://github.com/flutter/flutter/assets/36148254/d301df79-4e23-454f-8742-2f8e39c2960c

The corresponding merged engine PR can be found [here](https://github.com/flutter/engine/pull/43308).
This PR addresses https://github.com/flutter/flutter/issues/82907
More details are available in this [design doc.](flutter.dev/go/add-missing-features-to-selection-controls)

This is the same PR as https://github.com/flutter/flutter/pull/130532, this is an attempt to fix the Google Testing issue

f0197895

Add documentation in flutter.groovy noting that we always use the latest... · 00a83235

Gray Mackall authored Aug 02, 2023

Add documentation in flutter.groovy noting that we always use the latest available android version (#131705)

Last piece of/
Fixes https://github.com/flutter/flutter/issues/131425

Also added a period to a comment line that was missing one.

00a83235

[framework] lerp images in a save layer. (#131703) · 253bd3d4

Jonah Williams authored Aug 02, 2023

Without a saveLayer, the BlendMode.plus will add itself to the backdrop and not just the previous image. Pushing without tests to see if existing goldens fail, but otherwise I have some good examples locally.

This is necessary uncondtionally, and lerping lerped images has the same issue.

Fixes https://github.com/flutter/flutter/issues/131617

### Before

![flutter_02](https://github.com/flutter/flutter/assets/8975114/1e783285-2fc2-429f-9fd8-6d04d4a155e1)

### After

![flutter_03](https://github.com/flutter/flutter/assets/8975114/3d08b187-26aa-4471-926d-e9ed5946a206)

253bd3d4

Roll Packages from 3dc00c1a32f6 to 4e4961a24b3d (1 revision) (#131788) · 5720dead

engine-flutter-autoroll authored Aug 02, 2023

https://github.com/flutter/packages/compare/3dc00c1a32f6...4e4961a24b3d

2023-08-02 43054281+camsim99@users.noreply.github.com [google_maps_flutter_android] Disable flaky `testToggleInfo` test (flutter/packages#4629)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5720dead

add gem dependency to the ios_app_with_extensions_test (#131713) · 12b8e0cb
Chris Yang authored Aug 02, 2023
```
Adds gem dependency to the tests 

Fixes https://github.com/flutter/flutter/issues/131693
```
12b8e0cb

Roll Flutter Engine from d6b962d0e36d to 9304c0074d29 (4 revisions) (#131790) · aa77d1f4

engine-flutter-autoroll authored Aug 02, 2023

https://github.com/flutter/engine/compare/d6b962d0e36d...9304c0074d29

2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from d29f946d6180 to 01ee134bb223 (1 revision) (flutter/engine#44269)
2023-08-02 ychris@google.com [iOS][A11Y] fix hittest with non-SemanticsObject (flutter/engine#44014)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from d61a50c155bd to d29f946d6180 (1 revision) (flutter/engine#44267)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 6009cc6d7d80 to 514c66ce0471 (2 revisions) (flutter/engine#44268)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aa77d1f4

[flutter_tools] set terminal.singleCharMode to false after attach finishes (#131723) · 55bb3e55

Christopher Fujino authored Aug 02, 2023

Fixes https://github.com/flutter/flutter/issues/131511

Similar fix to https://github.com/flutter/flutter/commit/84c8abd0f6776455e91e9c375c7d7ed8f3291e75#diff-38f3e3415d9806f22a78060fafb3206d1a006f74631fac04e7a680a64e06ccf0

55bb3e55

Fix reentrancy with WidgetBindingObserver callbacks (#131774) · b3f99ffe

Dan Field authored Aug 02, 2023

Part of https://github.com/flutter/flutter/issues/131678

Fixes up callsites for WidgetsBindingObserver related callbacks.

b3f99ffe

Update .ci.yaml to add new shard to prevent timeouts (#131712) · aff8ef13

Elias Yishak authored Aug 02, 2023

Fixes:
- https://github.com/flutter/flutter/issues/131327

It was observed that the tests would hit their 30 minute timeout so this PR adds another shard to reduce how many tests are run per shard to reduce test run time

aff8ef13

Fix flex methods for min and max column widths (#131724) · a1203429

Kate Lovett authored Aug 02, 2023

Fixes https://github.com/flutter/flutter/issues/131467

An error in the flex methods of min and max column width would produce different results based on the position of the widths that were provided:
`MaxColumnWidth(a, b) != MaxColumnWidth(b, a)`

This fixes that.

a1203429

Manual roll Flutter Engine from 9dae7b708bda to d6b962d0e36d (25 revisions) (#131785) · f9e4567f

engine-flutter-autoroll authored Aug 02, 2023

Manual roll requested by jacksongardner@google.com

https://github.com/flutter/engine/compare/9dae7b708bda...d6b962d0e36d

2023-08-02 zanderso@users.noreply.github.com Revert "[Impeller] Support for rendering Android Platform Views into a HardwareBuffer backed texture." (flutter/engine#44262)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from c6577d328585 to 6009cc6d7d80 (2 revisions) (flutter/engine#44264)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 11cef17b53ac to d61a50c155bd (1 revision) (flutter/engine#44261)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 1c0bba7c1053 to c6577d328585 (2 revisions) (flutter/engine#44260)
2023-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 8ff03ebf7eaa to afbaf4216fc8 (1 revision) (flutter/engine#44259)
2023-08-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3JSF6hXLRdAK1wUN1... to Hx7ap5qcoqRIknnnG... (flutter/engine#44258)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from a21631c02e45 to 11cef17b53ac (1 revision) (flutter/engine#44256)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 6807d8b8a9d3 to 1c0bba7c1053 (1 revision) (flutter/engine#44255)
2023-08-02 skia-flutter-autoroll@skia.org Roll ANGLE from 5d4b3645d0dc to a21631c02e45 (1 revision) (flutter/engine#44252)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 6087a5224c6f to 6807d8b8a9d3 (2 revisions) (flutter/engine#44250)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 6cb888889ad8 to 6087a5224c6f (1 revision) (flutter/engine#44249)
2023-08-02 jonahwilliams@google.com [Impeller] Give a fixed timeout for acquireNextImageKHR. (flutter/engine#44241)
2023-08-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 7c03426705da to 8ff03ebf7eaa (2 revisions) (flutter/engine#44243)
2023-08-02 skia-flutter-autoroll@skia.org Roll Skia from 4deae93198f9 to 6cb888889ad8 (1 revision) (flutter/engine#44240)
2023-08-01 hterkelsen@users.noreply.github.com [canvaskit] Enable CanvasKit to compute tight SkPicture bounds (flutter/engine#43361)
2023-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 197fc0d7fea2 to 7c03426705da (2 revisions) (flutter/engine#44237)
2023-08-01 john@johnmccutchan.com [Impeller] Support for rendering Android Platform Views into a HardwareBuffer backed texture. (flutter/engine#44087)
2023-08-01 yjbanov@google.com [web:a11y] add platform view role (flutter/engine#44188)
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from 18cf818e044f to 4deae93198f9 (1 revision) (flutter/engine#44236)
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from 58c031441cbb to 18cf818e044f (6 revisions) (flutter/engine#44234)
2023-08-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from g0dgOL2IlZQJCK4El... to 3JSF6hXLRdAK1wUN1... (flutter/engine#44233)
2023-08-01 skia-flutter-autoroll@skia.org Roll ANGLE from b53d99d87e6a to 5d4b3645d0dc (1 revision) (flutter/engine#44231)
2023-08-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lwCo6le6r0X-Srvx3... to KPSWBhOvG6piddBQG... (flutter/engine#44230)
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from d53f7b880651 to 58c031441cbb (2 revisions) (flutter/engine#44229)
2023-08-01 58529443+srujzs@users.noreply.github.com Remove extends JSTypedArray from JSUint8Array1 (flutter/engine#44175)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lwCo6le6r0X- to KPSWBhOvG6pi
fuchsia/sdk/core/mac-amd64 from g0dgOL2IlZQJ to Hx7ap5qcoqRI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9e4567f

Added standard deviation to rasterizer results. (#131781) · 947367aa

gaaclarke authored Aug 02, 2023

This calculation is important if you want to calculate the probability that one thing is better than another.

947367aa

Tiny remove outdated comments (#130387) · 4b176a71

fzyzcjy authored Aug 02, 2023

I get confused when reading this comment. It seems that this code never calls `AnimationController.fling` (but only things like `animateTo`). Therefore, I do not think discussing the duration of `AnimationController.fling` is helpful - maybe it is just an outdated comment?

4b176a71

Bump ubuntu from `f8f6584` to `c9820a4` in /dev/ci/docker_linux (#130292) · 6cf50ef9

dependabot[bot] authored Aug 02, 2023

Bumps ubuntu from `f8f6584` to `c9820a4`.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ubuntu&package-manager=docker&previous-version=focal&new-version=focal)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

6cf50ef9

Fix for endless recursion for getLayoutExplorerNode on a Tooltip (#131486) · f80ff55a

Daniel Chevalier authored Aug 02, 2023

![](https://media.giphy.com/media/l0ExdBwqD6YkeEhQ4/giphy-downsized.gif)

Fixes https://github.com/flutter/devtools/issues/5946

While preparing DevTools for the Multi View changes, I noticed that
inspecting a Tooltip causes an stack overflow.
This PR addresses that issue by fixing the scope of the subtreeDepth variable and adding some other idiomatic fixes

f80ff55a

Bump google/mirror-branch-action from 1.0 to 2.0 (#126600) · dc4ab0f5

dependabot[bot] authored Aug 02, 2023

Bumps [google/mirror-branch-action](https://github.com/google/mirror-branch-action) from 1.0 to 2.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/google/mirror-branch-action/commit/30c52ee21f5d3bd7fb28b95501c11aae7f17eebb"><code>30c52ee</code></a> Update dependencies.</li>
<li><a href="https://github.com/google/mirror-branch-action/commit/4544d8a0903fb21cfbcf4642b793e47f90783d5a"><code>4544d8a</code></a> Update deprecated action environment</li>
<li><a href="https://github.com/google/mirror-branch-action/commit/884625cd18fadb1bdb646df951a7b486a5d9f3fc"><code>884625c</code></a> Bump node-fetch from 2.6.0 to 2.6.1</li>
<li><a href="https://github.com/google/mirror-branch-action/commit/d9fb13d47a8b349b51d369518c798306a6b42669"><code>d9fb13d</code></a> Bump <code>@âactions/core</code> from 1.2.4 to 1.2.6</li>
<li><a href="https://github.com/google/mirror-branch-action/commit/4083f5d474abe94ca3b49400e1c55d1d825f08dd"><code>4083f5d</code></a> Unify placeholders in README.md</li>
<li><a href="https://github.com/google/mirror-branch-action/commit/394f8d4604fee868b2e256f4ac8ea148a4292806"><code>394f8d4</code></a> Bump lodash from 4.17.15 to 4.17.19 (<a href="https://redirect.github.com/google/mirror-branch-action/issues/3">#3</a>)</li>
<li><a href="https://github.com/google/mirror-branch-action/commit/5d7016e8e9b3ef486f0a0f6dfbbb18c175c0c699"><code>5d7016e</code></a> The sample <code>uses:</code> line should reference <a href="https://github.com/v1"><code>@âv1</code></a>.0 (<a href="https://redirect.github.com/google/mirror-branch-action/issues/1">#1</a>)</li>
<li>See full diff in <a href="https://github.com/google/mirror-branch-action/compare/c6b07e441a7ffc5ae15860c1d0a8107a3a151db8...30c52ee21f5d3bd7fb28b95501c11aae7f17eebb">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/mirror-branch-action&package-manager=github_actions&previous-version=1.0&new-version=2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dc4ab0f5