1. 04 Mar, 2017 1 commit
  2. 17 Jan, 2017 1 commit
    • Adam Barth's avatar
      Fix several minor bugs and add many tests (#7506) · 2b742289
      Adam Barth authored
      * MultiTapGestureRecognizer previously would assert if there was no
         competition.
       * GestureArenaTeam would always select the first recongizer as the
         winner even if a later recognizer actually accepted the pointer
         sequence.
       * debugPrintStack would fail a type check if maxFrames was non-null.
       * FractionalOffset.lerp would throw a null-pointer exception if its
         second argument was null.
      
      Also, add a number of tests for previously untested lines of code.
      2b742289
  3. 10 Jan, 2017 1 commit
  4. 16 Nov, 2016 1 commit
  5. 30 Sep, 2016 1 commit
  6. 21 Sep, 2016 1 commit
    • James Robinson's avatar
      Isolate imports of generated Dart code from generated path (#5960) · a95c9fdb
      James Robinson authored
      This rewrites imports of various mojom.dart files from the Flutter
      engine repo to instead import normal-looking dart files from the
      (new) flutter_services package. This package handles exporting the
      correct symbols from generated code wherever that may live.
      
      Includes an engine roll to 3551e7a48e2e336777b15c7637af92fd7605b6c5
      which contains the new flutter_services package.
      a95c9fdb
  7. 15 Sep, 2016 1 commit
  8. 29 Mar, 2016 1 commit
  9. 16 Feb, 2016 1 commit
    • Adam Barth's avatar
      Enforce that we get a final move to the pointer up location · ddd58c5e
      Adam Barth authored
      Previously we asserted that we got a pointer move to the location where the
      pointer up occured, but not all sources of pointer packets respect that
      invariant. Specifically, on the iOS simulator, of you drag outside the window,
      you'll get a stream of pointers that violates that invariant.
      
      This patch teaches the converter to insert a PointerMoveEvent to move the
      pointer to the location where the up occurs, repairing the invariant.
      
      Fixes #1912
      ddd58c5e
  10. 05 Feb, 2016 1 commit
  11. 16 Jan, 2016 1 commit
  12. 14 Dec, 2015 1 commit
  13. 10 Dec, 2015 1 commit
  14. 09 Dec, 2015 1 commit
    • Eric Seidel's avatar
      Add a test to stocks for changing the locale · 09894ec5
      Eric Seidel authored
      I had to add a setLocale method to WidgetTester and
      split the code in FlutterBinding which handled locale
      changes to allow me to dispatch a locale change w/o actually
      changing what the c++ code reports as the locale.
      
      Also added the test to Travis.
      
      @abarth @jason-simmons
      09894ec5
  15. 08 Dec, 2015 2 commits
    • Hixie's avatar
      Clean up pointer handling. · 7514ce12
      Hixie authored
      Previously we tried to work around some possible badness from the engine
      side, but now we are more assertive about the engine needing to do the
      right thing.
      7514ce12
    • Jason Simmons's avatar
      Add a LocaleQuery widget that can be used to fetch locale-specific data · 9693cd55
      Jason Simmons authored
      Users of MaterialApp can provide an onLocaleChanged handler that will be
      called to asynchronously fetch locale-specific data.  MaterialApp will
      then instantiate a LocaleQuery that supplies the locale data to its
      descendants.
      9693cd55
  16. 07 Dec, 2015 2 commits
  17. 05 Dec, 2015 1 commit
    • Ian Hickson's avatar
      PointerInput refactor · f1625556
      Ian Hickson authored
      Instead of PointerInputEvent having a "type" field, we now have a
      different class for each pointer type.
      
      This has ripple effects throughout the system.
      
      I also did code cleanup in affected files while I was there.
      f1625556
  18. 02 Dec, 2015 1 commit
  19. 01 Dec, 2015 1 commit
    • Ian Hickson's avatar
      Remove the assert when opening popup menus. · fbd612e6
      Ian Hickson authored
      Some paint bounds are in fact empty, e.g. at the start of a growing
      animation if there's also a fade, the initial 0x0 box will also be
      opacity:0, and might get a dedicated layer and PaintingContext.
      fbd612e6
  20. 25 Nov, 2015 1 commit
  21. 19 Nov, 2015 1 commit
  22. 17 Nov, 2015 1 commit
  23. 13 Nov, 2015 2 commits
  24. 12 Nov, 2015 1 commit
    • Hixie's avatar
      flutter analyze command · a0227cab
      Hixie authored
      Other changes in this patch:
      - Make the 'flutter' tool say "Updating flutter tool..." when it calls
        pub get, to avoid confusion about what the pub get output is about.
      - Make the bash flutter tool call pub get when the revision has
        changed. (This was already happening on Windows.)
      - Fix a raft of bugs found by the analyzer.
      - Fix some style nits in various bits of code that happened to be near
        things the analyzer noticed.
      - Remove the logic in "flutter test" that would run "pub get", since
        upon further reflexion it was determined it didn't work anyway.
        We'll probably have to add better diagnostics here and say to run the
        updater script.
      - Remove the native velocity tracker script, since it was testing code
        that has since been removed.
      
      Notes on ignored warnings:
      - We ignore warnings in any packages that are not in the Flutter repo or
        in the author's current directory.
      - We ignore various irrelevant Strong Mode warnings. We still enable
        strong mode because even though it's not really relevant to our needs,
        it does (more or less accidentally) catch a few things that are
        helpful to us.
      - We allow CONSTANTS_LIKE_THIS, since we get some of those from other
        platforms that we are copying for sanity and consistency.
      - We allow one-member abstract classes since we have a number of them
        where it's perfectly reasonable.
      - We unfortunately still ignore warnings in mojom.dart autogenerated
        files. We should really fix those but that's a separate patch.
      - We verify the actual source file when we see the 'Name non-constant
        identifiers using lowerCamelCase.' lint, to allow one-letter variables
        that use capital letters (e.g. for physics expressions) and to allow
        multiple-underscore variable names.
      - We ignore all errors on lines that contain the following magic
        incantation and a "#" character:
          // analyzer doesn't like constructor tear-offs
      - For all remaining errors, if the line contains a comment of the form
          // analyzer says "..."
        ...then we ignore any errors that have that "..." string in them.
      a0227cab
  25. 11 Nov, 2015 1 commit
  26. 06 Nov, 2015 1 commit
    • Adam Barth's avatar
      We throw an exception if you tap the screen during load · 060b34f7
      Adam Barth authored
      Inside runApp, we were building the render tree for the app, but we weren't
      calling layout, which meant we were running a hit test on a dirty tree. Now
      hitTest specifically asserts that the tree is clean and we synchronously call
      layout for your app during runApp.
      
      Fixes #1960
      060b34f7
  27. 28 Oct, 2015 1 commit
  28. 27 Oct, 2015 1 commit
    • Hixie's avatar
      Notification of metrics changes. · 32ca055f
      Hixie authored
      The Rendering layer binding now multiplexes the dart:ui metrics change
      notification so that multiple consumers can all listen to the change.
      32ca055f
  29. 26 Oct, 2015 1 commit
  30. 19 Oct, 2015 1 commit
  31. 16 Oct, 2015 1 commit
    • Hixie's avatar
      Sundry debugging aids and fixes · d0d84e16
      Hixie authored
      (These are all the debugging-related fixes and trivial typo fixes that I
      extracted out of my heroes branch.)
      
      Fix rendering.dart import order.
      
      Introduce a debugLabel for Performances so that when you create a
      performance, you can tag it so that if later you print it out, you can
      figure out which performance it is.
      
      Allow the progress of a PerformanceView to be determined (but not set).
      
      Allow subclasses of PerformanceView that are constants to be created by
      defining a constant constructor for PerformanceView.
      
      Introduce a debugPrint() method that throttles its output. This is a
      test to see if it resolves the problems people have been having with
      debugDumpRenderTree() et al having their output corrupted on Android. It
      turns out (according to some things I read On The Internets) that
      Android only has a 64KB kernel buffer for its logs and and if you output
      to it too fast, it'll drop data on the floor. If this does in fact
      reliably resolve this problem, we should probably move the fix over to
      C++ land (where "print" is implemented) so that any use of print is
      handled (avoiding the interleaving problem we have now if you use both
      debugPrint() and print()).
      
      Fix a bug with the debugging code for "size". In the specific case of a
      RenderBox having a parent that doesn't set parentUsesSize, then later
      the parent setting parentUsesSize but the child having its layout
      short-circuited (e.g. because the constraints didn't change), we didn't
      update the _DebugSize object to know that now it's ok that the size be
      used by the parent, and we'd assert.
      
      Also, allow a _DebugSize to be used to set the size of yourself.
      Previously you could only set your size from a regular Size or from your
      child's _DebugSize.
      
      Add more debugging information to various Widgets where it might be
      helpful.
      
      Make GlobalKey's toString() include the runtimeType so that when
      subclassing it the new class doesn't claim to be a GlobalKey instance.
      
      Include the Widget's key in the Element's description since we don't
      include it in the detailed description normally (it's in the name part).
      
      Fix a test that was returning null from a route.
      d0d84e16
  32. 14 Oct, 2015 1 commit
  33. 13 Oct, 2015 3 commits
  34. 10 Oct, 2015 2 commits