- 27 Oct, 2023 9 commits
-
-
Taha Tesser authored
…9) (#137247)" This reverts commit 008a10f1. *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Martin Kustermann authored
Since the original PR that supposedly enabled proguard, it was using the android proguard rules that disable optimizations. See initial PR in [0] This PR changes the flutter gradle plugin to use the `proguard-android-optimize.txt` (instead of `proguard-android.txt`) which will enable optimizations/shrinking of platform code (i.e. java/kotlin). For a simple flutter hello world this results in a 25% reduction in the resulting DEX file (`classes.dex` of the APK). Note for users: For some users this may result in issues because their java/kotlin code is now better optimized & tree shaken and thereby symbols may be no longer available or being obfuscated. To fix those issues it's best to craft precise proguard rules describing the extra symbols that are needed by the app (see [1]). But it's also possible to opt out entirely of optimizations by using the unoptimized proguard rules. To add custom proguard rules or use the unoptimized android rules, one can update `android/app/build.gradle`: ``` android { ... buildTypes { release { ... + proguardFiles( + // Not ideal: Disables optimizations by using unoptimized android rules. + getDefaultProguardFile("proguard-android.txt"), + + // Better: Have precise keep rules to only keep things that are needed. + "custom-rules.pro", + ) } } } ``` [0] f098de1f [1] https://developer.android.com/build/shrink-code Fixes https://github.com/flutter/flutter/issues/136879
-
Taha Tesser authored
This updates one of them M3 test to use golden test from https://github.com/flutter/flutter/pull/135901 Keeping it consistent with this [update](https://github.com/flutter/flutter/pull/136809#discussion_r1365053630)
-
Taha Tesser authored
This relands https://github.com/flutter/flutter/pull/136809 (it was reverted in https://github.com/flutter/flutter/pull/137242) --- Updated unit tests for `CircleOutlinedButton` to have M2 and M3 versions. More info in #127064 This also gets rid of unnecessary `fromSwatch` usage (part of https://github.com/flutter/flutter/issues/132584 documentation and test cleanup)
-
Andrew Kolos authored
Closes https://github.com/flutter/flutter/issues/130455. Updates the name `WebServiceWorker` uses to reference the asset manifest file to the name of the new file generated since https://github.com/flutter/flutter/pull/131382. This will make Flutter web apps correctly prefetch the asset manifest file.
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/136698. Alters how `throwToolExit` creates its matcher. This results is an improved description of the matcher. The mismatch description isn't improved by this, but I writing an entirely custom matcher to fix this isn't ideal either. We can instead mitigate the issue by augmenting the `toString` implementation of `ToolExit` to include the exit code, if it is non-null. With these changes, the first few lines of output from a test would look like this: ``` Expected: throws <Instance of 'ToolExit'> with `exitCode`: <42> and `message`: contains 'message' Actual: <Closure: () => Never> Which: threw ToolExit:<Exit code: 41232. Error: message> ```
-
Todd Volkert authored
This method controls whether the builder needs to be called again again even if the layout constraints are the same. By default, the builder will always be called when the widget is updated because the logic in the callback might have changed. However, there are cases where subclasses of ConstrainedLayoutBuilder know that certain property updates only affect paint and not build. In these cases, we lack a way of expressing that the builder callback is not needed -- and we end up doing superfluous work. This PR gives subclasses the ability to know exactly when the callback needs to be called and when it can be skipped.
-
Binni Goel authored
## Description This PR fixes typos in - `actions.dart` - `app_bar.dart` - `basic.dart` - `button_bar_theme.dart`
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/87f384c2d70b...bedc49efc85c 2023-10-26 dkwingsmt@users.noreply.github.com Skip invalid renders in Dart (flutter/engine#47323) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 26 Oct, 2023 31 commits
-
-
Tirth authored
Fix Small Typos.
-
Kostia Sokolovskyi authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9788bb9ff83e...87f384c2d70b 2023-10-26 chris@bracken.jp [macOS] Reuse NSWindow instance across unit tests (flutter/engine#47350) 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from fb72136c9325 to 93a0ad4d7ca6 (1 revision) (flutter/engine#47352) 2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from akT2HxdLNPWSG-gbV... to 37VxdxlPfdkek7mwC... (flutter/engine#47351) 2023-10-26 johnoneil@users.noreply.github.com Fix for undefined `uint8_t` seen on Clang-15+GCC13 (flutter/engine#47288) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from akT2HxdLNPWS to 37VxdxlPfdke If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ce1c1ee54107...9788bb9ff83e 2023-10-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Disable layer tree screenshots." (flutter/engine#47356) 2023-10-26 737941+loic-sharma@users.noreply.github.com [Windows] Refactor high contrast mode detection (flutter/engine#47314) 2023-10-26 jonahwilliams@google.com [Impeller] Disable layer tree screenshots. (flutter/engine#46171) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 windows_startup_test" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20windows_startup_test%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 flutter_tool_startup__windows" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_tool_startup__windows%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 windows_home_scroll_perf__timeline_summary" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20windows_home_scroll_perf__timeline_summary%22). This test can be marked as unflaky.
-
Gray Mackall authored
Fixes https://github.com/flutter/flutter/issues/129471. Does so by doing a very similar thing that is done by https://github.com/flutter/flutter/pull/121958, but for a task that is specific to the add to app build process.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 complex_layout_win_desktop__start_up" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20complex_layout_win_desktop__start_up%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/394744d2c4d0...ce1c1ee54107 2023-10-26 jason-simmons@users.noreply.github.com [Impeller] Fix the transform and geometry criteria for an optimization in TiledTextureContents (flutter/engine#47341) 2023-10-26 jason-simmons@users.noreply.github.com Roll HarfBuzz to 8.2.2 (flutter/engine#47284) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 hot_mode_dev_cycle_win_target__benchmark" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hot_mode_dev_cycle_win_target__benchmark%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 flutter_view_win_desktop__start_up" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_view_win_desktop__start_up%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 platform_view_win_desktop__start_up" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20platform_view_win_desktop__start_up%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 flutter_gallery_win_desktop__start_up" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__start_up%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 hello_world_win_desktop__compile" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hello_world_win_desktop__compile%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 flutter_gallery_win_desktop__compile" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__compile%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 run_release_test_windows" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20run_release_test_windows%22). This test can be marked as unflaky.
-
Greg Price authored
This comment on _localizedThemeDataCacheSize was a bit garbled from getting split up, and the doc on _localizedThemeDataCache was missing from having been moved elsewhere. It looks like the dislocation happened in 8b86d238 (#116088), which was otherwise making unrelated changes, including a couple of lines near these. Likely it was due to an error in resolving merge or rebase conflicts at some point while revising that PR.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 platform_channel_sample_test_windows" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20platform_channel_sample_test_windows%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7c5c8f587992...394744d2c4d0 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 19e9ccf5f820 to fb72136c9325 (2 revisions) (flutter/engine#47346) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9363fe6ba503...7c5c8f587992 2023-10-26 jonahwilliams@google.com [Impeller] remove giant closure in EntityPass. (flutter/engine#47343) 2023-10-26 godofredoc@google.com Adds firebase test lab tests. (flutter/engine#47320) 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from e1cc41ff84ca to 19e9ccf5f820 (1 revision) (flutter/engine#47342) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/542f8bc4c019...9363fe6ba503 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 091de96cad96 to e1cc41ff84ca (1 revision) (flutter/engine#47340) 2023-10-26 30870216+gaaclarke@users.noreply.github.com [Impeller] added missing openplayground (flutter/engine#47338) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Elias Yishak authored
Related to tracking issue: - https://github.com/flutter/flutter/issues/128251 This PR sends analytic events for each of the doctor validators. This PR below will need to land first in `dart-lang/tools` before this merges.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d8132d5070bf...542f8bc4c019 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from bc5c938ccff4 to 091de96cad96 (1 revision) (flutter/engine#47339) 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from ebae76679a04 to bc5c938ccff4 (1 revision) (flutter/engine#47337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows_arm64 run_debug_test_windows" } --> The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20run_debug_test_windows%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0a6253dbfafd...d8132d5070bf 2023-10-26 30870216+gaaclarke@users.noreply.github.com [Impeller] Improved documentation of the gaussian blur. (flutter/engine#47283) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5da115661f01...0a6253dbfafd 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from fb63b86f7bb8 to ebae76679a04 (1 revision) (flutter/engine#47336) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/61ae5ef94e9c...5da115661f01 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 3b84335bf181 to fb63b86f7bb8 (2 revisions) (flutter/engine#47335) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/f751ffb7d3cf...fea24c5b93b4 2023-10-25 stuartmorgan@google.com [url_launcher] Fix launch mode types in new APIs (flutter/packages#5232) 2023-10-25 43054281+camsim99@users.noreply.github.com [camerax] Implement `setZoomLevel` (flutter/packages#4950) 2023-10-25 engine-flutter-autoroll@skia.org Roll Flutter from 5e8b5f4e to 5dd2a4e0 (59 revisions) (flutter/packages#5231) 2023-10-25 43054281+camsim99@users.noreply.github.com [file_selector_android] Run tests on AVDs running Android 34 (flutter/packages#5218) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/23649a0529e5...61ae5ef94e9c 2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 6aaac934861c to 3b84335bf181 (1 revision) (flutter/engine#47334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
Xcode Debug tests require an older version of Xcode to run in CI. New test is failing due to incompatible Xcode version: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_arm64_ios%20flavors_test_ios_xcode_debug/1/overview
-