- 26 Sep, 2019 24 commits
-
-
Greg Spencer authored
This changes the way ActionDispatchers are found by the Actions widget, so that by default it will look for dispatchers of the parent Actions widgets instead of just creating a default ActionDispatcher. This allows overriding of the ActionDispatcher at the top level: before, the custom action dispatcher would only be invoked if explicitly set on all the Actions widgets. This is not a breaking change because there was a default value to the dispatcher parameter before that performed this function, and not specifying the dispatcher anywhere will still result in a default dispatcher being created.
-
Greg Spencer authored
The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped. This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node. This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
-
Jonah Williams authored
-
stuartmorgan authored
Adds very preliminary support for Windows and Linux plugins: - Adds those platforms to the new plugin schema, initially supporting just a plugin class. - Adds C++ plugin registrant generation for any Windows or Linux plugins found. This doesn't have yet have any build tooling for either platform, so anyone using the generated registrant still needs to do manual build configuration. This reduces the manual work, however, and creates a starting point for future tooling work. As with all Windows and Linux work at this time, this is not final, and subject to change without warning in the future (e.g., Windows could potentially switch to a C# interface, or 'linux' may change to 'gtk' or 'linux_gtk' in pubspec.yaml).
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/b520d7fd4b6d...b126ba758533 git log b520d7fd4b6d..b126ba758533 --no-merges --oneline 2019-09-26 liyuqian@google.com Add .mskp file to binary format (flutter/engine#12454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Kristin Ho authored
* MouseRegion documentation claimed that onEnter and onExit would track entry and exit regardless of whether the pointer was down or up * It did such, but when grabbing the value of `event.down` from the passed event, the value was always `false` * PointerEnterEvent and PointerExitEvent were overriding the value passed from PointerEvent in constructors, even if the value was true e.g. in invocations of .fromMouseEvent((PointerMoveEvent...)) * This change now passes the value along to PointerEnter/ExitEvents while providing it a default of false, and updates documentation Fixes #40637
-
Zachary Anderson authored
-
Jonah Williams authored
-
Greg Spencer authored
This fixes the mouse hover code to not schedule frames with every mouse move. Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame. The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/223d6d3e4278...b520d7fd4b6d git log 223d6d3e4278..b520d7fd4b6d --no-merges --oneline 2019-09-26 bkonyi@google.com Roll src/third_party/dart 53564db036..6ff8d2199d (1 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Jonah Williams authored
-
liyuqian authored
This reverts commit 652be88e. This fix is in https://github.com/flutter/packages/pull/37
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/1060cfc7daae...223d6d3e4278 git log 1060cfc7daae..223d6d3e4278 --no-merges --oneline 2019-09-26 bkonyi@google.com Roll src/third_party/dart dd65f97118..53564db036 (6 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Zachary Anderson authored
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/9fd35df9bb47...1060cfc7daae git log 9fd35df9bb47..1060cfc7daae --no-merges --oneline 2019-09-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from KcXAg... to z3PaM... (flutter/engine#12458) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Hans Muller authored
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/3713ecf10728...9fd35df9bb47 git log 3713ecf10728..9fd35df9bb47 --no-merges --oneline 2019-09-26 bkonyi@google.com Roll src/third_party/dart c6a14f4459..dd65f97118 (3 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/b3f2aad1c64d...3713ecf10728 git log b3f2aad1c64d..3713ecf10728 --no-merges --oneline 2019-09-26 bkonyi@google.com Roll src/third_party/dart 6c81690c3a..c6a14f4459 (13 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Tong Wu authored
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/3360d861e5cf...b3f2aad1c64d git log 3360d861e5cf..b3f2aad1c64d --no-merges --oneline 2019-09-26 gspencergoog@users.noreply.github.com Revert "Send TYPE_VIEW_FOCUSED for views with input focus. (#12410)" (flutter/engine#12455) 2019-09-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from worpw... to PyQPO... (flutter/engine#12452) 2019-09-25 bkonyi@google.com Roll src/third_party/dart 69b5681546..6c81690c3a (38 commits) 2019-09-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from avi05... to KcXAg... (flutter/engine#12449) 2019-09-25 gspencergoog@users.noreply.github.com Send TYPE_VIEW_FOCUSED for views with input focus. (flutter/engine#12410) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Greg Spencer authored
* Revert "Roll engine c1773f3c57eb..739ee77864e3 (3 commits) (#41331)" This reverts commit 5caad71f. * Revert "c1773f3c5 Send TYPE_VIEW_FOCUSED for views with input focus. (flutter/engine#12410) (#41325)" This reverts commit ab8cf947.
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/c1773f3c57eb...739ee77864e3 git log c1773f3c57eb..739ee77864e3 --no-merges --oneline 2019-09-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from worpw... to PyQPO... (flutter/engine#12452) 2019-09-25 bkonyi@google.com Roll src/third_party/dart 69b5681546..6c81690c3a (38 commits) 2019-09-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from avi05... to KcXAg... (flutter/engine#12449) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Emmanuel Garcia authored
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/3360d861e5cf...c1773f3c57eb git log 3360d861e5cf..c1773f3c57eb --no-merges --oneline 2019-09-25 gspencergoog@users.noreply.github.com Send TYPE_VIEW_FOCUSED for views with input focus. (flutter/engine#12410) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
- 25 Sep, 2019 16 commits
-
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/efb7bf434f2c...3360d861e5cf git log efb7bf434f2c..3360d861e5cf --no-merges --oneline 2019-09-25 yjbanov@google.com [web] filter test targets; cache host.dart compilation (flutter/engine#12445) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Jonah Williams authored
-
Alexander Aprelev authored
* Update image_list test to use locally set up https server to validate performance of image loading over https(rather than http) protocol. Https requires more back-and-forward communication before image bytes are sent to the client, shows clear signs of throughput affected by how busy flutter UI isolate is.
-
Greg Spencer authored
This enables the manual tests to be built on a macOS desktop machine in desktop mode. I created the macos directory by using flutter create --macos
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/0bfca375b3f5...efb7bf434f2c git log 0bfca375b3f5..efb7bf434f2c --no-merges --oneline 2019-09-25 mklim@google.com Work around Samsung keyboard issue (flutter/engine#12432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Jonah Williams authored
-
Jonah Williams authored
-
Francisco Magdaleno authored
-
Nurhan Turgut authored
Fixing the editable_text unit tests by clearing the log. Add a modification for also testing cached size. (#41300)
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/48ad8a08e45f...0bfca375b3f5 git log 48ad8a08e45f..0bfca375b3f5 --no-merges --oneline 2019-09-25 yjbanov@google.com Force exit felt tool on sigint, sigterm (flutter/engine#12443) 2019-09-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6abaff3041a3..559ffe4a23ce (2 commits) (flutter/engine#12444) 2019-09-25 dworsham@google.com [fuchsia] Wire up OpacityLayer to Scenic (flutter/engine#11322) 2019-09-25 yjbanov@google.com delete golden files; switch to flutter/goldens (flutter/engine#12434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
Zachary Anderson authored
-
Alexandre Ardhuin authored
-
Emmanuel Garcia authored
-
engine-flutter-autoroll authored
git@github.com:flutter/engine.git/compare/63949eb0fd98...48ad8a08e45f git log 63949eb0fd98..48ad8a08e45f --no-merges --oneline 2019-09-25 devoncarew@google.com add dart:html, dart:js, and dart:js_util to the copy of the Dart SDK used for analysis (flutter/engine#12435) 2019-09-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from dmzjj... to worpw... (flutter/engine#12441) 2019-09-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2da97da4b024..6abaff3041a3 (1 commits) (flutter/engine#12440) 2019-09-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from rEYHD... to avi05... (flutter/engine#12439) 2019-09-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2137f90b9d98..2da97da4b024 (3 commits) (flutter/engine#12438) 2019-09-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia f050422f3285..2137f90b9d98 (4 commits) (flutter/engine#12437) 2019-09-25 ditman@gmail.com Interpret negative radii as 0 in recording_canvas drawDRRect (flutter/engine#12431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
-
LongCatIsLooong authored
-
Emmanuel Garcia authored
-