Commits · a04fe3169ae9f5b5d53366ecfeb2403ca7040312 · abdullh.alsoleman / Front-End

09 Mar, 2024 4 commits

Upgrade vm_service. (#144845) · a04fe316
Polina Cherkasova authored Mar 09, 2024

a04fe316

Percival authored Mar 09, 2024

I have found that some Apple-related links are no longer accessible, and they have been replaced

cab4a0fb

Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (#144849) · c0006488

engine-flutter-autoroll authored Mar 09, 2024

https://github.com/flutter/engine/compare/e099277ce061...953927eae78b

2024-03-08 zanderso@users.noreply.github.com Revert test if changes to golden tests (flutter/engine#51291)
2024-03-08 jmccandless@google.com iPad keyboard cut/copy/paste buttons (flutter/engine#50923)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0006488

Mark Mac_arm64_ios module_test_ios bringup: true (#144861) · 7bf84d0c
Zachary Anderson authored Mar 09, 2024
```
For https://github.com/flutter/flutter/issues/144860
```
7bf84d0c

08 Mar, 2024 13 commits

Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (#144855) · 0432a694

auto-submit[bot] authored Mar 08, 2024

Reverts: flutter/flutter#143176
Initiated by: QuncCccccc
Reason for reverting: made tree red.
Original PR Author: Hixie

Reviewed By: {Piinks}

This change reverts the following previous change:
This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)

0432a694

Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (#144844) · 0a40291f

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/engine/compare/05fdf947f81b...e099277ce061

2024-03-08 dnfield@google.com Use `io.flutter.Build.API_LEVELS` rather than `android.os.Build.VERSION_CODES` (flutter/engine#51171)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a40291f

Rename isAvailableForEnvironment to isForEnvironment (#143176) · 5bd34ef5

Ian Hickson authored Mar 08, 2024

This is part 4 of a broken down version of the #140101 refactor.

This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)

5bd34ef5

Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (#144839) · fde345a6

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/engine/compare/bc4abcda6357...05fdf947f81b

2024-03-08 jonahwilliams@google.com [Impeller] More efficient usage of transient onscreen attachments. (flutter/engine#51206)
2024-03-08 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc (flutter/engine#51234)
2024-03-08 chris@bracken.jp Migrate vulkan_memory_allocator to flutter/third_party (flutter/engine#51275)
2024-03-08 jason-simmons@users.noreply.github.com Update CI scripts to use either src/flutter/third_party/dart or src/third_party/dart (flutter/engine#51276)
2024-03-08 kustermann@google.com Add fuchsia_gn_sdk GN variable pointing to //flutter/tools/fuchsia/gn-sdk (flutter/engine#51287)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 993a88a663c8 to a4fb847f47d9 (1 revision) (flutter/engine#51283)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 15f8d03a9594 to 993a88a663c8 (1 revision) (flutter/engine#51282)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) (flutter/engine#51280)
2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from bf3f9c5f0edb to 093994f8f078 (1 revision) (flutter/engine#51278)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fde345a6

Fixes the transition builder changing the Cupertino transition on Android. (#134790) · 2be5084b

Mitchell Goodwin authored Mar 08, 2024

Fixes #124850.

Changes the fallback for the builder on Android. Before the error was from the platform being changed mid Cupertino transition to iOS. If a default builder wasn't set for iOS (which a developer developing only for Android might not), then it defaulted to the Zoom transition. Which changing the transition while on the fly caused issues.

2be5084b

Copy over source maps from dart2js target when they are enabled. (#144832) · 074114b8

Jackson Gardner authored Mar 08, 2024

This fixes https://github.com/flutter/flutter/issues/143703

We need to make sure that when source maps are enabled for the dart2js target, it advertises the sourcemap file as one of its outputs so that the web release bundle can copy it over.

074114b8

Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (#144677) · ea1ef751

Flutter GitHub Bot authored Mar 08, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android new_gallery_opengles_impeller__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20new_gallery_opengles_impeller__transition_perf%22).
This test can be marked as unflaky.

ea1ef751

Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (#144817) · fd4ab4f6

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/engine/compare/bbb1ed00af49...bc4abcda6357

2024-03-08 bdero@google.com [Impeller] Add mask blur style support to the RRect blur fast path. (flutter/engine#51250)
2024-03-08 30870216+gaaclarke@users.noreply.github.com [Impeller] moved tests to aiks_blur_unittests, added warning (flutter/engine#51274)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd4ab4f6

Roll Packages from 6701c9e61804 to 0badb4356021 (2 revisions) (#144831) · 1e1958fc

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/packages/compare/6701c9e61804...0badb4356021

2024-03-07 katelovett@google.com [two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells (flutter/packages#6283)
2024-03-07 engine-flutter-autoroll@skia.org Roll Flutter from 8f84f3f3 to 471a8285 (27 revisions) (flutter/packages#6281)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e1958fc

Remove `toString()` overrides in `dart:ui`/`package:flutter` in... · 7c89ec8b

Martin Kustermann authored Mar 08, 2024

Remove `toString()` overrides in `dart:ui`/`package:flutter` in profile/release mode on wasm/vm targets (#144763)

The flutter engine & framework can opt out of this optimization for
individual classes / class hierarchies via:

  * `@pragma(flutter:keep-to-string)`
  * `@pragma(flutter:keep-to-string-in-subtypes)`

Or by using the convenience constant `@keepToString` from `dart:ui`.

=> This aligns the build process more with g3 (which already does this)

Closes https://github.com/flutter/flutter/issues/52759

7c89ec8b

Roll Flutter Engine from 80cd7981043f to bbb1ed00af49 (3 revisions) (#144813) · 70186852

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/engine/compare/80cd7981043f...bbb1ed00af49

2024-03-08 chris@bracken.jp Move ANGLE to flutter/third_party (flutter/engine#51270)
2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) (flutter/engine#51268)
2024-03-07 jason-simmons@users.noreply.github.com [Impeller] Fix a buffer overrun in ImpellerC reflector resource offsets (flutter/engine#51108)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70186852

Update documentation of `AlertDialog`'s default `TextStyle` for Material 3 (#144697) · dde616db

Loïc de Porcaro authored Mar 08, 2024

## Update `AlertDialog` Documentation for Material 3 Defaults

This pull request updates the documentation for `AlertDialog` to accurately reflect the default text styles (`titleTextStyle` and `contentTextStyle`) when using Material 3.
Previously, the documentation suggested default styles (`TextTheme.titleLarge` for titles and `TextTheme.titleMedium` for content) that do not align with Material 3 implementation, which uses `TextTheme.headlineSmall` and `TextTheme.bodyMedium` respectively.

Fixes #144489

dde616db

Roll Flutter Engine from 175069397a40 to 80cd7981043f (5 revisions) (#144804) · d632f34f

engine-flutter-autoroll authored Mar 08, 2024

https://github.com/flutter/engine/compare/175069397a40...80cd7981043f

2024-03-07 chris@bracken.jp Roll buildroot to ef514ca5144ba0a4ce5e7075c325d24cd6da73a4 (flutter/engine#51265)
2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 4bc97350dc47 to 4c64fcc134bf (1 revision) (flutter/engine#51266)
2024-03-07 bdero@google.com [Impeller] Record restore clips in the replay mechanism when StC is enabled. (flutter/engine#51259)
2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) (flutter/engine#51263)
2024-03-07 zanderso@users.noreply.github.com [gn] Disable running some python scripts from GN (flutter/engine#51248)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d632f34f

07 Mar, 2024 23 commits

Enable asset transformation for `flutter run -d <browser>` and `flutter test` (#144734) · 06ac0422

Andrew Kolos authored Mar 07, 2024

Partial implementation of https://github.com/flutter/flutter/issues/143348.

The title says it all. Feel free to experiment with the feature using this project: https://github.com/andrewkolos/asset_transformers_test.

06ac0422

Roll Flutter Engine from ec4f9af3d53b to 175069397a40 (2 revisions) (#144799) · dfbf3d23

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/ec4f9af3d53b...175069397a40

2024-03-07 chris@bracken.jp Migrate build_overrides from buildroot to engine (flutter/engine#51258)
2024-03-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from y67DIBX84h7pAekIp... to 5Ra_AjCji-uR1GaX7... (flutter/engine#51261)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from y67DIBX84h7p to 5Ra_AjCji-uR

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dfbf3d23

refactor: Remove `throwOnPluginPubspecError` flag for plugin validation (#144214) · dc6f94a8

August authored Mar 07, 2024

Part of #137040 and #80374

The flag `throwOnPluginPubspecError` never actually was enabled during production in #79669, but only in some dart plugin tests. And in the tests the case of the error when enabling the flag was not explicitly tested. The only thing tested was, that it is not thrown when disabled.

As explained [here](https://github.com/flutter/flutter/pull/142035#discussion_r1484237904) the only case, where this error could be thrown is, when a dart implementation and a native inline implementation are provided simultaneously. But throwing an exception there is a wrong behavior, as both can coexist in a plugin package, thus in the pubspec file.

Disabling the flag means, that the error is not thrown and not shown to the user. This is the case in production (contrary to the dart plugin tests), which acts like these plugin cases of implementations are just skipped. And this is what actually should be done.

In conclusion, I think the case of coexisting dart and native implementation in pubspec was just overlooked and therefore this error validation was introduced, which is not necessary or even valid.

For more discussion, see: https://discord.com/channels/608014603317936148/608022056616853515/1200194937791205436

- This is tricky: I already added a test in #142035, which finally complies with the other tests, by removing the flag. So I think it falls in the category of "remove dead code".
- Theoretically this is a breaking change, as removing / altering some tests. But the flag actually was never valid or used, so IDK. But this may not does fall in the category of "contributed tests".

dc6f94a8

Roll Flutter Engine from 305333c50191 to ec4f9af3d53b (1 revision) (#144797) · 36e09ff3

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/305333c50191...ec4f9af3d53b

2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from cf7fefd0bbfb to 6bfd57b8790f (24 revisions) (flutter/engine#51260)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

36e09ff3

Roll Flutter Engine from c2863530ce39 to 305333c50191 (1 revision) (#144793) · d2ab6d9a

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/c2863530ce39...305333c50191

2024-03-07 skia-flutter-autoroll@skia.org Roll Skia from f17ec7494469 to cf7fefd0bbfb (1 revision) (flutter/engine#51227)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2ab6d9a

Fixed -> DropdownMenu throws exception when it is in any scrollable l… (#140566) · 874804e5
Faisal Ansari authored Mar 07, 2024
```
Fixed -> DropdownMenu throws exception when it is in any scrollable list view and scrolls quickly #139871
```
874804e5

Roll Flutter Engine from 9e8ccaa3842e to c2863530ce39 (2 revisions) (#144792) · 487d42f9

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/9e8ccaa3842e...c2863530ce39

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from bbf21a08a92d to 4bc97350dc47 (1 revision) (flutter/engine#51256)
2024-03-07 tugorez@users.noreply.github.com Prepend the accessibility placeholder (flutter/engine#51050)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

487d42f9

Roll Flutter Engine from 12828950890a to 9e8ccaa3842e (1 revision) (#144784) · a23a9afe

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/12828950890a...9e8ccaa3842e

2024-03-07 jesus_sguerrero@hotmail.com Skip impeller goldens on release (flutter/engine#51240)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a23a9afe

Marks Mac_x64 module_test_ios to be flaky (#144681) · d0287cc1

Flutter GitHub Bot authored Mar 07, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64 module_test_ios"
}
-->
Issue link: https://github.com/flutter/flutter/issues/144680

d0287cc1

[flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError (#140122) · 2dd06d10

Christopher Fujino authored Mar 07, 2024

Ensure tool code does not use Future.catchError or Future.onError, because it is not statically safe: https://github.com/dart-lang/sdk/issues/51248.

This was proposed upstream in dart-lang/linter in https://github.com/dart-lang/linter/issues/4071 and https://github.com/dart-lang/linter/pull/4068, but not accepted.

2dd06d10

Roll Flutter Engine from f8c3b2db8cd1 to 12828950890a (1 revision) (#144775) · 2ea5ca03

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/f8c3b2db8cd1...12828950890a

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from bf028d05b7fd to bbf21a08a92d (1 revision) (flutter/engine#51254)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ea5ca03

[flutter_test] Use defaultTargetPlatform for key events simulation (#143579) · 471a8285

Bruno Leroux authored Mar 07, 2024

## Description

This PRs changes the default value for the `platform` parameter used to simulate key events.

With this PR, the default value is "web" on web, otherwise it is the operating system name retrieved from `defaultTargetPlatform`.

Previously, for methods in `WidgetController`, it defaulted to âwebâ on web, and âandroidâ everywhere else. And for methods in `KeyEventSimulator` it defaulted to âwebâ on web, and the operating system that the test was running on everywhere else. Because the operating system was based on `Platform.operatingSystem`, it usually differed from the target platform the test was running on.

AFAIK, the `platform` parameter is only meaningful for simulating `RawKeyEvent`. Once `RawKeyboard` will be fully removed, the `platform` parameter wonât be needed. 
@gspencergoog  In the meantime, do you think it is worth merging this fix?

## Related Issue

Fixes to https://github.com/flutter/flutter/issues/133955

## Tests

Adds one test.

471a8285

Roll Packages from 9b88dbc53992 to 6701c9e61804 (3 revisions) (#144772) · 4e63a6a2

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/packages/compare/9b88dbc53992...6701c9e61804

2024-03-06 tugorez@users.noreply.github.com [rfw] Add support for widget builders (flutter/packages#5907)
2024-03-06 gabriel@terwesten.net [in_app_purchase_storekit] Handle translation of errors nested in dictionaries (flutter/packages#6277)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter from 3b5a2ecf to 8f84f3f3 (18 revisions) (flutter/packages#6276)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4e63a6a2

Fix frameworks added to bundle multiple times instead of lipo (#144688) · de728320

Matej Knopp authored Mar 07, 2024

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

de728320

Roll Flutter Engine from 40a42796b129 to f8c3b2db8cd1 (1 revision) (#144766) · 4d446622

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/40a42796b129...f8c3b2db8cd1

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 3538739eeea9 to bf028d05b7fd (1 revision) (flutter/engine#51252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d446622

Roll Flutter Engine from 0246484d2bae to 40a42796b129 (1 revision) (#144765) · 3aa89b39

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/0246484d2bae...40a42796b129

2024-03-07 kustermann@google.com Make @keepToString annotation work for web and non-web (flutter/engine#51251)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3aa89b39

Roll Flutter Engine from 6c1751bd774e to 0246484d2bae (1 revision) (#144756) · 4d3e26fa

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/6c1751bd774e...0246484d2bae

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 2cdf8f23c55f to 3538739eeea9 (1 revision) (flutter/engine#51249)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d3e26fa

[flutter_test] Change KeyEventSimulator default transit mode (#143847) · 8ade81fb

Bruno Leroux authored Mar 07, 2024

## Description

This PRs changes the default value transit mode for key event simulation.

The default transit mode for key event simulation is currently `KeyDataTransitMode.rawKeyData` while on the framework side `KeyDataTransitMode.keyDataThenRawKeyData` is the preferred transit mode.

`KeyDataTransitMode.keyDataThenRawKeyData` is more accurate and can help detect issues.

For instance the following test will fail with `KeyDataTransitMode.rawKeyData` because raw keyboard logic for modifier keys is less accurate:

```dart
  testWidgets('Press control left once', (WidgetTester tester) async {
    debugKeyEventSimulatorTransitModeOverride = KeyDataTransitMode.keyDataThenRawKeyData;

    final List<KeyEvent> events = <KeyEvent>[];
    final FocusNode focusNode = FocusNode();
    addTearDown(focusNode.dispose);

    await tester.pumpWidget(
      Focus(
        focusNode: focusNode,
        autofocus: true,
        onKeyEvent: (_, KeyEvent event) {
          events.add(event);
          return KeyEventResult.handled;
        },
        child: Container(),
      ),
    );

    await simulateKeyDownEvent(LogicalKeyboardKey.controlLeft);

    // This will fail when transit mode is KeyDataTransitMode.rawKeyData
    // because a down event for controlRight is synthesized.
    expect(events.length, 1);

    debugKeyEventSimulatorTransitModeOverride = null;
  });
```

And the following this test is ok with `KeyDataTransitMode.rawKeyData` but rightly fails with `KeyDataTransitMode.keyDataThenRawKeyData`:

```dart
  testWidgets('Simulates consecutive key down events', (WidgetTester tester) async {
    debugKeyEventSimulatorTransitModeOverride = KeyDataTransitMode.rawKeyData;

    // Simulating several key down events without key up in between is tolerated
    // when transit mode is KeyDataTransitMode.rawKeyData, it will trigger an
    // assert on KeyDataTransitMode.keyDataThenRawKeyData.
    await simulateKeyDownEvent(LogicalKeyboardKey.arrowDown);
    await simulateKeyDownEvent(LogicalKeyboardKey.arrowDown);

    debugKeyEventSimulatorTransitModeOverride = null;
  });
```

## Related Issue

Related to https://github.com/flutter/flutter/issues/143845

## Tests

Adds two tests.

8ade81fb

Roll Flutter Engine from 03ebd6460b83 to 6c1751bd774e (2 revisions) (#144747) · f6770276

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/03ebd6460b83...6c1751bd774e

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 3ad64881a209 to 2cdf8f23c55f (2 revisions) (flutter/engine#51247)
2024-03-07 dkwingsmt@users.noreply.github.com Reland 5: Multiview pipeline (flutter/engine#51186)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6770276

Roll Flutter Engine from 8a859c5b3a2d to 03ebd6460b83 (2 revisions) (#144746) · 95bf597a

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/8a859c5b3a2d...03ebd6460b83

2024-03-07 jonahwilliams@google.com [Impeller] add a per-frame trace event for heap usage on Vulkan. (flutter/engine#51246)
2024-03-07 chris@bracken.jp Move Abseil from src to flutter third_party dir (flutter/engine#51245)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

95bf597a

Roll Flutter Engine from 4f6ea31d1f25 to 8a859c5b3a2d (2 revisions) (#144743) · 894620b8

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/4f6ea31d1f25...8a859c5b3a2d

2024-03-07 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 9ea8813ab4d4 to 3ad64881a209 (5 revisions) (flutter/engine#51242)
2024-03-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] disable blending in gaussian intermediate steps. (#51118)" (flutter/engine#51244)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

894620b8

Fix memory leak in `editable_gesture_test.dart` (#144691) · 96dd1984
Valentin Vignal authored Mar 07, 2024

96dd1984

Roll Flutter Engine from 53ddbdfc24e5 to 4f6ea31d1f25 (2 revisions) (#144741) · 3e63c738

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/53ddbdfc24e5...4f6ea31d1f25

2024-03-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] fold memory check into allocator_vk (#51187)" (flutter/engine#51243)
2024-03-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 50464546d92d to 9ea8813ab4d4 (5 revisions) (flutter/engine#51239)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e63c738