- 22 Apr, 2023 1 commit
-
-
Callum Moffat authored
Include rects with any overlap instead of only when top-left or bottom-right included. The previous criteria didn't send any selection rects when text was taller than the text box and scroll offset was not zero. Part of #30476
-
- 21 Apr, 2023 3 commits
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/99360
-
Justin McCandless authored
iOS now hides the selection handles and shows red selection when tapping a misspelled word, like native.
-
Bruno Leroux authored
## Description This PR introduces `DefaultSelectionStyle.mouseCursor` to configure the mouse cursor over selectable text. It also applies this solution to `InkResponse` to make the mouse cursor win over the default one provided by selectable `Text` for many Material components (such as buttons). ### Before https://user-images.githubusercontent.com/840911/233627729-ddf98e2a-444d-4c6d-a6d5-f521982f48dd.mov ### After https://user-images.githubusercontent.com/840911/233627718-8871a68f-d33c-44cf-b4a1-91bb1fcdf076.mov ## Related Issue Fixes https://github.com/flutter/flutter/issues/104595 ## Tests Adds 6 tests.
-
- 20 Apr, 2023 4 commits
-
-
Renzo Olivares authored
#125151 introduced the magnifier on touch drag gestures, but when showing the magnifier the toolbar is implicitly hidden, this change makes the toolbar re-appear on drag end for double tap + drag.
-
Ian Hickson authored
I don't know what I was thinking when I wrote this code back in 2017 but this is so trivially fixable...
-
Tae Hyung Kim authored
Going to make some changes to the implementation so I'll revert in the meantime. Reverts flutter/flutter#124337
-
Renzo Olivares authored
This change shows the magnifier on touch drag gestures for Android and iOS and hides it when the drag ends. Fixes #118268
-
- 19 Apr, 2023 2 commits
-
-
chunhtai authored
The regression was caused by the previous pr https://github.com/flutter/flutter/pull/124624 changes postframecallback to scheduleframecallback. The reason is that if a new postframecallback was scheduled when running a postframecallback. The newly added postframecallback will be execute on the next frame. However, adding postframecallback will not schedule a new frame. So if there isn't other widget that schedule a new frame, the newly added postframecallback will never gets run. After changing to scheduleframecallback, it causes an issue that transient callback may be called when rendering tree contains dirty layout information that are waiting to be rebuilt. Therefore, I use microtask to get around of the postframecallback issue instead of scheduleframecallback. fixes https://github.com/flutter/flutter/issues/125065
-
Justin McCandless authored
Fixes https://github.com/flutter/flutter/issues/124247 | Native | Flutter before | Flutter after | | --- | --- | --- | | <img width="248" alt="Screenshot 2023-04-05 at 9 26 16 AM" src="https://user-images.githubusercontent.com/389558/230177116-154999e8-eef3-441d-9fe9-7063839a6b99.png"> | <img width="240" alt="Screenshot 2023-04-05 at 11 18 01 AM" src="https://user-images.githubusercontent.com/389558/230177125-1680e851-223e-4956-b5b6-1a24e11dc22a.png"> | <img width="226" alt="Screenshot 2023-04-05 at 11 17 36 AM" src="https://user-images.githubusercontent.com/389558/230177123-bde82134-67e1-4ce2-8eec-719eeb779bf4.png"> | Also, it's now possible for anyone to create disabled buttons like this by setting ContextMenuButtonItem.onPressed to `null`.
-
- 18 Apr, 2023 2 commits
-
-
Michael Goderbauer authored
These are currently unused and will not work in a multi-view environment where we will have multiple render trees. Work towards https://github.com/flutter/flutter/issues/121573.
-
Kate Lovett authored
This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation) This is one of the last little PRs to prep for the 2D scrolling foundation. This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis. In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done. There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.
-
- 17 Apr, 2023 2 commits
-
-
chunhtai authored
When swapping out delegate of selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
-
hangyu authored
issue #123378
-
- 13 Apr, 2023 1 commit
-
-
Justin McCandless authored
Explain how to do the two-step migration to the context menus feature.
-
- 12 Apr, 2023 3 commits
-
-
Nabeel Parkar authored
Bug report 2 issue template
-
Gabriel Gava authored
Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList
-
xubaolin authored
DraggableScrollableSheet & NestedScrollView should respect NeverScrollableScrollPhysics
-
- 11 Apr, 2023 1 commit
-
-
Aditya Thakur authored
Fix ShaderMask Example issue
-
- 10 Apr, 2023 4 commits
-
-
Tae Hyung Kim authored
Sliver Constrained Cross Axis
-
Callum Moffat authored
Reduce macOS overscroll friction
-
joshualitt authored
-
luckysmg authored
[Text Input] Only unfocus when receive connectionClosed on platform except web
-
- 08 Apr, 2023 2 commits
-
-
Christopher Fujino authored
document StaticIconProvider
-
Greg Spencer authored
Prepare for adding values to AppLifecycleState
-
- 07 Apr, 2023 4 commits
-
-
chunhtai authored
Reland Refactor reorderable list semantics
-
chunhtai authored
Fixes IgnorePointer and AbsorbPointer to only block user interactionsâ¦
-
Bruno Leroux authored
Fix EditableText misplaces caret when selection is invalid
-
Xilai Zhang authored
Revert "Refactor reorderable list semantics"
-
- 06 Apr, 2023 6 commits
-
-
chunhtai authored
Refactor reorderable list semantics
-
Justin McCandless authored
Make sure the removal of deprecated APIs TextSelectionControls.buildToolbar and TextSelectionHandleControls happen in two separate steps. Will make a tricky migration situation a little easier for affected users.
-
Gregory Conrad authored
Fix a memory leak in `AutomaticKeepAlive`
-
Tirth authored
[Docs] Fix Typos
-
Loune Lam authored
Remove mouse tap text drag selection throttling to improve responsiveness
-
Michael Goderbauer authored
-
- 05 Apr, 2023 4 commits
-
-
Renzo Olivares authored
TapAndDragGestureRecognizer should declare victory immediately when drag is detected
-
Loïc Sharma authored
Add CallbackShortcuts example
-
Camille Simon authored
Fixes https://github.com/flutter/flutter/issues/119534 by adding extra logic to allow the proper `TextSpan` trees to be build with spell check results that does not rely on the composing region. Also, refreshes the algorithm used to correct spell check results to improve cases where spell check results are out of date, but the composing region line does not help smooth over this fact by giving the framework extra time to update while a word is being composed (because a composing region line would cover up any flashing red underlines). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
hellohuanlin authored
[platform_view]fix iOS platform view's focus node leakage
-
- 04 Apr, 2023 1 commit
-
-
chunhtai authored
Adds i18n to widget layer
-