Commits · 9f5fd75e54fccbfd7ea0f66b12592a537621ae00 · abdullh.alsoleman / Front-End

14 Mar, 2024 15 commits

[framework] fix incorrect chinese localizations for Search Web and Share in... · 9f5fd75e

LouiseHsu authored Mar 14, 2024

[framework] fix incorrect chinese localizations for Search Web and Share in selection controls (#144857)

Fixes https://github.com/flutter/flutter/issues/144825

Corresponding translation suggestions:

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-TW
(I accidentally pressed submit 3 times :( )

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-HK

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-CN

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8883913494819754382&language=zh-CN

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

9f5fd75e

Asserts if a `TextPainter` gets disposed more than once (#145124) · a69567a3
LongCatIsLooong authored Mar 14, 2024
```
The overflow indicator was sharing the same `TextPainter`.
```
a69567a3

Roll Flutter Engine from 562d7a6e2861 to 46993c1bf5bb (2 revisions) (#145154) · 51d59a7d

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/562d7a6e2861...46993c1bf5bb

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from f4ce9fc2ec45 to 52bb1539c5cf (1 revision) (flutter/engine#51415)
2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from d006b668dcb2 to 749988e4d748 (1 revision) (flutter/engine#51414)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51d59a7d

Roll Packages from 38711aca66fa to b21c5424783a (5 revisions) (#145152) · 5b7d5cad

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/packages/compare/38711aca66fa...b21c5424783a

2024-03-14 pageli328@gmail.com Support overriding `ErrorWidget.builder` (flutter/packages#6302)
2024-03-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 61812ca3 to 394269f9 (6 revisions) (flutter/packages#6320)
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.1 to 4.1.2 (flutter/packages#6309)
2024-03-13 magder@google.com Replace deprecated UIGraphicsBeginImageContextWithOptions with UIGraphicsImageRenderer (flutter/packages#6285)
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.6 to 3.24.7 (flutter/packages#6310)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b7d5cad

Roll Flutter Engine from 8fcff7b44480 to 562d7a6e2861 (1 revision) (#145148) · 3d5f7864

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/8fcff7b44480...562d7a6e2861

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from 21186e265c39 to f4ce9fc2ec45 (1 revision) (flutter/engine#51413)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d5f7864

Roll Flutter Engine from 5c147a9f8fa6 to 8fcff7b44480 (1 revision) (#145142) · 826e47e0

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/5c147a9f8fa6...8fcff7b44480

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from 804d0ed22179 to 21186e265c39 (1 revision) (flutter/engine#51412)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

826e47e0

Roll Flutter Engine from 03d2af1d7a46 to 5c147a9f8fa6 (2 revisions) (#145135) · 4fa44339

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/03d2af1d7a46...5c147a9f8fa6

2024-03-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mYZPzdM3hCE1TA91s... to da-siZ7wPDA0Z0wXJ... (flutter/engine#51411)
2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from e175e61d6259 to 804d0ed22179 (1 revision) (flutter/engine#51410)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from mYZPzdM3hCE1 to da-siZ7wPDA0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4fa44339

Roll Flutter Engine from f3bd39808a74 to 03d2af1d7a46 (1 revision) (#145133) · 7bf36ae7

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/f3bd39808a74...03d2af1d7a46

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from cac09f152d9b to e175e61d6259 (2 revisions) (flutter/engine#51408)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7bf36ae7

Roll Flutter Engine from 1da1597ec60d to f3bd39808a74 (1 revision) (#145131) · 822f55b3

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/1da1597ec60d...f3bd39808a74

2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from b1e31a41fb17 to d006b668dcb2 (1 revision) (flutter/engine#51409)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

822f55b3

Roll Flutter Engine from bdf66af6ff0b to 1da1597ec60d (1 revision) (#145130) · fbf2692d

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/bdf66af6ff0b...1da1597ec60d

2024-03-14 matanlurey@users.noreply.github.com Remove `--enable-impeller-{backend}` flags (always `True`). (flutter/engine#51402)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fbf2692d

Roll Flutter Engine from 599dbd7382ec to bdf66af6ff0b (1 revision) (#145129) · d7dcd5ca

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/599dbd7382ec...bdf66af6ff0b

2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from abc8988e9dac to b1e31a41fb17 (1 revision) (flutter/engine#51403)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d7dcd5ca

Roll Flutter Engine from 6710d10ad703 to 599dbd7382ec (3 revisions) (#145123) · fa2f64ad

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/6710d10ad703...599dbd7382ec

2024-03-14 737941+loic-sharma@users.noreply.github.com [Embedder API] Add multi-view present callback (flutter/engine#51267)
2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from a315e4572f4e to cac09f152d9b (10 revisions) (flutter/engine#51398)
2024-03-14 dkwingsmt@users.noreply.github.com Multi-view View Metrics (flutter/engine#46174)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fa2f64ad

Roll Flutter Engine from cb9dead25ef9 to 6710d10ad703 (1 revision) (#145121) · 5ab91882

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/cb9dead25ef9...6710d10ad703

2024-03-13 yjbanov@google.com [web] make text more crawlable; fix a JAWS bug (flutter/engine#50794)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5ab91882

Roll Flutter Engine from d29383cc8122 to cb9dead25ef9 (1 revision) (#145120) · a769ef48

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/d29383cc8122...cb9dead25ef9

2024-03-13 john@johnmccutchan.com Disable cleaning up ImageReaders in memory pressure callback (flutter/engine#51391)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a769ef48

Reduce Windows_arm64 plugin_test_windows test timeout (#145110) · 349cbb4a

Loïc Sharma authored Mar 14, 2024

Windows Defender sometimes kills the `Windows_arm64 plugin_test_windows` test process, causing the test to hang until it times out after 30 minutes. This reduces the test timeout to 900 seconds (15 minutes) to recover from this scenario faster.

Test timeout duration was chosen by looking at successful duration percentiles in the last 100 days:

duration_seconds_p90 | duration_seconds_p99 | duration_seconds_max
-- | -- | --
532 | 545 | 576

BigQuery SQL:

```sql
WITH
  successful_steps AS (
    SELECT
      b.id,
      TIMESTAMP_DIFF(s.end_time, s.start_time, SECOND) AS duration_seconds,
    FROM cr-buildbucket.flutter.builds AS b, UNNEST(steps) AS s
    WHERE
      create_time > TIMESTAMP_SUB(CURRENT_TIMESTAMP(), INTERVAL 100 DAY)
      AND regexp_substr(input.gitiles_commit.project, '[^\\/]+$') = 'flutter'
      AND builder.project || '/' || builder.bucket || '/' || builder.builder
        = 'flutter/prod/Windows_arm64 plugin_test_windows'
      AND name = 'run plugin_test_windows'
      AND s.status = 'SUCCESS'
  )
SELECT
  percentiles[offset(90)] AS duration_seconds_p90,
  percentiles[offset(99)] AS duration_seconds_p99,
  duration_seconds_max
FROM (
  SELECT
    APPROX_QUANTILES(duration_seconds, 100) AS percentiles,
    MAX(duration_minutes) AS duration_seconds_max
  FROM successful_steps
);
```

`test_timeout_secs` is documented here: https://github.com/flutter/cocoon/blob/main/CI_YAML.md

Part of https://github.com/flutter/flutter/issues/145072

349cbb4a

13 Mar, 2024 22 commits

Roll Flutter Engine from d65c7e41f89a to d29383cc8122 (1 revision) (#145116) · 0e126f3f

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/d65c7e41f89a...d29383cc8122

2024-03-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 18ec60df0774 to abc8988e9dac (1 revision) (flutter/engine#51388)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0e126f3f

Roll Flutter Engine from c88934422419 to d65c7e41f89a (2 revisions) (#145113) · b246f587

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/c88934422419...d65c7e41f89a

2024-03-13 john@johnmccutchan.com Small improvements to et lint command (flutter/engine#51372)
2024-03-13 jonahwilliams@google.com [Impeller] cleanup and test vk image usage flags. (flutter/engine#51301)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b246f587

Update proxied devices to handle connection interface and diagnostics. (#145061) · 3dba3f2a
Lau Ching Jun authored Mar 13, 2024
```
Also improve the performance of daemon device discovery by parallelizing the calls.
```
3dba3f2a

RenderViewport max layout cycles should depend on number of slivers (#144104) · 19087442

Matej Knopp authored Mar 13, 2024

Fixes https://github.com/flutter/flutter/issues/144102

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

19087442

Roll Flutter Engine from 9551b49b3fa1 to c88934422419 (2 revisions) (#145108) · fd73a9a0

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/9551b49b3fa1...c88934422419

2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from 1ad0d0fabe7a to a315e4572f4e (7 revisions) (flutter/engine#51377)
2024-03-13 matej.knopp@gmail.com Reland "Reland: [macOS] Use CVDisplayLink to drive repaint" (flutter/engine#51210)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd73a9a0

Mark Mac_arm64_ios module_test_ios not flaky (#145044) · 6f175f1f

Jenn Magder authored Mar 13, 2024

Revert https://github.com/flutter/flutter/pull/144861

https://github.com/flutter/flutter/issues/144860 was resolved by https://github.com/openid/AppAuth-iOS/pull/825

I'm just going to mark this as unflaky instead of waiting for the bot.

6f175f1f

Revert "Add `FocusNode.focusabilityListenable` (#144280)" since the feature is... · 4f786841

LongCatIsLooong authored Mar 13, 2024

Revert "Add `FocusNode.focusabilityListenable` (#144280)" since the feature is no longer needed (#145102)

This reverts commit 726e5d28.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

4f786841

Fix TextField helper top padding on M3 (#145087) · 33fbb75a

Bruno Leroux authored Mar 13, 2024

## Description

`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.

This PR sets the correct values for M3 without changing the value for M2.

| Before | After | M3 Spec |
|--------|--------|--------|
| ![image](https://github.com/flutter/flutter/assets/840911/9947f334-d98f-4f7e-9da7-ca6d5c0770ac) | ![image](https://github.com/flutter/flutter/assets/840911/081dec4b-eb9f-4eee-a7dc-2538e7110ff0)| ![image](https://github.com/flutter/flutter/assets/840911/c8c8f045-3b79-43a5-a1a3-cc6d5460644f) |

If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144984

## Tests

Updates a value used by several existing tests.

33fbb75a

Roll Flutter Engine from 6ceccf894c41 to 9551b49b3fa1 (9 revisions) (#145106) · 247580c7

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/6ceccf894c41...9551b49b3fa1

2024-03-13 jonahwilliams@google.com [Impeller] fix heap selection process for YUV textures. (flutter/engine#51262)
2024-03-13 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Enable sound null safety everywhere (flutter/engine#51355)
2024-03-13 30870216+gaaclarke@users.noreply.github.com [Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer (flutter/engine#51368)
2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from dc7443fa4d88 to 1ad0d0fabe7a (1 revision) (flutter/engine#51373)
2024-03-13 tugorez@users.noreply.github.com Implement PlatformDispatcher.requestViewFocusChange on web. (flutter/engine#50535)
2024-03-13 jonahwilliams@google.com [Impeller] attempt to get validation errors from CI unittests. (flutter/engine#51341)
2024-03-13 skia-flutter-autoroll@skia.org Roll Dart SDK from b19e0995f317 to 18ec60df0774 (1 revision) (flutter/engine#51374)
2024-03-13 jonahwilliams@google.com [scenario app] make image matching fuzzier. (flutter/engine#51376)
2024-03-13 skia-flutter-autoroll@skia.org Roll Skia from bbe453e3525d to dc7443fa4d88 (1 revision) (flutter/engine#51371)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

247580c7

Fix Cupertino Context Menu Container to Remove White Corners (#144883) · f91614a4
Dhikshith authored Mar 13, 2024
```
Fixes a visual glitch when CupertinoContextMenu is on a non-white background.
```
f91614a4

Roll Packages from d1aeb26e1b43 to 38711aca66fa (1 revision) (#145099) · 12284931

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/packages/compare/d1aeb26e1b43...38711aca66fa

2024-03-12 engine-flutter-autoroll@skia.org Roll Flutter from 1ca88730 to 61812ca3 (1 revision) (flutter/packages#6305)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12284931

[Impeller] remove unstable debug checked banner for zoom test. (#145097) · e4c79841
Jonah Williams authored Mar 13, 2024
```
These tests have been flaky for impeller since it has rotated text.
```
e4c79841

Turning `if` chains into shorter `switch` statements (#144977) · b9e53733

Nate authored Mar 13, 2024

This pull request is part of the effort to solve issue #144903.

In the past, my efforts to reduce line length involved refactoring away from switch statements, but unlike [yesterday's PR](https://github.com/flutter/flutter/pull/144905), this one is full of switch statements that make things more concise!

b9e53733

Roll Flutter Engine from 2871c2601135 to 6ceccf894c41 (2 revisions) (#145094) · 017f33df

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/2871c2601135...6ceccf894c41

2024-03-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UR-nKoLidl7cVLrrN... to mYZPzdM3hCE1TA91s... (flutter/engine#51370)
2024-03-13 flar@google.com Add a comparative benchmark for SkM44 vs SkMatrix vs impeller::Matrix (flutter/engine#51332)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UR-nKoLidl7c to mYZPzdM3hCE1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

017f33df

Set cacheExtent for SliverFillRemaining widget (#143612) · 825e901e

Victoria Ashworth authored Mar 13, 2024

When a Sliver with items is outside of the Viewport, but within the Viewport's `cacheExtent`, the framework should create SemanticNodes for the items even though they are out of view. However, for this to work, the Sliver's geometry must have a `cacheExtent` (how much space the sliver took up of the Viewport's `cacheExtent`) greater than 0, otherwise it is [excluded](https://github.com/flutter/flutter/blob/f01ce9f4cb41beff7b85122b5fcf1228bb655a87/packages/flutter/lib/src/rendering/viewport.dart#L311-L315).

`SliverFillRemaining` widgets that fall outside the viewport did not have this set and therefore were being excluded when SemanticNodes were created, even if they were within the Viewport's `cacheExtent`. This PR sets the `cacheExtent` for `SliverFillRemaining` widgets.

In addition, `RenderSliverFillRemainingWithScrollable` would get dropped from the semantic tree because it's child had a size of 0 when outside the remaining paint extent. To fix, we give the child a `maxExtent` of the sliver's `cacheExtent` if it's outside the remaining paint extent but within the viewport's cacheExtent.

Fixes https://github.com/flutter/flutter/issues/142065.

Definitions:
* `RenderViewport.cacheExtent`:
```dart
/// The viewport has an area before and after the visible area to cache items
/// that are about to become visible when the user scrolls.
///
/// Items that fall in this cache area are laid out even though they are not
/// (yet) visible on screen. The [cacheExtent] describes how many pixels
/// the cache area extends before the leading edge and after the trailing edge
/// of the viewport.
///
/// The total extent, which the viewport will try to cover with children, is
/// [cacheExtent] before the leading edge + extent of the main axis +
/// [cacheExtent] after the trailing edge.
///
/// The cache area is also used to implement implicit accessibility scrolling
/// on iOS: When the accessibility focus moves from an item in the visible
/// viewport to an invisible item in the cache area, the framework will bring
/// that item into view with an (implicit) scroll action.
```
* `SliverGeometry.cacheExtent`:
```dart
/// How many pixels the sliver has consumed in the
/// [SliverConstraints.remainingCacheExtent].
```
* `SliverContraints.remainingCacheExtent`:
```dart
/// Describes how much content the sliver should provide starting from the
/// [cacheOrigin].
///
/// Not all content in the [remainingCacheExtent] will be visible as some
/// of it might fall into the cache area of the viewport.
///
/// Each sliver should start laying out content at the [cacheOrigin] and
/// try to provide as much content as the [remainingCacheExtent] allows.
```

825e901e

Remove `showTrackOnHover` from `Scrollbar` and `ScrollbarTheme` (#144180) · 1ccad1a2

Qun Cheng authored Mar 13, 2024

This PR is to remove deprecated `Scrollbar.showTrackOnHover` and `ScrollbarThemeData.showTrackOnHover`.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/111706.
Part of https://github.com/flutter/flutter/issues/143956

1ccad1a2

Roll Flutter Engine from 285b9fb287a3 to 2871c2601135 (2 revisions) (#145067) · 59da4dea

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/285b9fb287a3...2871c2601135

2024-03-13 john@johnmccutchan.com Add et lint command (flutter/engine#51238)
2024-03-13 matanlurey@users.noreply.github.com Refactor `golden_tests_harvester`, throw when not `--dry-run`, add tests. (flutter/engine#51364)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

59da4dea

InputDecorator M3 tests migration - Step5 - Helper/Counter/Error (#144932) · 34b454f4

Bruno Leroux authored Mar 13, 2024

## Description

This PR migrates `InputDecorator` helper/counter/error related tests to M3 and adds some missing tests.

It is the fifth step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520
Step 4: https://github.com/flutter/flutter/pull/144169

## Related Issue

Related to https://github.com/flutter/flutter/issues/139076
fixes https://github.com/flutter/flutter/issues/138213

34b454f4

[New feature]Introduce iOS multi-touch drag behavior (#141355) · c83237f3

xubaolin authored Mar 13, 2024

Fixes #38926

This patch implements the iOS behavior pointed out by @dkwingsmt at #38926 , which is also consistent with the performance of my settings application on the iPhone.

### iOS behavior (horizontal or vertical drag)

## Algorithm
When dragging: delta(combined) = max(i of n that are positive) delta(i) - max(i of n that are negative) delta(i)
It means that, if two fingers are moving +50 and +10 respectively, it will move +50; if they're moving at +50 and -10 respectively, it will move +40.

~~TODO~~
~~Write some test cases~~

c83237f3

Roll Flutter Engine from ea848c3b2443 to 285b9fb287a3 (3 revisions) (#145062) · 1da48594

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/ea848c3b2443...285b9fb287a3

2024-03-13 bdero@google.com Copy the flutter_gpu package into the engine artifacts. (flutter/engine#51365)
2024-03-13 chinmaygarde@google.com [Impeller] Make masks type safe. (flutter/engine#51369)
2024-03-12 bdero@google.com Remove early Flutter GPU prototype from ui/experiments. (flutter/engine#51367)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1da48594

Reland "Add a microbenchmark for text intrinsic height layout (#145007)" (#145037) · 8270872f

LongCatIsLooong authored Mar 13, 2024

Add the missing `Directionality` widget and `await test.pump()` call: commit: https://github.com/flutter/flutter/commit/0fd7712fa72449d35b73d108884b5aeb97b3298a

Without the `pump` 1s, it sometimes schedules multiple `handleBeginFrame`s and `handleDrawFrame`s.

8270872f

Roll Flutter Engine from e25e977a0222 to ea848c3b2443 (6 revisions) (#145042) · 2fde3ac3

engine-flutter-autoroll authored Mar 13, 2024

https://github.com/flutter/engine/compare/e25e977a0222...ea848c3b2443

2024-03-12 jason-simmons@users.noreply.github.com Fix some races in the platform isolate tests (flutter/engine#51358)
2024-03-12 skia-flutter-autoroll@skia.org Roll Skia from 187488b64570 to bbe453e3525d (1 revision) (flutter/engine#51366)
2024-03-12 pavel.mazhnik@gmail.com [web] make addView/removeView functions sync (flutter/engine#51103)
2024-03-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f26f32f374f to b19e0995f317 (1 revision) (flutter/engine#51363)
2024-03-12 737941+loic-sharma@users.noreply.github.com [dart:ui] Add view ID to `PointerData.toString` (flutter/engine#51352)
2024-03-12 flar@google.com Fix null filter NOP case in DlLocalMatrixImageFilter (flutter/engine#51340)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2fde3ac3

12 Mar, 2024 3 commits

Roll Flutter Engine from f1db33f48070 to e25e977a0222 (2 revisions) (#145035) · 4dc2ea3e

engine-flutter-autoroll authored Mar 12, 2024

https://github.com/flutter/engine/compare/f1db33f48070...e25e977a0222

2024-03-12 skia-flutter-autoroll@skia.org Roll Skia from 47baa55b4669 to 187488b64570 (1 revision) (flutter/engine#51362)
2024-03-12 chinmaygarde@google.com [Impeller] Add utility for type safe masks. (flutter/engine#51361)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4dc2ea3e

Flutter Web Bootstrapping Improvements (#144434) · 3c30e3cb

Jackson Gardner authored Mar 12, 2024

This makes several changes to flutter web app bootstrapping.
* The build now produces a `flutter_bootstrap.js` file.
  * By default, this file does the basic streamlined startup of a flutter app with the service worker settings and no user configuration.
  * The user can also put a `flutter_bootstrap.js` file in the `web` subdirectory in the project directory which can have whatever custom bootstrapping logic they'd like to write instead. This file is also templated, and can use any of the tokens  that can be used with the `index.html` (with the exception of `{{flutter_bootstrap_js}}`, see below).
* Introduced a few new templating tokens for `index.html`:
  * `{{flutter_js}}` => inlines the entirety of `flutter.js`
  * `{{flutter_service_worker_version}}` => replaced directly by the service worker version. This can be used instead of the script that sets the `serviceWorkerVersion` local variable that we used to have by default.
  * `{{flutter_bootstrap_js}}` => inlines the entirety of `flutter_bootstrap.js` (this token obviously doesn't apply to `flutter_bootstrap.js` itself).
* Changed `IndexHtml` to be called `WebTemplate` instead, since it is used for more than just the index.html now.
* We now emit warnings at build time for certain deprecated flows:
  * Warn on the old service worker version pattern (i.e.`(const|var) serviceWorkerVersion = null`) and recommends using `{{flutter_service_worker_version}}` token instead
  * Warn on use of `FlutterLoader.loadEntrypoint` and recommend using `FlutterLoader.load` instead
  * Warn on manual loading of `flutter_service_worker.js`.
* The default `index.html` on `flutter create` now uses an async script tag with `flutter_bootstrap.js`.

3c30e3cb

Bump actions/checkout from 4.1.1 to 4.1.2 (#145032) · 5b006bf5

dependabot[bot] authored Mar 12, 2024

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.2</h2>
<p>We are investigating the following issue with this release and have rolled-back the <code>v4</code> tag to point to <code>v4.1.1</code></p>
<ul>
<li><code>sparse-checkout</code> is not available on git versions prior to 2.27.0 (see <a href="https://redirect.github.com/actions/checkout/issues/1651">actions/checkout#1651</a>)</li>
</ul>
<h2>What's Changed</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho"><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598">actions/checkout#1598</a></li>
<li>Bump tough-cookie from 4.0.0 to 4.1.3 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1406">actions/checkout#1406</a></li>
<li>Bump <code>@âbabel/traverse</code> from 7.20.5 to 7.24.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1642">actions/checkout#1642</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/jww3"><code>@âjww3</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1616">actions/checkout#1616</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.1...v4.1.2">https://github.com/actions/checkout/compare/v4.1.1...v4.1.2</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho"><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@âpeterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth &gt; 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@âactions/io</code> to 1.1.2</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/9bb56186c3b09b4f86b1c65136769dd318469633"><code>9bb5618</code></a> Prep for release of  v4.1.2  (<a href="https://redirect.github.com/actions/checkout/issues/1649">#1649</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8eb1f6a495037164bea451156472f35fdd6bafc0"><code>8eb1f6a</code></a> Bump <code>@âbabel/traverse</code> from 7.20.5 to 7.24.0 (<a href="https://redirect.github.com/actions/checkout/issues/1642">#1642</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/556e4c3cb0b8b54b734286d5439adadcb0a8cb92"><code>556e4c3</code></a> Bump tough-cookie from 4.0.0 to 4.1.3 (<a href="https://redirect.github.com/actions/checkout/issues/1406">#1406</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/b32f140b0c872d58512e0a66172253c302617b90"><code>b32f140</code></a> Warn on attempts to publish <code>test-ubuntu-git</code> from non-main branch. (<a href="https://redirect.github.com/actions/checkout/issues/1623">#1623</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/2650dbd060003e3b5ae211e4358852f336b682a7"><code>2650dbd</code></a> Give <code>test-ubuntu-git</code> its own <code>README</code> (<a href="https://redirect.github.com/actions/checkout/issues/1620">#1620</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/aadec899646c8e0f34c52d9219c2faac36626b55"><code>aadec89</code></a> Explicitly disable sparse checkout unless asked for (<a href="https://redirect.github.com/actions/checkout/issues/1598">#1598</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/df0bcddf6d6823307c716b56a7ef9c3b25078874"><code>df0bcdd</code></a> Refine workflow for generating <code>test-ubuntu-git</code> (<a href="https://redirect.github.com/actions/checkout/issues/1617">#1617</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/473055ba18d6d2da209cd46110aadb9275e3194e"><code>473055b</code></a> Create <code>test-ubuntu-git</code> Docker Container for Proxy Tests (<a href="https://redirect.github.com/actions/checkout/issues/1616">#1616</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/b4ffde65f46336ab88eb53be808477a3936bae11...9bb56186c3b09b4f86b1c65136769dd318469633">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.1&new-version=4.1.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

5b006bf5