1. 23 May, 2019 1 commit
  2. 21 May, 2019 1 commit
    • Todd Volkert's avatar
      Add some sanity to the ImageStream listener API (#32936) · 592f81e7
      Todd Volkert authored
      The current API was broken in that you registered multiple
      callbacks at once, but when you removed listeners, only the
      primary listener was used to determine what was removed.
      This led to unintuitive cases where the caller could get
      unexpected behavior.
      
      This updates the API to add and remove listeners using
      a newly introduced [ImageStreamListener] object, a value
      object that has references to the individual callbacks
      that may fire.
      
      flutter/flutter#24722
      flutter/flutter#32374
      flutter/flutter#32935
      592f81e7
  3. 07 Jan, 2019 1 commit
  4. 03 Jan, 2019 1 commit
    • Jonah Williams's avatar
      Ensure all errors thrown by image providers can be caught by developers. (#25980) · d84879d9
      Jonah Williams authored
      * Ensure all errors thrown by image providers can be caught by developers.
      
      Add an `onError` parameter to the ImageCache.putIfAbsent method.
      In the event that an error is thrown when resolving an image, catch if
      this parameter is provided. Use the onError parameter to ensure that all
      errors thrown are forwarded to the ImageStream error channel instead of
      directly into the void.
      d84879d9
  5. 18 Dec, 2018 1 commit
  6. 12 Sep, 2018 1 commit
  7. 27 Jul, 2018 1 commit
  8. 14 Jul, 2018 1 commit
  9. 10 Jul, 2018 1 commit
  10. 12 Jun, 2018 1 commit
  11. 07 Dec, 2017 1 commit
    • Ian Hickson's avatar
      Move image logic from services/ to painting/. (#13409) · 44e228eb
      Ian Hickson authored
      This allows the scheduler library to depend on the services library
      and the painting library to depend on the scheduler library without
      the services library having to depend on the scheduler library.
      
      While I was at it I also cleaned up some of the binding logic: the
      licenses logic can now be overridden (and the test library does so),
      and the image cache can now be overridden as well.
      44e228eb
  12. 18 Aug, 2017 1 commit
  13. 06 May, 2017 1 commit
  14. 05 May, 2017 1 commit
  15. 08 Mar, 2017 1 commit
  16. 09 Aug, 2016 1 commit
  17. 16 Jun, 2016 1 commit
    • Ian Hickson's avatar
      Refactor everything to do with images (#4583) · 2dfdc840
      Ian Hickson authored
      Overview
      ========
      
      This patch refactors images to achieve the following goals:
      
      * it allows references to unresolved assets to be passed
        around (previously, almost every layer of the system had to know about
        whether an image came from an asset bundle or the network or
        elsewhere, and had to manually interact with the image cache).
      
      * it allows decorations to use the same API for declaring images as the
        widget tree.
      
      It requires some minor changes to call sites that use images, as
      discussed below.
      
      Widgets
      -------
      
      Change this:
      
      ```dart
            child: new AssetImage(
              name: 'my_asset.png',
              ...
            )
      ```
      
      ...to this:
      
      ```dart
            child: new Image(
              image: new AssetImage('my_asset.png'),
              ...
            )
      ```
      
      Decorations
      -----------
      
      Change this:
      
      ```dart
            child: new DecoratedBox(
              decoration: new BoxDecoration(
                backgroundImage: new BackgroundImage(
                  image: DefaultAssetBundle.of(context).loadImage('my_asset.png'),
                  ...
                ),
                ...
              ),
              child: ...
            )
      ```
      
      ...to this:
      
      ```dart
            child: new DecoratedBox(
              decoration: new BoxDecoration(
                backgroundImage: new BackgroundImage(
                  image: new AssetImage('my_asset.png'),
                  ...
                ),
                ...
              ),
              child: ...
            )
      ```
      
      DETAILED CHANGE LOG
      ===================
      
      The following APIs have been replaced in this patch:
      
      * The `AssetImage` and `NetworkImage` widgets have been split in two,
        with identically-named `ImageProvider` subclasses providing the
        image-loading logic, and a single `Image` widget providing all the
        widget tree logic.
      
      * `ImageResource` is now `ImageStream`. Rather than configuring it with
        a `Future<ImageInfo>`, you complete it with an `ImageStreamCompleter`.
      
      * `ImageCache.load` and `ImageCache.loadProvider` are replaced by
        `ImageCache.putIfAbsent`.
      
      The following APIs have changed in this patch:
      
      * `ImageCache` works in terms of arbitrary keys and caches
        `ImageStreamCompleter` objects using those keys. With the new model,
        you should never need to interact with the cache directly.
      
      * `Decoration` can now be `const`. The state has moved to the
        `BoxPainter` class. Instead of a list of listeners, there's now just a
        single callback and a `dispose()` method on the painter. The callback
        is passed in to the `createBoxPainter()` method. When invoked, you
        should repaint the painter.
      
      The following new APIs are introduced:
      
      * `AssetBundle.loadStructuredData`.
      
      * `SynchronousFuture`, a variant of `Future` that calls the `then`
        callback synchronously. This enables the asynchronous and
        synchronous (in-the-cache) code paths to look identical yet for the
        latter to avoid returning to the event loop mid-paint.
      
      * `ExactAssetImage`, a variant of `AssetImage` that doesn't do anything clever.
      
      * `ImageConfiguration`, a class that describes parameters that configure
        the `AssetImage` resolver.
      
      The following APIs are entirely removed by this patch:
      
      * `AssetBundle.loadImage` is gone. Use an `AssetImage` instead.
      
      * `AssetVendor` is gone. `AssetImage` handles everything `AssetVendor`
        used to handle.
      
      * `RawImageResource` and `AsyncImage` are gone.
      
      The following code-level changes are performed:
      
      * `Image`, which replaces `AsyncImage`, `NetworkImage`, `AssetImage`,
        and `RawResourceImage`, lives in `image.dart`.
      
      * `DecoratedBox` and `Container` live in their own file now,
        `container.dart` (they reference `image.dart`).
      
      DIRECTIONS FOR FUTURE RESEARCH
      ==============================
      
      * The `ImageConfiguration` fields are mostly aspirational. Right now
        only `devicePixelRatio` and `bundle` are implemented. `locale` isn't
        even plumbed through, it will require work on the localisation logic.
      
      * We should go through and make `BoxDecoration`, `AssetImage`, and
        `NetworkImage` objects `const` where possible.
      
      * This patch makes supporting animated GIFs much easier.
      
      * This patch makes it possible to create an abstract concept of an
        "Icon" that could be either an image or a font-based glyph (using
        `IconData` or similar). (see
        https://github.com/flutter/flutter/issues/4494)
      
      RELATED ISSUES
      ==============
      
      Fixes https://github.com/flutter/flutter/issues/4500
      Fixes https://github.com/flutter/flutter/issues/4495
      Obsoletes https://github.com/flutter/flutter/issues/4496
      2dfdc840
  18. 03 Jun, 2016 1 commit
  19. 25 May, 2016 1 commit
  20. 24 May, 2016 1 commit
  21. 12 May, 2016 1 commit
  22. 27 Apr, 2016 1 commit
  23. 25 Mar, 2016 1 commit
    • Ian Hickson's avatar
      Clean up prints in services/* · da48e2a3
      Ian Hickson authored
      We really shouldn't have two separate network library wrappers... I filed https://github.com/flutter/flutter/issues/2889 on that. But for now, this makes one of them have a generally better error handling story, and makes the other one only dump to the console in debug mode. It also makes both use debugPrint instead of print, and makes one use the 'mojom' prefix for mojom imports.
      da48e2a3
  24. 23 Mar, 2016 2 commits
  25. 14 Mar, 2016 1 commit
  26. 12 Mar, 2016 3 commits
  27. 11 Mar, 2016 1 commit
    • Ian Hickson's avatar
      Enable ALL THE LINTS · 1b9cd520
      Ian Hickson authored
      Well, all the easy ones, anyway.
      
      For some reason `// ignore:` isn't working for me so I've disabled
      lints that need that. Also disabled those that require a ton of work
      (which I'm doing, but not in this PR, to keep it reviewable).
      
      This adds:
      - avoid_init_to_null
      - library_names
      - package_api_docs
      - package_names
      - package_prefixed_library_names
      - prefer_is_not_empty
      - sort_constructors_first
      - sort_unnamed_constructors_first
      - unnecessary_getters_setters
      1b9cd520
  28. 12 Feb, 2016 1 commit
    • Adam Barth's avatar
      ImageCache should be a public type · 45c40690
      Adam Barth authored
      We expose `imageCache`, which is an ImageCache, but previously the class
      was private which means there was no documentation for the methods on
      that object.
      
      Fixes #1750
      45c40690
  29. 02 Feb, 2016 1 commit
  30. 01 Feb, 2016 1 commit
  31. 07 Jan, 2016 1 commit
  32. 19 Nov, 2015 1 commit
  33. 12 Oct, 2015 1 commit
    • Hixie's avatar
      Lots of trivial warning fixes · f2cc43a4
      Hixie authored
      Add type annotations in many places.
      Fix some identifiers to have more lint-satisfying names.
      Make all operator==s consistent in style.
      Reorder some functions for consistency.
      Make ParentData no longer dynamic, and fix all the code around that.
      f2cc43a4
  34. 10 Oct, 2015 2 commits
  35. 09 Oct, 2015 1 commit
    • Hixie's avatar
      Relative paths in internal flutter libraries · 37bda251
      Hixie authored
      Now that you import a top-level file for each layer of the Flutter
      framework, within the framework we can use relative paths without being
      worried about the copy/pasta problem we used to have.
      37bda251
  36. 06 Oct, 2015 1 commit
    • Adam Barth's avatar
      NetworkImage occasionally does not grab the image · 8b1effc5
      Adam Barth authored
      I haven't been able to reproduce this bug consistently, but my theory is that
      the ImageDecoder was being garbage collected before it called its completion
      callback. This patch prevents that by keeping a reference to the image decoder
      while the callback is in flight.
      
      Fixes #801
      8b1effc5