1. 12 Nov, 2018 1 commit
  2. 05 Nov, 2018 1 commit
  3. 23 Oct, 2018 1 commit
  4. 19 Oct, 2018 1 commit
  5. 18 Oct, 2018 1 commit
  6. 17 Oct, 2018 1 commit
  7. 16 Oct, 2018 1 commit
  8. 13 Oct, 2018 1 commit
    • Michael Goderbauer's avatar
      Remove all service extensions from release mode (#23038) · 8e2ca93f
      Michael Goderbauer authored
      Service extensions can only be activated in debug or profile mode, their code should never be included in release mode. This PR adds guards around all service extension registration calls that enable Dart's tree shaker to remove the extension's code in release mode, which reduces our binary size:
      
      Android Snapshot (uncompressed): minus 127,384 Bytes (-124.40KB)
      APK (compressed): minus 38,136 Bytes (-37.24KB)
      iOS Snapshot (App.framework, uncompressed): 264,304 Bytes(-258.10KB)
      
      For details: https://docs.google.com/document/d/13JlgvliCn5sWwT2K2SfDwD1NhEfxpJH9DCf22gZZru8/edit
      
      **Benchmark Regressions:** This PR may cause benchmarks to regress because it may change the timing of GC. If you notice a benchmark regression **please note down the exact set of benchmarks that regressed on this PR** and then feel free to revert. I will follow-up with a PR that forces a GC before the effected benchmarks run to get a clean baseline before re-applying this PR.
      8e2ca93f
  9. 05 Oct, 2018 2 commits
  10. 01 Oct, 2018 1 commit
  11. 14 Sep, 2018 1 commit
  12. 12 Sep, 2018 1 commit
  13. 07 Sep, 2018 1 commit
  14. 29 Aug, 2018 1 commit
  15. 23 Aug, 2018 1 commit
  16. 02 Aug, 2018 1 commit
  17. 27 Jul, 2018 1 commit
  18. 23 Jul, 2018 1 commit
  19. 16 Jul, 2018 2 commits
  20. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  21. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  22. 05 Jun, 2018 1 commit
  23. 30 May, 2018 2 commits
  24. 06 Apr, 2018 1 commit
  25. 12 Mar, 2018 1 commit
  26. 20 Jan, 2018 1 commit
    • Ian Hickson's avatar
      [H] Move the splitting of licenses to an isolate (#14160) · a29d723c
      Ian Hickson authored
      * Move the splitting of licenses to an isolate
      
      This improves (from horrific to terrible) the performance of the
      license screen. It also introduces a feature in the foundation layer
      to make using isolates for one-off computations easier.
      
      The real problem that remains with this, though, is that transfering
      data between isolates is a stop-the-world operation and can take an
      absurd amount of time (far more than a few milliseconds), so we still
      skip frames.
      
      More work thus remains to be done.
      
      * - Add profile instrumentation to the isolate compute() method
      - Add profile instrumentation to the LicensePage
      - Add profile instrumentation to the scheduleTask method
      - Make scheduleTask support returning a value
      - Make the license page builder logic use scheduled tasks so that it doesn't blow the frame budget
      a29d723c
  27. 19 Jan, 2018 1 commit
  28. 09 Jan, 2018 2 commits
  29. 14 Dec, 2017 1 commit
  30. 09 Dec, 2017 1 commit
  31. 17 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Fix spelling errors in all the dartdocs. (#13061) · 0259be90
      Greg Spencer authored
      I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.
      
      This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
      0259be90
  32. 21 Sep, 2017 1 commit
  33. 14 Sep, 2017 1 commit
  34. 31 Aug, 2017 1 commit
    • Devon Carew's avatar
      More frame events (#11747) · 8c36ccf5
      Devon Carew authored
      * Revert "Revert "fire service protocol events for frames (#11565)" (#11727)"
      
      This reverts commit f25e2f52.
      
      * move the postEvent() call into a separate method
      8c36ccf5
  35. 22 Aug, 2017 2 commits