1. 12 Sep, 2018 1 commit
  2. 30 Aug, 2018 1 commit
  3. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  4. 24 May, 2018 1 commit
  5. 19 Mar, 2018 1 commit
  6. 12 Mar, 2018 1 commit
  7. 12 Jan, 2018 1 commit
    • Chris Bracken's avatar
      Decode syslog-encoded iOS logs (#14075) · 6a42ed3f
      Chris Bracken authored
      Apple encodes syslog entries using a 7-bit encoding where input UTF-8 bytes
      are encoded as follows:
      1. 0x00 to 0x19: non-printing range. Some ignored, some encoded as <...>.
      2. 0x20 to 0x7f: as-is, with the exception of 0x5c (backslash).
      3. 0x5c (backslash): octal representation \134.
      4. 0x80 to 0x9f: \M^x (using control-character notation for range 0x00 to 0x40).
      5. 0xa0: octal representation \240.
      6. 0xa1 to 0xf7: \M-x (where x is the input byte stripped of its high-order bit).
      7. 0xf8 to 0xff: unused in 4-byte UTF-8.
      
      As there doesn't appear to be a system tool to decode these strings, we
      implement here in Dart. If we're unable to decode a string (e.g.
      decoding results in an invalid UTF-8 string), we fall back to emitting
      the log line as-is.
      6a42ed3f
  8. 19 Dec, 2017 1 commit
    • Alan Russian's avatar
      Change async stubbing to use thenAnswer. (#13521) · 30720bd1
      Alan Russian authored
      * Change async stubbing to use thenAnswer.
      
      Mockito now prohibits calling thenReturn with Futures and Streams. dart-lang/mockito#79
      
      * Update all Mockito deps to 3.0.0.
      
      * Revert "Update all Mockito deps to 3.0.0."
      
      This reverts commit e8ab9d37c33d3d7fe384abde64ea5b4d72623c75.
      
      I did not correctly update the mockito dep, and there's no easy way to update to 3.0 alpha right now.
      
      * Change thenAnswer((_) => to thenAnswer((invocation) =>
      
      * Add Invocation type to thenAnswer lambdas
      30720bd1
  9. 07 Sep, 2017 2 commits
    • Chris Bracken's avatar
      Eliminate iOS log blacklist (#11981) · 8c61116c
      Chris Bracken authored
      This was introduced to suppress libMobileGestalt noise originating from
      libsystem_asl.dylib. Commit 39680ebf
      suppresses all application log messages not originating from the
      app/engine iteself on iOS 10 and above. Since the log message in
      question is only emitted on devices running iOS >= 10.3.0, this
      blacklist no longer necessary.
      8c61116c
    • Chris Bracken's avatar
      Suppress non-Flutter log messages in terminal (#11969) · 39680ebf
      Chris Bracken authored
      On iOS 10 and above, suppress engine log messages from system components
      other than Flutter. This eliminates a large amount of keyboard/plugin
      related noise during edit-refresh development.
      39680ebf
  10. 01 Sep, 2017 1 commit
    • Chris Bracken's avatar
      Use idevice_id, ideviceinfo for iOS device listing (#11883) · eba6ceb8
      Chris Bracken authored
      This patch migrates iOS device listing from using Xcode instruments to
      using the libimobiledevice tools idevice_id and ideviceinfo.
      
      ideviceinfo was previously incompatible with iOS 11 physical devices;
      this has now been fixed.
      
      In 37bb5f13 flutter_tools migrated from
      libimobiledevice-based device listing on iOS to using Xcode instruments
      to work around the lack of support for iOS 11. Using instruments entails
      several downsides, including a significantly higher performance hit, and
      leaking hung DTServiceHub processes in certain cases when a simulator is
      running, necessitating workarounds in which we watched for, and cleaned
      up leaked DTServiceHub processes. This patch returns reverts the move to
      instruments now that it's no longer necessary.
      eba6ceb8
  11. 31 Aug, 2017 1 commit
  12. 23 Aug, 2017 1 commit
    • Chris Bracken's avatar
      Suppress libmobilegestalt noise from iOS device logging (#11745) · dc5d2937
      Chris Bracken authored
      This patch supports basic filtering of log lines from physical iOS
      devices, similar to existing functionality for iOS simulator logging.
      
      This patch also suppresses the following two log messages which are
      emitted at app startup on iOS 10.3 devices:
        libMobileGestalt MobileGestaltSupport.m:153: pid 123 (Runner) does not have sandbox access for frZQaeyWLUvLjeuEK43hmg and IS NOT appropriately entitled
        libMobileGestalt MobileGestalt.c:550: no access to InverseDeviceID (see <rdar://problem/11744455>)
      dc5d2937
  13. 19 Jun, 2017 1 commit
    • Chris Bracken's avatar
      Re-enable use of instruments for iOS device lookup (#10838) · 1d9f0095
      Chris Bracken authored
      This reverts commit b2909a24.
      
      This resubmits the following patches:
      
      1. Use Xcode instruments to list devices (#10801)
      Eliminates the dependency on idevice_id from libimobiledevice. Instead,
      uses Xcode built-in functionality.
      
      2. Make device discovery asynchronous (#10803)
      Migrates DeviceDiscovery.devices and all device-specific lookup to be
      asynchronous.
      1d9f0095
  14. 17 Jun, 2017 2 commits
    • Chris Bracken's avatar
      Revert use of Xcode instruments for device lookup (#10806) · b2909a24
      Chris Bracken authored
      * Revert "Make device discovery asynchronous (#10803)"
      This reverts commit 972be9c8.
      
      * Revert "Use Xcode instruments to list devices (#10801)"
      This reverts commit 37bb5f13.
      
      This is to resolve a failure that looks related to a bad install of Xcode 8.0
      on our build bots and should be reinstated when the infra issue is diagnosed
      and resolved.
      
      Instruments worked well when this was originally landed, and on the
      following commit, but started failing two commits after this originally
      landed. Manual invocation of instruments on the build host currently
      results in:
      
      ```
      dyld: Library not loaded: @rpath/InstrumentsAnalysisCore.framework/Versions/A/InstrumentsAnalysisCore
        Referenced from: /Applications/Xcode8.0.app/Contents/Developer/usr/bin/instruments
        Reason: image not found
      Abort trap: 6
      ```
      
      It appears the /Applications/Xcode8.0.app/Contents/Applications
      directory (which contains Instruments) is missing on the host.
      b2909a24
    • Chris Bracken's avatar
      Make device discovery asynchronous (#10803) · 972be9c8
      Chris Bracken authored
      Migrates DeviceDiscovery.devices and all device-specific lookup to be
      asynchronous.
      972be9c8
  15. 16 Jun, 2017 3 commits
  16. 15 Jun, 2017 1 commit
  17. 12 May, 2017 1 commit
  18. 26 Apr, 2017 1 commit
    • Todd Volkert's avatar
      Switch many `Device` methods to be async (#9587) · 60c5ffc1
      Todd Volkert authored
      `adb` can sometimes hang, which will in turn hang the Dart isolate if
      we're using `Process.runSync()`. This changes many of the `Device` methods
      to return `Future<T>` in order to allow them to use the async process
      methods. A future change will add timeouts to the associated calls so
      that we can properly alert the user to the hung `adb` process.
      
      This is work towards #7102, #9567
      60c5ffc1
  19. 10 Mar, 2017 2 commits
  20. 28 Feb, 2017 1 commit
  21. 17 Feb, 2017 1 commit