- 07 Feb, 2023 1 commit
-
-
Qun Cheng authored
* Update to v0.158 of the token database. * Update checkbox template * Fix DatePickerTheme test --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 31 Jan, 2023 1 commit
-
-
Tanay Neotia authored
* Add support for image insertion on Android * Fix checks * Use proper Dart syntax on snippet * Specify type annotation on list * Fix nits, add some asserts, and improve example code * Add missing import * Fix nullsafety error * Fix nullsafety error * Remove reference to contentCommitMimeTypes in docs * Fix nits * Fix warnings and import * Add test for content commit in editable_text_test.dart * Check that URIs are equal in test * Fix nits and rename functions / classes to be more self-explanatory * Fix failing debugFillProperties tests * Add empty implementation to `insertContent` in TextInputClient * Tweak documentation slightly * Improve docs for contentInsertionMimeTypes and fix assert * Rework contentInsertionMimeType asserts * Add test for onContentInserted example * Switch implementation to a configuration class for more granularity in setting mime types * Fix nits * Improve docs and fix doc tests * Fix more nits (LongCatIsLooong) * Fix failing tests * Make parameters (guaranteed by platform to be non-nullable) non-nullable * Fix analysis issues
-
- 27 Jan, 2023 1 commit
-
-
Qun Cheng authored
* Add canRequestFocus to TextField and requestFocusOnTap to DropdownMenu * Address comments * Address comments --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 17 Jan, 2023 1 commit
-
-
Darren Austin authored
-
- 04 Jan, 2023 1 commit
-
-
Renzo Olivares authored
* Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa0117. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by:
Renzo Olivares <roliv@google.com>
-
- 03 Jan, 2023 1 commit
-
-
Darren Austin authored
* Updated to tokens v0.150. * Updated with a reverted list_tile.dart.
-
- 21 Dec, 2022 2 commits
-
-
Renzo Olivares authored
This reverts commit cd0f15a7. Co-authored-by:
Renzo Olivares <roliv@google.com>
-
Renzo Olivares authored
* Replace PanGestureRecognizer in TextSelection with TapAndDragGestureRecognizer * add tracking of _DragState to new tap_and_drag recognizer and remove some legacy double tap code from text_selection.dart and add logs" * add dragTapCount, a tap count that is persistent for an entire drag and is set to null on drag end vs the regular tap count which is reset on a timer * basic double tap to drag functionality and add a local dragTapCount in text_selection.dart to use with the timer callback * Add offsetFromOrigin and localOffsetFromOrigin to DragUpdateDetails similar to LongPressMoveUpdateDetails, eliminates the need to hold the state of lastDragStartDetails * make a generic baselongpressgesturerecognizer * Revert "make a generic baselongpressgesturerecognizer" This reverts commit aad8f7433bd01e4cd016d527af832c3b1f15fac5. * rename tap_and_drag to selection_recognizers * add mixin for consecutivetap * tap and long press gesture recognizer * Revert "Revert "make a generic baselongpressgesturerecognizer"" This reverts commit 181350c36718f644eada3e45c1b7b5939f90a340. * Revert "Revert "Revert "make a generic baselongpressgesturerecognizer""" This reverts commit 4d69775967858dfd66dd9429e1713da598908a85. * Add support for secondary button clicks on drag gesture recognizer and separate drag end and tap up callback * get test running * rename tapCount to consecutiveTapCount * dispose timer properly * add some comments to tests * Add comments * Make ConsecutiveTapMixin private and move logic to increment tap count into mixin * stop tracking pointer when gesture is rejected and detect drags on touch devices * onCancel for TapAndDrag * have the TapAndDragGestureRecognizer handle tap downs and tap ups on touch and mouse devices * add drag to move cursor for android and iOS, and pointer device kind to DragUpdateDetails * get tests running * refactor TapAndDragGestureRecognizer moving some logic into _check methods * Handle cancel properly on TapAndDragGestureRecognizer, having both onTapCancel and onDragCancel, also fix tests * Fix test mouse drag selects and cannot drag cursor, save _initialPosition based on dragStartBehavior (either on tapDown or dragStart) * determine if drag has a sufficient global distance to accept and fix some cancel behavior, making _checkCancel clearer * give up pointer on drag end * properly stop tracking pointer, fixes test for right click on Apple and non-apple platforms * clean up some comments from last commit * remove drag on touch for now * fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate * Revert "fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate" This reverts commit 124dc79bc3389672c76d7c014ce04edab297abc6. * correctly use _initialPosition for checkStart and call _checkUpdate after _checkStart if localDelta is not zero * updates * fix double tap chains * Add docs * Address analyzer * more analyzer, only issues left are with print statements * add deadlineTimer to fix conflict with ForcePressGestureRecognizer * Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer" This reverts commit 3b29ddfff4cde4845edd481ecefb789fea2a0781. * remove unecessary changes to tests * secondaryButton should not drag * Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer"" This reverts commit 0a008f029f5796acd48c17c1897c0b700d5ef3a7. * updates * Revert "updates" This reverts commit 4803b8443a2b67f0b8d29e9a01f712dfcb0f588c. * Revert "Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer""" This reverts commit 79251a7af88d5dbb1460a960afc77e65dea18bff. * fix shift + tap + drag tests, this was happening because a double tap + drag was being registered and not a single tap, added a duration to pumpAndSettle to fix this * remove TapAndLongPressGestureRecognizer * fix cupertino text field tests related to shift + tap + drag * deadline timer try 2 * more logs * Should reset taps when tap cancel is called, and should wait until gesture is accepted to initiate a drag * should clear _down and _up when gesture is rejected * remove erroneous log * fix selectable text double tap chains test * dont restart timer until tap up * reset consecutiveTapCount on drag end * fix selectableText test * fix material text field tests * reject TapAndDragGestureRecognizer when it is neither a tap nor a drag * remove prints * clean up * shift aware * clean up * fix cupertino test * fix text field focus tests * Add 100ms delay to cupertino test, to prevent a double tap * clean up test comments * add comment to test * uncomment test * remove longpress changes * Fix drag on mobile * remove debug * Fix drag to move cursor on iOS * left over from drag fix * add tests for drag on touch devices * add test for double tap + drag mouse devices * add tests * Fix bug where initialPosition was used before it was set * Address some review comments and fix issue where if double tap was held too long then long press gesture recognizer would take over * remove _isDoubleTap flag since it is no longer needed due to previous commit * Add docs for onTapCancel and onDragCancel * analyzer fixes * Do not test selection handles on macOS, since macOS does not support touch * Add assert for dragStartBehavior * add double tap + drag tests to cupertino * use kDoubleTapTimeout instead of const Duration(milliseconds: 300) for readability * analyzer issues * update docs * update more docs * address comments * more doc updates * fix docs * unused import * fix docs * Add more tests * Add more tests and reject a tap up if we have exceeded the tap tolerance * updates * Address comments * fix test naming * update documentation * move selection_recognizers to selection_gestures * fix analyzer * fix analyzer * keysPressedOnDown instead of isShiftPressed * update docs * update docs * Add drag update throttle to TapAndDragGestureRecognizer * update comments * missed from merge * Replace _ConsecutiveTapMixin with _TapStatusTrackerMixin * updates * correctly cancel tap when when past tap tolerance with new implementation * Should call tap and drag cancel if we are giving up a pointer without succesfully tracking a PointerUpEvent * comments * move pastTapTolerance to tap tracker * move pastTapTolerance to tap tracker * clean up check for nulls and remove use of consecutiveTapCountWhileDragging * move call to super.acceptGesture to top * remove print * clean up * Fix tests where both PanGestureRecognizer and TapAndDragGestureRecognizer lost * clean up * _GestureState -> _DragState * more docs clean up * more clean up * Add onSecondaryTapCancel * Add docs * more docs * Fix broken isPointerAllowed when attempting a right click drag - the _initialButtons is never reset * revert debug flag * make primaryPointer private * Add support for upper count limit in TapAndDragGestureRecognizer, the tap counter should not be allowed to grow infinitely unless that is desired * fix analyzer * Use new TapDrag details objects and callbacks * clean up docs * clean up and add test for upperLimit * Add docs for TapAndDragGestureRecognizer and remove some ambiguity of onStart onUpdate and onEnd parameters * Address review comments * analyzer fixes * Call cancel before rejecting the gesture so we can still access _initialButtons * Recognizer should reject any pointer differing from the original * Revert "Recognizer should reject any pointer differing from the original" This reverts commit afd9807480bd11e119bdd2b7d520631511973bab. * Address reviewer comments * Correct cancel behavior * Fix consecutive tap + drag because _dragStart state was not being set when consecutive tap is greater than one * Add more tests * Add documentation on behavior with TapGestureRecognizer and DragGestureRecognizer * more docs * more docs * remove comments * updates * fix multiple pointer behavior * only handle the primary pointer * Clean up dangerous assumptions in gesture details objects * forgot from rebase * update docs * updates * Clean up some redundant code * remove whitespace * fix tests as a result of #115849 * update test docs * Fix same test from last commit for material variants * More clean up of redundant code and update docs * Clean up didStopTrackingLastPointer and untie TapAndDragGestureRecognizer cancel behavior from TapStatusTrackerMixin.currentUp state * untie pastTapTolerance * updates * Add slopTolerance * update docs * Have secondary tap handled by TapGestureRecognizer * update docs * fix analyzer and address comments * Add more docs * Update cancel behavior tol not call on tap cancel when a drag has been accepted * Change cancel behavior to only cancel if the tap down callback has been sent and merge tapcancel and dragcancel * update docs; * Rename selection_gestures to tap_and_drag_gestures * Address some reviewer comments * make deadline and slopTolerance private * updates * updates * Address review comments * remove _initialButtons * fix docs * trackTrap -> trackTap * fix analyzer * Add test to verify that tap up is called when recognizer accepts before handleEvent is called * implement Diagnosticable for Details objects; * sentTapDown == wonArenaForPrimaryPointer, so the implementation now only uses sentTapDown * Count user tap up immediately and do not wait to win the arena * Do not need to call super from TapAndDragGestureRecognizer.acceptGesture anymore because mixin implementation is gone * Do not start selection drag on Android, iOS, and Fuchshsia touch devices if renderEditable does not have focus, this fixes many scubas * Address reviewer comments * fix test * TapAndDragGestureRecognizer should wait for other recognizer to lose before winning the arena * Address review comments * Dont check for drag if the start was already found * Only check for a drag if it has not already been found" * fix from rebase Co-authored-by:
Renzo Olivares <roliv@google.com>
-
- 20 Dec, 2022 1 commit
-
-
Camille Simon authored
* Add spell check suggestions toolbar * Fix test and move menu * Cleanup * Cleanup and fix bug * More cleanup * Make height dynamic and use localized delete * Begin adding tests * Create var checking for results * Add tests * Fix analyze (sorta) * Add back hideToolbar call for testing * Add back hidetoolbar in ts and delete one in et * Remove unecessary calls to hidToolbar * Fix analyze and docs * Test fix * Fix container issue * Clean up * Fix analyze * Move delegate * Fix typos * Start addressing review * Continue addressing review * Add assert * Some refactoring * Add test for button behavior * Undo test change * Make spell check results public * Rearrange test * Add comment * Address review * Finish addressing review * remove unused imports * Address nits * Address review * Fix formatting * Refactor findsuggestionspanatcursorindex and textselectiontoolbar constraints * Fix analyze:
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 07 Dec, 2022 1 commit
-
-
Greg Spencer authored
* Make some minor changes in preparation for updating the Time Picker to M3 * Revert OutlineInputBorder.borderRadius type change * Revert more OutlineInputBorder.borderRadius changes.
-
- 28 Nov, 2022 1 commit
-
-
Darren Austin authored
-
- 15 Nov, 2022 1 commit
-
-
Darren Austin authored
-
- 28 Oct, 2022 1 commit
-
-
Justin McCandless authored
* Can show context menus anywhere in the app, not just on text. * Unifies all desktop/mobile context menus to go through one class (ContextMenuController). * All context menus are now just plain widgets that can be fully customized. * Existing default context menus can be customized and reused.
-
- 24 Oct, 2022 2 commits
-
-
Darren Austin authored
-
Renzo Olivares authored
-
- 17 Oct, 2022 1 commit
-
-
Renzo Olivares authored
-
- 23 Sep, 2022 1 commit
-
-
Anthony Oleinik authored
-
- 19 Sep, 2022 1 commit
-
-
Qun Cheng authored
-
- 15 Sep, 2022 1 commit
-
-
godofredoc authored
-
- 14 Sep, 2022 1 commit
-
-
Qun Cheng authored
-
- 09 Sep, 2022 1 commit
-
-
Renzo Olivares authored
-
- 07 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 02 Sep, 2022 2 commits
-
-
Pierre-Louis authored
-
Pierre-Louis authored
-
- 22 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 17 Aug, 2022 1 commit
-
-
Camille Simon authored
-
- 16 Aug, 2022 3 commits
-
-
olof-dev authored
-
Jonah Williams authored
This reverts commit ff9fe356.
-
Camille Simon authored
-
- 13 Aug, 2022 1 commit
-
-
Renzo Olivares authored
-
- 10 Aug, 2022 2 commits
-
-
Ian Hickson authored
-
Tomasz Gucio authored
-
- 04 Aug, 2022 1 commit
-
-
hangyu authored
* M3 counter error style * polish * Update text_field_template.dart * Roll Flutter Engine from 3cba105ed0bd to cf0db3e54687 (1 revision) (#108716) * resolve comments * Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (#108738) * Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (#108623) * Roll Flutter Engine from cf0db3e54687 to aa9004449786 (1 revision) (#108734) * Roll Flutter Engine from aa9004449786 to 6d2fd23404b8 (5 revisions) (#108744) * Fix lerp to eccentric circle. (#108743) * Roll Flutter Engine from 6d2fd23404b8 to f182794500dc (4 revisions) (#108749) * Roll Flutter Engine from f182794500dc to 25e8021c91e4 (1 revision) (#108751) * Sync with https://github.com/flutter/.github/pull/13 (#108754) * Roll Flutter Engine from 25e8021c91e4 to e771729efdde (2 revisions) (#108755) * clean-up analysis_options.yaml (#108747) * Fix ExpansionTile shows children background when expanded (#107834) * Create `containsSemantics` to allow for partial matching of semantics in tests. (#108573) * Roll Flutter Engine from e771729efdde to 7d0f6d2f11df (2 revisions) (#108757) * Enable conditional_uri_does_not_exist (#108652) * Roll Flutter Engine from 7d0f6d2f11df to b257966d8daa (3 revisions) (#108763) * Roll Flutter Engine from b257966d8daa to 60e5eb6f3c2c (3 revisions) (#108766) * Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (#108466) (#108769) * [SelectionOverlay]Move the debug statement to the scope of the assertion. (#108508) * Roll Flutter Engine from 60e5eb6f3c2c to 1c3b1b305ef3 (11 revisions) (#108780) * Roll Flutter Engine from 1c3b1b305ef3 to b6078110efda (1 revision) (#108782) * Roll Flutter Engine from b6078110efda to 3b2bd24a1e0b (1 revision) (#108784) * Roll Flutter Engine from 3b2bd24a1e0b to 0e5392c4c248 (1 revision) (#108788) * Roll Flutter Engine from 0e5392c4c248 to 4b192569797f (1 revision) (#108793) * Roll Flutter Engine from 4b192569797f to e0b5edc1131b (2 revisions) (#108798) * Roll Flutter Engine from e0b5edc1131b to b164c5c86d1c (1 revision) (#108814) * Update text_field.dart * Roll Flutter Engine from b164c5c86d1c to eb2b57bdb7bc (4 revisions) (#108821) * Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (#108822) * Roll Flutter Engine from eb2b57bdb7bc to 978d8e2dbe35 (2 revisions) (#108825) * Loupe Android + iOS (#107477) * added Magnifier for iOS and Android * Mark `Mac_ios microbenchmarks_ios_flaky` flaky (#108820) * Deprecate `toggleableActiveColor` (#97972) * Roll Flutter Engine from 978d8e2dbe35 to 2b3173254281 (4 revisions) (#108830) * [flutter_tools] Test that DAP process terminates at the end of a session (#108301) * Roll Flutter Engine from 2b3173254281 to 4e9c8699468a (1 revision) (#108833) * fix noop toString() diagnostics (#108836) * [flutter_tools] Migrate more tool tests to null-safety (#108639) * Revert "Fix ExpansionTile shows children background when expanded" (#108844) * Roll Flutter Engine from 4e9c8699468a to 6724561b1cf4 (2 revisions) (#108838) * Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (#104088) * Update documentation to match implementation (#108843) * Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." #108718 * Roll Flutter Engine from 6724561b1cf4 to f3deaba5a359 (8 revisions) (#108847) * Roll Flutter Engine from f3deaba5a359 to c07e1acfadda (2 revisions) (#108849) * Roll Flutter Engine from c07e1acfadda to a1e77ae885a0 (5 revisions) (#108850) * Roll Flutter Engine from a1e77ae885a0 to c4564762773f (2 revisions) (#108853) * Roll Flutter Engine from c4564762773f to 6cd744bb9706 (1 revision) (#108857) * Roll Flutter Engine from 6cd744bb9706 to 51296a62d98c (1 revision) (#108860) * Roll Flutter Engine from 51296a62d98c to 05228ad454bc (1 revision) (#108862) * Revert "Roll Flutter Engine from 51296a62d98c to 05228ad454bc (1 revision) (#108862)" (#108882) This reverts commit a880c4ed. * Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (#108887) * Roll Flutter Engine from 51296a62d98c to 2c282981d849 (6 revisions) (#108899) * [flutter_test] Add flag to send device pointer events to the framework (#108430) * Roll Flutter Engine from 2c282981d849 to adba70232a61 (2 revisions) (#108903) * fix flutter not finding custom device (#108884) * Force a11y services to off for complex_layout_semantics_perf test (#108906) * Update `equalsIgnoringHashCodes` to take a list of Strings (#108507) * [macOS] Use editing intents from engine (#105407) * Added `IconButtonTheme` and apply it to `IconButton` in M3 (#108332) * Created IconButtonTheme and apply it to IconButton * [web] Add onEntrypointLoaded to FlutterLoader. (#108776) * Roll pub packages (#108919) * [flutter_test] perf: find.ancestor (#108868) * Roll Flutter Engine from adba70232a61 to 1188a808e1e0 (4 revisions) (#108922) * Bump github/codeql-action from 2.1.17 to 2.1.18 (#108923) * Remove some outdated ignores from framework (#108915) * Roll Flutter Engine from 1188a808e1e0 to 1743d1db1dda (1 revision) (#108925) * Clean up ScrollbarPainter (#107179) * Remove outdated ignores (#108924) * Add more logs to diagnose Gold flake (#108930) * M3 counter error style * polish * Update text_field_template.dart * resolve comments * Update text_field.dart Co-authored-by:
engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by:
Tomasz Gucio <72562119+tgucio@users.noreply.github.com> Co-authored-by:
Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by:
Ian Hickson <ian@hixie.ch> Co-authored-by:
Michael Goderbauer <goderbauer@google.com> Co-authored-by:
Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by:
pdblasi-google <109253501+pdblasi-google@users.noreply.github.com> Co-authored-by:
Kaushik Iska <iska.kaushik@gmail.com> Co-authored-by:
xubaolin <xubaolin@oppo.com> Co-authored-by:
Anthony Oleinik <48811365+antholeole@users.noreply.github.com> Co-authored-by:
keyonghan <54558023+keyonghan@users.noreply.github.com> Co-authored-by:
Taha Tesser <tessertaha@gmail.com> Co-authored-by:
Danny Tuppeny <danny@tuppeny.com> Co-authored-by:
Phil Quitslund <pq@users.noreply.github.com> Co-authored-by:
Christopher Fujino <christopherfujino@gmail.com> Co-authored-by:
Kate Lovett <katelovett@google.com> Co-authored-by:
Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by:
parkershepherd <me@parkershepherd.com> Co-authored-by:
Darren Austin <darrenaustin@google.com> Co-authored-by:
Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by:
Jia Hao <jiahaog@users.noreply.github.com> Co-authored-by:
Hannes Winkler <hanneswinkler2000@web.de> Co-authored-by:
Matej Knopp <matej.knopp@gmail.com> Co-authored-by:
Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by:
David Iglesias <ditman@gmail.com> Co-authored-by:
Pascal Welsch <pascal@welsch.dev> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- 02 Aug, 2022 1 commit
-
-
Anthony Oleinik authored
* added Magnifier for iOS and Android
-
- 29 Jul, 2022 1 commit
-
-
Greg Spencer authored
-
- 28 Jul, 2022 1 commit
-
-
hangyu authored
* Update input style * generate M3 text style * Add test
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Jul, 2022 1 commit
-
-
Taha Tesser authored
Fixes a fidelity bug on desktop involving the selection toolbar not hiding when it should have.
-