- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 26 Jul, 2023 3 commits
-
-
Ian Hickson authored
This primarily implements DecorationImage.lerp(). It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation. Fixes https://github.com/flutter/flutter/issues/12452 This was first landed in https://github.com/flutter/flutter/pull/130533 and reverted in https://github.com/flutter/flutter/pull/131347.
-
Ian Hickson authored
Reverts flutter/flutter#130533 Tree breakage.
-
Ian Hickson authored
This primarily implements DecorationImage.lerp(). It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation. Fixes https://github.com/flutter/flutter/issues/12452
-
- 20 Jun, 2023 1 commit
-
-
Tae Hyung Kim authored
This is a second attempt to merge #107269. Currently I've fixed two of the issues: 1. Fixed horizontal scrollview by using a switch statement to consider vertical/horizontal case. 2. Fixed issue of `paintExtent` not being the right extent for painting. Rather using a `scrollExtent` for the main axis length of the decoration box and painting it offsetted by the `scrollOffset`. 3. If the sliver child has inifinite scrollExtent, then we only draw the decoration down to the bottom of the `cacheExtent`. The developer is expected to ensure that the border does not creep up above the cache area. This PR includes a test that checks that the correct rectangle is drawn at a certain scrollOffset for both the horizontal and vertical case which should be sufficient for checking that `SliverDecoration` works properly now. Fixes https://github.com/flutter/flutter/issues/107498.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 23 Feb, 2023 1 commit
-
-
Hans Muller authored
-
- 31 Jan, 2023 1 commit
-
-
Ian Hickson authored
The default implementation returns EdgeInsets.zero, the ShapeDecoration subclass already makes it non-nullable, and there isn't any benefit to returning null as far as I can tell.
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 25 Aug, 2022 1 commit
-
-
Greg Spencer authored
-
- 24 Aug, 2022 1 commit
-
-
Newton Michael authored
-
- 21 Aug, 2022 1 commit
-
-
Greg Spencer authored
This reverts commit b3aba4d9 because it breaks Google tests.
-
- 19 Aug, 2022 1 commit
-
-
Greg Spencer authored
-
- 16 Aug, 2022 1 commit
-
-
Casey Hillers authored
-
- 15 Aug, 2022 1 commit
-
-
Bernardo Ferrari authored
-
- 13 Jul, 2022 1 commit
-
-
Jonah Williams authored
-
- 12 Jul, 2022 1 commit
-
-
Jonah Williams authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
Use `curly_braces_in_flow_control_structures` for `foundation`, `gestures`, `painting`, `physics` (#104610) * Use `curly_braces_in_flow_control_structures` for `foundation` * Use `curly_braces_in_flow_control_structures` for `gestures` * Use `curly_braces_in_flow_control_structures` for `painting` * Use `curly_braces_in_flow_control_structures` for `physics` * fix comments * remove trailing space * fix TODO style
-
- 12 May, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 25 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 01 Mar, 2022 1 commit
-
-
Viren Khatri authored
* migrates lib/foundation and lib/widgets * migrates lib/painting and lib/material * migrates lib/cupertino, lib/gestures, lib/services, lib/semantics and lib/rendering * fixes failing tests * migrates test/ * improves hashing of lists
-
- 20 Aug, 2021 1 commit
-
-
nt4f04uNd authored
-
- 10 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 08 Sep, 2020 1 commit
-
-
Ian Hickson authored
This allows us to rationalize the nullability of some of our APIs. Prior to this we'd end up in a situation where Container assumed that getClipPath would be non-null but Decoration was ok with return null.
-
- 21 Aug, 2020 1 commit
-
-
timekone authored
-
- 12 Aug, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Aug, 2020 1 commit
-
-
Nolan Scobie authored
* Add punctuation for unterminated sentences in doc comments * Addressing review nit
-
- 16 Jul, 2020 1 commit
-
-
Bogdan Lukin authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 22 Apr, 2020 1 commit
-
-
Darren Austin authored
-
- 11 Feb, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Jan, 2020 1 commit
-
-
Greg Spencer authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 03 Dec, 2019 1 commit
-
-
Sahand Akbarzadeh authored
-