1. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must not be null' comments from painting and rendering libraries. (#134993) · fe9a2c54
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the painting and rendering libraries.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      fe9a2c54
  2. 26 Jul, 2023 3 commits
  3. 20 Jun, 2023 1 commit
    • Tae Hyung Kim's avatar
      DecoratedSliver (#127823) · 541fdd60
      Tae Hyung Kim authored
      This is a second attempt to merge #107269. Currently I've fixed two of the issues:
      1. Fixed horizontal scrollview by using a switch statement to consider vertical/horizontal case.
      2. Fixed issue of `paintExtent` not being the right extent for painting. Rather using a `scrollExtent` for the main axis length of the decoration box and painting it offsetted by the `scrollOffset`.
      3. If the sliver child has inifinite scrollExtent, then we only draw the decoration down to the bottom of the `cacheExtent`. The developer is expected to ensure that the border does not creep up above the cache area.
      
      This PR includes a test that checks that the correct rectangle is drawn at a certain scrollOffset for both the horizontal and vertical case which should be sufficient for checking that `SliverDecoration` works properly now.
      
      Fixes https://github.com/flutter/flutter/issues/107498.
      541fdd60
  4. 22 Mar, 2023 1 commit
  5. 23 Feb, 2023 1 commit
  6. 31 Jan, 2023 1 commit
  7. 21 Jan, 2023 1 commit
  8. 25 Aug, 2022 1 commit
  9. 24 Aug, 2022 1 commit
  10. 21 Aug, 2022 1 commit
  11. 19 Aug, 2022 1 commit
  12. 16 Aug, 2022 1 commit
  13. 15 Aug, 2022 1 commit
  14. 13 Jul, 2022 1 commit
  15. 12 Jul, 2022 1 commit
  16. 25 May, 2022 1 commit
    • Pierre-Louis's avatar
      Use `curly_braces_in_flow_control_structures` for `foundation`, `gestures`,... · 9cc72df7
      Pierre-Louis authored
      Use `curly_braces_in_flow_control_structures` for `foundation`, `gestures`, `painting`, `physics` (#104610)
      
      * Use `curly_braces_in_flow_control_structures` for `foundation`
      
      * Use `curly_braces_in_flow_control_structures` for `gestures`
      
      * Use `curly_braces_in_flow_control_structures` for `painting`
      
      * Use `curly_braces_in_flow_control_structures` for `physics`
      
      * fix comments
      
      * remove trailing space
      
      * fix TODO style
      9cc72df7
  17. 12 May, 2022 1 commit
  18. 25 Mar, 2022 1 commit
  19. 01 Mar, 2022 1 commit
  20. 20 Aug, 2021 1 commit
  21. 10 May, 2021 1 commit
  22. 03 Apr, 2021 1 commit
  23. 31 Mar, 2021 1 commit
  24. 02 Nov, 2020 1 commit
  25. 27 Sep, 2020 1 commit
  26. 08 Sep, 2020 1 commit
  27. 21 Aug, 2020 1 commit
  28. 12 Aug, 2020 1 commit
  29. 06 Aug, 2020 1 commit
  30. 16 Jul, 2020 1 commit
  31. 11 Jun, 2020 1 commit
  32. 22 Apr, 2020 1 commit
  33. 11 Feb, 2020 1 commit
  34. 09 Jan, 2020 1 commit
  35. 08 Jan, 2020 1 commit
  36. 07 Jan, 2020 1 commit
  37. 05 Dec, 2019 1 commit
  38. 03 Dec, 2019 1 commit