1. 08 Feb, 2019 13 commits
    • Phil Quitslund's avatar
      remove super_goes_last (#27690) · 9e3a0d30
      Phil Quitslund authored
      In Dart 2, it is a compile-time error if a superinitializer
      appears in an initializer list at any other position than at the end so this
      rule is made redundant by the Dart analyzer's basic checks and is no longer
      necessary.
      9e3a0d30
    • Greg Spencer's avatar
      Adding support for logical and physical key events (#27627) · 431cfdaf
      Greg Spencer authored
      This adds support for logical and physical key information inside of RawKeyEvent. This allows developers to differentiate keys in a platform-agnostic way. They are able to tell the physical location of a key (PhysicalKeyboardKey) and a logical meaning of the key (LogicalKeyboardKey), as well as get notified of the character generated by the keypress. All of which is useful for handling keyboard shortcuts.
      
      This PR builds on the previous PR (#27620) which generated the key code mappings and definitions.
      431cfdaf
    • Kartik Sharma's avatar
    • engine-flutter-autoroll's avatar
      Roll engine b8473cdee13d..25c513c72a5a (10 commits) (#27689) · 4e8b732f
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/b8473cdee13d...25c513c72a5a
      
      git log b8473cdee13d4739afda6b171f4c84280584ab98..25c513c72a5a4b2ef3cf5c174a9541e7f327d2b8 --no-merges --oneline
      25c513c72 Roll src/third_party/dart 246430bc8c..52f5e34dbf (5 commits)
      b5892b6af Roll src/third_party/skia 44bffbfc1c3e..f2a3f5943e4c (3 commits) (flutter/engine#7749)
      f20d8558d Roll src/third_party/skia 26490759e464..44bffbfc1c3e (1 commits) (flutter/engine#7748)
      87d3f4281 Roll src/third_party/dart 9c0a73f943..246430bc8c (1 commits)
      401d2e24f Roll src/third_party/skia 50e24d7d5f52..26490759e464 (3 commits) (flutter/engine#7745)
      aa901fc84 [fuchsia] Update path to fuchsia.ui.scenic (flutter/engine#7731)
      c5ab02766 use full git hash for version (flutter/engine#7741)
      8c80b404d Roll src/third_party/skia d978b90d205d..50e24d7d5f52 (4 commits) (flutter/engine#7743)
      168f92ddd Roll src/third_party/dart 6c680a0ebd..9c0a73f943 (31 commits)
      929c8feec Roll src/third_party/skia 8619a34bb875..d978b90d205d (17 commits) (flutter/engine#7736)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
      the roller if necessary.
      4e8b732f
    • Hans Muller's avatar
      022f7d89
    • Greg Spencer's avatar
      Make sample analyzer more friendly for running locally. (#27648) · bcd60fa8
      Greg Spencer authored
      Now the sample analyzer can be run locally with:
      
      dart dev/bots/analyze-sample-code.dart --temp=/tmp/samples
      
      And it leaves /tmp/samples around so you can take a look at the code that was generated to see if it's the artificial environment that the samples are evaluated in that is the culprit for a failed analysis.
      
      Before, you had to specify the whole path to the dart executable, and had to modify the code to keep the tempdir around.
      bcd60fa8
    • engine-flutter-autoroll's avatar
      b8473cdee use correct no-download-badge (flutter/engine#7735) (#27669) · 53632b8a
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/b0370c13c302...b8473cdee13d
      
      git log b0370c13c302bc747f0cb3736a3a79e79ae4f7cd..b8473cdee13d4739afda6b171f4c84280584ab98 --no-merges --oneline
      b8473cdee use correct no-download-badge (flutter/engine#7735)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
      the roller if necessary.
      53632b8a
    • Martin's avatar
      Create slider with editable numerical value in gallery (#23506) · 6d313239
      Martin authored
      * Update doc header in Opacity class to fix issue #23311
      
      * Added slider with editable numerical value to gallery. Fixes flutter#1542
      
      * Revert "Update doc header in Opacity class to fix issue #23311"
      
      This reverts commit 2d3642bbda6e00389e78631360f8274e9bb7d675.
      
      * Fix typo in slider description
      
      * Increase TextField size to pass accessibility test
      
      * Added Semantics widget to pass accessibility test
      
      * Made description start with caps to match other examples
      
      * Removed unnecessary spacing Container widget
      
      * Update authors file
      
      * Fix indent
      
      * Removed decimal and replaced boundaries with .clamp
      Signed-off-by: 's avatarMartin Staadecker <machstg@gmail.com>
      
      * Undo line wrap from previous commit
      Signed-off-by: 's avatarMartin Staadecker <machstg@gmail.com>
      
      * Update onSubmitted to only call setState when value has changed
      Signed-off-by: 's avatarMartin Staadecker <machstg@gmail.com>
      6d313239
    • Zachary Anderson's avatar
      Add build_runner_core to flutter_tools BUILD.gn (#27661) · fe701c45
      Zachary Anderson authored
      Need for roll into Fuchsia
      fe701c45
    • engine-flutter-autoroll's avatar
      Roll engine c40d6dacc78b..b0370c13c302 (3 commits) (#27664) · 4e9cfa8f
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/c40d6dacc78b...b0370c13c302
      
      git log c40d6dacc78b8c25a2822ec8c6f47aa46f642c5f..b0370c13c302bc747f0cb3736a3a79e79ae4f7cd --no-merges --oneline
      b0370c13c Decode using the last cached required frame (flutter/engine#7715)
      4f3eb42df Update documentation for command line args in FlutterProjectArgs. (flutter/engine#7733)
      4e13ede57 Roll src/third_party/skia 9564bf44e5fa..8619a34bb875 (10 commits) (flutter/engine#7732)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
      the roller if necessary.
      4e9cfa8f
    • xster's avatar
      9e4ab00e
    • Michael Klimushyn's avatar
      Warn when gradle builds fail because of AndroidX (#27566) · 4a9e5bc1
      Michael Klimushyn authored
      Try to detect Gradle error messages that hint at AndroidX problems, and
      warn in the logs about the potential problem and point to documentation
      on how to fix the issue.
      
      Unfortunately the Gradle errors based on this root issue are varied and
      project dependent. It's probably better to still leave the message
      intact in case the problem is unrelated.
      
      Also filters out the plugin warning message pending in
      flutter/plugins#1138. It's still valuable to add that for people on
      previous versions of Flutter, but this link should override that message
      for anyone on an up to date version of Flutter.
      
      #27106
      4a9e5bc1
    • engine-flutter-autoroll's avatar
      Roll engine fdc699b80347..c40d6dacc78b (14 commits) (#27653) · cd9a0037
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/fdc699b80347...c40d6dacc78b
      
      git log fdc699b803478c7d90a40a51832a964f7da160ae..c40d6dacc78b8c25a2822ec8c6f47aa46f642c5f --no-merges --oneline
      c40d6dacc [fuchsia] Update scenic include (flutter/engine#7708)
      3c38dd342 Fix versions implementation (flutter/engine#7726)
      d292ed6c2 Roll src/third_party/skia c19d81acc096..9564bf44e5fa (5 commits) (flutter/engine#7730)
      473097b53 Roll src/third_party/skia 859db6b5a03c..c19d81acc096 (2 commits) (flutter/engine#7729)
      d0fee9b28 Roll src/third_party/dart caa8747a37..6c680a0ebd (12 commits) 6c680a0ebd Update dartfix readme and update version numbers 33337cf8d0 Fix API breakage, reexport ConstantEvaluator. c2cdc1c639 Allow migration of multiple files at once. d68d8526f4 Allow nullabilty migration prepareInput/processInput to operate on different ASTs. 5ecf660b50 [dartdevc] skip co19 tests on linux bots ba9fbda83e Rework provisional migration API. a4b681b83a Update dartdoc to 0.28.1&#43;2. fea5413d5a [ VM ] Fix hang of Flutter engine tests caused by global RuntimeEntry objects being destroyed when exit() is called when the VM hasn&#39;t finished shutting down. a5570bd995 [vm/compiler] Add optimization flag f0d5cb73a9 Guard the custom formatter for a Map against errors df779789f2 Support two more cases in the convert-to-spread assist (issue 35867) fd2225ab6c Adapt to the flow analysis spec v2.
      168cabc97 Roll src/third_party/skia f36ad269e88a..859db6b5a03c (1 commits) (flutter/engine#7727)
      ee0cf82c1 Correct libraries.yaml path for stub_ui, add brightness, copy dart2js_platform.dill files (flutter/engine#7725)
      053f7a8fa Roll src/third_party/skia 2fc1474f9d62..f36ad269e88a (2 commits) (flutter/engine#7724)
      211adeac3 Introduced a number of Java system channels in io/flutter/embedding/engine/systemchannels/ (flutter/engine#7500)
      fdf57a64d Roll src/third_party/skia 429251513f71..2fc1474f9d62 (8 commits) (flutter/engine#7721)
      77b318603 Roll src/third_party/dart adfa4791fc..caa8747a37 (2 commits) caa8747a37 Rework dartfix NNBD fix to use new NullabilityMigration engine ae5bd68570 Lower relevance of deprecated suggestion sets.
      67831a3ed Roll buildroot to c82412bcdcd593f1385a478ae2c4b8eb9814f3b8 (flutter/engine#7718)
      6585f334a Allow all entrypoints support by the command line VM. (flutter/engine#7717)
      ce0739918 Add FlutterProjectArgs::root_isolate_create_callback (flutter/engine#7651)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
      the roller if necessary.
      cd9a0037
  2. 07 Feb, 2019 6 commits
    • KyleWong's avatar
      99497dc2
    • xster's avatar
    • Alexander Ryzhov's avatar
    • engine-flutter-autoroll's avatar
      Roll engine 3c118b6c3b42..fdc699b80347 (2 commits) (#27622) · e5e89529
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/3c118b6c3b42...fdc699b80347
      
      git log 3c118b6c3b42c89f4ef18fce4b27e328f2fd754d..fdc699b803478c7d90a40a51832a964f7da160ae --no-merges --oneline
      fdc699b80 Roll src/third_party/dart 631c550ff9..adfa4791fc (20 commits) adfa4791fc Improve storage for available declarations. 392a869ee4 [infra] Skip all co19_2 tests that are timing out on dartdevc. 033cb7ffcc Issue 1438. Use expression function body for createState(). c3542cbc3b Set relevance for IncludedSuggestionSet. 661e91e30e Extract and migrate tests for ConstantEvaluator. cc74e20eee Make some fields on Interface private, and change the way InheritanceManager2 is tested. 512e2ef292 Extract FixCodeTask/Processor from main dartfix class e4755b34ba Extract FixLintTask/Processor from main dartfix class 1e8f9bf63a Extract FixErrorTask/Processor from main dartfix class 5ae156e055 Extract DartFixListener to record source changes and recommendations 1c0422735e Abstract type operations in flow analysis. efcf8b01b1 Move integration tests of migration API to analysis server. 8f821d408e Fix status files for dartkp 6b73a02937 Fix status files for simarm and simarm64 4fb220707e Hardcode SourceFileEdit.fileStamp to -1 in migration prototype. d972c2b7b7 [vm] Update raw_object_fields.cc after 7e81f56a. c2778062e7 Add UI as code status file entries for simarm 2b8560f4b2 [Fasta] Add spread and control-flow collection flags dc812e0921 [infra] Add third_party/requirejs to the fileset used by dartdevc testing 7e81f56ad7 Save Initializer for field and pass into debugger to enable breakpoint setting.
      9f4b8e442 Roll src/third_party/skia 455c74797b46..429251513f71 (8 commits) (flutter/engine#7714)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
      the roller if necessary.
      e5e89529
    • Greg Spencer's avatar
      Add a keyboard key code generator. (#27620) · 2aad5931
      Greg Spencer authored
      This adds a keycode generator that incorporates input from the Chromium and Android source trees, as well as some local tables, to generate static constants for the LogicalKeyboardKey and PhysicalKeyboardKey classes, as well as mappings from each of the platforms we support so far (currently only Android and Fuchsia).
      
      This code generator parses the input files, generates an intermediate data structure (`key_data.json`) that is checked in, and then generates the Dart sources for these classes and some static maps that will also be checked in (but are not included in this PR).
      
      The idea is that these codes don't change often, and so we don't need to generate them on every build, but we would like to be able to update them easily in the future if new data becomes available. If the existing data disappears or becomes unusable, we can maintain the checked-in data structure by hand if necessary, and still be able to generate the code.
      
      This PR only contains the code generator, not the classes themselves. In another follow-on PR, I'll run the generator and check in the output of the generator.
      2aad5931
    • Matt Carroll's avatar
      a13fdbcf
  3. 06 Feb, 2019 18 commits
  4. 05 Feb, 2019 3 commits