Commits · 9b6945b465a104c7dea41f3042a70781abc39718 · abdullh.alsoleman / Front-End

11 Aug, 2023 8 commits

Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (#132389) · 9b6945b4

engine-flutter-autoroll authored Aug 11, 2023

https://github.com/flutter/engine/compare/93e8901490e7...77dfeea40e10

2023-08-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 13317278a6fa to 83f96a990792 (1 revision) (flutter/engine#44633)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9b6945b4

Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (#132381) · b062b81b

engine-flutter-autoroll authored Aug 11, 2023

https://github.com/flutter/engine/compare/4e532b957225...93e8901490e7

2023-08-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hdjihTvRxbNprHI9x... to 7DmdwgtGmIxyejFDl... (flutter/engine#44630)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from hdjihTvRxbNp to 7DmdwgtGmIxy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b062b81b

Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (#132376) · 496144de

engine-flutter-autoroll authored Aug 11, 2023

https://github.com/flutter/engine/compare/25afdb9b696d...4e532b957225

2023-08-11 john@johnmccutchan.com Add support for HardwareBuffer backed Android Platform Views under Impeller/GLES (flutter/engine#44617)
2023-08-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from konJQZKk2qXc276iA... to v33NyNdr6Y1sKZDze... (flutter/engine#44627)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 41d099099095 to 723df2275d7b (1 revision) (flutter/engine#44626)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from f4080803ee69 to 41d099099095 (2 revisions) (flutter/engine#44624)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from konJQZKk2qXc to v33NyNdr6Y1s

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

496144de

Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (#132370) · a491089a

engine-flutter-autoroll authored Aug 11, 2023

https://github.com/flutter/engine/compare/da23fb0d9a1d...25afdb9b696d

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 88d5e1daa3ba to f4080803ee69 (1 revision) (flutter/engine#44622)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a491089a

Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (#132367) · 9d3268b8

engine-flutter-autoroll authored Aug 11, 2023

https://github.com/flutter/engine/compare/acd1bc5536ef...da23fb0d9a1d

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from b669a6cd29f7 to 88d5e1daa3ba (1 revision) (flutter/engine#44620)
2023-08-11 skia-flutter-autoroll@skia.org Roll Dart SDK from a2eac00da6b8 to 13317278a6fa (2 revisions) (flutter/engine#44618)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9d3268b8

Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (#132365) · dd4c8d9f

engine-flutter-autoroll authored Aug 11, 2023

https://github.com/flutter/engine/compare/578a8e8aabf6...acd1bc5536ef

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from b001e0a5e46f to b669a6cd29f7 (1 revision) (flutter/engine#44615)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dd4c8d9f

Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (#132364) · 65318766

engine-flutter-autoroll authored Aug 11, 2023

https://github.com/flutter/engine/compare/18a71c031f5f...578a8e8aabf6

2023-08-11 matanlurey@users.noreply.github.com Update `examples/**` to provide `--local-engine-host`. (flutter/engine#44610)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65318766

Update `dev/devicelab/**` to provide `--local-engine-host`. (#132342) · a7997f60

Matan Lurey authored Aug 11, 2023

Partial work towards https://github.com/flutter/flutter/issues/132245.

I have to admit I don't totally understand what I've updated, or whether
there are more integration points needed.

a7997f60

10 Aug, 2023 32 commits

Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (#132347) · 978461c5

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/b019ac62f21f...18a71c031f5f

2023-08-10 chris@bracken.jp [shell] Add references to VsyncWaiter docs (flutter/engine#44607)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from b6492f5ce8c3 to b001e0a5e46f (1 revision) (flutter/engine#44606)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

978461c5

Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (#132341) · 67ded4b0

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/16b01b98af20...b019ac62f21f

2023-08-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SoKcmsZ5H8uHJXV1S... to hdjihTvRxbNprHI9x... (flutter/engine#44600)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from SoKcmsZ5H8uH to hdjihTvRxbNp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

67ded4b0

Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (#132336) · b4d5c8f4

Matan Lurey authored Aug 10, 2023

Partial work towards https://github.com/flutter/flutter/issues/132245.

Other than updating error messages, and passing `$LOCAL_ENGINE_HOST`
downwards, this PR should not change the behavior of any existing
workflows or code (i.e. it's purely additive).

b4d5c8f4

Update application id and bundle id of a11y assessment app (#132334) · 7dff527b
chunhtai authored Aug 10, 2023
```
The skeleton id needed to be updated to be sent to app store or play store
```
7dff527b

Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (#132332) · 2bb91a26

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/a9be77e6f475...16b01b98af20

2023-08-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 46da53e7abe2 to a2eac00da6b8 (1 revision) (flutter/engine#44601)
2023-08-10 huxiaohu2007@gmail.com Fix unexpected pointer change issue and Add test case (flutter/engine#43949)
2023-08-10 47866232+chunhtai@users.noreply.github.com Reland "Android a11y bridge sets importantness" (flutter/engine#44589)
2023-08-10 john@johnmccutchan.com Support for Android Platform Views under Impeller/Vulkan (flutter/engine#44571)
2023-08-10 109111084+yaakovschectman@users.noreply.github.com Reintroduce Windows lifecycle with guard for posthumous `OnWindowStateEvent` (flutter/engine#44344)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 92e6f52b0fa8 to b6492f5ce8c3 (1 revision) (flutter/engine#44597)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2bb91a26

Remove the fast reassemble / single widget reload feature (#132255) · a2e25749
Ian Hickson authored Aug 10, 2023
```
Fixes https://github.com/flutter/flutter/issues/132157
```
a2e25749
Analyze code snippets in integration_test docs (#132314) · 6cf5dbe3
Michael Goderbauer authored Aug 10, 2023

6cf5dbe3

Adds SemanticsNode Finders for searching the semantics tree (#127137) · 5df1c996

pdblasi-google authored Aug 10, 2023

* Pulled `FinderBase` out of `Finder`
  * `FinderBase` can be used for any object, not just elements
  * Terminology was updated to be more "find" related
* Re-implemented `Finder` using `FinderBase<Element>`
  * Backwards compatibility maintained with `_LegacyFinderMixin`
* Introduced base classes for SemanticsNode finders
* Introduced basic SemanticsNode finders through `find.semantics`
* Updated some relevant matchers to make use of the more generic `FinderBase`

Closes #123634
Closes #115874

5df1c996

TextField should correctly resolve provided style for material states (#132330) · 73e0dbf5

Renzo Olivares authored Aug 10, 2023

This change makes sure the style provided through the `TextField`s `style` parameter is resolved for material states before merging it with defaults.

Fixes #132212

73e0dbf5

setState documentation (#132090) · 1e35d3a6
Ian Hickson authored Aug 10, 2023
```
Fixes https://github.com/flutter/flutter/issues/12296
```
1e35d3a6

Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (#132328) · eb126ccf

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/ea7730c16301...a9be77e6f475

2023-08-10 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Fixing Behavior Issue (flutter/engine#44586)
2023-08-10 bdero@google.com [Impeller] Flutter GPU: Add context override. (flutter/engine#44566)
2023-08-10 bdero@google.com [Impeller] External OpenGLES texture sampling. (flutter/engine#44559)
2023-08-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 961_tJawsbLMdy5i0... to konJQZKk2qXc276iA... (flutter/engine#44593)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 364900538771 to 92e6f52b0fa8 (1 revision) (flutter/engine#44592)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from f39fd2de8f10 to 364900538771 (1 revision) (flutter/engine#44590)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 961_tJawsbLM to konJQZKk2qXc

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eb126ccf

Fix: use --web-launch-url and --web-hostname arguments in flutter drive (#131763) · 82e2de06

Danny Eldering authored Aug 10, 2023

Implement expected functionalities when supplying `--web-launch-url` and/or `--web-hostname` arguments to `flutter drive`.
- `--web-launch-url` now sets the starting url for the (headless) browser
  - Which for example means you can start at a certain part of the app at the start of your integration test
- `--web-hostname` now sets the hostname where the target of flutter drive will be hosted
  - Which allows you to set something other than localhost (allowing access via a reverse-proxy for example)

Fixes #118028

82e2de06

GridView sample code (#131900) · 4d42f1a8
Ian Hickson authored Aug 10, 2023

4d42f1a8
Upgrade flutter packages. (#132326) · 60634c65
Polina Cherkasova authored Aug 10, 2023

60634c65
TextPainter migration cleanup (#132317) · e1fd2ace
LongCatIsLooong authored Aug 10, 2023
```
Undo temporary changes made in #132094
```
e1fd2ace
An example of parentData usage. (#131818) · f9a578dd
Ian Hickson authored Aug 10, 2023

f9a578dd

Add hasInteractedByUser getter in FormField (#131539) · e972d5a3

Fré Dumazy authored Aug 10, 2023

Adds a getter to access the value of the private `RestorableBool _hasInteractedByUser`.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes #131538

e972d5a3

Roll Flutter Engine from e2ed1bebf31d to ea7730c16301 (3 revisions) (#132313) · 685141bf

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/e2ed1bebf31d...ea7730c16301

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 67bad75b41c2 to f39fd2de8f10 (1 revision) (flutter/engine#44588)
2023-08-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d89e4ead966d to 46da53e7abe2 (4 revisions) (flutter/engine#44584)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from aac2d55d35eb to 67bad75b41c2 (1 revision) (flutter/engine#44583)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

685141bf

Fix flutter attach local engine (#131825) · a6118612

Christopher Fujino authored Aug 10, 2023

Fixes: https://github.com/flutter/flutter/issues/124970
Part of https://github.com/flutter/flutter/issues/47161

Before this change, there were two places we overrode the `Artifacts` in a Zone:

1. if/when we parse local-engine CLI options: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart#L281
2. an additional override for fuchsia platform dill (no longer used, deleted in this PR): https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/commands/attach.dart#L274

Note 1 above creates a new instance of `Artifacts.getLocalEngine()`. In this flow, there exist two instances of `Artifacts`:

1. The default fallback instance of `CachedArtifacts` (which gets all artifacts from flutter/bin/cache), instantiated in context_runner.dart: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/context_runner.dart#L137
2. An instance of `CachedLocalEngineArtifacts` created in the command runner once the CLI options have been parsed: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart#L281

The regression happened when we direct injected the Artifacts 1 from above BEFORE we parsed the local-engine flag, and then used this in the second zone override, and then when creating the `FlutterDevice` there are multiple calls to `globals.artifacts` returned it when it should have returned Artifacts 2: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/resident_runner.dart#L80

Device.artifactOverrides was originally introduced in https://github.com/flutter/flutter/pull/32071, but is no longer used, so I deleted it.

I also removed direct injection of `Artifacts` to the attach sub-command, because that class now no longer references artifacts.

I believe the ideal true fix for this would be to:

1. Migrate all leaf calls to `globals.artifacts` to use direct injection (in this case, the offending invocations were in [`FlutterDevice.create()`](https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/resident_runner.dart#L80-L218), but I'm not sure that something else would not have broken later)
2. Ensure we are always direct injecting the desired instance of `Artifacts`--that is, if the user desires local engine artifacts, that we are passing an instance of `CachedLocalEngineArtifacts`.
a. Alternatively, and probably simpler, teach `CachedArtifacts` to know about the local engine. This would mean parsing the global CLI options BEFORE we ever construct any instance of `Artifacts`.

As an overall recommendation for implementing https://github.com/flutter/flutter/issues/47161, in the overall tree of tool function calls, we should probably migrate the leaves first (that is, migrate the sub-commands last). We should also audit and reconsider any usage of `runZoned()` or `context.run()` for the purpose overriding zoneValues.

a6118612

Analyze code snippets in flutter_test docs (#132246) · 64a0683b
Michael Goderbauer authored Aug 10, 2023
```
Fixes https://github.com/flutter/flutter/issues/132274.
```
64a0683b

Roll Flutter Engine from 3359d6696da4 to e2ed1bebf31d (1 revision) (#132311) · e11cc350

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/3359d6696da4...e2ed1bebf31d

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 7a1fec6b197f to aac2d55d35eb (1 revision) (flutter/engine#44582)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e11cc350

Add `--local-engine-host`, which if specified, is used instead of being inferred (#132180) · 52a6de25

Matan Lurey authored Aug 10, 2023

Closes https://github.com/flutter/flutter/issues/132162.

I did a tiny bit of minor cleanup but didn't want to go 🍔 beyond the
scope of this change. After it lands I'll update the Wiki.

## Before

```bash
$ fl run \
  --local-engine-src-path=$ENGINE \
  --local-engine=android_debug_unopt_arm64
```

... would try to use `host_debug_unopt` (i.e. Rosetta).

## After

```bash
$ fl run \
  --local-engine-src-path=$ENGINE \
  --local-engine=android_debug_unopt_arm64 \
  --local-engine-host=host_debug_unopt_arm64
```

... uses `host_debug_unopt_arm64`, as specified.

---

/cc @jonahwilliams @gaaclarke @zanderso

52a6de25

Remove bringup from Windows build_tests shards (#132306) · bd1bb675
Zachary Anderson authored Aug 10, 2023
```
Context:
https://github.com/flutter/flutter/commit/aff8ef13d428395725ce8f836ca771b8bf2d87db
```
bd1bb675

Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile` padding... · 96e02c61

Taha Tesser authored Aug 10, 2023

Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile` padding and update default horizontal padding for Material 3 (#131609)

fixes [`PopupMenuItem` adds redundant padding when using `ListItem`](https://github.com/flutter/flutter/issues/128553)

### Description

- Fixed redundant `ListTile` padding when using `CheckedPopupMenuItem` or  `PopupMenuItem`  with the `ListTile` child for complex popup menu items as suggested in the docs.
- Updated default horizontal padding for popup menu items.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [PopupMenuButton].

// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }

void main() => runApp(const PopupMenuApp());

class PopupMenuApp extends StatelessWidget {
  const PopupMenuApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: const PopupMenuExample(),
    );
  }
}

class PopupMenuExample extends StatefulWidget {
  const PopupMenuExample({super.key});

  @override
  State<PopupMenuExample> createState() => _PopupMenuExampleState();
}

class _PopupMenuExampleState extends State<PopupMenuExample> {
  SampleItem? selectedMenu;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('PopupMenuButton')),
      body: Center(
        child: SizedBox(
          width: 150,
          height: 100,
          child: Align(
            alignment: Alignment.topLeft,
            child: PopupMenuButton<SampleItem>(
              initialValue: selectedMenu,
              // Callback that sets the selected popup menu item.
              onSelected: (SampleItem item) {
                setState(() {
                  selectedMenu = item;
                });
              },
              itemBuilder: (BuildContext context) =>
                  <PopupMenuEntry<SampleItem>>[
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: Text('PopupMenuItem'),
                ),
                const CheckedPopupMenuItem<SampleItem>(
                  checked: true,
                  value: SampleItem.itemTwo,
                  child: Text('CheckedPopupMenuItem'),
                ),
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: ListTile(
                    leading: Icon(Icons.cloud),
                    title: Text('ListTile'),
                    contentPadding: EdgeInsets.zero,
                    trailing: Icon(Icons.arrow_right_rounded),
                  ),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}
``` 
	
</details>

### Before

![image](https://github.com/flutter/flutter/assets/48603081/aad15ffb-ca11-4997-81d1-b46288161a4e)

- Default horizontal padding is the same as M2 (16.0), while the specs use a smaller value (12.0)
- `ListTile` nested by default in `CheckedPopupMenuItem` has redundant padding
- `PopupMenuItem` using `ListTile` as a child for complex menu items contains redundant padding.

![Screenshot 2023-07-31 at 17 17 08](https://github.com/flutter/flutter/assets/48603081/75ad1fe5-e051-42ba-badf-e20c799dee96)

### After 

- Default horizontal padding is updated for Material 3.
- `PopupMenuItem` & `CheckedPopupMenuItem` override `ListTile` padding (similar to how `ExpansionTile` overrides `ListTile` text and icon color.

![Screenshot 2023-07-31 at 17 17 25](https://github.com/flutter/flutter/assets/48603081/288cf892-5b51-4365-9855-5ef0ed2928e9)

96e02c61

Roll Flutter Engine from 2fe84892b90a to 3359d6696da4 (1 revision) (#132305) · c428d915

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/2fe84892b90a...3359d6696da4

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from a3975f2a9e79 to 7a1fec6b197f (1 revision) (flutter/engine#44580)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c428d915

Roll Flutter Engine from 02ac5e84097b to 2fe84892b90a (2 revisions) (#132294) · 7c59dfeb

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/02ac5e84097b...2fe84892b90a

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from d9e9b7073171 to a3975f2a9e79 (2 revisions) (flutter/engine#44577)
2023-08-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zoCGnScKZWbm5s9Hy... to SoKcmsZ5H8uHJXV1S... (flutter/engine#44576)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from zoCGnScKZWbm to SoKcmsZ5H8uH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c59dfeb

Fix `DropdownButtonFormField` input border clipping (#131481) · bb6b72d6

Taha Tesser authored Aug 10, 2023

fixes [BUG: DropdownButtonFormField input decorator focus/hover is not clipped
](https://github.com/flutter/flutter/issues/131282)

### Description

This fixes an issue where `DropdownButtonFormField`'s input border isn't used for clipping with `InkWell`.

### Before
![Screenshot 2023-07-28 at 17 06 20](https://github.com/flutter/flutter/assets/48603081/8fe1ee1f-5cea-4297-b4f6-e672d74bb583)

### After
![Screenshot 2023-07-28 at 17 06 38](https://github.com/flutter/flutter/assets/48603081/a0091459-67dc-45ca-96b1-95d7093d475f)

bb6b72d6

Roll Flutter Engine from 9117ff27d9c9 to 02ac5e84097b (2 revisions) (#132288) · 35a3ef7e

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/9117ff27d9c9...02ac5e84097b

2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 7c5f6b17a998 to d9e9b7073171 (1 revision) (flutter/engine#44573)
2023-08-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZCP8LDbKF4LTBFz_W... to 961_tJawsbLMdy5i0... (flutter/engine#44572)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZCP8LDbKF4LT to 961_tJawsbLM

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35a3ef7e

Roll Flutter Engine from b5b41ff66dae to 9117ff27d9c9 (16 revisions) (#132284) · a50776e5

engine-flutter-autoroll authored Aug 10, 2023

https://github.com/flutter/engine/compare/b5b41ff66dae...9117ff27d9c9

2023-08-10 zanderso@users.noreply.github.com Revert "Android a11y bridge sets importantness" (flutter/engine#44569)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 491f67637e6e to 7c5f6b17a998 (2 revisions) (flutter/engine#44568)
2023-08-10 matanlurey@users.noreply.github.com [Impeller] Replace Vulkan rotation checks with polling (flutter/engine#44361)
2023-08-10 31859944+LongCatIsLooong@users.noreply.github.com Disable text rounding hack by default (flutter/engine#44544)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 3d5a6138b7e5 to 491f67637e6e (4 revisions) (flutter/engine#44563)
2023-08-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f664f4b9c50d to d89e4ead966d (11 revisions) (flutter/engine#44560)
2023-08-09 58529443+srujzs@users.noreply.github.com Make toJS'd function use JS types (flutter/engine#44469)
2023-08-09 xty50337@hotmail.com [web] Fix rendering of gradients in html mode (flutter/engine#40345)
2023-08-09 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Fixing Animation Issue (flutter/engine#44514)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 8c9a8d3e073c to 3d5a6138b7e5 (4 revisions) (flutter/engine#44557)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from d210bab77137 to 8c9a8d3e073c (1 revision) (flutter/engine#44555)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 25aedb939915 to d210bab77137 (2 revisions) (flutter/engine#44550)
2023-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from e7bMhkfY-RPMrSMhB... to zoCGnScKZWbm5s9Hy... (flutter/engine#44548)
2023-08-09 skia-flutter-autoroll@skia.org Roll Skia from 17ba2122707b to 25aedb939915 (3 revisions) (flutter/engine#44547)
2023-08-09 47866232+chunhtai@users.noreply.github.com Android a11y bridge sets importantness (flutter/engine#44452)
2023-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tO6r8iQqnmsYkLcvZ... to ZCP8LDbKF4LTBFz_W... (flutter/engine#44545)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tO6r8iQqnmsY to ZCP8LDbKF4LT
fuchsia/sdk/core/mac-amd64 from e7bMhkfY-RPM to zoCGnScKZWbm

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a50776e5

Keep alive support for 2D scrolling (#131641) · 0c80ed6d

Kate Lovett authored Aug 10, 2023

Fixes https://github.com/flutter/flutter/issues/126297

This adds support for keep alive to the 2D scrolling foundation. The TwoDimensionalChildBuilderDelegate and TwoDimensionalChildListDelegate will both add automatic keep alives to their children, matching the convention from SliverChildDelegates. The TwoDimensionalViewportParentData now incorporates keep alive and which is managed by the RenderTwoDimensionalViewport.

0c80ed6d

Add missing `ignore: deprecated_member_use` to unblock the engine roller (#132280) · 9156f6b5

LongCatIsLooong authored Aug 10, 2023

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

9156f6b5

Pin leak_tracker. (#132261) · 2efda23a
Polina Cherkasova authored Aug 10, 2023

2efda23a