1. 23 Aug, 2023 1 commit
  2. 22 Aug, 2023 1 commit
  3. 18 Aug, 2023 1 commit
  4. 17 Aug, 2023 1 commit
  5. 10 Aug, 2023 1 commit
  6. 07 Jul, 2023 1 commit
  7. 23 Jun, 2023 1 commit
    • Oleh Prypin's avatar
      Prepare for making `intl` `toBeginningOfSentenceCase` non-nullable (#127488) · 71228e02
      Oleh Prypin authored
      I intend to edit `toBeginningOfSentenceCase`'s return value to be non-nullable because it really is never null. That will mean that non-null asserts around it will become flagged as unnecessary, although right now they are necessary. So, apply a workaround - instead use a function that does a non-null assert without triggering any lints even after it becomes unnecessary.
      71228e02
  8. 09 Jun, 2023 1 commit
    • William Hesse's avatar
      [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (#128335) · 0d39f646
      William Hesse authored
      Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.
      
      This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.
      
      Bug: #127683
      
      - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
      - [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
      - [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
      - [X ] I signed the [CLA].
      - [X ] I listed at least one issue that this PR fixes in the description above.
      - [X ] I updated/added relevant documentation (doc comments with `///`).
      0d39f646
  9. 24 May, 2023 1 commit
  10. 23 May, 2023 1 commit
    • Ian Hickson's avatar
      Give channel descriptions in `flutter channel`, use branch instead of upstream... · 9c7a9e77
      Ian Hickson authored
      Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936)
      
      ## How we determine the channel name
      
      Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time.
      
      I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird.
      
      This PR changes the logic to uses the current branch as the channel name.
      
      ## How we display channels
      
      The main reason this PR exists is to add channel descriptions to the `flutter channel` list:
      
      ```
      ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel
      Flutter channels:
        master (tip of tree, for contributors)
        main (tip of tree, follows master channel)
        beta (updated monthly, recommended for experienced users)
        stable (updated quarterly, for new users and for production app releases)
      * foo_bar
      
      Currently not on an official channel.
      ianh@burmese:~/dev/flutter/packages/flutter_tools$
      ```
      
      ## Other changes
      
      I made a few other changes while I was at it:
      
      * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on.
      * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`.
      * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context.
      * Simplified some of the code.
      * Made some of the tests more strict (checking all output rather than just some aspects of it).
      * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly.
      * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy).
      * Tweaked the help text for the `downgrade` command to be clearer.
      * Removed some misleading text in some error messages.
      * Made the `.metadata` generator consistent with the template file.
      * Removed some obsolete code to do with the `dev` branch.
      
      ## Reviewer notes
      
      I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
      9c7a9e77
  11. 19 May, 2023 1 commit
  12. 16 May, 2023 2 commits
  13. 15 May, 2023 1 commit
  14. 05 May, 2023 1 commit
  15. 03 May, 2023 1 commit
  16. 02 May, 2023 1 commit
  17. 19 Apr, 2023 2 commits
  18. 15 Apr, 2023 1 commit
    • Andrew Kolos's avatar
      [flutter_tools] Remove `Version.unknown` (#124771) · 68ec71f4
      Andrew Kolos authored
      Fixes #124756 by removing the concept of `Version.unknown`.
      
      `Version` fields that needed the ability to represent an unknown version have been made nullable. Assigning `null` to them represents an unknown version.
      68ec71f4
  19. 14 Apr, 2023 1 commit
  20. 05 Apr, 2023 1 commit
    • Reid Baker's avatar
      Add Java-Gradle-AGP validation to flutter analyze (#123916) · 2383400f
      Reid Baker authored
      https://github.com/flutter/flutter/issues/123917
      
      Doc covering a broad set of issues related to android studio updating. 
      
      https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1#
      
      Specifically this pr: 
      - Adds new functions to find a projects AGP, Gradle and java versions,
      and tests.
      - Adds new functions that take versions and parse if the versions are
      compatible with each other, and tests.
      - Adds validator for `flutter analyze --suggestions` that evaluates the
      java/gradle/agp versions and checks if they are compatible, and
      integration test.
      - Updates the version of gradle used by
      dev/integration_tests/flutter_gallery/ to the minimum supported by java
      18 so that the integration tests pass (It is unknown why the java
      version is 18.9 instead of 11)
      - Moves `isWithinVersionRange` to version.dart, and tests. 
      - Adds FakeAndroidStudio to fakes to be used in multiple tests but does
      not remove existing copies.
      
      Metrics will be included as part of the definition of done for this bug
      but not as part of this cl. It is already too big.
      
      Known work still left in this pr: 
      * Understand why analyze integration tests are failing. 
      
      
      Example output if Java and gradle are not compatible: 
      ```
      ┌───────────────────────────────────────────────────────────────────┐
      │ General Info                                                      │
      │ [✓] App Name: espresso_example                                    │
      │ [✓] Supported Platforms: android                                  │
      │ [✓] Is Flutter Package: yes                                       │
      │ [✓] Uses Material Design: yes                                     │
      │ [✓] Is Plugin: no                                                 │
      │ [✗] Java/Gradle/Android Gradle Plugin:                            │
      │                                                                   │
      │ Incompatible Java/Gradle versions.                                │
      │                                                                   │
      │ Java Version: 17.0.6, Gradle Version: 7.0.2                       │
      │                                                                   │
      │ See the link below for more information.                          │
      │ https://docs.gradle.org/current/userguide/compatibility.html#java │
      │                                                                   │
      └───────────────────────────────────────────────────────────────────┘
      ```
      Example output if Gradle and AGP are not compatible
      ```
      ┌─────────────────────────────────────────────────────────────────────────────┐
      │ General Info                                                                │
      │ [✓] App Name: espresso_example                                              │
      │ [✓] Supported Platforms: android                                            │
      │ [✓] Is Flutter Package: yes                                                 │
      │ [✓] Uses Material Design: yes                                               │
      │ [✓] Is Plugin: no                                                           │
      │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions.    │
      │                                                                             │
      │ Gradle Version: 7.0.2, AGP Version: 7.4.2                                   │
      │                                                                             │
      │ Update gradle to at least "7.5".                                            │
      │ See the link below for more information:                                    │
      │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │
      │                                                                             │
      │ Incompatible Java/Gradle versions.                                          │
      │                                                                             │
      │ Java Version: 17.0.6, Gradle Version: 7.0.2                                 │
      │                                                                             │
      │ See the link below for more information:                                    │
      │ https://docs.gradle.org/current/userguide/compatibility.html#java           │
      │                                                                             │
      └─────────────────────────────────────────────────────────────────────────────┘
      ```
      Example output if Java/Gradle/Agp are not compatible. 
      ```
      
      ┌─────────────────────────────────────────────────────────────────────────────┐
      │ General Info                                                                │
      │ [✓] App Name: espresso_example                                              │
      │ [✓] Supported Platforms: android                                            │
      │ [✓] Is Flutter Package: yes                                                 │
      │ [✓] Uses Material Design: yes                                               │
      │ [✓] Is Plugin: no                                                           │
      │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions.    │
      │                                                                             │
      │ Gradle Version: 7.0.2, AGP Version: 7.4.2                                   │
      │                                                                             │
      │ Update gradle to at least "7.5".                                            │
      │ See the link below for more information:                                    │
      │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │
      │                                                                             │
      │ Incompatible Java/Gradle versions.                                          │
      │                                                                             │
      │ Java Version: 17.0.6, Gradle Version: 7.0.2                                 │
      │                                                                             │
      │ See the link below for more information:                                    │
      │ https://docs.gradle.org/current/userguide/compatibility.html#java           │
      │                                                                             │
      └─────────────────────────────────────────────────────────────────────────────┘
      ```
      
      Commit messages
      - Add function to gradle_utils.dart that gets the gradle version from
      wrapper or system and add a test for each situation
      - Add method to get agp version, add method to validate agp against
      gradle version, update documentation, add tests for agp validation.
      - Update dart doc for validateGradleAndAgp to describe where the info
      came from and corner case behavior, create function to validate java and
      gradle and hardcode return to false
      - Fill out and test java gradle compatibility function in gradle_utils
      - Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with
      hardcoded java version
      - Add java --version output parsing and tests
      - Add getJavaBinary test
      - Update comment in android_sdk for mac behavior with java_home -v
      
      ## Pre-launch Checklist
      
      - [x] I read the [Contributor Guide] and followed the process outlined
      there for submitting PRs.
      - [x] I read the [Tree Hygiene] wiki page, which explains my
      responsibilities.
      - [x] I read and followed the [Flutter Style Guide], including [Features
      we expect every widget to implement].
      - [x] I signed the [CLA].
      - [x] I listed at least one issue that this PR fixes in the description
      above.
      - [x] I updated/added relevant documentation (doc comments with `///`).
      - [x] I added new tests to check the change I am making, or this PR is
      [test-exempt].
      - [ ] All existing and new tests are passing.
      2383400f
  21. 29 Mar, 2023 1 commit
  22. 28 Mar, 2023 2 commits
  23. 22 Mar, 2023 1 commit
  24. 21 Mar, 2023 1 commit
  25. 15 Mar, 2023 1 commit
  26. 28 Feb, 2023 1 commit
  27. 27 Feb, 2023 2 commits
  28. 23 Feb, 2023 1 commit
  29. 17 Feb, 2023 3 commits
  30. 15 Feb, 2023 1 commit
    • Ian Hickson's avatar
      Improve network resources doctor check (#120417) · d29668dd
      Ian Hickson authored
      ...and various other minor cleanup:
      
      * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.
      
      * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.
      
      * Made the logger delete the slow warning when it's finished.
      
      * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.
      
      * Added a debug toString to ValidationResult for debugging purposes (not used).
      
      * In http_host_validator:
      
        - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
        - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
        - Renamed the check "Network resources".
        - Updated the `slowWarning` of the check to say which hosts are pending.
        - Removed all timeout logic. Timeouts violate our style guide.
        - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
        - Replaced the `_HostValidationResult` class with `String?` for simplicity.
        - Improved the error messages to be more detailed.
        - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
        - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
        - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
        - Replaced a lot of list-filtering logic with just a single for loop to check the results.
        - Replaced code that added a constant to a known-empty list with just returning a constant list.
        - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
      d29668dd
  31. 13 Feb, 2023 1 commit
  32. 09 Feb, 2023 1 commit
  33. 06 Feb, 2023 1 commit
  34. 03 Feb, 2023 1 commit