1. 16 Feb, 2024 16 commits
    • Andrew Kolos's avatar
    • Tirth's avatar
      Added Missing Field Name in Doc Comment in SnackBarThemeData (#143588) · 1b8742b9
      Tirth authored
      Added Missing Field Name in Doc Comment in SnackBarThemeData.
      1b8742b9
    • Nate's avatar
      Implementing `switch` expressions [refactoring `flutter/lib/src/`] (#143496) · 944cd11d
      Nate authored
      This PR is the 8ᵗʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable.
      
      (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293)
      
      I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring.
      
      This pull request is just the complicated stuff. 😎 I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).
      944cd11d
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from dd530f1556df to 5fd5ccf32d08 (3 revisions) (#143593) · 383067fc
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/dd530f1556df...5fd5ccf32d08
      
      2024-02-16 jason-simmons@users.noreply.github.com Use the Pixel 7/API 33 device in the Firebase test lab script (flutter/engine#50721)
      2024-02-16 leroux_bruno@yahoo.fr [Web] Ignore invalid keyboard events related to autofill (flutter/engine#50590)
      2024-02-16 jason-simmons@users.noreply.github.com Add the web package to the set of Dart third_party packages in DEPS (flutter/engine#50714)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      383067fc
    • engine-flutter-autoroll's avatar
      Roll Packages from ef349bec8ee9 to c56c12dd51ef (5 revisions) (#143581) · d7867ca7
      engine-flutter-autoroll authored
      https://github.com/flutter/packages/compare/ef349bec8ee9...c56c12dd51ef
      
      2024-02-16 10687576+bparrishMines@users.noreply.github.com [tool] Add support for using a Kotlin test runner file (flutter/packages#6131)
      2024-02-16 louisehsu@google.com [in_app_purchase] fix skerror nullability (flutter/packages#6139)
      2024-02-15 jacksongardner@google.com Explicitly pass the web renderer into the tests. (flutter/packages#6140)
      2024-02-15 stuartmorgan@google.com [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141)
      2024-02-15 stuartmorgan@google.com [local_auth] Add compatibility with latest `intl` (flutter/packages#6138)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
      Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      d7867ca7
    • Taha Tesser's avatar
      Update `MaterialStatesController` docs for calling `setState` in a listener (#143453) · a603a178
      Taha Tesser authored
      fixes [Calling `setState` in a `MaterialStatesController` listener and `MaterialStateController.update` causes Exception](https://github.com/flutter/flutter/issues/138986)
      
      ### Description
      `MaterialStatesController` listener  calls `setState` during build when `MaterialStatesController.update` listener calls `notifyListeners`.
      
      I tried fixing this issue by putting `notifyListeners` in a post-frame callback. However, this breaks existing customer tests (particularly super editor tests).
      
      A safer approach would be to document that the listener's `setState` call should be in a post-frame callback to delay it and not call this during the build phase triggered by the `MaterialStatesController.update` in the widgets such as InkWell or buttons.
      a603a178
    • Taha Tesser's avatar
      Update `DataTable` docs for disabled `DataRow` ink well (#143450) · 81297970
      Taha Tesser authored
      fixes [[`DataTable`] Data row does not respond to `MaterialState.hovered`](https://github.com/flutter/flutter/issues/138968)
      81297970
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from b7103bc8b374 to dd530f1556df (17 revisions) (#143565) · 6ee7e24b
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/b7103bc8b374...dd530f1556df
      
      2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709)
      2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708)
      2024-02-16 737941+loic-sharma@users.noreply.github.com [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676)
      2024-02-16 zanderso@users.noreply.github.com [et] Adds a logger (flutter/engine#50693)
      2024-02-15 matanlurey@users.noreply.github.com Update README.md (flutter/engine#50702)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704)
      2024-02-15 tugorez@users.noreply.github.com Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
      2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
      2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
      2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
      2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
      2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
      2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      6ee7e24b
    • Jason Simmons's avatar
      Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65 (#143564) · 6f6950b1
      Jason Simmons authored
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
      2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
      2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
      2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
      2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
      2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
      6f6950b1
    • Jason Simmons's avatar
      Manual roll Flutter Engine from d3c71d78f8ef to df0dc1fc06ca (#143563) · da92f0cf
      Jason Simmons authored
      2024-02-15 30870216+gaaclarke@users.noreply.github.com Added tool to easily check golden diffs locally. (flutter/engine#50654)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 4bbf2060b008 to 12d0b7fac4c3 (2 revisions) (flutter/engine#50689)
      2024-02-15 johnoneil@users.noreply.github.com Provide a matrix inverse shim for GLES 2.0. (flutter/engine#50545)
      2024-02-15 jonahwilliams@google.com [iOS] Ensure FlutterMetalLayer has correct backpressure. (flutter/engine#50486)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 682f0e1e7e77 to 4bbf2060b008 (3 revisions) (flutter/engine#50686)
      2024-02-15 103135467+sealesj@users.noreply.github.com Pin OSV-Scanner reusable workflow (flutter/engine#50649)
      2024-02-15 whesse@google.com Add support for dart_src GN variable to flutter_frontend_server build (flutter/engine#50685)
      2024-02-15 6718144+renancaraujo@users.noreply.github.com fix: consider array size on canvaskit shader data (flutter/engine#49754)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 1277910beec9 to 682f0e1e7e77 (1 revision) (flutter/engine#50683)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 85ab600a9519 to 1277910beec9 (2 revisions) (flutter/engine#50682)
      da92f0cf
    • Jason Simmons's avatar
      Manual roll Flutter Engine from bc4dd534a0fa to d3c71d78f8ef (#143561) · 66bac4ed
      Jason Simmons authored
      2024-02-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mZP8LxbhYHstUxmxd... to fXqP_YC4zTp9G2hA5... (flutter/engine#50680)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from b6201d9c2f73 to 85ab600a9519 (1 revision) (flutter/engine#50679)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from f1b1fa85a1be to 5e442dc80903 (1 revision) (flutter/engine#50678)
      2024-02-15 chinmaygarde@google.com Use a GN variable (dart_src) to reference the location of the Dart checkout. (flutter/engine#50624)
      2024-02-15 matanlurey@users.noreply.github.com Add a &right_filter=params to the Skia Gold links. (flutter/engine#50675)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 2d5cf67614d0 to b6201d9c2f73 (2 revisions) (flutter/engine#50674)
      2024-02-15 matanlurey@users.noreply.github.com Disable Android API v28 tests on CI. (flutter/engine#50672)
      2024-02-15 matanlurey@users.noreply.github.com Use modern concurrency constructs. (flutter/engine#50671)
      2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 322e34dc53f6 to f1b1fa85a1be (1 revision) (flutter/engine#50670)
      2024-02-15 matanlurey@users.noreply.github.com Move boringssl to flutter/third_party. (flutter/engine#50601)
      66bac4ed
    • Jason Simmons's avatar
      Manual roll Flutter Engine from edb2745e9834 to bc4dd534a0fa (#143559) · 7b9f7be7
      Jason Simmons authored
      2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647)
      2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635)
      2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271)
      2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667)
      2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664)
      2024-02-14 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613)
      2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666)
      2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660)
      2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623)
      2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
      7b9f7be7
    • Jason Simmons's avatar
      Manual roll Flutter Engine from 15a358bbaf71 to edb2745e9834 (#143555) · f31205a7
      Jason Simmons authored
      Run engine_tool tests (flutter/engine#50662)
      Refactor, update, and move around `testing/scenario_app/README.md` (flutter/engine#50659)
      Starts a command line tool for assisting engine dev workflows (flutter/engine#50642)
      macOS: add stubs for PlatformView gesture handling (flutter/engine#50630)
      [Impeller] Conditionally use A8 or R8 format glyph atlas based on capabilities. (flutter/engine#50534)
      Roll Dart SDK from e7cfba13d375 to 322e34dc53f6 (1 revision) (flutter/engine#50651)
      Roll Skia from 4235c0421a48 to eae42ea9f7bc (2 revisions) (flutter/engine#50650)
      Roll Skia from ea2fd25220cb to 4235c0421a48 (1 revision) (flutter/engine#50648)
      Roll Dart SDK from 9982d96cebb0 to e7cfba13d375 (1 revision) (flutter/engine#50646)
      Roll Skia from 1e6e2114f15e to ea2fd25220cb (1 revision) (flutter/engine#50643)
      Roll Dart SDK from 032323fa534b to 9982d96cebb0 (1 revision) (flutter/engine#50644)
      Roll Skia from 2aec75cda46e to 1e6e2114f15e (2 revisions) (flutter/engine#50641)
      Roll Skia from b8acfa559db0 to 2aec75cda46e (1 revision) (flutter/engine#50639)
      Roll Fuchsia Linux SDK from l6mWjvlO1xJg5ZFKK... to mZP8LxbhYHstUxmxd... (flutter/engine#50638)
      Roll Skia from 79ec267090bd to b8acfa559db0 (1 revision) (flutter/engine#50636)
      Roll Skia from d650dcaf4b49 to 79ec267090bd (1 revision) (flutter/engine#50634)
      f31205a7
    • Jonah Williams's avatar
      [devicelab] retain prior events for flutter gallery. (#143554) · a22c2305
      Jonah Williams authored
      Capture first frames in gallery benchmarks
      
      Calling https://github.com/flutter/flutter/issues/143404 fixed, since all the full app benchmarks capture the start now.
      
      Fixes https://github.com/flutter/flutter/issues/143404
      a22c2305
    • Martin Kustermann's avatar
      Reland "Disentangle and align flutter build web --wasm flags (#143517)" (#143549) · d4b1b6e7
      Martin Kustermann authored
      Update: Accidentally use `--O4` instead of `-O4` in `dev/devicelab/lib/tasks/web_benchmarks.dart` update.
      
      Original description:
      
      * Make `flutter build web` have one option that determins the
      optimization level: `-O<level>` / `--optimization-level=<level>` =>
      Defaulting to -O4 => Will apply to both dart2js and dart2wasm
      
      * Deprecate `--dart2js-optimization=O<level>`
      
      * Disentagle concept of optimization from concept of static symbols =>
      Add a `--strip-wasm` / `--no-strip-wasm` flag that determins whether
      static symbols are kept in the resulting wasm file.
      
      * Remove copy&past'ed code in the tests for wasm build tests
      
      * Cleanup some artifacts code, now that we no longer use `wasm-opt`
      inside flutter tools
      d4b1b6e7
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 3af336bfb2df to 15a358bbaf71 (1 revision) (#143428) · b769ced7
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/3af336bfb2df...15a358bbaf71
      
      2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from f7e3a5395fe1 to
      d650dcaf4b49 (8 revisions) (flutter/engine#50632)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the
      revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter:
      https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      b769ced7
  2. 15 Feb, 2024 16 commits
  3. 14 Feb, 2024 8 commits