- 15 Oct, 2020 6 commits
-
-
Jonah Williams authored
-
Jay Freeman (saurik) authored
-
Alexandre Ardhuin authored
-
Jonah Williams authored
[devicelab] allow the devicelab to take a screenshot if the iOS connection fails with FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE (#68156) More attempts to remote diagnose the issues in the iOS devicelab
-
Jonah Williams authored
This reverts commit d962c8f2.
-
Jonah Williams authored
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
-
- 14 Oct, 2020 9 commits
-
-
Jenn Magder authored
-
Jenn Magder authored
-
Jonah Williams authored
-
Jenn Magder authored
-
Jonah Williams authored
* [flutter_tools] partial revert of start app change
-
Jenn Magder authored
Revert "[flutter_tools] If run fails to install the application on iOS, try uninstalling it and trying again. (#68078)" (#68118) This reverts commit 61ba7dd2.
-
Jonah Williams authored
[flutter_tools] If run fails to install the application on iOS, try uninstalling it and trying again. (#68078)
-
Jonah Williams authored
Do not allow attach in release mode, as there is not VM Service to connect to. Observed in crash reporting as thrown string which is changed to exception below.
-
Jonah Williams authored
--use-application-binary allows running with an already built APK. This can be useful for speeding up CI test cases, or in our case eventually supporting some sort of build server. Demonstrate that this works by updating the old gallery test to use it. Fixes #56604 Co-authored-by:
Jenn Magder <magder@google.com>
-
- 13 Oct, 2020 8 commits
-
-
Jonah Williams authored
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
-
Jenn Magder authored
-
Jenn Magder authored
-
Jonah Williams authored
This class is entirely superseded by the application package factory. Only drive and install use it, and removing it from drive will allow use-application-binary support.
-
Jonah Williams authored
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE. fixes #67986
-
Nobuhiro Tabuki authored
This PR will update IntelliJ IDEA/Community validation logic for 2020.1 and later on Linux and Windows.
-
Jonah Williams authored
All of the network requests from google cloud storage include an x-goog-hash header which contains an MD5 checksum. If present, use to validate that the downloaded binary is valid. This will rule out corrupt files as the cause of getting started crashers in the flutter_tool. #38980 This does not fully resolve the above issue, because while we can check if the checksum matches what was expected from cloud storage, this A) may not necessarily be present and B) may not match up to what should be uploaded as part of the engine build process. But when life gives you lemons you hash those lemons using an outdated hashing algorithm.
-
Jonah Williams authored
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation. A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered? (9a3a0dc1 caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
-
- 12 Oct, 2020 12 commits
-
-
Jonah Williams authored
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool (#67957)" (#67968) This reverts commit bd813879.
-
Jonah Williams authored
According to https://dart.dev/tools/pub/pubspec#name , uppercase is not permitted for package names.
-
Jonah Williams authored
Reland of #67669 The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. So that we can adjust/modify this logic, fold it into flutter and add some additional logging. caches the resolved executable per target directory, to avoid repeated look ups. Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found Accept files or symlinks for the executable path. user where/which to resolve path instead of package:process logic.
-
Jonah Williams authored
On every hot reload, the flutter tool must file stat each asset in the bundle. With a large number of assets or a slow file system, this can take 20 - 30 ms. Do this operation while the flutter tool is waiting for a response from the frontend_server. No tests updated since this is only a timing update. Any difference in behavior will be shown on benchmarks
-
Jonah Williams authored
This reverts commit 10c78c26.
-
Jonah Williams authored
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
-
Jonah Williams authored
Fixes #61772 tool exit if there is no file at the path provided when building/running with sksl
-
Jonah Williams authored
Work towards #39925 Currently flutter run will uninstall and reinstall if the initial install fails and the APK was previously installed. Allow drive to share this same logic by moving it into installApp and out of startApp. This should reduce the occurrence of the error in the devicelab.
-
Jonah Williams authored
This failure has been happening for a while but was covered by the overly broad catch. Removing that revealed that newer intellij versions have a different plugins file. The tool still can't find the file, but it won't crash now Fixes #67918
-
Sam Rawlins authored
-
Jonah Williams authored
For historical reasons, the flutter tool uploads dill files to paths based on the entrypoint URI. This isn't actually necessary, and the tool can use specific files : main.dart.incremental.dill for incremental dills, and main.dart.dill/main.dart.swap.dill for full dills. This allows hot restarting applications with an entrypoint outside of lib/ and simplifies the devFS code. Fixes #63243
-
Jonah Williams authored
HACKTOBERFEST
-
- 10 Oct, 2020 1 commit
-
-
Jonah Williams authored
Remove flutter create --with-driver-test . Fixes #64095
-
- 09 Oct, 2020 4 commits
-
-
Alexander Markov authored
-
James D. Lin authored
[flutter tools] Add a DelegatingLogger class Move most of `DelegateLogger` `from test/src/testbed.dart` to `lib/src/base/logger.dart` to better formalize the common practice of chaining `Logger`s together. I renamed the class since it isn't itself the delegate and to better match the `Delegating...` classes from `package:collection`. Additionally, add a freestanding `asLogger<T>` function to "cast" a `Logger` into a matching delegate if possible. This will allow `Logger` chains to be ordered a *bit* more freely (e.g. `NotifyingLogger` and `AppRunLogger` will no longer required to be at the end of the chain, an unwritten rule that has led to breakage in google3). Chain order still matters since lack of virtual dispatch means that parent `Logger`s can never invoke child methods, however. I made `asLogger<T>` a freestanding function because I didn't want to make it part of the `Logger` interface (and I thought that making it an extension method might be weird). Bonus cleanup: There no longer appears to be a way to construct an `AppRunLogger` with a null parent, so remove all of code paths for that case and make the `parent` construction parameter required.
-
Jonah Williams authored
If the vm of an attached device rejects a hot reload, pretty print the reason. Suggest a hot restart so that users are aware that they do not have to detach and rebuild. Also resets the last compilation time, so a subsequent restart would still apply the last change. Adds an integration test for the const field removal. Fixes #64027
-
Jonah Williams authored
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get. #29805
-