Commits · 94855a964c748517c095d344221a0ea85c980b78 · abdullh.alsoleman / Front-End

22 Feb, 2024 23 commits

Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (#143986) · 94855a96
Michael Goderbauer authored Feb 22, 2024
```
https://github.com/flutter/engine/pull/50737 broke the tree
```
94855a96
Remove deprecated FlutterDriver.enableAccessibility (#143979) · cbab555d
Kate Lovett authored Feb 22, 2024
```
https://github.com/flutter/flutter/issues/143956
```
cbab555d

Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (#143980) · a8861fb8

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/cb6115d3a6ab...c5d2e011652b

2024-02-22 30870216+gaaclarke@users.noreply.github.com [Impeller] moved the kernel size assert to a more appropriate location. (flutter/engine#50880)
2024-02-22 15619084+vashworth@users.noreply.github.com Build macOS engine as an xcframework (flutter/engine#50300)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (flutter/engine#50878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8861fb8

Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (#143973) · 4715216c
Qun Cheng authored Feb 22, 2024
```
Reverts flutter/flutter#138521
```
4715216c

Add CloseButtonTooltip to the 'X' button on a SnackBar (#143934) · 16535924

dsanagustin authored Feb 22, 2024

Adds a localized Close Button tooltip to the 'X' Button on a SnackBar, making it readable by screen readers.

Github Issue #143793 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

16535924

Bump github/codeql-action from 3.24.3 to 3.24.4 (#143971) · b476e967

dependabot[bot] authored Feb 22, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.3 to 3.24.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li>
<li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li>
</ul>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/e2e140ad1441662206e8f97754b166877dfa1c73"><code>e2e140a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2157">#2157</a> from github/update-v3.24.4-982d9346a</li>
<li><a href="https://github.com/github/codeql-action/commit/5b1ae298f9e2aa0908205f904ebeebebdc74685f"><code>5b1ae29</code></a> Update changelog for v3.24.4</li>
<li><a href="https://github.com/github/codeql-action/commit/982d9346add1ff0ac9db3b764aa5d1007496e9f8"><code>982d934</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2111">#2111</a> from github/nickfyson/first-or-third-party</li>
<li><a href="https://github.com/github/codeql-action/commit/ebda17e8597cc970bf2442f27c6f2a429d14826f"><code>ebda17e</code></a> respond to review comments</li>
<li><a href="https://github.com/github/codeql-action/commit/cca1ddefc0a060bc9070bbddd3a1330c965f7d4f"><code>cca1dde</code></a> Merge branch 'main' into nickfyson/first-or-third-party</li>
<li><a href="https://github.com/github/codeql-action/commit/f32f0bf8e4be601057cf2b42bd296510931d5a6e"><code>f32f0bf</code></a> ensure only the upload-sarif action can submit a status report with first_par...</li>
<li><a href="https://github.com/github/codeql-action/commit/bf8c75ee37169a266fa6b795e1fd1fd9b4a32110"><code>bf8c75e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2153">#2153</a> from github/aeisenberg/add-permissions-doc</li>
<li><a href="https://github.com/github/codeql-action/commit/36c51ac2b5abbdffd22f44a746f1882962308885"><code>36c51ac</code></a> Capitalize Code Scanning</li>
<li><a href="https://github.com/github/codeql-action/commit/a7dc22949666ca49b1add57eb421b6d550ef80d2"><code>a7dc229</code></a> add first_party_analysis boolean to all status reports</li>
<li><a href="https://github.com/github/codeql-action/commit/592977e6ae857384aa79bb31e7a1d62d63449ec5"><code>592977e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2151">#2151</a> from angelapwen/fix-cpu-group-bug</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/379614612a29c9e28f31f39a59013eb8012a51f0...e2e140ad1441662206e8f97754b166877dfa1c73">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.3&new-version=3.24.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

b476e967

Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (#143972) · 0387f62a

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/06448ee8165f...cb6115d3a6ab

2024-02-22 dnfield@google.com Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874)
2024-02-22 15619084+vashworth@users.noreply.github.com Delete and create iOS simulator before running Scenario app test (flutter/engine#50835)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872)
2024-02-22 zanderso@users.noreply.github.com Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865)
2024-02-22 31859944+LongCatIsLooong@users.noreply.github.com Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385)
2024-02-22 jacksongardner@google.com Implement frame timing callbacks in Skwasm. (flutter/engine#50737)
2024-02-22 flar@google.com [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873)
2024-02-22 zanderso@users.noreply.github.com Use RBE on more Windows builders (flutter/engine#50866)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0387f62a

Use inlining annotations on important methods for all targets (#143923) · b09ca497
Martin Kustermann authored Feb 22, 2024

b09ca497

Add missing `TextPainter.strutStyle` to paragraph style (#143771) · 44e440ae

LongCatIsLooong authored Feb 22, 2024

Fixes an issue where if the `TextSpan` doesn't have a text style, the specified strutStyle is not applied.

Additionally, adds a migration flag for https://github.com/flutter/engine/pull/50385, for internal golden changes. It's only going to exist for a week.

44e440ae

Shift Moto G4 staging tests to A02s (#143957) · d13bc10a
Zachary Anderson authored Feb 22, 2024
```
https://github.com/flutter/flutter/issues/143915

cc @yusuf-goog
```
d13bc10a

Add CurvedAnimation disposals in some widgets (#143790) · f0205354

Kostia Sokolovskyi authored Feb 22, 2024

Contributes to https://github.com/flutter/flutter/issues/141198

### Description
- Adds `CurvedAnimation` disposals to `material/chip.dart`, `material/input_decorator.dart`, `material/toggleable.dart`, `widgets/animated_switcher.dart`, `widgets/overscroll_indicator.dart`.

f0205354

Fix documentation typo in basic.dart (#143887) · 9176f7b6
Andrew authored Feb 22, 2024
```
Fixes a small documentation typo.
```
9176f7b6

Fixed Small Typo in Emulators Test Name (#143578) · 3053b6ce

Tirth authored Feb 22, 2024

Fixed Small Typo in Emulators Test Name. I filed #140656 and it was fixed in #142853. I noticed this one there and decided to send a fix.

3053b6ce

Support using lightweight Flutter Engines to run tests (#141726) · dfb5888e

Derek Xu authored Feb 22, 2024

This PR implements the functionality described above and hides it behind
the `--experimental-faster-testing` flag of `flutter test`.

### The following are some performance measurements from test runs
conducted on GitHub Actions

run 1 logs:
https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/1
run 2 logs:
https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/2
run 3 logs:
https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/3

**length of `flutter test --reporter=expanded test/animation
test/foundation` step**

run 1: 54s
run 2: 52s
run 3: 56s

average: 54s

**length of `flutter test --experimental-faster-testing
--reporter=expanded test/animation test/foundation` step**

run 1: 27s
run 2: 27s
run 3: 29s

average: 27.67s (~48.77% shorter than 54s)

**length of `flutter test --reporter=expanded test/animation
test/foundation test/gestures test/painting test/physics test/rendering
test/scheduler test/semantics test/services` step**

run 1: 260s
run 2: 270s
run 3: 305s

average: 278.33s


**length of `flutter test --experimental-faster-testing
--reporter=expanded test/animation test/foundation test/gestures
test/painting test/physics test/rendering test/scheduler test/semantics
test/services` step**

from a clean build (right after deleting the build folder):

run 1: 215s
run 2: 227s
run 3: 245s

average: 229s (~17.72% shorter than 278.33s)

Note that in reality, `test/material` was not passed to `flutter test`
in the trials below. All of the test files under `test/material` except
for `test/material/icons_test.dart` were listed out individually

**length of `flutter test --reporter=expanded test/material` step**

run 1: 408s
run 2: 421s
run 3: 451s

average: 426.67s

**length of `flutter test --experimental-faster-testing
--reporter=expanded test/material` step**

run 1: 382s
run 2: 373s
run 3: 400s

average: 385s (~9.77% shorter than 426.67s)

---------
Co-authored-by: Dan Field <dnfield@google.com>

dfb5888e

Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (#143943) · 44bcc9ce

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/9250bfdb38c5...06448ee8165f

2024-02-22 zanderso@users.noreply.github.com Change "Linux mac_unopt" to "Mac mac_unopt" (flutter/engine#50863)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44bcc9ce

Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (#143946) · f655f592

auto-submit[bot] authored Feb 22, 2024

Reverts flutter/flutter#143799

Initiated by: goderbauer

Reason for reverting: The microbenchmark failed two run two times in a row after this was committed (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755379171959141089/+/u/run_microbenchmarks/stdout).

Original PR Author: bernaferrari

Reviewed By: {goderbauer}

This change reverts the following previous change:
Original Description:
Re-lands https://github.com/flutter/flutter/pull/143542 (which is part 1 of https://github.com/flutter/flutter/pull/138481)

The filename was wrong 🫠

f655f592

Roll Packages from 48048f6bc779 to 078c2a304a01 (11 revisions) (#143935) · b48ae314

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/packages/compare/48048f6bc779...078c2a304a01

2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter from 5129806e to efee280c (47 revisions) (flutter/packages#6180)
2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from bae5e49bc2a8 to abb292a07e20 (1 revision) (flutter/packages#6179)
2024-02-21 louisehsu@google.com [in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165)
2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each (flutter/packages#6109)
2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` (flutter/packages#6059)
2024-02-21 stuartmorgan@google.com [various] Commit Windows build migrations (flutter/packages#6175)
2024-02-21 kevmoo@users.noreply.github.com [flutter_markdown] Support wasm (flutter/packages#6168)
2024-02-21 737941+loic-sharma@users.noreply.github.com [ci] Run Windows Arm64 build tests post-submit (flutter/packages#6166)
2024-02-21 stuartmorgan@google.com [url_launcher] Remove `renderView` usage (flutter/packages#6137)
2024-02-21 b@sdevaan.nl [camera_android_camerax] Fix typo in readme (flutter/packages#6143)
2024-02-21 stuartmorgan@google.com [local_auth] Switch iOS endorsement to `local_auth_darwin` (flutter/packages#6107)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b48ae314

Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (#143933) · 1710a84e

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/7777480eb94d...9250bfdb38c5

2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 0b55d78d32f9 to b9c16065b76d (1 revision) (flutter/engine#50861)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from cbdbcf9bebe6 to 0b55d78d32f9 (1 revision) (flutter/engine#50860)
2024-02-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dLhvv964txwnSlvNw... to j9cJ94K-T1i3u5xGh... (flutter/engine#50858)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from ec119f44e6b9 to cbdbcf9bebe6 (2 revisions) (flutter/engine#50857)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 4aa97aca087c to ec119f44e6b9 (1 revision) (flutter/engine#50849)
2024-02-22 bdero@google.com [Impeller] Add StC color source/clip behavior + constexpr flag for enabling StC. (flutter/engine#50817)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 3fd1a5a7c7c1 to 4aa97aca087c (2 revisions) (flutter/engine#50848)
2024-02-22 matanlurey@users.noreply.github.com Minor non-semantic refactors of `ExternalTexturesFlutterActivity` (flutter/engine#50845)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dLhvv964txwn to j9cJ94K-T1i3

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1710a84e

Reland Add UI Benchmarks (#143542) (#143799) · 063f59fb

Bernardo Ferrari authored Feb 22, 2024

Re-lands https://github.com/flutter/flutter/pull/143542 (which is part 1 of https://github.com/flutter/flutter/pull/138481)

The filename was wrong ð«

063f59fb

Roll Flutter Engine from 7eeb697687d5 to 7777480eb94d (1 revision) (#143913) · 41581c9a

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/7eeb697687d5...7777480eb94d

2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 57490c8d257e to 3fd1a5a7c7c1 (9 revisions) (flutter/engine#50842)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

41581c9a

Roll Flutter Engine from bf5c003085fd to 7eeb697687d5 (16 revisions) (#143911) · efee280c

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/bf5c003085fd...7eeb697687d5

2024-02-22 tugorez@users.noreply.github.com Add view focus direction detection to flutter web. (flutter/engine#50843)
2024-02-22 matanlurey@users.noreply.github.com Add a similar `runIf` guard to `web_engine` as web framework. (flutter/engine#50846)
2024-02-22 dkwingsmt@users.noreply.github.com Add scheduleWarmUpFrame (flutter/engine#50570)
2024-02-22 matanlurey@users.noreply.github.com Remove/reduce unused or private methods and add tests to `SkiaGoldClient` (flutter/engine#50844)
2024-02-22 matanlurey@users.noreply.github.com Clean up contributing formatting, add a Skia gold callout (flutter/engine#50828)
2024-02-21 34871572+gmackall@users.noreply.github.com Make Android Studio be able to run android embedding unit tests out of the box (flutter/engine#50840)
2024-02-21 zanderso@users.noreply.github.com Shift some deps to //flutter/third_party (flutter/engine#50830)
2024-02-21 tugorez@users.noreply.github.com Make the view focus binding report focus transitions across elements. (flutter/engine#50610)
2024-02-21 chris@bracken.jp [macOS] Wrap FlutterEngineTest in autoreleasepool (flutter/engine#50832)
2024-02-21 jason-simmons@users.noreply.github.com Update the vulkan_glfw sample for the latest roll of vulkan-deps (flutter/engine#50839)
2024-02-21 skia-flutter-autoroll@skia.org Roll Skia from 8fa858855820 to 57490c8d257e (6 revisions) (flutter/engine#50833)
2024-02-21 zanderso@users.noreply.github.com Starts a .ci.yaml parser (flutter/engine#50783)
2024-02-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f344e2266468 to 0f0f7400c38a (6 revisions) (flutter/engine#50837)
2024-02-21 737941+loic-sharma@users.noreply.github.com [Windows] Fix top-level message procedure order (flutter/engine#50797)
2024-02-21 john@johnmccutchan.com Tweak verbose log messages in ImageReaderSurfaceProducer (flutter/engine#50831)
2024-02-21 matanlurey@users.noreply.github.com Add a throw statement for imgtestAdd non 0 exit codes. (flutter/engine#50829)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efee280c

Update PR template for dart fix (#143879) · de97a050

Kate Lovett authored Feb 22, 2024

I don't know if this is feasible, but figured it was worth seeing.
Often times dart fixes are forgotten as part of the code review process.
I know some people ignore the PR template, but considered maybe a mention was warranted.

I've made the change reflected below:

de97a050

Re-use methods to calculate leading and trailing garbage in RenderSliverMultiBoxAdaptor (#143884) · f97978f9

Kate Lovett authored Feb 22, 2024

My RenderSliverMultiBoxAdaptor/RenderSliverFixedExtentList/RenderSliverVariedExtentList yak shave continues.

I've been subclassing RenderSliverVariedExtentList for SliverTree and have found some opportunities for clean up.
There is a larger clean up I'd like to do, but this week SliverTree comes first.

I noticed these methods were getting repeated ð, and I was about to repeat them again ð for the tree, so I figured bumping them up to the base class was better than continuing to copy-paste the same methods.

f97978f9

21 Feb, 2024 17 commits

Reverts "[Impeller] Make impeller goldens test blocking. (#143864)" (#143896) · c3e786f3

auto-submit[bot] authored Feb 21, 2024

Reverts flutter/flutter#143864

Initiated by: goderbauer

Reason for reverting: The test is consistently failing in post-submit, e.g. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755443299639610049/+/u/run_test.dart_for_framework_tests_shard_and_subshard_impeller/stdout

Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.

c3e786f3

[Impeller] Make impeller goldens test blocking. (#143864) · 0be66684

Jonah Williams authored Feb 21, 2024

Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.

0be66684

Disable color filter sepia test for Impeller. (#143861) · d699bcb4
Jonah Williams authored Feb 21, 2024
```
This test is still unstable with the debug banner disabled. the Icon in the FAB appears to be shifting.
```
d699bcb4

Roll Flutter Engine from 52ffcaadea41 to bf5c003085fd (12 revisions) (#143875) · 9ed5496c

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/52ffcaadea41...bf5c003085fd

2024-02-21 skia-flutter-autoroll@skia.org Roll Skia from 9d86359b5fe8 to 8fa858855820 (15 revisions) (flutter/engine#50827)
2024-02-21 matanlurey@users.noreply.github.com Add the `scenario_app` `'solid_blue'` golden to the Android test suite (flutter/engine#50801)
2024-02-21 matanlurey@users.noreply.github.com Ignore EOF newline characters and added tests to `dir_contents_diff` tool (flutter/engine#50805)
2024-02-21 jason-simmons@users.noreply.github.com Make the GL context current in EmbedderSurfaceGLImpeller before creating the GPU surface (flutter/engine#50807)
2024-02-21 matanlurey@users.noreply.github.com Fail engine post-submit on skia-gold comparions. (flutter/engine#50826)
2024-02-21 34871572+gmackall@users.noreply.github.com Remove WindowManager reflection in SingleViewPresentation.java (flutter/engine#49996)
2024-02-21 30870216+gaaclarke@users.noreply.github.com [Impeller] applied the lerp hack to blur (roughly 2x speedup?) (flutter/engine#50790)
2024-02-21 jason-simmons@users.noreply.github.com Migrate the Fuchsia embedder to the Dart_RecordTimelineEvent API (flutter/engine#50823)
2024-02-21 john@johnmccutchan.com Hook ImageReaderSurfaceProducer to the onTrimMemory listener interface (flutter/engine#50792)
2024-02-21 matanlurey@users.noreply.github.com Fix the local-only lint errors due to an unexpected `GeneratedPluginRegistrant.java` (flutter/engine#50795)
2024-02-21 jonahwilliams@google.com [Impeller] cache onscreen render targets. (flutter/engine#50751)
2024-02-21 zanderso@users.noreply.github.com Use 'et format' in CI. Check formatting of all files in CI (flutter/engine#50810)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9ed5496c

Roll Flutter Engine from 4128895d79a1 to 52ffcaadea41 (1 revision) (#143862) · c1a1c47c

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/4128895d79a1...52ffcaadea41

2024-02-21 jonahwilliams@google.com [Impeller] force bootstrap render pass. (flutter/engine#50749)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c1a1c47c

Deprecate redundant itemExtent in RenderSliverFixedExtentBoxAdaptor methods (#143412) · 09e0e1b8

Kate Lovett authored Feb 21, 2024

Multiple methods in `RenderSliverFixedExtentBoxAdaptor` pass a `double itemExtent` for computing things like what children will be laid out, what the max scroll offset will be, and how the children will be laid out.

Since `RenderSliverFixedExtentBoxAdaptor` was further subclassed to support a `itemExtentBuider` in `RenderSliverVariedExtentList`, these itemExtent parameters became useless when using that RenderObject. Reading through `RenderSliverFixedExtentBoxAdaptor.performLayout`, the remaining artifacts of passing around itemExtent make it hard to follow when it is irrelevant. 

`RenderSliverFixedExtentBoxAdaptor.itemExtent` is available from these methods, so it does not need to pass it. It is redundant API.

Plus, if a bogus itemExtent is passed for some reason, errors will ensue and the layout will be incorrect. ð£ ð¥ 

Deprecating so we can remove these for a cleaner API. Unfortunately this is not supported by dart fix, but the fact that these methods are protected means usage outside of the framework is likely minimal.

09e0e1b8

Add aab as alias for appbundle (#143855) · b09a015f
Reid Baker authored Feb 21, 2024
```
- **Fix #143778 add aab as alias to appbundle**

Fixes #143778
```
b09a015f

Roll Flutter Engine from e16f43eeaaa4 to 4128895d79a1 (1 revision) (#143856) · bfeaf5a7

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/e16f43eeaaa4...4128895d79a1

2024-02-21 matanlurey@users.noreply.github.com Disallow files additional named `GeneratedPluginRegistrant.java`. (flutter/engine#50796)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfeaf5a7

Roll Packages from 8bba41b0c046 to 48048f6bc779 (2 revisions) (#143853) · 4aecbf91

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/packages/compare/8bba41b0c046...48048f6bc779

2024-02-20 ditman@gmail.com [google_sign_in_web] Updates package:web dependency to 0.5.0. (flutter/packages#6167)
2024-02-20 kevmoo@users.noreply.github.com [web] Updates package:web dependency to ^0.5.0. (flutter/packages#5791)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4aecbf91

Update `hourMinuteTextStyle` defaults for Material 3 Time Picker (#143749) · 3403ca41

Taha Tesser authored Feb 21, 2024

fixes [`hourMinuteTextStyle` Material 3 default doesn't match the specs](https://github.com/flutter/flutter/issues/143748)

This updates `hourMinuteTextStyle` defaults to match Material 3 specs. `hourMinuteTextStyle` should use different font style for different entry modes based on the specs.

### Specs
![Screenshot 2024-02-20 at 15 06 40](https://github.com/flutter/flutter/assets/48603081/5198a5da-314d-401e-8d7f-d4a68b86e43c)
![Screenshot 2024-02-20 at 15 07 22](https://github.com/flutter/flutter/assets/48603081/79436ce4-fef6-480a-bc43-b628497e860f)

### Before
```dart
 return _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states));
```
### After 
```dart
      return entryMode == TimePickerEntryMode.dial
        ? _textTheme.displayLarge!.copyWith(color: _hourMinuteTextColor.resolve(states))
        : _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states));
```

3403ca41

Roll Flutter Engine from 93063f61943a to e16f43eeaaa4 (2 revisions) (#143827) · 35fd7062

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/93063f61943a...e16f43eeaaa4

2024-02-21 bdero@google.com [Impeller] Add GeometryResult enum with StC modes. (flutter/engine#50816)
2024-02-21 bdero@google.com Update impeller-cmake-example (flutter/engine#50808)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35fd7062

Roll Flutter Engine from ed49634486e9 to 93063f61943a (1 revision) (#143826) · ca05958f

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/ed49634486e9...93063f61943a

2024-02-21 bdero@google.com [Impeller] Remove non-Flutter fill types from impeller::Path. (flutter/engine#50814)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca05958f

`CalendarDatePicker` doesn't announce selected date on desktop (#143583) · 5d2353c1

Taha Tesser authored Feb 21, 2024

fixes [Screen reader is not announcing the selected date as selected on DatePicker](https://github.com/flutter/flutter/issues/143439)

### Descriptions
- This fixes an issue where `CalendarDatePicker` doesn't announce selected date on desktop.
- Add semantic label to describe the selected date is indeed "Selected".

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  MyHomePageState createState() => MyHomePageState();
}

class MyHomePageState extends State<MyHomePage> {
  void _showDatePicker() async {
    await showDatePicker(
      context: context,
      initialDate: DateTime.now(),
      firstDate: DateTime(1900),
      lastDate: DateTime(2200),
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title,
            style: const TextStyle(fontFamily: 'ProductSans')),
      ),
      body: const Center(
        child: Text('Click the button to show date picker.'),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _showDatePicker,
        tooltip: 'Show date picker',
        child: const Icon(Icons.edit_calendar),
      ),
    );
  }
}

// import 'package:flutter/material.dart';

// void main() => runApp(const MyApp());

// class MyApp extends StatelessWidget {
//   const MyApp({super.key});

//   @override
//   Widget build(BuildContext context) {
//     return MaterialApp(
//       debugShowCheckedModeBanner: false,
//       home: Scaffold(
//         body: Center(
//           child: CalendarDatePicker(
//             initialDate: DateTime.now(),
//             firstDate: DateTime(2020),
//             lastDate: DateTime(2050),
//             onDateChanged: (date) {
//               print(date);
//             },
//           ),
//         ),
//       ),
//     );
//   }
// }
```

</details>

### Before

https://github.com/flutter/flutter/assets/48603081/c82e1f15-f067-4865-8a5a-1f3c0c8d91da

### After

https://github.com/flutter/flutter/assets/48603081/193d9e26-df9e-4d89-97ce-265c3d564607

5d2353c1

Roll Flutter Engine from 9100d326475a to ed49634486e9 (2 revisions) (#143824) · a41868e5

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/9100d326475a...ed49634486e9

2024-02-21 bdero@google.com [Impeller] Apply Entity depth in filter shaders that may render directly to an EntityPass. (flutter/engine#50742)
2024-02-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gKg6HlBeR52y-cMhu... to dLhvv964txwnSlvNw... (flutter/engine#50813)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gKg6HlBeR52y to dLhvv964txwn

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a41868e5

Add `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle` for... · 95cdebed

Taha Tesser authored Feb 21, 2024

Add `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle`  for Material 3 Time Picker (#143739)

fixes [`Time selector separator` in TimePicker is not centered vertically](https://github.com/flutter/flutter/issues/143691)

Separator currently `hourMinuteTextStyle` to style itself.

This introduces `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle` from Material 3 specs to correctly style  the separator. This also adds ability to change separator color without changing `hourMinuteTextColor`.

### Specs for the time selector separator
https://m3.material.io/components/time-pickers/specs
![image](https://github.com/flutter/flutter/assets/48603081/0c84f649-545d-441b-adbf-2b9ec872b14c)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const App());
}

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        // timePickerTheme: TimePickerThemeData(
        //   hourMinuteTextColor: Colors.amber,
        // )
      ),
      home: Scaffold(
        body: Center(
          child: Builder(builder: (context) {
            return ElevatedButton(
              onPressed: () async {
                await showTimePicker(
                  context: context,
                  initialTime: TimeOfDay.now(),
                );
              },
              child: const Text('Pick Time'),
            );
          }),
        ),
      ),
    );
  }
}

```

</details>

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/20beeba4-5cc2-49ee-bba8-1c552c0d1e44" /> | <img src="https://github.com/flutter/flutter/assets/48603081/24927187-aff7-4191-930c-bceab6a4b4c2" /> |

95cdebed

Roll Flutter Engine from efc69946cb1e to 9100d326475a (2 revisions) (#143820) · f9233756

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/efc69946cb1e...9100d326475a

2024-02-21 leroux_bruno@yahoo.fr [Web] Update modifier state when Meta key is seen as Process key (flutter/engine#50779)
2024-02-21 jason-simmons@users.noreply.github.com Add pub.dev to the hosted package URIs checked by the pub_get_offline script (flutter/engine#50811)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9233756

Roll Flutter Engine from 700250436e3f to efc69946cb1e (2 revisions) (#143816) · e9f3244e

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/700250436e3f...efc69946cb1e

2024-02-21 zanderso@users.noreply.github.com Make global builds uniquely named per platform (flutter/engine#50764)
2024-02-21 zanderso@users.noreply.github.com [et] Adds a format command (flutter/engine#50747)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9f3244e