1. 21 Aug, 2019 1 commit
  2. 19 Aug, 2019 2 commits
  3. 31 Jul, 2019 1 commit
  4. 26 Jul, 2019 2 commits
  5. 19 Jul, 2019 1 commit
  6. 16 Jul, 2019 1 commit
    • liyuqian's avatar
      Fix flaky peer connection (#36089) · 180aa0c0
      liyuqian authored
      Fixes https://github.com/flutter/flutter/issues/36091.
      
      Previously, a sendRequest will be sent even if the peer is closed during
      a driver test. That will cause a time out without any error information.
      Such issue is unreproducible on my Mac Book Pro, but 100% reproducible
      on our new Mac mini (2018).
      
      The closing issue is tracked in https://github.com/flutter/flutter/issues/36268
      
      Additional to this fix, we should also patch the jason_rpc_2 so the peer
      will throw exception if sendRequest is attempted while the connection is
      closed.
      
      **Test**:
      tiles_scroll_perf_iphonexs__timeline_summary failed without this patch.
      It will pass after this patch.
      
      I'm not sure how to add a unit test for this. Please let me know if you have
      some ideas.
      
      This patch will generate the following warning log on the new Mac Mini
      ```
      flutter: Observatory listening on http://127.0.0.1:50192/cZPDF4sW7MM=/  
      Installing and launching...                                        10.2s
      00:00 +0: scrolling performance test (setUpAll)
      [info ] FlutterDriver: Connecting to Flutter application at http://127.0.0.1:1069/cZPDF4sW7MM=/
      [trace] FlutterDriver: Isolate found with number: 3684677742843303
      [trace] FlutterDriver: Isolate is paused at start.
      [trace] FlutterDriver: Attempting to resume isolate
      [trace] FlutterDriver: Waiting for service extension
      [info ] FlutterDriver: Connected to Flutter application.
      00:00 +0: scrolling performance test complex_layout_scroll_perf
      [warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
      [warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
      00:10 +1: scrolling performance test tiles_scroll_perf
      [warning] FlutterDriver: Instance of '_WebSocketImpl' is closed with an unexpected code 1005
      [warning] FlutterDriver: Peer connection is closed! Trying to restore the connection...
      00:20 +2: scrolling performance test (tearDownAll)
      00:20 +2: All tests passed!
      Stopping application instance.
      ```
      180aa0c0
  7. 02 Jul, 2019 1 commit
  8. 19 Jun, 2019 1 commit
  9. 31 May, 2019 1 commit
  10. 29 May, 2019 1 commit
  11. 20 May, 2019 1 commit
  12. 14 May, 2019 1 commit
  13. 10 May, 2019 2 commits
  14. 09 May, 2019 1 commit
  15. 04 May, 2019 1 commit
  16. 01 May, 2019 1 commit
  17. 30 Apr, 2019 2 commits
  18. 25 Apr, 2019 1 commit
  19. 19 Apr, 2019 1 commit
  20. 10 Apr, 2019 1 commit
  21. 22 Mar, 2019 1 commit
  22. 19 Mar, 2019 1 commit
  23. 09 Mar, 2019 1 commit
  24. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  25. 21 Feb, 2019 1 commit
  26. 16 Feb, 2019 1 commit
  27. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  28. 09 Jan, 2019 1 commit
    • Andrew Davies's avatar
      [flutter_driver] Move Fuchsia logging code. (#26266) · bd6ac326
      Andrew Davies authored
      When setting the Fuchsia logging function, it should happen before any
      initialization code, as init can still cause warning/error/info messages
      to get printed to logs. Since the default stderr/stdout fd's aren't
      correct, this can cause a program to crash for unclear reasons.
      bd6ac326
  29. 07 Jan, 2019 1 commit
  30. 21 Dec, 2018 2 commits
    • Ian Hickson's avatar
      Revert "[O] Remove many timeouts. (#23531)" (#25646) · 8426910a
      Ian Hickson authored
      This reverts commit 76f70810.
      8426910a
    • Ian Hickson's avatar
      [O] Remove many timeouts. (#23531) · 76f70810
      Ian Hickson authored
      * Remove many timeouts.
      
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      
      * Get the attach tests to pass.
      
      * Apply review comments from Todd
      
      * More review comment fixes
      
      * Put back the extended timeouts here now that I know why we have them...
      76f70810
  31. 15 Nov, 2018 1 commit
  32. 21 Oct, 2018 1 commit
  33. 16 Oct, 2018 1 commit
  34. 08 Oct, 2018 1 commit
  35. 04 Oct, 2018 1 commit