- 23 May, 2023 1 commit
-
-
Ian Hickson authored
Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936) ## How we determine the channel name Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time. I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird. This PR changes the logic to uses the current branch as the channel name. ## How we display channels The main reason this PR exists is to add channel descriptions to the `flutter channel` list: ``` ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel Flutter channels: master (tip of tree, for contributors) main (tip of tree, follows master channel) beta (updated monthly, recommended for experienced users) stable (updated quarterly, for new users and for production app releases) * foo_bar Currently not on an official channel. ianh@burmese:~/dev/flutter/packages/flutter_tools$ ``` ## Other changes I made a few other changes while I was at it: * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on. * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`. * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context. * Simplified some of the code. * Made some of the tests more strict (checking all output rather than just some aspects of it). * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly. * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy). * Tweaked the help text for the `downgrade` command to be clearer. * Removed some misleading text in some error messages. * Made the `.metadata` generator consistent with the template file. * Removed some obsolete code to do with the `dev` branch. ## Reviewer notes I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
-
- 06 Sep, 2022 1 commit
-
-
Liam Appelbe authored
* Migrate packages/flutter_tools/test/commands.shard/hermetic, part 2/3 * Fix tests * Fix analysis * Chris's comments
-
- 27 Apr, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 Jan, 2022 1 commit
-
-
Christopher Fujino authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 14 May, 2021 1 commit
-
-
Jonah Williams authored
-
- 07 Apr, 2021 1 commit
-
-
Jenn Magder authored
-
- 15 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 05 Mar, 2021 1 commit
-
-
Jonah Williams authored
[flutter_tools] replace MockFlutterVersion usage with fake where possible, move from context (#77390)
-
- 08 Feb, 2021 1 commit
-
-
Jonah Williams authored
This reverts commit 8b6baae4.
-
- 04 Feb, 2021 1 commit
-
-
Jonah Williams authored
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 13 Oct, 2020 1 commit
-
-
Jonah Williams authored
This class is entirely superseded by the application package factory. Only drive and install use it, and removing it from drive will allow use-application-binary support.
-
- 03 Mar, 2020 1 commit
-
-
Jonah Williams authored
-
- 13 Feb, 2020 1 commit
-
-
Jonah Williams authored
-