1. 11 Feb, 2020 4 commits
    • Greg Spencer's avatar
      Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235) · 8ef5e2f0
      Greg Spencer authored
      This change adds a way to provide explicit focus order for a part of the widget tree.
      
      It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.
      
      It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.
      
      As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.
      
      I was able to do this without breaking the API (AFAICT).
      8ef5e2f0
    • Gary Qian's avatar
    • Christopher Fujino's avatar
    • Amir Hardon's avatar
  2. 10 Feb, 2020 18 commits
  3. 08 Feb, 2020 5 commits
  4. 07 Feb, 2020 13 commits
    • jimshepherd's avatar
      Use state value in DropdownButtonFieldForm (#37145) · 92a335e4
      jimshepherd authored
      The current implementation of DropdownButtonFormField does not pass the initial value to _DropdownButtonFormFieldState. As a result changes made through the child DropdownButton are not made to the FormFieldState and the widget is not updated unless a onChanged function is provided to the DropdownButtomFormField constructor.
      
      This change modifies DropdownButtonFormField to behave more consistently with other FormField widgets in how the Form state is handled.
      92a335e4
    • Jenn Magder's avatar
    • engine-flutter-autoroll's avatar
      Roll engine f3ce90e9387b..580503c35926 (24 commits) (#50363) · ef74572e
      engine-flutter-autoroll authored
      * 71ec0a181 Relax timing restrictions on WakeUpTimersAreSingletons. (flutter/engine#16446)
      
      * 3ac1e6d8b Disable unit tests using --gtest-filter instead of at compile time (flutter/engine#16472)
      
      * 80be2c43e Fix RasterCache LRU logic, opportunistic simplifications. (flutter/engine#16434)
      
      * ca40f11ee Roll src/third_party/skia 7f36405ea3ec..c0360582d211 (6 commits) (flutter/engine#16476)
      
      * c9e7713b5 Fix analyzer warnings for frontend_server change (flutter/engine#16470)
      
      * 9ada1b0e0 Fix elf_loader.cc on Fuchsia, add a TODO for proper fix
      
      * 051762798 Enable runtime_unittests on Fuchsia
      
      * 03f639e12 Add noexcept annotations to EnableValue moves (flutter/engine#16478)
      
      * 00904dd96 Various fixes in CanvasKit (flutter/engine#16433)
      
      * de7022b3b Roll src/third_party/skia c0360582d211..121750c2efff (7 commits) (flutter/engine#16479)
      
      * d2aab27b4 Enable shell_unittests on Fuchsia with Vulkan dependencies. (flutter/engine#16376)
      
      * eec73e3a7 Roll src/third_party/dart b3396cbdcae1..49850e6919f7 (45 commits) (flutter/engine#16480)
      
      * 557f3a2d2 Run Flutter framework tests against the web engine in Cirrus (flutter/engine#16343)
      
      * 477527b3f Roll src/third_party/skia 121750c2efff..046f9893b953 (4 commits) (flutter/engine#16482)
      
      * eb8691f2a Code cleanup on destructors (flutter/engine#16481)
      
      * 73978177e Roll fuchsia/sdk/core/linux-amd64 from A9STP... to g2s3c... (flutter/engine#16484)
      
      * 313527d2e Roll src/third_party/dart 49850e6919f7..16782e6c171f (16 commits) (flutter/engine#16485)
      
      * 83feaf4fc Roll src/third_party/skia 046f9893b953..97bf6578796c (1 commits) (flutter/engine#16486)
      
      * 918405870 Roll src/third_party/skia 97bf6578796c..f3560b680e35 (1 commits) (flutter/engine#16487)
      
      * 0db017d09 Roll src/third_party/dart 16782e6c171f..d765d237460d (1 commits) (flutter/engine#16488)
      
      * f9ed07cf5 Roll fuchsia/sdk/core/linux-amd64 from g2s3c... to LvSlH... (flutter/engine#16489)
      
      * a1b91dad7 Roll src/third_party/skia f3560b680e35..77fdf66946d2 (1 commits) (flutter/engine#16490)
      
      * 7edb803b6 Roll src/third_party/dart d765d237460d..514a8d4c8417 (7 commits) (flutter/engine#16491)
      
      * 580503c35 Roll src/third_party/skia 77fdf66946d2..87e3bef6f82f (2 commits) (flutter/engine#16492)
      ef74572e
    • Mouad Debbar's avatar
    • Jenn Magder's avatar
      4411d8e6
    • Christopher Fujino's avatar
    • Shi-Hao Hong's avatar
      Remove redundant gen_l10n tests (#50301) · 5dfa8e9c
      Shi-Hao Hong authored
      5dfa8e9c
    • Jenn Magder's avatar
      Revert "Update minimum version to Xcode 11.0 (#50315)" (#50369) · 48a9bd56
      Jenn Magder authored
      This reverts commit 2b7582ef.
      48a9bd56
    • Jenn Magder's avatar
      2b7582ef
    • Dan Field's avatar
      Disable tests using gauge (#50367) · 9348aea0
      Dan Field authored
      9348aea0
    • engine-flutter-autoroll's avatar
      Roll engine f34bc65bee49..f3ce90e9387b (20 commits) (#50305) · fc2c0af4
      engine-flutter-autoroll authored
      * d5442b86e Roll src/third_party/skia bc3307c395e2..ebc00f97fab1 (21 commits) (flutter/engine#16429)
      
      * 76b291a65 Added a plugin method that gets called when the engine is about to be deleted (flutter/engine#16336)
      
      * 07f25c51e fix bad reference to maxDiffRatePercent (flutter/engine#16440)
      
      * 41d50c220 Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (flutter/engine#16365)
      
      * f25d325b1 [fuchsia] change kMaxFramesInFlight to 3 (flutter/engine#16425)
      
      * 473f55940 Suppress some deprecation warnings on Windows (flutter/engine#16416)
      
      * 2e34ad6b7 Roll fuchsia/sdk/core/mac-amd64 from ubThi... to fvWgE... (flutter/engine#16454)
      
      * 47c02e6fc Roll src/third_party/skia ebc00f97fab1..cbf79b95c2d4 (4 commits) (flutter/engine#16456)
      
      * 3d1b112d7 Roll buildroot (flutter/engine#16419)
      
      * 28e663726 Add explicit casts to printing of function pointers (flutter/engine#16370)
      
      * 9ad81dae1 Wrap strdup to use compliant name on Windows (flutter/engine#16372)
      
      * 9708e5274 Roll rapidjson (flutter/engine#16347)
      
      * f06ebba3e Include <memory> in hb_wrapper.h because unique_ptr is used. (flutter/engine#16442)
      
      * e530376fb Roll fuchsia/sdk/core/linux-amd64 from VJv0H... to A9STP... (flutter/engine#16457)
      
      * 4cc41ae97 Roll src/third_party/skia cbf79b95c2d4..4721e067812f (1 commits) (flutter/engine#16459)
      
      * 2f233edf5 Roll src/third_party/skia 4721e067812f..f6e3eaf05150 (1 commits) (flutter/engine#16461)
      
      * b0b0ed83b Roll src/third_party/skia f6e3eaf05150..cc21d0c1f2ce (1 commits) (flutter/engine#16463)
      
      * 7fea936a0 Roll src/third_party/skia cc21d0c1f2ce..116b33e8ab21 (3 commits) (flutter/engine#16466)
      
      * 001b3a0b1 Roll src/third_party/skia 116b33e8ab21..7f36405ea3ec (3 commits) (flutter/engine#16471)
      
      * f3ce90e93 Reset width/height before deallocation for Safari allocation bug. (flutter/engine#16469)
      fc2c0af4
    • Tong Mu's avatar
      Change definition of offset to object (#50157) · 324a2168
      Tong Mu authored
      324a2168
    • Dan Field's avatar
      26271223