Commits · 8e3b7a9cb5d1e4558d97fa6024ceff17986903ca · abdullh.alsoleman / Front-End

30 Sep, 2023 12 commits

Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (#135801) · 8e3b7a9c

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/d814c69abe26...4ed733d99cd5

2023-09-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vSGsxh_81aaf5CdfW... to DEmzJ6vnZAAUzsm81... (flutter/engine#46438)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from vSGsxh_81aaf to DEmzJ6vnZAAU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e3b7a9c

Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (#135799) · d0a5bc62

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/f726438d4d65...d814c69abe26

2023-09-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from U0lgvzao-MdzfEvoT... to ZDxyy9-hcaVyv65as... (flutter/engine#46437)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from U0lgvzao-Mdz to ZDxyy9-hcaVy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0a5bc62

Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (#135796) · ba1d6147

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/0b96a82cc874...f726438d4d65

2023-09-30 skia-flutter-autoroll@skia.org Roll Skia from a063eaeaf1e0 to 20a431090e24 (1 revision) (flutter/engine#46436)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba1d6147

Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (#135793) · 10e9b63b

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/f3a4cab69962...0b96a82cc874

2023-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 9aca08d40398 to 4574906880c1 (1 revision) (flutter/engine#46435)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

10e9b63b

Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (#135792) · f6e3dae0

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/e719b7957763...f3a4cab69962

2023-09-30 jason-simmons@users.noreply.github.com [Impeller] Apply the transform to PointFieldGeometry coverage (flutter/engine#46428)
2023-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 0931bb8a43c8 to 9aca08d40398 (1 revision) (flutter/engine#46432)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6e3dae0

Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (#135789) · 853bd95d

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/8939f9c1f4e4...e719b7957763

2023-09-30 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed subpass filter coverage with image filters (flutter/engine#46431)
2023-09-30 john@johnmccutchan.com Add an AndroidManifest.xml flag to disable ImageReader backed Platform Views (flutter/engine#46430)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

853bd95d

Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (#135788) · f7dface9

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/6a13607008ed...8939f9c1f4e4

2023-09-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mR_mhiacGiD-ObsoG... to vSGsxh_81aaf5CdfW... (flutter/engine#46427)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from mR_mhiacGiD- to vSGsxh_81aaf

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7dface9

Add device ready check (#135526) · 4e5e47e7

Ricardo Amador authored Sep 30, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/121420

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

4e5e47e7

Temporarily disable NexusLowRes, version=29 (#135785) · d7739dff

Ricardo Amador authored Sep 30, 2023

There are too many flakes to leave this version enabled. Temporarily disabled and following up with FTL.

*List which issues are fixed by this PR. You must list at least one issue.*
Related to https://github.com/flutter/flutter/issues/135784

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

d7739dff

Cover more test/widgets tests with leak tracking #12. (#135385) · 95eae5f9
Kostia Sokolovskyi authored Sep 30, 2023

95eae5f9
DraggableScrollableController should dispatch creation in constructor. (#135423) · fdde2419
Kostia Sokolovskyi authored Sep 30, 2023

fdde2419

Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (#135780) · 0f5cc2c0

engine-flutter-autoroll authored Sep 30, 2023

https://github.com/flutter/engine/compare/d203e349781c...6a13607008ed

2023-09-29 chillers@google.com Disable enableHardwareBufferRenderingTarget (flutter/engine#46425)
2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vbw3Gwj-6eN7rSqb4... to U0lgvzao-MdzfEvoT... (flutter/engine#46424)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from vbw3Gwj-6eN7 to U0lgvzao-Mdz

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0f5cc2c0

29 Sep, 2023 21 commits

Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (#135776) · e7368213

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/48973d7f9beb...d203e349781c

2023-09-29 dkwingsmt@users.noreply.github.com Multi-view Rasterizer (flutter/engine#45512)
2023-09-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 955a3a964621 to 0931bb8a43c8 (1 revision) (flutter/engine#46423)
2023-09-29 jonahwilliams@google.com [Impeller] Redo simplify invert colors. (flutter/engine#46416)
2023-09-29 jacksongardner@google.com Use `dart:_wasm` constructs to avoid dependence on `WebAssembly.Function` (flutter/engine#46388)
2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 2d4045f55fd5 to a063eaeaf1e0 (6 revisions) (flutter/engine#46420)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e7368213

ViewportOffset should dispatch creation in constructor. (#135420) · a11b21db
Kostia Sokolovskyi authored Sep 29, 2023

a11b21db

Use platform dill from the engine when compiling with dart2wasm. (#134970) · 9f4f6c47

Jackson Gardner authored Sep 29, 2023

This is the final change needed to address https://github.com/flutter/flutter/issues/133467

This allows us to use the platform dill that is built by the engine when compiling apps. This also fixes the `--local-web-sdk` flag when compiling to wasm (which previously didn't work without some serious tweaking of the engine build output).

9f4f6c47

Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (#135765) · 878a48fa

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/d5fcd78a879b...48973d7f9beb

2023-09-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from e042e83c85a5 to 955a3a964621 (2 revisions) (flutter/engine#46412)
2023-09-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] simplify invert colors flag by supporting composed color filters." (flutter/engine#46414)
2023-09-29 jonahwilliams@google.com [Impeller] simplify invert colors flag by supporting composed color filters. (flutter/engine#46391)
2023-09-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 077d768accfa to e042e83c85a5 (3 revisions) (flutter/engine#46409)
2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 9f8242377455 to 2d4045f55fd5 (3 revisions) (flutter/engine#46408)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

878a48fa

Upgrade leak_tracker to fix flackiness. (#135760) · 9d9f213e

Polina Cherkasova authored Sep 29, 2023

Fixes: https://github.com/flutter/flutter/issues/135716
leak_tracker is left pinned because future updates are going to be breaking.

9d9f213e

Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (#135755) · 46ba4983

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/c52251a8b2d0...d5fcd78a879b

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from a80c164ffb8a to 9f8242377455 (1 revision) (flutter/engine#46406)
2023-09-29 30870216+gaaclarke@users.noreply.github.com [Impeller] Implements canvas recorder with trace serializer (flutter/engine#46376)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

46ba4983

Update `Drawer` tests for M2/M3 (#135752) · ebaf1603
Taha Tesser authored Sep 29, 2023
```
Updated unit tests for `Drawer` to have M2 and M3 versions.

More info in #127064
```
ebaf1603

Expose onAttach and onDetach in ScrollController subclasses (#135721) · 7c9feea8

Kate Lovett authored Sep 29, 2023

Fixes https://github.com/flutter/flutter/issues/135574
This exposes the onAttach and onDetach callbacks of ScrollController in all of its subclasses.

7c9feea8

Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (#135723) · 0f947a09

Jackson Gardner authored Sep 29, 2023

Some upcoming engine changes will bind to a function provided by the emscripten JS wrapper around skwasm, rather than just the wasm module itself. This will make sure not to break the benchmarks when those engine changes land. See https://github.com/flutter/engine/pull/46388

0f947a09

Update logic for getting `Analytics` instance from package:unified_analytics (#134756) · ba141695

Elias Yishak authored Sep 29, 2023

Part of:
- https://github.com/flutter/flutter/issues/128251

Currently, when we want to use the analytics instance from `package:unified_analytics`, we are just grabbing it from globals. However, with the legacy analytics instance, there are some things we check to return a no-op version of the instance.. for example, if we are running on bots or a non standard branch, we use a no-op instance

This PR uses the same previous checks for the new analytics instance

ba141695

Roll Packages from c070b0a7a80a to d0e9a0e1b3ac (5 revisions) (#135753) · 57b5c3cd

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/packages/compare/c070b0a7a80a...d0e9a0e1b3ac

2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c7 to ff4a0f67 (107 revisions) (flutter/packages#5011)
2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda59847 to ead455963c12 (1 revision) (flutter/packages#5022)
2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

57b5c3cd

Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (#135748) · cfdaf1e5

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/db4d3b5b3f59...c52251a8b2d0

2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Ta8wiQnzbBc7fAGeR... to mR_mhiacGiD-ObsoG... (flutter/engine#46403)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Ta8wiQnzbBc7 to mR_mhiacGiD-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cfdaf1e5

Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (#135745) · 3d003f9f

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/8b4e633c65eb...db4d3b5b3f59

2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from l2RxJKPfYn7QzGOoL... to vbw3Gwj-6eN7rSqb4... (flutter/engine#46401)
2023-09-29 49699333+dependabot[bot]@users.noreply.github.com Bump webdriver from 3.0.2 to 3.0.3 in /lib/web_ui (flutter/engine#46400)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from l2RxJKPfYn7Q to vbw3Gwj-6eN7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d003f9f

Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (#135744) · e4fbb6d3

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/09130bf5be97...8b4e633c65eb

2023-09-29 matej.knopp@gmail.com [macOS] Ensure first responder is consistent during and after text input (flutter/engine#46032)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4fbb6d3

Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (#135741) · e8915160

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/ccb30585d3f3...09130bf5be97

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 75033613a49f to a80c164ffb8a (3 revisions) (flutter/engine#46399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e8915160

Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (#135737) · fc9fef29

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/2052515c44f3...ccb30585d3f3

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 08485e753e3a to 75033613a49f (2 revisions) (flutter/engine#46396)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc9fef29

Update localizations. (#135691) · 938bb217
godofredoc authored Sep 29, 2023
```
Updates the localization files.
```
938bb217

Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (#135732) · 96e6f18c

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/485543c6765a...2052515c44f3

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4WW3KRrAbuY7VeGT0... to Ta8wiQnzbBc7fAGeR... (flutter/engine#46387)
2023-09-28 jonahwilliams@google.com [Impeller] revert stencil config changes. (flutter/engine#46386)
2023-09-28 bdero@google.com Bump impeller-cmake to head (flutter/engine#46385)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from 33502f9b0c7d to 08485e753e3a (1 revision) (flutter/engine#46384)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 4WW3KRrAbuY7 to Ta8wiQnzbBc7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96e6f18c

Add arch property for windows_arm64 platform (#135725) · 951653a1

keyonghan authored Sep 29, 2023

Window arm64 bots are using x64 built python, which gave incorrect arch info. This PR adds the arch info explicitly so that recipes can get this value and populate to benchmark tags.

Part of https://github.com/flutter/flutter/issues/135722

951653a1

[flutter_tools] remove VmService screenshot for native devices. (#135462) · d13cd884

Jonah Williams authored Sep 29, 2023

* This is completely broken on the Impeller renderer, see: https://github.com/flutter/flutter/issues/135052
* Even on the Skia renderer, this gives a software rasterized screenshot which will absolutely look different from a native rendering screenshot.

I plan to remove this functionality from the engine.

d13cd884

Pin leak_tracker before publishing breaking change. (#135720) · e5d3b704
Polina Cherkasova authored Sep 29, 2023

e5d3b704

28 Sep, 2023 7 commits

Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (#135717) · de20e74a

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/cc7c3c1f0f41...485543c6765a

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cu6apvEZ2P6zhishc... to l2RxJKPfYn7QzGOoL... (flutter/engine#46382)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Remove opacity layer dcheck. (flutter/engine#46160)
2023-09-28 matanlurey@users.noreply.github.com Add initial support for 4x MSAA in OpenGLES backend. (flutter/engine#46381)
2023-09-28 matej.knopp@gmail.com Reland: [macOS] performKeyEquivalent cleanup (flutter/engine#46377)
2023-09-28 matej.knopp@gmail.com [macOS] TextInputPlugin should mark navigation events in IME popover as handled (flutter/engine#46141)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Removed unnecessary dynamic dispatch (flutter/engine#46369)
2023-09-28 joel.winarske@gmail.com [Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. (flutter/engine#46287)
2023-09-28 ajihyf@gmail.com Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cu6apvEZ2P6z to l2RxJKPfYn7Q

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de20e74a

Remove assertions on getOffsetToReveal (#135634) · 3509a1df
Kate Lovett authored Sep 28, 2023

3509a1df

Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (#135565) · 55c7a2ef

Flutter GitHub Bot authored Sep 28, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
The issue https://github.com/flutter/flutter/issues/134631 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20flutter_gallery__start_up_delayed%22).
This test can be marked as unflaky.

55c7a2ef

Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (#135701) · 49689632

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/dbb60932a6ab...cc7c3c1f0f41

2023-09-28 matej.knopp@gmail.com [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

49689632

[tool] fallback to sigkill when closing Chromium (#135521) · 371aadd8

Yegor authored Sep 28, 2023

This implements https://github.com/flutter/flutter/issues/132654#issuecomment-1738221257, namely:

Make `Chromium.close` more robust:

* Send `SIGTERM` and wait up to 5 seconds, if the process exited, great! Return from the function.
* If the process has not exited, then send a `SIGKILL`, which is a much firmer way to exit a process. Same as before, wait up to 5 seconds, if the process exited, great! Return from the function.
* If it still hasn't exited then give up trying to exit Chromium, just print a warning to the console and return from the function.

Bonus: a few nullability fixes and extra `-v` logging.

Fixes https://github.com/flutter/flutter/issues/132654

371aadd8

Roll pub packages (#135455) · b5c8fd11
flutter-pub-roller-bot authored Sep 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
b5c8fd11

Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (#135694) · 97847e09

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/9789dbc2ec3f...dbb60932a6ab

2023-09-28 chris@bracken.jp Revert "[macOS] performKeyEquivalent cleanup (#45946)" (flutter/engine#46374)
2023-09-28 matej.knopp@gmail.com [macOS] performKeyEquivalent cleanup (flutter/engine#45946)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

97847e09