- 06 Feb, 2024 1 commit
-
-
Renzo Olivares authored
This change affects Android and iOS devices using the TextField's context menu. After this change the context menu will fade out when scrolling the text and fade in when the scroll ends. If the scroll ends and the selection is outside of the view, then the toolbar will be scheduled to show in a future scroll end. This toolbar scheduling can be invalidated if the `TextEditingValue` changed anytime between the scheduling and when the toolbar is ready to be shown. This change also fixes a regression where the TextField context menu would not fade when the selection handles where not visible. When using the native browser context menu this behavior is not controlled by Flutter. https://github.com/flutter/flutter/assets/948037/3f46bcbb-ba6f-456c-8473-e42919b9d572 Fixes #52425 Fixes #105804 Fixes #52426
-
- 29 Jan, 2024 1 commit
-
-
Bryan Olivares authored
This PR is adding a flag parameter to the `TextField` widget. This flag controls whether the TextField ignores pointers. The flag takes priority over other TextField behaviors such as enabled, so it can be useful when trying to have a disabled TextField that can be scrolled (behavior observed using TextArea on the web). Adding a flag parameter to `TextField` helps with more customization and flexibility to the widget which can improve user experience. I am open to other ideas. Fixes issue #140147 Before: https://github.com/flutter/flutter/assets/66151079/293e5b4e-3126-4a00-824d-1530aeaa494b After: https://github.com/flutter/flutter/assets/66151079/08c1af09-3bf9-4b49-b684-dda4dd920503 Usage: ```dart child: TextField( ignorePointer: false, enabled: false, ), ```
-
- 19 Jan, 2024 1 commit
-
-
Ian Hickson authored
Turns out all implementations of this method made this call, so it seems like it should belong in the superclass.
-
- 18 Jan, 2024 1 commit
-
-
Renzo Olivares authored
Previously `TextField`s error `cursorColor` was being derived without taking into account any `InputDecorationTheme` defaults. This change respects `InputDecorationTheme` defaults when deriving the error `cursorColor`. Fixes #140607
-
- 11 Dec, 2023 1 commit
-
-
LongCatIsLooong authored
Extacted from #130101, dropped the `@_debugAssert` stuff from that PR so it's easier to review.
-
- 29 Nov, 2023 1 commit
-
-
Renzo Olivares authored
This change adds support for a `MaterialStatesController` in `TextField` and `TextFormField`. With this change a user can listen to `MaterialState` changes in an input field by passing a `MaterialStatesController` to `TextField` or `TextFormField`. Fixes #133273
-
- 28 Nov, 2023 1 commit
-
-
Tirth authored
Added `keyboardType` & `textInputAction` props to `SearchBar`, `SearchAnchor` & `SearchAnchor.bar` Fixes #138483
-
- 09 Nov, 2023 1 commit
-
-
Renzo Olivares authored
This changes fixes text selection gestures on the search field when using `SearchAnchor`. Before this change text selection gestures did not work due to an `IgnorePointer` in the widget tree. This change: * Removes the `IgnorePointer` so the underlying `TextField` can receive pointer events. * Introduces `TextField.onTapAlwaysCalled` and `TextSelectionGestureDetector.onUserTapAlwaysCalled`, so a user provided on tap callback can be called on consecutive taps. This is so that the user provided on tap callback for `SearchAnchor/SearchBar` that was previously only handled by `InkWell` will still work if a tap occurs in the `TextField`s hit box. The `TextField`s default behavior is maintained outside of the context of `SearchAnchor/SearchBar`. Fixes https://github.com/flutter/flutter/issues/128332 and #134965
-
- 24 Oct, 2023 1 commit
-
-
lirantzairi authored
The color of the TextField's cursor in error state is the same as the error text color by default. However we should be allowed to customize it Fixes #135580
-
- 28 Sep, 2023 1 commit
-
-
Taha Tesser authored
fixes [TextField uses bodyLarge instead of titleMedium as the documentation says ](https://github.com/flutter/flutter/issues/135411)
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 08 Sep, 2023 1 commit
-
-
Renzo Olivares authored
When passed an `error` widget, `InputDecoration` should activate its error state. Before this change the `errorBorder` would only activate if an `errorText` was provided. This change solves this issue by accounting for a provided `error` widget.
-
- 10 Aug, 2023 1 commit
-
-
Renzo Olivares authored
This change makes sure the style provided through the `TextField`s `style` parameter is resolved for material states before merging it with defaults. Fixes #132212
-
- 08 Aug, 2023 1 commit
-
-
Jesús S Guerrero authored
Reverts flutter/flutter#130164 reverting because it cause internal google testing failures b/294917394
-
- 02 Aug, 2023 1 commit
-
-
Justin McCandless authored
Simplifying the TextField API.
-
- 18 Jul, 2023 1 commit
-
-
fzyzcjy authored
Just fix a space... I do hope we can have the auto formatter enabled in the future!
-
- 13 Jul, 2023 1 commit
-
-
chunhtai authored
related https://github.com/flutter/flutter/issues/128709 engine PR: https://github.com/flutter/engine/pull/43279 The web engine requires a way to unfocus textfield, It comes to nature to me that we should leverage didGain/didLose a11y focus action. I also unifies the action handler of all desktop platforms ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 12 Jul, 2023 1 commit
-
-
Greg Spencer authored
## Description This adds links to examples that were not linked anywhere. ## Related Issues - Fixes #129956 ## Tests - Documentation only change
-
- 09 Jun, 2023 1 commit
-
-
Pierre-Louis authored
## Description This improves defaults generation with logging, stats, and token validation. This PR includes these changes: * introduce `TokenLogger`, with a verbose mode * prints versions and tokens usage to the console * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google * find token files in `data` automatically * hide tokens `Map` * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`. * tokens can be checked for existence with `tokenAvailable` * remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version * improve documentation ## Related Issues - Fixes https://github.com/flutter/flutter/issues/122602 ## Tests - Added tests for `TokenLogger` - Regenerated tokens, no-op except version removal ## Future work A future PR should replace or remove the following invalid tokens usages <img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
-
- 16 May, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 15 May, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 25 Apr, 2023 1 commit
-
-
Justin McCandless authored
When using a Material TextField on iOS, the spell check selection style now defaults to the red iOS-style, not Android's blue.
-
- 20 Apr, 2023 1 commit
-
-
Justin McCandless authored
Even in TextField using the Material library, iOS devices will still show the iOS-style spell check toolbar by default when using spell check.
-
- 18 Apr, 2023 1 commit
-
-
Justin McCandless authored
Tidying up the spell check API.
-
- 31 Mar, 2023 1 commit
-
-
Camille Simon authored
[iOS] Add spell check suggestions toolbar on tap
-
- 29 Mar, 2023 1 commit
-
-
Vinny authored
Modified TextField docs - Replaced 'labelText' to 'hintText' in code snippet
-
- 23 Mar, 2023 1 commit
-
-
Benjamin Quinn authored
Expose toggle to textfield's opacity animation.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 17 Mar, 2023 1 commit
-
-
Renzo Olivares authored
Co-authored-by:
Renzo Olivares <roliv@google.com>
-
- 13 Mar, 2023 1 commit
-
-
Pierre-Louis authored
Update Material tokens to 0.162
-
- 09 Mar, 2023 1 commit
-
-
Hasnen Tai authored
According to Material specs, cursor should be red in error state.
-
- 08 Mar, 2023 1 commit
-
-
Jami Couch authored
Add support for iOS UndoManager
-
- 01 Mar, 2023 1 commit
-
-
takashi kasai authored
moving the left handle automatically scrolls EditableText to the right handle, which doesn't happen on native (#105836) Fixes a scrolling issue when dragging selection handles.
-
- 07 Feb, 2023 1 commit
-
-
Qun Cheng authored
* Update to v0.158 of the token database. * Update checkbox template * Fix DatePickerTheme test --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 31 Jan, 2023 1 commit
-
-
Tanay Neotia authored
* Add support for image insertion on Android * Fix checks * Use proper Dart syntax on snippet * Specify type annotation on list * Fix nits, add some asserts, and improve example code * Add missing import * Fix nullsafety error * Fix nullsafety error * Remove reference to contentCommitMimeTypes in docs * Fix nits * Fix warnings and import * Add test for content commit in editable_text_test.dart * Check that URIs are equal in test * Fix nits and rename functions / classes to be more self-explanatory * Fix failing debugFillProperties tests * Add empty implementation to `insertContent` in TextInputClient * Tweak documentation slightly * Improve docs for contentInsertionMimeTypes and fix assert * Rework contentInsertionMimeType asserts * Add test for onContentInserted example * Switch implementation to a configuration class for more granularity in setting mime types * Fix nits * Improve docs and fix doc tests * Fix more nits (LongCatIsLooong) * Fix failing tests * Make parameters (guaranteed by platform to be non-nullable) non-nullable * Fix analysis issues
-
- 27 Jan, 2023 1 commit
-
-
Qun Cheng authored
* Add canRequestFocus to TextField and requestFocusOnTap to DropdownMenu * Address comments * Address comments --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 17 Jan, 2023 1 commit
-
-
Darren Austin authored
-
- 04 Jan, 2023 1 commit
-
-
Renzo Olivares authored
* Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa0117. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by:
Renzo Olivares <roliv@google.com>
-
- 03 Jan, 2023 1 commit
-
-
Darren Austin authored
* Updated to tokens v0.150. * Updated with a reverted list_tile.dart.
-