- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 09 Jun, 2023 1 commit
-
-
Devin authored
Fixes https://github.com/flutter/flutter/issues/74114 This PR addresses the issue detailed here: https://github.com/flutter/flutter/issues/74114 . The boolean isExpanded returned by the expansion panel callback now reflects the state of the panel that the user is seeing. If it's expanded on screen then the callback returns true. When you close the panel the callback returns false. When another panel is open and you open a different one, the callback executes twice. It returns isExpanded == false for the panel you are closing and true for the panel that is being opened. I had to change the code in a couple existing tests because some tests are using the old behavior of the callback. This PR addresses feedback listed in closed PR -> https://github.com/flutter/flutter/pull/127876 . The reasone the original PR is closed is that I was having some struggles with git. A couple of the commits in this PR are just reverts of commits I meant not to happen. Pre-launch Checklist [ X] I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) and followed the process outlined there for submitting PRs. [ X] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities. [ X] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement). [ X] I signed the [CLA](https://cla.developers.google.com/). [ X] I listed at least one issue that this PR fixes in the description above. I updated/added relevant documentation (doc comments with ///). [ X] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests). [ X] All existing and new tests are passing.
-
- 06 May, 2023 1 commit
-
-
Tirth authored
Adds `materialGapSize` property to `ExpansionPanelList` widget. | `materialGapSize: 0` | `materialGapSize: 16` (default) | `materialGapSize: 30` | | --- | --- | --- | |  |  |  | |  |  |  | |  |  |  | |  |  |  | Fixes: #118167
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 06 Jan, 2023 2 commits
-
-
Morris Kurz authored
* Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by:
Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by:
Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by:
Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by:
Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by:
Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by:
Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by:
Morris Kurz <morriskurz@gmail.com>
-
Mohammed CHAHBOUN authored
* Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 01 Mar, 2022 1 commit
-
-
Viren Khatri authored
* migrates lib/foundation and lib/widgets * migrates lib/painting and lib/material * migrates lib/cupertino, lib/gestures, lib/services, lib/semantics and lib/rendering * fixes failing tests * migrates test/ * improves hashing of lists
-
- 14 Jan, 2022 1 commit
-
-
Alberto authored
-
- 04 Oct, 2021 1 commit
-
-
Greg Spencer authored
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder. I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed. I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
-
- 25 Aug, 2021 1 commit
-
-
Greg Spencer authored
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
-
- 11 May, 2021 1 commit
-
-
Abhishek Ghaskata authored
-
- 03 May, 2021 1 commit
-
-
Abhishek Ghaskata authored
-
- 31 Mar, 2021 2 commits
-
-
Alexandre Ardhuin authored
-
Alexandre Ardhuin authored
-
- 26 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2021 1 commit
-
-
Greg Spencer authored
Update samples to use repo analysis options, Fix sample templates and a ton of analyzer issues (#77868)
-
- 27 Jan, 2021 1 commit
-
-
Sam Rawlins authored
-
- 24 Dec, 2020 1 commit
-
-
Shi-Hao Hong authored
-
- 11 Dec, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 08 Dec, 2020 1 commit
-
-
Ayush Bherwani authored
-
- 23 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 06 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate material to nullsafety * address review comments * address review comments * fix build
-
- 05 Aug, 2020 1 commit
-
-
Ayush Bherwani authored
-
- 17 Jun, 2020 1 commit
-
-
Ayush Bherwani authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 11 Feb, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 Feb, 2020 1 commit
-
-
Greg Spencer authored
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site. It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally. I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level). I modified a few of the examples so that they looked nicer, and fit better on the page. I added the sample description text above each DartPad instance, since that often defines the context of the example. I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
-
- 09 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Jan, 2020 2 commits
-
-
Greg Spencer authored
-
Marius Meißner authored
* Added property for expanded padding of expansion panel for solving #24071 * #24071: Renamed default const name for being more descriptive * #24071: Improved comment of property expandedPadding * #24071: Improved test by expanding the expansion panel by header tap + precise assertion * #24071: Renamed property to be more descriptive * #24071: Adjusted property comment and added missing trailing commas * #24071: Improved test by checking real exact header size * #24071: Added test for default header padding * #24071: Improved comment of expandedHeaderPadding + code style adjustments * #24071: Added missing trailing comma
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/material * address review comments
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 30 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add missing trailing commas * add more missing trailing commas * add more and more missing trailing commas
-