- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 31 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `animation` * Use `curly_braces_in_flow_control_structures` for `cupertino` * fix comments
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 28 Mar, 2022 1 commit
-
-
Taha Tesser authored
`CupertinoSegmentedControl`/`CupertinoSlidingSegmentedControl`: Add clickable cursor for web (#99551)
-
- 15 Feb, 2022 1 commit
-
-
Taha Tesser authored
-
- 21 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 May, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2021 1 commit
-
-
Greg Spencer authored
Update samples to use repo analysis options, Fix sample templates and a ton of analyzer issues (#77868)
-
- 12 Jan, 2021 1 commit
-
-
Sam Rawlins authored
-
- 22 Dec, 2020 1 commit
-
-
Kate Lovett authored
-
- 11 Dec, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 21 Nov, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 30 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate material to nullsafety * address review comments * address review comments * fix build
-
- 24 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Aug, 2020 1 commit
-
-
Nolan Scobie authored
* Add punctuation for unterminated sentences in doc comments * Addressing review nit
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 20 May, 2020 1 commit
-
-
LongCatIsLooong authored
-
- 18 May, 2020 1 commit
-
-
LongCatIsLooong authored
-
- 28 Feb, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 2132a0c7.
-
- 26 Feb, 2020 1 commit
-
- 25 Feb, 2020 1 commit
-
-
Ferhat authored
-
- 27 Jan, 2020 1 commit
-
-
Dan Field authored
-
- 17 Jan, 2020 2 commits
-
-
Anthony authored
[a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985)
-
Justin McCandless authored
-
- 08 Jan, 2020 1 commit
-
-
Greg Spencer authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 16 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 08 Nov, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 16 Jun, 2019 1 commit
-
-
Van Looveren Koen authored
-
- 09 May, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 07 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* fix indentof statements in BlockFunctionBody * fix indentof statements in BlockFunctionBody in tests
-