1. 07 Feb, 2024 1 commit
  2. 06 Feb, 2024 2 commits
  3. 16 Jan, 2024 1 commit
  4. 05 Dec, 2023 1 commit
    • Shanmugam's avatar
      Support for dismissDirection property in SnackBarTheme (#139068) · af61c6c7
      Shanmugam authored
      This PR introduces a new feature that allows users to configure the 'dismissDirection' in SnackBarTheme. This enhancement provides users with the flexibility to set the 'dismissDirection' property in the ThemeData, rather than having to apply it each time when initializing a snack bar. This streamlines the process and makes it more convenient for users to manage and customize the behavior of snack bars within their applications.
      
      Fixes #139012
      af61c6c7
  5. 28 Oct, 2023 1 commit
  6. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from material. (#134991) · a1e49be2
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the material library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      a1e49be2
  7. 14 Jul, 2023 1 commit
    • lsaudon's avatar
      Tap on button behind snack bar defined by margin (#127959) · c3cd0166
      lsaudon authored
      If the margin is used, set the `HitTestBehavior` to `deferToChild`. 
      
      *List which issues are fixed by this PR. You must list at least one issue.*
      #78537 
      #114810 
      
      *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
      c3cd0166
  8. 12 Jul, 2023 1 commit
  9. 14 Jun, 2023 1 commit
  10. 09 Jun, 2023 1 commit
    • Pierre-Louis's avatar
      Improve defaults generation with logging, stats, and token validation (#128244) · 66cda591
      Pierre-Louis authored
      ## Description
      
      This improves defaults generation with logging, stats, and token validation. 
      
      This PR includes these changes:
      * introduce `TokenLogger`, with a verbose mode
        * prints versions and tokens usage to the console
        * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google
      * find token files in `data` automatically
      * hide tokens `Map`
        * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`.
        * tokens can be checked for existence with `tokenAvailable`
      * remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version
      * improve documentation
      
      ## Related Issues
       - Fixes https://github.com/flutter/flutter/issues/122602
      
      ## Tests
       - Added tests for `TokenLogger`
       - Regenerated tokens, no-op except version removal
      
      ## Future work
      A future PR should replace or remove the following invalid tokens usages
      
      <img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
      66cda591
  11. 19 May, 2023 1 commit
  12. 27 Apr, 2023 1 commit
  13. 27 Mar, 2023 1 commit
  14. 14 Mar, 2023 1 commit
  15. 13 Mar, 2023 1 commit
  16. 23 Feb, 2023 1 commit
  17. 14 Feb, 2023 1 commit
  18. 08 Feb, 2023 1 commit
    • MarchMore's avatar
      Removed "if" on resolving text color at "SnackBarAction" (#120050) · 0588b925
      MarchMore authored
      * Removed "if" on resolving text color at "SnackBarAction"
      
      Removed multiple "if" for "resolveForegroundColor" method at "SnackBarAction". At least one of the multiple "if" ("defaults.actionTextColor is MaterialStateColor") led to not applying a custom set color (e.g. MaterialColor "Colors.red") for the action text when using Material 3.
      
      The second "if" ("snackBarTheme.actionTextColor is MaterialStateColor") also makes no sense then as the set color of the Theme would lead to the same blocking behaviour of manual color assignment.
      
      The last remaining "if" ("widget.textColor is MaterialStateColor") will be unnecessary if the other "if" will be removed, as it will be resolved in the code right afterwards.
      
      The three "if" also seems to block the usage of the custom text color or the color at all if the widget is in the "MaterialState.disabled" state.
      
      * Adjusted recent modifications to SnackBarAction's text color resolution
      
      * Now the "widget.textColor" is checked if it is set.
        * If it is a MaterialStateColor, it will be used
        * Otherwise continue with normal resolution (It will be used in the resolution anyways because it's set)
      
      * Repeat same steps with "snackBarTheme.actionTextColor" if previous was not set
      
      * Repeat same steps with "defaults.actionTextColor" if previous was not set
      
      * Reverted the auto formatting changes
      
      * Added two test cases to "snack_bar_test"
      
       * Test for setting a MaterialColor to a SnackBarAction' label (M3)
       * Test for setting a MaterialStateColor to a SnackBarAction' label (M3)
      
      * Renamed test cases "Snackbar labels can be colored"
      0588b925
  19. 07 Feb, 2023 1 commit
  20. 25 Jan, 2023 1 commit
  21. 24 Jan, 2023 1 commit
  22. 17 Jan, 2023 1 commit
  23. 03 Jan, 2023 1 commit
  24. 11 Dec, 2022 1 commit
  25. 09 Dec, 2022 1 commit
  26. 07 Dec, 2022 1 commit
    • Greg Spencer's avatar
      Time picker precursors (#116450) · 31719941
      Greg Spencer authored
      * Make some minor changes in preparation for updating the Time Picker to M3
      
      * Revert OutlineInputBorder.borderRadius type change
      
      * Revert more OutlineInputBorder.borderRadius changes.
      31719941
  27. 02 Dec, 2022 1 commit
    • Eilidh Southren's avatar
      [CP] Fix Snackbar TalkBack regression (#116417) · 22cbef30
      Eilidh Southren authored
      * Add M2 defaults and template skeleton
      
      * add MaterialStateColor functionality to ActionTextColor (issue #110402)
      
      * Add M2 defaults and template skeleton
      
      * updated material 3 tokens
      
      * Updated snackbar demo
      
      * add theme tests
      
      * add gen defaults
      
      * formatting
      
      * more whitespace fixes
      
      * add widget type
      
      * update docs
      
      * code review changes
      
      * Add line overflow functionality
      
      * whitespace fixes
      
      * update M3 animation
      
      * whitespace fixes
      
      * add insetPadding param
      
      * Modifed icon parameter to showCloseIcon
      
      * white space fixes
      
      * test fixes
      
      * rename iconColor to closeIconColor
      
      * debug test fix
      
      * de-britishification
      
      * g3fix
      
      * g3fix
      
      * debug test fix
      
      * Fix Snackbar talkback regression
      
      * fix merge weirdness
      
      * test fix
      
      * fix linux analysis error
      
      * fix linux analysis error
      
      * fix linux analysis error
      
      * fix linux analysis error
      
      * fix linux analysis error
      
      * fix linux analysis error
      22cbef30
  28. 30 Nov, 2022 1 commit
    • Eilidh Southren's avatar
      M3 snackbar [re-land] (#116218) · 29422d25
      Eilidh Southren authored
      * Add M2 defaults and template skeleton
      
      * add MaterialStateColor functionality to ActionTextColor (issue #110402)
      
      * Add M2 defaults and template skeleton
      
      * updated material 3 tokens
      
      * Updated snackbar demo
      
      * add theme tests
      
      * add gen defaults
      
      * formatting
      
      * more whitespace fixes
      
      * add widget type
      
      * update docs
      
      * code review changes
      
      * Add line overflow functionality
      
      * whitespace fixes
      
      * update M3 animation
      
      * whitespace fixes
      
      * add insetPadding param
      
      * Modifed icon parameter to showCloseIcon
      
      * white space fixes
      
      * test fixes
      
      * rename iconColor to closeIconColor
      
      * debug test fix
      
      * de-britishification
      
      * g3fix
      
      * g3fix
      
      * debug test fix
      29422d25
  29. 29 Nov, 2022 2 commits
    • Kate Lovett's avatar
      Revert "Update SnackBar to support Material 3" (#116199) · 8b32ac7a
      Kate Lovett authored
      * Revert "Update SnackBar to support Material 3 (#115750)"
      
      This reverts commit d58855c4.
      
      * Kick ci.yaml
      Co-authored-by: 's avatarJenn Magder <magder@google.com>
      8b32ac7a
    • Eilidh Southren's avatar
      Update SnackBar to support Material 3 (#115750) · d58855c4
      Eilidh Southren authored
      * Add M2 defaults and template skeleton
      
      * add MaterialStateColor functionality to ActionTextColor (issue #110402)
      
      * Add M2 defaults and template skeleton
      
      * updated material 3 tokens
      
      * Updated snackbar demo
      
      * add theme tests
      
      * add gen defaults
      
      * formatting
      
      * more whitespace fixes
      
      * add widget type
      
      * update docs
      
      * code review changes
      
      * Add line overflow functionality
      
      * whitespace fixes
      
      * update M3 animation
      
      * whitespace fixes
      
      * add insetPadding param
      
      * Modifed icon parameter to showCloseIcon
      
      * white space fixes
      
      * test fixes
      
      * rename iconColor to closeIconColor
      
      * debug test fix
      
      * de-britishification
      d58855c4
  30. 05 Oct, 2022 1 commit
    • Eilidh Southren's avatar
      Add width property to SnackBarThemeData (#112636) · 4862a84b
      Eilidh Southren authored
      * Adding snackbar theme data width field
      
      * Whitespace formatting
      
      * Update docstrings
      
      * version update
      
      * tidy up
      
      * Revert auto text formatting
      
      * Text formatting
      
      * Remove whitespace
      
      * Test tidy
      
      * Whitespace fix
      
      * y Please enter the commit message for your changes. Lines starting
      
      * whitespace
      
      * test fixes
      
      * de-British-ification
      
      * comment modification
      4862a84b
  31. 22 Aug, 2022 1 commit
  32. 17 Aug, 2022 1 commit
  33. 10 Aug, 2022 1 commit
  34. 27 Jul, 2022 1 commit
  35. 19 Jul, 2022 1 commit
  36. 25 May, 2022 1 commit
  37. 14 Apr, 2022 1 commit
  38. 08 Apr, 2022 1 commit