- 07 Feb, 2024 1 commit
-
-
Taha Tesser authored
[Original was reverted due to uncaught analysis failure ](https://github.com/flutter/flutter/pull/142825#issuecomment-1930620085) --- fixes [`showSnackBar` is always replacing `animation` parameter of `SnackBar`](https://github.com/flutter/flutter/issues/141646) ### Code sample preview 
-
- 06 Feb, 2024 2 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#142825 Initiated by: zanderso Reason for reverting: Analysis failure closing the engine tree https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756815302197889649/+/u/Framework_analyze/Framework_analyze/stdout?format=raw Original PR Author: TahaTesser Reviewed By: {HansMuller} This change reverts the following previous change: Original Description: fixes [`showSnackBar` is always replacing `animation` parameter of `SnackBar`](https://github.com/flutter/flutter/issues/141646) ### Code sample preview 
-
Taha Tesser authored
fixes [`showSnackBar` is always replacing `animation` parameter of `SnackBar`](https://github.com/flutter/flutter/issues/141646) ### Code sample preview 
-
- 16 Jan, 2024 1 commit
-
-
Anis Alibegić authored
I continued [my mission](https://github.com/flutter/flutter/pull/141431) to find as many typos as I could. This time it's a smaller set than before. There is no need for issues since it's a typo fix.
-
- 05 Dec, 2023 1 commit
-
-
Shanmugam authored
This PR introduces a new feature that allows users to configure the 'dismissDirection' in SnackBarTheme. This enhancement provides users with the flexibility to set the 'dismissDirection' property in the ThemeData, rather than having to apply it each time when initializing a snack bar. This streamlines the process and makes it more convenient for users to manage and customize the behavior of snack bars within their applications. Fixes #139012
-
- 28 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 14 Jul, 2023 1 commit
-
-
lsaudon authored
If the margin is used, set the `HitTestBehavior` to `deferToChild`. *List which issues are fixed by this PR. You must list at least one issue.* #78537 #114810 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
- 12 Jul, 2023 1 commit
-
-
Greg Spencer authored
## Description This adds links to examples that were not linked anywhere. ## Related Issues - Fixes #129956 ## Tests - Documentation only change
-
- 14 Jun, 2023 1 commit
-
-
Qun Cheng authored
-
- 09 Jun, 2023 1 commit
-
-
Pierre-Louis authored
## Description This improves defaults generation with logging, stats, and token validation. This PR includes these changes: * introduce `TokenLogger`, with a verbose mode * prints versions and tokens usage to the console * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google * find token files in `data` automatically * hide tokens `Map` * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`. * tokens can be checked for existence with `tokenAvailable` * remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version * improve documentation ## Related Issues - Fixes https://github.com/flutter/flutter/issues/122602 ## Tests - Added tests for `TokenLogger` - Regenerated tokens, no-op except version removal ## Future work A future PR should replace or remove the following invalid tokens usages <img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
-
- 19 May, 2023 1 commit
-
-
Qun Cheng authored
This PR is to remove deprecated `primaryVariant` and `secondaryVariant` from framework. These two apis are made obsolete in #93427 Part of https://github.com/flutter/flutter/issues/127042
-
- 27 Apr, 2023 1 commit
-
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/125619 ### Before  ### After 
-
- 27 Mar, 2023 1 commit
-
-
Chinmoy authored
-
- 14 Mar, 2023 1 commit
-
-
Taha Tesser authored
Cleanup M3 token templates for theme lookups
-
- 13 Mar, 2023 1 commit
-
-
Pierre-Louis authored
Update Material tokens to 0.162
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 14 Feb, 2023 1 commit
-
-
Eilidh Southren authored
* add actionOverflowThreshold param * analyzer tings * https://www.youtube.com/watch?v=NPwyyjtxlzU * remove erroneous switch changes * rename test * remove unwanted switch.dart diff * remove redundant values * review changes
-
- 08 Feb, 2023 1 commit
-
-
MarchMore authored
* Removed "if" on resolving text color at "SnackBarAction" Removed multiple "if" for "resolveForegroundColor" method at "SnackBarAction". At least one of the multiple "if" ("defaults.actionTextColor is MaterialStateColor") led to not applying a custom set color (e.g. MaterialColor "Colors.red") for the action text when using Material 3. The second "if" ("snackBarTheme.actionTextColor is MaterialStateColor") also makes no sense then as the set color of the Theme would lead to the same blocking behaviour of manual color assignment. The last remaining "if" ("widget.textColor is MaterialStateColor") will be unnecessary if the other "if" will be removed, as it will be resolved in the code right afterwards. The three "if" also seems to block the usage of the custom text color or the color at all if the widget is in the "MaterialState.disabled" state. * Adjusted recent modifications to SnackBarAction's text color resolution * Now the "widget.textColor" is checked if it is set. * If it is a MaterialStateColor, it will be used * Otherwise continue with normal resolution (It will be used in the resolution anyways because it's set) * Repeat same steps with "snackBarTheme.actionTextColor" if previous was not set * Repeat same steps with "defaults.actionTextColor" if previous was not set * Reverted the auto formatting changes * Added two test cases to "snack_bar_test" * Test for setting a MaterialColor to a SnackBarAction' label (M3) * Test for setting a MaterialStateColor to a SnackBarAction' label (M3) * Renamed test cases "Snackbar labels can be colored"
-
- 07 Feb, 2023 1 commit
-
-
Qun Cheng authored
* Update to v0.158 of the token database. * Update checkbox template * Fix DatePickerTheme test --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 25 Jan, 2023 1 commit
-
-
Ahmed Ashour authored
* Remove superfluous words from comments. * Revert `win32_window.h` Which seems to come from `gallery`
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 17 Jan, 2023 1 commit
-
-
Darren Austin authored
-
- 03 Jan, 2023 1 commit
-
-
Darren Austin authored
* Updated to tokens v0.150. * Updated with a reverted list_tile.dart.
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 07 Dec, 2022 1 commit
-
-
Greg Spencer authored
* Make some minor changes in preparation for updating the Time Picker to M3 * Revert OutlineInputBorder.borderRadius type change * Revert more OutlineInputBorder.borderRadius changes.
-
- 02 Dec, 2022 1 commit
-
-
Eilidh Southren authored
* Add M2 defaults and template skeleton * add MaterialStateColor functionality to ActionTextColor (issue #110402) * Add M2 defaults and template skeleton * updated material 3 tokens * Updated snackbar demo * add theme tests * add gen defaults * formatting * more whitespace fixes * add widget type * update docs * code review changes * Add line overflow functionality * whitespace fixes * update M3 animation * whitespace fixes * add insetPadding param * Modifed icon parameter to showCloseIcon * white space fixes * test fixes * rename iconColor to closeIconColor * debug test fix * de-britishification * g3fix * g3fix * debug test fix * Fix Snackbar talkback regression * fix merge weirdness * test fix * fix linux analysis error * fix linux analysis error * fix linux analysis error * fix linux analysis error * fix linux analysis error * fix linux analysis error
-
- 30 Nov, 2022 1 commit
-
-
Eilidh Southren authored
* Add M2 defaults and template skeleton * add MaterialStateColor functionality to ActionTextColor (issue #110402) * Add M2 defaults and template skeleton * updated material 3 tokens * Updated snackbar demo * add theme tests * add gen defaults * formatting * more whitespace fixes * add widget type * update docs * code review changes * Add line overflow functionality * whitespace fixes * update M3 animation * whitespace fixes * add insetPadding param * Modifed icon parameter to showCloseIcon * white space fixes * test fixes * rename iconColor to closeIconColor * debug test fix * de-britishification * g3fix * g3fix * debug test fix
-
- 29 Nov, 2022 2 commits
-
-
Kate Lovett authored
* Revert "Update SnackBar to support Material 3 (#115750)" This reverts commit d58855c4. * Kick ci.yaml Co-authored-by:
Jenn Magder <magder@google.com>
-
Eilidh Southren authored
* Add M2 defaults and template skeleton * add MaterialStateColor functionality to ActionTextColor (issue #110402) * Add M2 defaults and template skeleton * updated material 3 tokens * Updated snackbar demo * add theme tests * add gen defaults * formatting * more whitespace fixes * add widget type * update docs * code review changes * Add line overflow functionality * whitespace fixes * update M3 animation * whitespace fixes * add insetPadding param * Modifed icon parameter to showCloseIcon * white space fixes * test fixes * rename iconColor to closeIconColor * debug test fix * de-britishification
-
- 05 Oct, 2022 1 commit
-
-
Eilidh Southren authored
* Adding snackbar theme data width field * Whitespace formatting * Update docstrings * version update * tidy up * Revert auto text formatting * Text formatting * Remove whitespace * Test tidy * Whitespace fix * y Please enter the commit message for your changes. Lines starting * whitespace * test fixes * de-British-ification * comment modification
-
- 22 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 17 Aug, 2022 1 commit
-
-
Greg Spencer authored
-
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 27 Jul, 2022 1 commit
-
-
Darren Austin authored
-
- 19 Jul, 2022 1 commit
-
-
Romain Rastel authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 08 Apr, 2022 1 commit
-
-
Kate Lovett authored
-