1. 22 Mar, 2019 1 commit
  2. 20 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      some spaces formatting (#29452) · a6af4228
      Alexandre Ardhuin authored
      * some space formattings
      
      * always use blocks in if-else if a block is used
      
      * format spaces in for and while
      
      * allow multiline if conditions
      
      * fix missing space
      a6af4228
  3. 07 Mar, 2019 1 commit
  4. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  5. 16 Feb, 2019 1 commit
  6. 16 Oct, 2018 1 commit
  7. 14 Sep, 2018 1 commit
  8. 12 Sep, 2018 1 commit
  9. 28 Aug, 2018 1 commit
  10. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  11. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  12. 02 Aug, 2018 1 commit
  13. 27 Jul, 2018 1 commit
  14. 23 Jul, 2018 1 commit
  15. 20 Jul, 2018 1 commit
  16. 16 Jul, 2018 2 commits
  17. 14 Jul, 2018 1 commit
  18. 09 Jul, 2018 1 commit
  19. 02 Jul, 2018 2 commits
  20. 28 Jun, 2018 1 commit
  21. 12 Mar, 2018 1 commit
  22. 23 Nov, 2017 2 commits
    • Chris Bracken's avatar
      Reorganise flutter driver implementation sources (#13163) · cf37a472
      Chris Bracken authored
      This patch reorganises flutter_driver's lib/src directory into three
      subdirectories:
      
      * driver: sources transitively imported/exported by flutter_driver.dart,
        which defines the API used by driver tests executed on the host machine.
      
      * extension: sources transitively imported/exported by
        driver_extension.dart, which defines the API used to instrument a
        Flutter app running on the target device for use with a driver test.
      
      * common: sources common to both driver and extension code.
      
      This makes rolling Flutter into repositories that use Bazel (or
      Bazel-like build systems) significantly more robust, due to the simpler
      glob patterns involved.
      cf37a472
    • Chris Bracken's avatar
  23. 22 Nov, 2017 1 commit
  24. 21 Nov, 2017 1 commit
    • Chris Bracken's avatar
      Use duration not threadDuration for frame duration (#13117) · 14b5cb04
      Chris Bracken authored
      1. We want to measure wall-clock duration for the benchmarks, as opposed
         to thread duration (e.g., waiting on a mutex should accrue time) and
         'dur' is the metric to use for that.
      
      2. On Darwin-based systems (macOS and iOS) 'tdur' is the result of a
         mach syscall lookup to thread_info. This call returns unreliable data
         on iOS. Chromium, for example, disables thread time support entirely
         for iOS.
      14b5cb04
  25. 23 Jun, 2017 1 commit
    • Ian Hickson's avatar
      Deep linking: automatically push the route hiearchy on load. (#10894) · 9adb4a78
      Ian Hickson authored
      The main purpose of this PR is to make it so that when you set the
      initial route and it's a hierarchical route (e.g. `/a/b/c`), it
      implies multiple pushes, one for each step of the route (so in that
      case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those
      routes don't exist, it falls back to '/'.
      
      As part of doing that, I:
      
       * Changed the default for MaterialApp.initialRoute to honor the
         actual initial route.
      
       * Added a MaterialApp.onUnknownRoute for handling bad routes.
      
       * Added a feature to flutter_driver that allows the host test script
         and the device test app to communicate.
      
       * Added a test to make sure `flutter drive --route` works.
         (Hopefully that will also prove `flutter run --route` works, though
         this isn't testing the `flutter` tool's side of that. My main
         concern is over whether the engine side works.)
      
       * Fixed `flutter drive` to output the right target file name.
      
       * Changed how the stocks app represents its data, so that we can
         show a page for a stock before we know if it exists.
      
       * Made it possible to show a stock page that doesn't exist. It shows
         a progress indicator if we're loading the data, or else shows a
         message saying it doesn't exist.
      
       * Changed the pathing structure of routes in stocks to work more
         sanely.
      
       * Made search in the stocks app actually work (before it only worked
         if we happened to accidentally trigger a rebuild). Added a test.
      
       * Replaced some custom code in the stocks app with a BackButton.
      
       * Added a "color" feature to BackButton to support the stocks use case.
      
       * Spaced out the ErrorWidget text a bit more.
      
       * Added `RouteSettings.copyWith`, which I ended up not using.
      
       * Improved the error messages around routing.
      
      While I was in some files I made a few formatting fixes, fixed some
      code health issues, and also removed `flaky: true` from some devicelab
      tests that have been stable for a while. Also added some documentation
      here and there.
      9adb4a78
  26. 04 Mar, 2017 1 commit
  27. 28 Feb, 2017 1 commit
  28. 14 Feb, 2017 1 commit
    • Adam Barth's avatar
      Switch benchmarks to thread duration (#8113) · be865544
      Adam Barth authored
      For measuring the Dart thread, we care about thread duration (tdur) rather than
      wall duration (dur) because we don't want to count the time when the Dart
      thread is descheduled (e.g., in preference to the raster thread).
      
      Prior to this change, these benchmarks were mostly measuring whether the OS
      decided to finish the Dart thread's time slice or hand over the CPU to the
      raster thread to complete the visual part of the frame. Now we actually measure
      the work done on the Dart thread.
      be865544
  29. 10 Feb, 2017 1 commit
  30. 08 Feb, 2017 1 commit
  31. 10 Dec, 2016 1 commit
  32. 25 Oct, 2016 1 commit
  33. 04 May, 2016 1 commit
    • pq's avatar
      Literals get type annotations. · bcede8df
      pq authored
      As per the recent fix to the `always_specify_types` lint (https://github.com/dart-lang/linter/issues/199), literal maps and lists are now expected to be explicitly typed.
      
      Running that lint on the repo identifies quite a few spots to update.  This focuses on `flutter_driver` and `flutter_sprites` (somewhat arbitrarily) but the changes are fairly representative.
      
      Note there are a number of places where I made a quick judgement on how specific to make the types.  Feedback on those is welcome.  (Especially as we move forward with more.)
      bcede8df
  34. 03 May, 2016 1 commit
  35. 14 Apr, 2016 1 commit
  36. 07 Apr, 2016 1 commit
  37. 05 Apr, 2016 1 commit