1. 19 Mar, 2019 1 commit
  2. 21 Feb, 2019 1 commit
  3. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  4. 21 Dec, 2018 2 commits
    • Ian Hickson's avatar
      Revert "[O] Remove many timeouts. (#23531)" (#25646) · 8426910a
      Ian Hickson authored
      This reverts commit 76f70810.
      8426910a
    • Ian Hickson's avatar
      [O] Remove many timeouts. (#23531) · 76f70810
      Ian Hickson authored
      * Remove many timeouts.
      
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      
      * Get the attach tests to pass.
      
      * Apply review comments from Todd
      
      * More review comment fixes
      
      * Put back the extended timeouts here now that I know why we have them...
      76f70810
  5. 16 Oct, 2018 1 commit
  6. 04 Oct, 2018 1 commit
  7. 01 Oct, 2018 1 commit
  8. 14 Sep, 2018 1 commit
  9. 12 Sep, 2018 1 commit
  10. 23 Aug, 2018 1 commit
  11. 06 Aug, 2018 1 commit
  12. 02 Aug, 2018 2 commits
  13. 20 Jul, 2018 1 commit
  14. 14 Jul, 2018 1 commit
  15. 09 Jul, 2018 1 commit
  16. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  17. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  18. 05 Jun, 2018 1 commit
  19. 30 May, 2018 2 commits
  20. 20 Apr, 2018 1 commit
  21. 12 Mar, 2018 1 commit
  22. 16 Feb, 2018 1 commit
    • Vyacheslav Egorov's avatar
      Fix several Dart 2 issues in the flutter_driver. (#14749) · aa7e9637
      Vyacheslav Egorov authored
      * All lists produced by JSON parsing are List<dynamic>. If more
      speficic type is required then they need to be explicitly cast, e.g.
      using castFrom helper;
      * Function of type (ByText) -> Finder is not a subtype of
      (SerializableFinder) -> Finder because ByText is in the contravariant
      position;
      * In Dart 2 typed(any) should be used instead of any in mockito based
      tests.
      aa7e9637
  23. 07 Dec, 2017 4 commits
  24. 23 Nov, 2017 1 commit
    • Chris Bracken's avatar
      Reorganise flutter driver implementation sources (#13163) · cf37a472
      Chris Bracken authored
      This patch reorganises flutter_driver's lib/src directory into three
      subdirectories:
      
      * driver: sources transitively imported/exported by flutter_driver.dart,
        which defines the API used by driver tests executed on the host machine.
      
      * extension: sources transitively imported/exported by
        driver_extension.dart, which defines the API used to instrument a
        Flutter app running on the target device for use with a driver test.
      
      * common: sources common to both driver and extension code.
      
      This makes rolling Flutter into repositories that use Bazel (or
      Bazel-like build systems) significantly more robust, due to the simpler
      glob patterns involved.
      cf37a472
  25. 11 Sep, 2017 1 commit
    • Yegor's avatar
      only tap on widgets reachable by hit testing (#11767) · ba5b5e7f
      Yegor authored
      * only tap on widgets reachable by hit testing
      
      * use FractionalOffset
      
      * added tests
      
      * check finder finds correct widget
      
      * undo unintentional changes
      
      * address comments
      
      * style fix
      
      * add Directionality in test
      
      * fix analysis warning
      ba5b5e7f
  26. 22 Aug, 2017 1 commit
    • Carlo Bernaschina's avatar
      Add log to understand flakiness of commands_test (#11720) · a8aff388
      Carlo Bernaschina authored
      The flakiness of commands_test is generally visible via:
      
      ```
      drive:stdout:   Expected: 'log: paint'
      drive:stdout:     Actual: ''
      drive:stdout:      Which: is different. Both strings start the same, but the actual value is missing the following trailing characters: log: paint ...
      ```
      
      By returning the name of the test we will be able to understand if
      another test is running by reading the `Actual` value
      a8aff388
  27. 01 Aug, 2017 2 commits
  28. 28 Jul, 2017 1 commit
  29. 21 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Add documentation and clean up code. (#11330) · 8f56f6fd
      Ian Hickson authored
      Mainly, this adds documentation to members that were previously
      lacking documentation.
      
      It also adds a big block of documentation about improving performance
      of widgets.
      
      This also removes some references to package:collection and adds
      global setEquals and listEquals methods in foundation that we can use.
      (setEquals in particular should be much faster than the
      package:collection equivalent, though both should be faster as they
      avoid allocating new objects.) All remaining references now qualify
      the import so we know what our remaining dependencies are.
      
      Also lots of code reordering in Flutter driver to make the code
      consistent and apply the style guide more thoroughly.
      8f56f6fd
  30. 19 Jul, 2017 1 commit
  31. 23 Jun, 2017 1 commit
    • Ian Hickson's avatar
      Deep linking: automatically push the route hiearchy on load. (#10894) · 9adb4a78
      Ian Hickson authored
      The main purpose of this PR is to make it so that when you set the
      initial route and it's a hierarchical route (e.g. `/a/b/c`), it
      implies multiple pushes, one for each step of the route (so in that
      case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those
      routes don't exist, it falls back to '/'.
      
      As part of doing that, I:
      
       * Changed the default for MaterialApp.initialRoute to honor the
         actual initial route.
      
       * Added a MaterialApp.onUnknownRoute for handling bad routes.
      
       * Added a feature to flutter_driver that allows the host test script
         and the device test app to communicate.
      
       * Added a test to make sure `flutter drive --route` works.
         (Hopefully that will also prove `flutter run --route` works, though
         this isn't testing the `flutter` tool's side of that. My main
         concern is over whether the engine side works.)
      
       * Fixed `flutter drive` to output the right target file name.
      
       * Changed how the stocks app represents its data, so that we can
         show a page for a stock before we know if it exists.
      
       * Made it possible to show a stock page that doesn't exist. It shows
         a progress indicator if we're loading the data, or else shows a
         message saying it doesn't exist.
      
       * Changed the pathing structure of routes in stocks to work more
         sanely.
      
       * Made search in the stocks app actually work (before it only worked
         if we happened to accidentally trigger a rebuild). Added a test.
      
       * Replaced some custom code in the stocks app with a BackButton.
      
       * Added a "color" feature to BackButton to support the stocks use case.
      
       * Spaced out the ErrorWidget text a bit more.
      
       * Added `RouteSettings.copyWith`, which I ended up not using.
      
       * Improved the error messages around routing.
      
      While I was in some files I made a few formatting fixes, fixed some
      code health issues, and also removed `flaky: true` from some devicelab
      tests that have been stable for a while. Also added some documentation
      here and there.
      9adb4a78
  32. 13 Jun, 2017 1 commit
  33. 09 Jun, 2017 1 commit