- 25 Jan, 2024 1 commit
-
-
Andrew Kolos authored
Part of work on [#101077](https://github.com/flutter/flutter/pull/141194). This is done as a separate PR to avoid a massive diff. ## Context 1. The `FakeCommand` class accepts a list of patterns that's used to match a command given to its `FakeProcessManager`. Since `FakeCommand` can match a list of patterns, not just specifically strings, it can be used to match commands where the exact value of some arguments can't (easily) known ahead of time. For example, a part of the tool may invoke a command with an argument that is the path of a temporarily file that has a randomly-generated basename. 2. The `FakeCommand` class provides on `onRun` parameter, which is a callback that is run when the `FakeProcessManager` runs a command that matches the `FakeCommand` in question. ## Issue In the event that a `FakeCommand` is constructed using patterns, the test code can't know the exact values used for arguments in the command. This PR proposes changing the type of `onRun` from `VoidCallback?` to `void Function(List<String>)?`. When run, the value `List<String>` parameter will be the full command that the `FakeCommand` matched. Example: ```dart FakeCommand( command: <Pattern>[ artifacts.getArtifactPath(Artifact.engineDartBinary), 'run', 'vector_graphics_compiler', RegExp(r'--input=/.*\.temp'), RegExp(r'--output=/.*\.temp'), ], onRun: (List<String> command) { final outputPath = (() { // code to parse `--output` from `command` })(); testFileSystem.file(outputPath).createSync(recursive: true); }, ) ```
-
- 09 Oct, 2023 1 commit
-
-
Casey Hillers authored
Move more of the playbook into conductor. The MPA command inputs are prone to human error.
-
- 10 Jul, 2023 1 commit
-
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/129744 This change: 1. re-enables the Linux packages_autoroller 2. ensures we redact the token from appearing in any logs (in local testing I realized some failure logs might still expose the token) What actually fixed authentication however was creating and uploading a new GitHub personal access token, not this change. It's currently failing post-submit because being marked `bringup` it is running in the try pool, which does not have permissions to access the cloud KMS. However, I ran a LED build in the prod pool that succeeded: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/fujino_google.com/3a8f128c352fca53a9a29f1e7eab6c3ed24f3bb2a5feb196ea1a69127540e8a6/+/build.proto?server=chromium-swarm.appspot.com
-
- 03 Mar, 2023 1 commit
-
-
Casey Hillers authored
[conductor] Roll engine whenever version is out of date
-
- 10 Feb, 2023 1 commit
-
-
Casey Hillers authored
* [conductor] Tag engine versions * Move tag to repository
-
- 01 Feb, 2023 1 commit
-
-
Kevin Chisholm authored
* update console link * update test to include new console link
-
- 21 Sep, 2022 1 commit
-
-
Xilai Zhang authored
-
- 23 Jun, 2022 1 commit
-
-
Christopher Fujino authored
-
- 12 May, 2022 1 commit
-
-
Casey Hillers authored
-
- 27 Apr, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 30 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 25 Mar, 2022 1 commit
-
-
Casey Hillers authored
-
- 19 Feb, 2022 1 commit
-
-
Christopher Fujino authored
-
- 13 Jan, 2022 1 commit
-
-
Christopher Fujino authored
-
- 07 Dec, 2021 2 commits
-
-
Christopher Fujino authored
-
Christopher Fujino authored
-
- 23 Nov, 2021 1 commit
-
-
Christopher Fujino authored
-
- 20 Nov, 2021 1 commit
-
-
Christopher Fujino authored
-
- 14 Oct, 2021 1 commit
-
-
Christopher Fujino authored
-
- 24 Sep, 2021 1 commit
-
-
Christopher Fujino authored
-
- 16 Sep, 2021 1 commit
-
-
Alex authored
* fixed a small messaging bug * forgot to remove a s
-
- 20 Aug, 2021 1 commit
-
-
Christopher Fujino authored
-
- 16 Aug, 2021 1 commit
-
-
Christopher Fujino authored
-
- 30 Jul, 2021 1 commit
-
-
Christopher Fujino authored
-
- 29 Jul, 2021 1 commit
-
-
Christopher Fujino authored
-
- 08 Jul, 2021 2 commits
-
-
Christopher Fujino authored
-
Christopher Fujino authored
-
- 22 Jun, 2021 1 commit
-
-
Christopher Fujino authored
-