- 18 May, 2016 4 commits
-
-
Ian Hickson authored
Don't suggest filing an issue when we can definitively say that the assertion in question was not thrown from within the flutter package. Fixes https://github.com/flutter/flutter/issues/3812. Put the stack trace first after the message, with more details below the stack trace, since the stack is often very useful and the stacks are no longer stupidly long. Better document the 'rescheduling' feature, and improve the error handling asserts when it is misused. Fixes https://github.com/flutter/flutter/issues/3888. Improve the wording around the stack dump for exceptions during callbacks. Improve the color and font size of messages in live tests. Fixes https://github.com/flutter/flutter/issues/4018.
-
Ian Hickson authored
-
Ian Hickson authored
-
Ian Hickson authored
* Add a "build" phase to EnginePhase for completeness. * Ignore events from the device during test execution. * More dartdocs * Slightly more helpful messages about Timers in verifyInvariants. * Add widgetList, elementList, stateList, renderObjectList. * Send test events asynchronously for consistency with other APIs. * Fix a test that was depending on test events being synchronous (or rather, scheduled in a microtask that came before the microtask for the completer of the future that the tap() function returned).
-
- 17 May, 2016 1 commit
-
-
Ian Hickson authored
Also, make sure that broken tests actually break the bots. And add a test to make sure that keeps happening.
-
- 16 May, 2016 2 commits
-
-
Ian Hickson authored
This exposes the default throttling implementation, and an alternative non-throttling implementation, of `debugPrint`.
-
Ian Hickson authored
This makes it possible to substitute 'flutter run' for 'flutter test' and actually watch a test run on a device. For any test that depends on flutter_test: 1. Remove any import of 'package:test/test.dart'. 2. Replace `testWidgets('...', (WidgetTester tester) {` with `testWidgets('...', (WidgetTester tester) async {` 3. Add an "await" in front of calls to any of the following: * tap() * tapAt() * fling() * flingFrom() * scroll() * scrollAt() * pump() * pumpWidget() 4. Replace any calls to `tester.flushMicrotasks()` with calls to `await tester.idle()`. There's a guarding API that you can use, if you have particularly complicated tests, to get better error messages. Search for TestAsyncUtils.
-
- 04 May, 2016 1 commit
-
-
Adam Barth authored
This test hangs occationally on the bots and the bots aren't smart enough to recover, which means the whole project gets blocked. Filed #3735 about the hang.
-
- 29 Apr, 2016 1 commit
-
-
Ian Hickson authored
* Refactor widget test framework Instead of: ```dart test("Card Collection smoke test", () { testWidgets((WidgetTester tester) { ``` ...you now say: ```dart testWidgets("Card Collection smoke test", (WidgetTester tester) { ``` Instead of: ```dart expect(tester, hasWidget(find.text('hello'))); ``` ...you now say: ```dart expect(find.text('hello'), findsOneWidget); ``` Instead of the previous API (exists, widgets, widget, stateOf, elementOf, etc), you now have the following comprehensive API. All these are functions that take a Finder, except the all* properties. * `any()` - true if anything matches, c.f. `Iterable.any` * `allWidgets` - all the widgets in the tree * `widget()` - the one and only widget that matches the finder * `firstWidget()` - the first widget that matches the finder * `allElements` - all the elements in the tree * `element()` - the one and only element that matches the finder * `firstElement()` - the first element that matches the finder * `allStates` - all the `State`s in the tree * `state()` - the one and only state that matches the finder * `firstState()` - the first state that matches the finder * `allRenderObjects` - all the render objects in the tree * `renderObject()` - the one and only render object that matches the finder * `firstRenderObject()` - the first render object that matches the finder There's also `layers' which returns the list of current layers. `tap`, `fling`, getCenter, getSize, etc, take Finders, like the APIs above, and expect there to only be one matching widget. The finders are: * `find.text(String text)` * `find.widgetWithText(Type widgetType, String text)` * `find.byKey(Key key)` * `find.byType(Type type)` * `find.byElementType(Type type)` * `find.byConfig(Widget config)` * `find.byWidgetPredicate(WidgetPredicate predicate)` * `find.byElementPredicate(ElementPredicate predicate)` The matchers (for `expect`) are: * `findsNothing` * `findsWidgets` * `findsOneWidget` * `findsNWidgets(n)` * `isOnStage` * `isOffStage` * `isInCard` * `isNotInCard` Benchmarks now use benchmarkWidgets instead of testWidgets. Also, for those of you using mockers, `serviceMocker` now automatically handles the binding initialization. This patch also: * changes how tests are run so that we can more easily swap the logic out for a "real" mode instead of FakeAsync. * introduces CachingIterable. * changes how flutter_driver interacts with the widget tree to use the aforementioned new API rather than ElementTreeTester, which is gone. * removes ElementTreeTester. * changes the semantics of a test for scrollables because we couldn't convince ourselves that the old semantics made sense; it only worked before because flushing the microtasks after every event was broken. * fixes the flushing of microtasks after every event. * Reindent the tests * Fix review comments
-
- 28 Apr, 2016 1 commit
-
-
Adam Barth authored
Related to #3608
-
- 26 Apr, 2016 1 commit
-
-
Adam Barth authored
Wait until the end of the microtask to tell gesture recognizers that they've won in the gesture arena. This lets recognizers dispose reject themselves at arbitrary times without triggering gestures in awkward call stacks. Fixes #3183
-
- 25 Apr, 2016 1 commit
-
-
Devon Carew authored
* improve text for devices * nit * tweak text
-
- 22 Apr, 2016 1 commit
-
-
Ian Hickson authored
The old names were getting silly and started stepping on valuable namespace. The new names are consistent and clear.
-
- 21 Apr, 2016 5 commits
-
-
Ian Hickson authored
This reorders some classes so that this file makes more sense, and adds a bunch of docs. It also makes the following changes: * Move allElements from Instrumentation to TestWidgets. (Instrumentation is going away.) * Remove findElements. * Rename byElement to byElementPredicate * Rename byPredicate to byWidgetPredicate * Implement _WidgetPredicateFinder so that byWidgetPredicate has good messages * Fix one use of byElementPredicate to use byWidgetPredicate.
-
Ian Hickson authored
Previously the widgets layer only provided a concrete binding, which makes it awkward to extend it compared to other bindings. This moves widgets to the same style as the other layers. In a subsequent patch I'll use this to make the tests layer saner.
-
Ian Hickson authored
Moves TestGesture into test_pointer.dart and makes it more self-contained. This is part of a general refactoring of flutter_test. Depends on https://github.com/flutter/flutter/pull/3459
-
Hans Muller authored
* Enhance Finder toString()
-
Adam Barth authored
Use the route table to generate the list of screens to test in the smoke test.
-
- 20 Apr, 2016 1 commit
-
-
Ian Hickson authored
Also a bit of code cleanup. The key part of this patch is the addition in `_endScroll` to reset `_simulation`. It seems like this was the one place where it's possible for us to end the animation but not reset our state. Since we assert that are state is coherent, we were hitting asserts when a fling finished and then you interacted with the widget again.
-
- 16 Apr, 2016 1 commit
-
-
Hans Muller authored
-
- 15 Apr, 2016 3 commits
-
-
Yegor authored
-
Ian Hickson authored
We're getting back to the point where we have a bunch of foundation APIs and it's getting confusing having them mixed with services/.
-
Ian Hickson authored
...even if the test fails.
-
- 14 Apr, 2016 1 commit
-
-
Yegor authored
-
- 13 Apr, 2016 1 commit
-
-
Ian Hickson authored
...by adding tests to our examples that don't import flutter_test, which pins the relevant dependencies. Also, provide more information when complaining about leaked transient callbacks in tests. Also, make tests display full information when they have an exception, by bypassing the throttling we have for Android logging in tests. Also, make the word wrapping not wrap stack traces if they happen to be included in exception output. Also, fix a leaked transient callback in the checkbox code.
-
- 02 Apr, 2016 1 commit
-
-
Ian Hickson authored
- Create a FlutterErrorDetails struct-like class that describes an exception along with more details that aren't in the exception, like where it was caught and what was going on when it was caught. - Provide a FlutterError static API for handling these objects: - FlutterError.onError which is called whenever Flutter catches an error. - FlutterError.reportError() which handles an error. - FlutterError.dumpErrorToConsole() which is the default behavior for onError. - Removes all the existing exception handler callbacks. - Replaces all the existing places that described exceptions using debugPrint with calls to FlutterError.reportError(). - Extend lockState() to also catch exceptions, so that we catch exceptions that happen during finalizers. - Make the test framework catch errors and treat them as failures. - Provide a mechanism to override this behavior in the test framework. - Make the tests that used to depend on the exception handler callbacks use this new mechanism. - Make pump() also support the phase argument. - Improve some tests using these new features. Fixes #2356, #2988, #2985, #2220.
-
- 31 Mar, 2016 1 commit
-
-
Kris Giesing authored
Adds BuildOwner to manage the dirty list and build processing for widgets/elements, and adds a widget unit test to make sure separation is enforced. Fixes #2723
-
- 25 Mar, 2016 1 commit
-
-
Andrew Wilson authored
-
- 24 Mar, 2016 1 commit
-
-
Kris Giesing authored
Fixes #2723
-
- 14 Mar, 2016 1 commit
-
-
Hixie authored
-
- 12 Mar, 2016 4 commits
-
-
Adam Barth authored
This patch renames StatelessComponent to StatelessWidget and StatefulComponent to StatefulWidget. Fixes #2308
-
Hixie authored
And fix the zillion issues that uncovered.
-
Ian Hickson authored
This reverts commit f41b3411, reversing changes made to e33d8d96. This was a bad check-in due to my mangling uploading a new version of the branch from a different machine. This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
-
Hixie authored
And fix the zillion issues that uncovered.
-
- 09 Mar, 2016 2 commits
-
-
Hixie authored
It has performance implications in release mode. We'll enable the lint once https://github.com/dart-lang/linter/issues/195 is fixed.
-
Adam Barth authored
After running a widget test, we now clear out the widget tree and check that we didn't leak any timers or animations. Also, fix several bugs that this addtional check revealed. Fixes #2481
-
- 07 Mar, 2016 1 commit
-
-
Ian Hickson authored
-
- 04 Mar, 2016 2 commits
-
-
Kris Giesing authored
-
Kris Giesing authored
Fixes #2198
-
- 03 Mar, 2016 1 commit
-
-
Adam Barth authored
The mojo_sdk has cleaned up its dependencies, so we no longer need to depend on package:test from package:flutter.
-