- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 11 Oct, 2022 1 commit
-
-
Jenn Magder authored
This reverts commit 21fab6f9.
-
- 10 Oct, 2022 1 commit
-
-
fzyzcjy authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 22 Sep, 2020 1 commit
-
-
xubaolin authored
SliverList perform layout start from the initial child when there is no valid layout offset (#66262)
-
- 27 Aug, 2020 1 commit
-
-
Ian Hickson authored
-
- 06 Aug, 2020 1 commit
-
-
Kate Lovett authored
-
- 23 Jun, 2020 1 commit
-
-
chunhtai authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 25 Mar, 2020 1 commit
-
-
chunhtai authored
-
- 20 Mar, 2020 1 commit
-
- 19 Mar, 2020 1 commit
-
-
chunhtai authored
-
- 28 Feb, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 2132a0c7.
-
- 26 Feb, 2020 1 commit
-
- 25 Feb, 2020 1 commit
-
-
Ferhat authored
-
- 04 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/rendering * address review comments
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 19 Jul, 2019 1 commit
-
-
chunhtai authored
-
- 02 May, 2019 1 commit
-
-
Dan Field authored
-
- 11 Apr, 2019 1 commit
-
-
chunhtai authored
-
- 20 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* some space formattings * always use blocks in if-else if a block is used * format spaces in for and while * allow multiline if conditions * fix missing space
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 15 Jun, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 04 May, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 08 Jun, 2017 1 commit
-
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/10547
-
- 26 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 21 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 04 Apr, 2017 1 commit
-
-
Adam Barth authored
This patch adds docs for many of the sliver widgets.
-
- 30 Mar, 2017 1 commit
-
-
Adam Barth authored
This patch adds a notification to SliverChildDelegate that says which children are alive after each layout. The delegate can use this information to optimize it's underlying model of the children (e.g., by discarding models for children that are far outside the live range). Fixes #9045
-
- 29 Mar, 2017 1 commit
-
-
xster authored
-
- 15 Mar, 2017 1 commit
-
-
Adam Barth authored
Also, add a few other random dartdocs that I encountered along the way.
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 16 Feb, 2017 1 commit
-
-
Adam Barth authored
Previously, the scroll correction code path was untested. This patch introduces a test for the code path and fixes two issues with it. There's likely more work we'll need to do in this area to nail down all the cases. Fixes #8155
-
- 09 Feb, 2017 1 commit
-
-
Adam Barth authored
We weren't triggering a relayout when the number of children changed. Fixes #8001
-