Commits · 83e5aca1c97693775f2d8ac5a65278708ae13125 · abdullh.alsoleman / Front-End

21 Jul, 2023 4 commits

Roll Flutter Engine from 218b71cd7a45 to b5a6b1c9cba5 (1 revision) (#131025) · 83e5aca1

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/218b71cd7a45...b5a6b1c9cba5

2023-07-20 dnfield@google.com [Impeller] [Vulkan] Add reset command buffer bit to command pools. (flutter/engine#43867)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83e5aca1

Roll Flutter Engine from ab7d424d4467 to 218b71cd7a45 (2 revisions) (#131024) · a6750235

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/ab7d424d4467...218b71cd7a45

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 981146e6305d to 6f2b2e94ebbd (3 revisions) (flutter/engine#43871)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 100d0f858f02 to 981146e6305d (3 revisions) (flutter/engine#43866)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a6750235

Use downgraded analyze for flutter/packages (#130878) · 273441ee

stuartmorgan authored Jul 21, 2023

Add the `--downgrade` flag to the flutter/packages analyze test, so that it won't get the latest version of dependencies, avoiding out-of-band failures in flutter/flutter due to package publishing events.

Fixes https://github.com/flutter/flutter/issues/129633

273441ee

Roll pub packages (#131022) · 0df683c0
flutter-pub-roller-bot authored Jul 21, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
0df683c0

20 Jul, 2023 32 commits

Roll Flutter Engine from 9b2ebf2afe00 to ab7d424d4467 (4 revisions) (#131015) · f17f7483

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/9b2ebf2afe00...ab7d424d4467

2023-07-20 jonahwilliams@google.com [Impeller] Provide fragment uniform data through varyings for solid color, glyph atlas, texture shaders. (flutter/engine#43838)
2023-07-20 skia-flutter-autoroll@skia.org Roll ANGLE from a4c283be741f to f2e0f8a0b236 (2 revisions) (flutter/engine#43864)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 18e834916f47 to 100d0f858f02 (7 revisions) (flutter/engine#43863)
2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SmAtKPfGzPllC9gfO... to -SaPL-46jpiYbnCAu... (flutter/engine#43862)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from SmAtKPfGzPll to -SaPL-46jpiY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f17f7483

Add applyFocusChangeIfNeeded, have menus restore focus before activating (#130536) · e4a39fa2

Greg Spencer authored Jul 20, 2023

## Description

This modifies the `MenuAnchor` `onPressed` activation to delay until after the current frame is built, and resolve any focus changes before it invokes the `onPressed`, so that actions that operate on the `primaryFocus` can have a chance of working on the focused item they were meant to work on.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/118731

## Tests
 - No tests yet (hence draft still)

e4a39fa2

Migrate more integration tests to process result matcher (#130994) · d457287f
Christopher Fujino authored Jul 20, 2023
```
Part of https://github.com/flutter/flutter/issues/127135
```
d457287f

Roll Flutter Engine from 062079ba30b6 to 9b2ebf2afe00 (2 revisions) (#131013) · 773b667b

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/062079ba30b6...9b2ebf2afe00

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from a3aca7ae523e to 18e834916f47 (1 revision) (flutter/engine#43860)
2023-07-20 mdebbar@google.com Add url to get GoogleFonts API key (flutter/engine#43857)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

773b667b

Trivial grammar and wrapping fix for docs (#130955) · 14c2153b
Ian Hickson authored Jul 20, 2023

14c2153b
Updated the ThemeData API example (#130954) · 93f7dc32
Hans Muller authored Jul 20, 2023

93f7dc32

Roll Flutter Engine from a3fc18514cd6 to 062079ba30b6 (3 revisions) (#131010) · 038e57c0

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/a3fc18514cd6...062079ba30b6

2023-07-20 dnfield@google.com More validation logs for CommandEncoderVK submission (flutter/engine#43859)
2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 857c9a2ae14a to 1df95f328d0c (1 revision) (flutter/engine#43858)
2023-07-20 mdebbar@google.com [web] Preserve correct CanvasKit Variant during test initialization (flutter/engine#43854)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

038e57c0

Roll Flutter Engine from 6d7842d25f81 to a3fc18514cd6 (2 revisions) (#131007) · de26ad0a

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/6d7842d25f81...a3fc18514cd6

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from b8133dda3a8c to a3aca7ae523e (1 revision) (flutter/engine#43855)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 401c85ab1e21 to b8133dda3a8c (4 revisions) (flutter/engine#43853)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de26ad0a

Update `TextSelectionTheme`, `ThemeData`, `TimePicker`, and `TimePickerTheme`... · 0ed17dd5

Qun Cheng authored Jul 20, 2023

Update `TextSelectionTheme`, `ThemeData`, `TimePicker`, and `TimePickerTheme` tests for M2/M3 (#130547)

Updated unit tests for `TextSelectionTheme`, `ThemeData`, `TimePicker` and `TimePickerTheme` to have M2 and M3 versions.

More info in #127064

0ed17dd5

Roll Flutter Engine from c645eb6da8a9 to 6d7842d25f81 (1 revision) (#130992) · d4005a87

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/c645eb6da8a9...6d7842d25f81

2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 603aacd8400f to 857c9a2ae14a (1 revision) (flutter/engine#43851)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d4005a87

Update AutoComplete test for M3 migration (#130883) · 56da3710

Bruno Leroux authored Jul 20, 2023

This PR updates unit tests from autocomplete_test.dart for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

I replaced magic numbers (64.0 and 187.0) and found ways to compute them without relying on the Material version.

56da3710

Update about tests for M3 (#130970) · 2afe8aa5

Bruno Leroux authored Jul 20, 2023

This PR updates unit tests in `about_test.dart` for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

- Two tests were failing in M3 due to a memory leak. As the memory leak is now fixed, see https://github.com/flutter/flutter/pull/130720, this two tests does not depend anymore on the Material version.

- Created several M3 tests related to typography and rendering changes.

2afe8aa5

Roll Packages from 209db219ad73 to 674179f97bda (4 revisions) (#130989) · 67e0e878

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/packages/compare/209db219ad73...674179f97bda

2023-07-19 stuartmorgan@google.com [image_picker] Deprecate platform interface methods (flutter/packages#4520)
2023-07-19 47866232+chunhtai@users.noreply.github.com [go_router] Adds a parentNavigatorKey parameter to ShellRouteData. (flutter/packages#4409)
2023-07-19 stuartmorgan@google.com [ci] Shard Windows Dart unit tests (flutter/packages#4519)
2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter from 6f09064e to d07e8aec (60 revisions) (flutter/packages#4522)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

67e0e878

Roll Flutter Engine from e40995da7869 to c645eb6da8a9 (1 revision) (#130988) · 1a804207

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/e40995da7869...c645eb6da8a9

2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZwCUlo28olVzLlqTl... to hVAAd2NqYOjUF_I99... (flutter/engine#43850)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZwCUlo28olVz to hVAAd2NqYOjU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a804207

Upgrade leak_tracker. (#130951) · e8a975e8
Polina Cherkasova authored Jul 20, 2023

e8a975e8

Roll Flutter Engine from 2df3b9c4b2a4 to e40995da7869 (2 revisions) (#130985) · 98e9a73c

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/2df3b9c4b2a4...e40995da7869

2023-07-20 skia-flutter-autoroll@skia.org Roll ANGLE from 5e38a31bd76a to a4c283be741f (1 revision) (flutter/engine#43849)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 65a83c4de7f2 to 401c85ab1e21 (1 revision) (flutter/engine#43848)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98e9a73c

Roll Flutter Engine from b494143fb0bc to 2df3b9c4b2a4 (3 revisions) (#130973) · f212b101

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/b494143fb0bc...2df3b9c4b2a4

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from d09e9869f84c to 65a83c4de7f2 (2 revisions) (flutter/engine#43847)
2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7kGBjmX-zBXcg1svE... to SmAtKPfGzPllC9gfO... (flutter/engine#43845)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from b238c09fe959 to d09e9869f84c (1 revision) (flutter/engine#43842)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 7kGBjmX-zBXc to SmAtKPfGzPll

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f212b101

Fix chip delete button tap target spilling into the label. (#130896) · f92637d7

Taha Tesser authored Jul 20, 2023

fixes [Chip's delete button tap target is too big](https://github.com/flutter/flutter/issues/129986)

### Description 

This PR fixes the issue where the chip delete button is tappable within the label. 

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: Chip(
          label: const Text('Really Long Label'),
          onDeleted: () {},
        ),
      ),
    );
  }
}
``` 
	
</details>

### Before

https://github.com/flutter/flutter/assets/48603081/14b369c5-c740-4dfc-a512-779bd3a1a46b

### After

https://github.com/flutter/flutter/assets/48603081/08c6e232-0237-4ab2-9829-66ee8e5cead2

f92637d7

Fix IconButton leaks its internal MaterialStatesController (#130720) · 0aba94f4

Bruno Leroux authored Jul 20, 2023

## Description

This PR adds a call to dispose the internal `MaterialStatesController` instantiated by `_SelectableIconButtonState`.

I found this memory leak while working on M2/M3 test update for `about_test.dart`. This memory leak only happens when using M3 because `IconButton` relies on `_SelectableIconButton` only when useMaterial3 is true:

https://github.com/flutter/flutter/blob/3a1190a5a85c3e6a0cf3a9c30f34548fdd48ac1e/packages/flutter/lib/src/material/icon_button.dart#L671-L721

## Related Issue

Fixes https://github.com/flutter/flutter/issues/130708

## Tests

Adds 1 test.

0aba94f4

Update banner_theme_test.dart for M3 (#130884) · ec508319

Bruno Leroux authored Jul 20, 2023

This PR updates unit tests from banner_theme_test.dart for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

Just added some `Material`prefixes.

ec508319

Roll Flutter Engine from 204625490ca1 to b494143fb0bc (1 revision) (#130966) · 4cd9fd00

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/204625490ca1...b494143fb0bc

2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 368a205aa1d4 to 603aacd8400f (1 revision) (flutter/engine#43843)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4cd9fd00

Make PollingDeviceDiscovery start the initial poll faster. (#130755) · d1d78bc9
Lau Ching Jun authored Jul 20, 2023
```
This will speed up the initial population of the device list.
```
d1d78bc9

Roll Flutter Engine from c902fec1e3ce to 204625490ca1 (1 revision) (#130962) · 86c8abf8

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/c902fec1e3ce...204625490ca1

2023-07-20 john@johnmccutchan.com Add a PlatformViewRenderTarget abstraction (flutter/engine#43813)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

86c8abf8

More documentation for MediaQuery and friends (#130509) · a1b13863
Ian Hickson authored Jul 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/11697
```
a1b13863

Roll Flutter Engine from 56e88e8b0eef to c902fec1e3ce (1 revision) (#130960) · 64edc55a

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/56e88e8b0eef...c902fec1e3ce

2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 677bbf64d4d7 to 368a205aa1d4 (1 revision) (flutter/engine#43841)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

64edc55a

Automatically create the layer when setting hints in PaintingContext (#130364) · 3a1300e0
Ian Hickson authored Jul 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/92722
```
3a1300e0

Roll Flutter Engine from e2a36be2f084 to 56e88e8b0eef (1 revision) (#130959) · 123413b0

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/e2a36be2f084...56e88e8b0eef

2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -SNz0augjLKFVsUWn... to ZwCUlo28olVzLlqTl... (flutter/engine#43839)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -SNz0augjLKF to ZwCUlo28olVz

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

123413b0

Further clarify Stack documentation on overflowing (#130776) · 17b732bb
Ian Hickson authored Jul 20, 2023
```
Fixes #75731
```
17b732bb

Roll Flutter Engine from eff70f7287f9 to e2a36be2f084 (2 revisions) (#130956) · 3d7f5752

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/eff70f7287f9...e2a36be2f084

2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 4515b270772e to 5e38a31bd76a (1 revision) (flutter/engine#43836)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 8413c82dea43 to b238c09fe959 (1 revision) (flutter/engine#43835)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d7f5752

Can traverse if current focused node skips traversal (#130812) · 4763be74

chunhtai authored Jul 20, 2023

Currently if the focus is on a focusnode that `skipTraversal = true`, the tab won't be able to traverse focus out of the node.

this pr fixes it

4763be74

Document that you can't change initialRoute usefully (#130450) · 9c8ee4fa
Ian Hickson authored Jul 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/12454
```
9c8ee4fa

Roll Flutter Engine from 7671e2f2a9fc to eff70f7287f9 (3 revisions) (#130953) · 28dfd836

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/7671e2f2a9fc...eff70f7287f9

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833)
2023-07-19 flar@google.com Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#43831)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

28dfd836

19 Jul, 2023 4 commits

Roll Flutter Engine from 938140a974b0 to 7671e2f2a9fc (3 revisions) (#130948) · 1c569e9c

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/938140a974b0...7671e2f2a9fc

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from b1d6eab1f590 to bf75ae2f6eec (2 revisions) (flutter/engine#43829)
2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 4dcaad2a894d to 4515b270772e (2 revisions) (flutter/engine#43830)
2023-07-19 737941+loic-sharma@users.noreply.github.com Add the 'affects: desktop' label to labeler.yml (flutter/engine#43827)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c569e9c

Roll Flutter Engine from 0af285219809 to 938140a974b0 (1 revision) (#130943) · 76017e26

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/0af285219809...938140a974b0

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 30d458aea0b9 to b1d6eab1f590 (2 revisions) (flutter/engine#43826)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

76017e26

Add docs to Route.maintainState (#130638) · 10f46489
Ian Hickson authored Jul 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/44836
```
10f46489

Bump github/codeql-action from 2.20.4 to 2.21.0 (#130941) · 910e87eb

dependabot[bot] authored Jul 19, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.4 to 2.21.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2"><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2"><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
<p>No user facing changes.</p>
<h2>2.20.1 - 21 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.4. <a href="https://redirect.github.com/github/codeql-action/pull/1721">#1721</a></li>
<li>Experimental: add a new <code>resolve-environment</code> action which attempts to infer a configuration for the build environment that is required to build a given project. Do not use this in production as it is part of an internal experiment and subject to change at any time.</li>
</ul>
<h2>2.20.0 - 13 Jun 2023</h2>
<ul>
<li>Bump the version of the Action to 2.20.0. This ensures that users who received a Dependabot upgrade to <a href="https://github.com/github/codeql-action/commit/cdcdbb579706841c47f7063dda365e292e5cad7a"><code>cdcdbb5</code></a>, which was mistakenly marked as Action version 2.13.4, continue to receive updates to the CodeQL Action. Full details in <a href="https://redirect.github.com/github/codeql-action/pull/1729">#1729</a></li>
</ul>
<h2>2.3.6 - 01 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.3. <a href="https://redirect.github.com/github/codeql-action/pull/1698">#1698</a></li>
</ul>
<h2>2.3.5 - 25 May 2023</h2>
<ul>
<li>Allow invalid URIs to be used as values to <code>artifactLocation.uri</code> properties. This reverses a change from <a href="https://redirect.github.com/github/codeql-action/pull/1668">#1668</a> that inadvertently led to stricter validation of some URI values. <a href="https://redirect.github.com/github/codeql-action/pull/1705">#1705</a></li>
<li>Gracefully handle invalid URIs when fingerprinting. <a href="https://redirect.github.com/github/codeql-action/pull/1694">#1694</a></li>
</ul>
<h2>2.3.4 - 24 May 2023</h2>
<ul>
<li>Updated the SARIF 2.1.0 JSON schema file to the latest from <a href="https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json">oasis-tcs/sarif-spec</a>. <a href="https://redirect.github.com/github/codeql-action/pull/1668">#1668</a></li>
<li>We are rolling out a feature in May 2023 that will disable Python dependency installation for new users of the CodeQL Action. This improves the speed of analysis while having only a very minor impact on results. <a href="https://redirect.github.com/github/codeql-action/pull/1676">#1676</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/1813ca74c3faaa3a2da2070b9b8a0b3e7373a0d8"><code>1813ca7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1791">#1791</a> from github/update-v2.21.0-6ae46f7a9</li>
<li><a href="https://github.com/github/codeql-action/commit/684354087657f9de21799430ad93dbce751693fe"><code>6843540</code></a> Update changelog for v2.21.0</li>
<li><a href="https://github.com/github/codeql-action/commit/6ae46f7a92375136e54d98f1562e956ac595c7fc"><code>6ae46f7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1790">#1790</a> from github/henrymercer/aborted-user-error</li>
<li><a href="https://github.com/github/codeql-action/commit/0cae69e06273f42be35cb7080491d9f0a3ff62cf"><code>0cae69e</code></a> Report user errors in the abort stage appropriately</li>
<li><a href="https://github.com/github/codeql-action/commit/d2ed0a05b63da98c856e847eb1a2c07256508499"><code>d2ed0a0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1786">#1786</a> from github/dependabot/npm_and_yarn/npm-0a410f26d2</li>
<li><a href="https://github.com/github/codeql-action/commit/651d09131ae0a806606194b9be1ce5dd31548fa1"><code>651d091</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1788">#1788</a> from github/henrymercer/fix-feature-flag-usage</li>
<li><a href="https://github.com/github/codeql-action/commit/e0f0892f83e1a0cc3252d7670b6f39a0c7b1ebb4"><code>e0f0892</code></a> Add tests for new analysis summary feature flag</li>
<li><a href="https://github.com/github/codeql-action/commit/27d3b2f85746a6ddec4aeadb033c7ebfc6465bdf"><code>27d3b2f</code></a> Fix scaling reserved RAM feature flag naming</li>
<li><a href="https://github.com/github/codeql-action/commit/da4e0a06c0f04ff404830612058d9e7477fabbf2"><code>da4e0a0</code></a> Fix CodeQL version checks</li>
<li><a href="https://github.com/github/codeql-action/commit/e266801e21b8b911929eb77e4c8493192846b843"><code>e266801</code></a> Update checked-in dependencies</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/489225d82a57396c6f426a40e66d461b16b3461d...1813ca74c3faaa3a2da2070b9b8a0b3e7373a0d8">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.20.4&new-version=2.21.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

910e87eb