Commits · 83c24274bbc2eabd3be250367c7c529fd81dfe96 · abdullh.alsoleman / Front-End

07 Sep, 2023 3 commits

Roll Flutter Engine from 75437a3bd002 to 187c5b3c5f71 (1 revision) (#134193) · 83c24274

engine-flutter-autoroll authored Sep 07, 2023

https://github.com/flutter/engine/compare/75437a3bd002...187c5b3c5f71

2023-09-07 bdero@google.com [Impeller] Gaussian blur: Remove lingering BlurStyle vertex data/uniforms. (flutter/engine#45524)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83c24274

Manual roll Flutter Engine from 2c69d05dfafb to 75437a3bd002 (15 revisions) (#134188) · 14ced759

engine-flutter-autoroll authored Sep 07, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/2c69d05dfafb...75437a3bd002

2023-09-07 zanderso@users.noreply.github.com Revert "Enforce the rule of calling `FlutterView.Render`" (flutter/engine#45525)
2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 2b76d1113497 to 9e86d3f6239a (1 revision) (flutter/engine#45521)
2023-09-07 bdero@google.com [Impeller] Gaussian blur: Remove the current blur style implementation. (flutter/engine#45520)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 9c9757c5d17d to 2b76d1113497 (2 revisions) (flutter/engine#45518)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 0039caadd635 to 9c9757c5d17d (1 revision) (flutter/engine#45516)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 00daa451320c to 60b56591dee5 (1 revision) (flutter/engine#45517)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8dgICHnG28wNHzoz3... to SCoDb2m_zQDLrMhwT... (flutter/engine#45514)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from a274609c442c to 0039caadd635 (2 revisions) (flutter/engine#45513)
2023-09-06 stuartmorgan@google.com Add macOS support for plugin value publishing (flutter/engine#45502)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from e5ed4ffaaaa4 to a274609c442c (2 revisions) (flutter/engine#45510)
2023-09-06 zanderso@users.noreply.github.com Roll Fuchsia with license script fix (flutter/engine#45498)
2023-09-06 dkwingsmt@users.noreply.github.com Enforce the rule of calling `FlutterView.Render` (flutter/engine#45300)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 7b0bb0f6e785 to 00daa451320c (1 revision) (flutter/engine#45507)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 59e54ccf25a4 to e5ed4ffaaaa4 (4 revisions) (flutter/engine#45506)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dFe-t1SosqZwU5lZR... to hHwU6r12A0sy5Bq-0... (flutter/engine#45505)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from z9uQ0mXwjKFQ to SCoDb2m_zQDL
fuchsia/sdk/core/mac-amd64 from dFe-t1SosqZw to hHwU6r12A0sy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14ced759

Revert "Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions)" (#134183) · e8ff2aed
Zachary Anderson authored Sep 07, 2023
```
Reverts flutter/flutter#134169

windows_startup_test is failing following the roll
```
e8ff2aed

06 Sep, 2023 24 commits

Bump actions/upload-artifact from 3.1.2 to 3.1.3 (#134173) · cf1968aa

dependabot[bot] authored Sep 06, 2023

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v3.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(github): remove trailing whitespaces by <a href="https://github.com/ljmf00"><code>@âljmf00</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/313">actions/upload-artifact#313</a></li>
<li>Bump <code>@âactions/artifact</code> version to v1.1.2 by <a href="https://github.com/bethanyj28"><code>@âbethanyj28</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/436">actions/upload-artifact#436</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v3.1.3">https://github.com/actions/upload-artifact/compare/v3...v3.1.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/upload-artifact/commit/a8a3f3ad30e3422c9c7b888a15615d19a852ae32"><code>a8a3f3a</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/436">#436</a> from bethanyj28/main</li>
<li><a href="https://github.com/actions/upload-artifact/commit/7b48769c030f7121ecb01c3558dd3cd8b9660a20"><code>7b48769</code></a> update dependency cache</li>
<li><a href="https://github.com/actions/upload-artifact/commit/66630398dfe3d04deb4c489ac54b9b468f071706"><code>6663039</code></a> update dist/index.js</li>
<li><a href="https://github.com/actions/upload-artifact/commit/55e76b779da56f582e27a6f7aff54c1e610551e5"><code>55e76b7</code></a> bump <code>@âactions/artifact</code> version</li>
<li><a href="https://github.com/actions/upload-artifact/commit/65d862660abb392b8c4a3d1195a2108db131dd05"><code>65d8626</code></a> chore(github): remove trailing whitespaces (<a href="https://redirect.github.com/actions/upload-artifact/issues/313">#313</a>)</li>
<li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/0b7f8abb1508181956e8e162db84b466c27e18ce...a8a3f3ad30e3422c9c7b888a15615d19a852ae32">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3.1.2&new-version=3.1.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

cf1968aa

Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions) (#134169) · f0394437

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/2c69d05dfafb...fa14d337449b

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from e5ed4ffaaaa4 to a274609c442c (2 revisions) (flutter/engine#45510)
2023-09-06 zanderso@users.noreply.github.com Roll Fuchsia with license script fix (flutter/engine#45498)
2023-09-06 dkwingsmt@users.noreply.github.com Enforce the rule of calling `FlutterView.Render` (flutter/engine#45300)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 7b0bb0f6e785 to 00daa451320c (1 revision) (flutter/engine#45507)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 59e54ccf25a4 to e5ed4ffaaaa4 (4 revisions) (flutter/engine#45506)
2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dFe-t1SosqZwU5lZR... to hHwU6r12A0sy5Bq-0... (flutter/engine#45505)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from z9uQ0mXwjKFQ to 8dgICHnG28wN
fuchsia/sdk/core/mac-amd64 from dFe-t1SosqZw to hHwU6r12A0sy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f0394437

DraggableScrollableActuator should dispose notifier. (#133917) · 1f0730e6
Polina Cherkasova authored Sep 06, 2023

1f0730e6

Roll Flutter Engine from b04c2a378302 to 2c69d05dfafb (3 revisions) (#134164) · 41ebf282

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/b04c2a378302...2c69d05dfafb

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 1b8ab5382ff6 to 7b0bb0f6e785 (2 revisions) (flutter/engine#45503)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 487cd9240571 to 59e54ccf25a4 (1 revision) (flutter/engine#45504)
2023-09-06 zanderso@users.noreply.github.com Roll clang to 576b184d6e3b633f51b908b61ebd281d2ecbf66f (flutter/engine#45499)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

41ebf282

Clean the fixed TODOs. (#133859) · 420aa9f7

Polina Cherkasova authored Sep 06, 2023

https://github.com/flutter/flutter/issues/130354 is fixed, but the test still fails, so converted it back to 'testWidgets' to investigate later.

420aa9f7

Roll Flutter Engine from 839051596b1d to b04c2a378302 (7 revisions) (#134158) · 4184a1d2

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/839051596b1d...b04c2a378302

2023-09-06 nshahan@google.com Update deps on DDC build targets (flutter/engine#45404)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 99bcee22f87d to 487cd9240571 (1 revision) (flutter/engine#45500)
2023-09-06 30870216+gaaclarke@users.noreply.github.com Remove android API 26 bump for validation layers (flutter/engine#45468)
2023-09-06 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#45480)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4468ef79f3d7 to 99bcee22f87d (5 revisions) (flutter/engine#45495)
2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 55d3636b66e0 to 1b8ab5382ff6 (1 revision) (flutter/engine#45494)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 596a1f192faa to 4468ef79f3d7 (2 revisions) (flutter/engine#45493)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4184a1d2

[Windows Arm64] Also use Windows 11 for Devicelab tests (#134082) · d792c664

Loïc Sharma authored Sep 06, 2023

Currently, the Windows Arm64 tests try to run on Windows 10 devices.
However, [all Windows Arm64 devices use Windows
11](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows-11&f=pool%3Aluci.flutter.staging&s=id)
which result in the Windows Arm64 tests not running. This updates the
configuration to accept both Windows 10 and 11 (ideally the tests would
run on both OSes).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d792c664

Fix `subtitleTextStyle.color` isn't applied to the `ListTile.subtitle` in Material 2 (#133422) · cd9a257d

Burak İmdat authored Sep 06, 2023

The difference between header text style and subtitle text style and the reason why it doesn't work is the code difference below. If we make the subtitle text style the same as the title text style it will work

<details>
  <summary>Title Text Style</summary>
  
  ###  All Code
  
  ```dart
  TextStyle titleStyle = titleTextStyle
      ?? tileTheme.titleTextStyle
      ?? defaults.titleTextStyle!;
    final Color? titleColor = effectiveColor;
    titleStyle = titleStyle.copyWith(
      color: titleColor,
      fontSize: _isDenseLayout(theme, tileTheme) ? 13.0 : null,
    );
    final Widget titleText = AnimatedDefaultTextStyle(
      style: titleStyle,
      duration: kThemeChangeDuration,
      child: title ?? const SizedBox(),
    );
  ```
  
  ## Different Code Section
  
  ```dart
  final Color? titleColor = effectiveColor;
  ```
</details>

<details>
  <summary>Subtitle Text Style</summary>
  
  ## All Code
  
  ```dart
  subtitleStyle = subtitleTextStyle
        ?? tileTheme.subtitleTextStyle
        ?? defaults.subtitleTextStyle!;
      final Color? subtitleColor = effectiveColor
        ?? (theme.useMaterial3 ? null : theme.textTheme.bodySmall!.color);
      subtitleStyle = subtitleStyle.copyWith(
        color: subtitleColor,
        fontSize: _isDenseLayout(theme, tileTheme) ? 12.0 : null,
      );
      subtitleText = AnimatedDefaultTextStyle(
        style: subtitleStyle,
        duration: kThemeChangeDuration,
        child: subtitle!,
      );
  ```
  
  ## Different Code Section
  
  ```dart
  final Color? subtitleColor = effectiveColor
        ?? (theme.useMaterial3 ? null : theme.textTheme.bodySmall!.color);
  ```

### Description for code 
- The value `theme.textTheme.bodySmall!.color` is given because the `effectiveColor` value is `null` and the `theme.useMaterial3` value is `false`
</details>

<details>
  <summary>Problem solved code</summary>
  
  ## All Code
  
  ```dart
  subtitleStyle = subtitleTextStyle
        ?? tileTheme.subtitleTextStyle
        ?? defaults.subtitleTextStyle!;
      final Color? subtitleColor = effectiveColor;
      subtitleStyle = subtitleStyle.copyWith(
        color: subtitleColor,
        fontSize: _isDenseLayout(theme, tileTheme) ? 12.0 : null,
      );
      subtitleText = AnimatedDefaultTextStyle(
        style: subtitleStyle,
        duration: kThemeChangeDuration,
        child: subtitle!,
      );
  ```
</details>

<details>
<summary>Screenshot of the result after making the necessary change</summary>
<img src="https://github.com/flutter/flutter/assets/70351342/b552fd4c-fdcd-4bf5-b4ba-d6b2cfe527cc" width=250>
</details>

#133412

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

cd9a257d

Add `CheckedPopupMenuItem.onTap` callback (#134000) · b0e5a5ca
Tirth authored Sep 06, 2023
```
Adds parent prop `onTap` to CheckedPopupMenuItem.

Fixes #127800
```
b0e5a5ca
MinimumTextContrastGuideline should dispose image. (#133861) · ee0a15d4
Polina Cherkasova authored Sep 06, 2023

ee0a15d4
[flutter_tools] Fix "FormatException: Invalid date format" during version freshness check (#134088) · 195dca02
Christopher Fujino authored Sep 06, 2023
```
Fixes https://github.com/flutter/flutter/issues/134067
```
195dca02
Fix not disposed items in Cupertino app and route. (#134085) · 61a388a4
Polina Cherkasova authored Sep 06, 2023

61a388a4

Roll Flutter Engine from a5e7fa6bf81a to 839051596b1d (2 revisions) (#134140) · 99f5cf07

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/a5e7fa6bf81a...839051596b1d

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from a74a98890cc1 to 596a1f192faa (1 revision) (flutter/engine#45492)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from d603af2045ce to a74a98890cc1 (2 revisions) (flutter/engine#45491)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99f5cf07

_DropdownMenuState should dispose TextEditingController. (#133914) · 03b60ac7
Polina Cherkasova authored Sep 06, 2023

03b60ac7

Roll Flutter Engine from 5253a33096d1 to a5e7fa6bf81a (1 revision) (#134137) · 03fcfbef

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/5253a33096d1...a5e7fa6bf81a

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 2cc5d8f0b0ef to d603af2045ce (1 revision) (flutter/engine#45490)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

03fcfbef

Roll Flutter Engine from c7fd088291e2 to 5253a33096d1 (1 revision) (#134135) · c97e7fd4

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/c7fd088291e2...5253a33096d1

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 0d91e2410d0e to 2cc5d8f0b0ef (1 revision) (flutter/engine#45489)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c97e7fd4

Roll Flutter Engine from 3d9989f1e155 to c7fd088291e2 (1 revision) (#134132) · 90d6b0bf

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/3d9989f1e155...c7fd088291e2

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 5116f54eca4f to 55d3636b66e0 (1 revision) (flutter/engine#45488)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90d6b0bf

Roll Flutter Engine from bace539bb654 to 3d9989f1e155 (3 revisions) (#134128) · 151e8b57

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/bace539bb654...3d9989f1e155

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from d664543f3e6d to 5116f54eca4f (1 revision) (flutter/engine#45487)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from a7f50692638d to 0d91e2410d0e (1 revision) (flutter/engine#45485)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 619eef2d0d67 to a7f50692638d (1 revision) (flutter/engine#45483)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

151e8b57

Roll Flutter Engine from 9344685efbc3 to bace539bb654 (1 revision) (#134104) · 3e65d04c

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/9344685efbc3...bace539bb654

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 72d57724bcb8 to 619eef2d0d67 (1 revision) (flutter/engine#45481)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e65d04c

Roll Flutter Engine from 0c8c1647dcd0 to 9344685efbc3 (1 revision) (#134103) · 7b0b0e27

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/0c8c1647dcd0...9344685efbc3

2023-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bHw1LzoikQJthLkTE... to dFe-t1SosqZwU5lZR... (flutter/engine#45479)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bHw1LzoikQJt to dFe-t1SosqZw

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b0b0e27

Roll Flutter Engine from 0c663258fd09 to 0c8c1647dcd0 (1 revision) (#134100) · f4a6f69d

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/0c663258fd09...0c8c1647dcd0

2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 0ff71d5ecd25 to d664543f3e6d (1 revision) (flutter/engine#45477)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f4a6f69d

Roll Flutter Engine from 8bacc3b38707 to 0c663258fd09 (3 revisions) (#134096) · 1db39ddc

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/8bacc3b38707...0c663258fd09

2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 3a3a64670e08 to 72d57724bcb8 (1 revision) (flutter/engine#45476)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from ce2da423cb5d to 3a3a64670e08 (1 revision) (flutter/engine#45475)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 0a253625a76a to ce2da423cb5d (1 revision) (flutter/engine#45473)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1db39ddc

Roll Flutter Engine from 590349006d23 to 8bacc3b38707 (5 revisions) (#134089) · 70c35bb5

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/590349006d23...8bacc3b38707

2023-09-06 jonahwilliams@google.com [Impeller] construct text frames on UI thread. (flutter/engine#45418)
2023-09-06 jiahaog@users.noreply.github.com Add import for `<unordered_map>` to fix the g3 build (flutter/engine#45471)
2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from af473004622f to 0a253625a76a (2 revisions) (flutter/engine#45470)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 1019c10a2d38 to af473004622f (2 revisions) (flutter/engine#45469)
2023-09-05 zanderso@users.noreply.github.com Adds a comment on clang_arm64_apilevel26 toolchain usage (flutter/engine#45467)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70c35bb5

Roll Flutter Engine from 5b2cc9d9b8fe to 590349006d23 (2 revisions) (#134081) · 3871139f

engine-flutter-autoroll authored Sep 06, 2023

https://github.com/flutter/engine/compare/5b2cc9d9b8fe...590349006d23

2023-09-05 ychris@google.com [iOS ] Fix errors in unittest and scenario tests running against iOS 17 simulators (details in the description) (flutter/engine#45391)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 2b9fc6a2c250 to 1019c10a2d38 (2 revisions) (flutter/engine#45466)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3871139f

05 Sep, 2023 13 commits

Roll Flutter Engine from 98b036ae708e to 5b2cc9d9b8fe (2 revisions) (#134080) · db0daa09

engine-flutter-autoroll authored Sep 05, 2023

https://github.com/flutter/engine/compare/98b036ae708e...5b2cc9d9b8fe

2023-09-05 ychris@google.com Fix iOS unittests leak in shared.invoke method channel that causes crash (flutter/engine#45416)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 7e80aedd05b6 to 2b9fc6a2c250 (1 revision) (flutter/engine#45465)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

db0daa09

Roll Flutter Engine from f4975e04f35e to 98b036ae708e (3 revisions) (#134077) · 9bde4f70

engine-flutter-autoroll authored Sep 05, 2023

https://github.com/flutter/engine/compare/f4975e04f35e...98b036ae708e

2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 72c56fab439c to 7e80aedd05b6 (1 revision) (flutter/engine#45464)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from a0572041af8e to 72c56fab439c (1 revision) (flutter/engine#45463)
2023-09-05 skia-flutter-autoroll@skia.org Roll ANGLE from dcd62fc41c3b to 0ff71d5ecd25 (2 revisions) (flutter/engine#45462)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9bde4f70

Retry connecting to device in CI after lost connection (#133769) · 6c564216

Victoria Ashworth authored Sep 05, 2023

Sometimes `ios-deploy` loses connection to the device after installing, starting debugserver, and launching. This is shown with an error message like:
```
Process 579 exited with status = -1 (0xffffffff) lost connection
```
This happens frequently in our CI system: https://github.com/flutter/flutter/issues/120808

Usually in CI, on retry it'll work and pass - so this is an attempt to retry without failing the test first. It's not guaranteed to fix since we're unable to recreate this error locally.

6c564216

Roll Flutter Engine from 1a6b47af3eb0 to f4975e04f35e (16 revisions) (#134069) · d6edbfc3

engine-flutter-autoroll authored Sep 05, 2023

https://github.com/flutter/engine/compare/1a6b47af3eb0...f4975e04f35e

2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from c07fbf4c1d67 to a0572041af8e (3 revisions) (flutter/engine#45460)
2023-09-05 skia-flutter-autoroll@skia.org Roll ANGLE from 9666d4d5f7c8 to dcd62fc41c3b (1 revision) (flutter/engine#45457)
2023-09-05 jonahwilliams@google.com [Impeller] compute path bounds once, use Skia computed bounds where possible. (flutter/engine#45456)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from d8ea902500a3 to c07fbf4c1d67 (2 revisions) (flutter/engine#45451)
2023-09-05 zanderso@users.noreply.github.com Adds a Dart library for loading and parsing build configs (flutter/engine#45390)
2023-09-05 skia-flutter-autoroll@skia.org Roll ANGLE from 17c4741d70dd to 9666d4d5f7c8 (1 revision) (flutter/engine#45453)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 055b26152483 to d8ea902500a3 (1 revision) (flutter/engine#45448)
2023-09-05 skia-flutter-autoroll@skia.org Roll ANGLE from e72efa276c45 to 17c4741d70dd (1 revision) (flutter/engine#45449)
2023-09-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qe_q1aYCmE0eC-2Yz... to bHw1LzoikQJthLkTE... (flutter/engine#45447)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 9ef0225b5f8a to 055b26152483 (1 revision) (flutter/engine#45446)
2023-09-05 skia-flutter-autoroll@skia.org Roll ANGLE from b62216047112 to e72efa276c45 (1 revision) (flutter/engine#45443)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 7d0e33e32427 to 9ef0225b5f8a (1 revision) (flutter/engine#45442)
2023-09-05 skia-flutter-autoroll@skia.org Roll ANGLE from e691a4edb19a to b62216047112 (1 revision) (flutter/engine#45441)
2023-09-05 skia-flutter-autoroll@skia.org Roll Skia from 8206402f3c35 to 7d0e33e32427 (2 revisions) (flutter/engine#45440)
2023-09-05 skia-flutter-autoroll@skia.org Roll ANGLE from ab9bbb9b11b3 to e691a4edb19a (1 revision) (flutter/engine#45437)
2023-09-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from A82pOZ3-NNgfJ2Da7... to qe_q1aYCmE0eC-2Yz... (flutter/engine#45436)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from A82pOZ3-NNgf to bHw1LzoikQJt

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d6edbfc3

Revert "CupertinoAlertDialog should not create ScrollController on every... · a425e562

Polina Cherkasova authored Sep 05, 2023

Revert "CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor." (#134071)

Reverts flutter/flutter#133918 as it causes build failures.

a425e562

Revert "_SearchBarState should dispose FocusNode, if it created it." (#134072) · e30f9c42
Polina Cherkasova authored Sep 05, 2023
```
Reverts flutter/flutter#133947 as it causes build failures.
```
e30f9c42

Dispose AnimationSheetRecorder to avoid leaks (#133365) · e66ec8e0

Tong Mu authored Sep 05, 2023

This PR adds `AnimationSheetRecorder.dispose`, which disposes all the images generated by the recorder, eliminating leaks.

Fixes https://github.com/flutter/flutter/issues/133071.

e66ec8e0

Cover more tests with leak tracking. (#133958) · a7dbec31
Polina Cherkasova authored Sep 05, 2023

a7dbec31
_MaterialAppState should dispose MaterialHeroController. (#133951) · 7625c10f
Polina Cherkasova authored Sep 05, 2023

7625c10f
RenderParagraph should dispose instances of SelectableFragments. (#133915) · af1b7494
Polina Cherkasova authored Sep 05, 2023

af1b7494
_SearchBarState should dispose FocusNode, if it created it. (#133947) · c9f70e9f
Polina Cherkasova authored Sep 05, 2023

c9f70e9f
CupertinoAlertDialog should not create ScrollController on every build, if... · 7cdf314d
Polina Cherkasova authored Sep 05, 2023
```
CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. (#133918)
```
7cdf314d

[Reland] Fix flavors test install checks (#134060) · c05dc3e6

Andrew Kolos authored Sep 05, 2023

Reland of https://github.com/flutter/flutter/pull/133719. Updates [the string comparison in flavor_test.dart](https://github.com/flutter/flutter/pull/134060/files#diff-53383b32b975bfed6875306dfb98911cad077a5251ca0591c5b0e125fb4a0f05R39) to use `path.join` to build the path string so that the generated path is correct for both Linux and Windows hosts.

Fixes https://github.com/flutter/flutter/issues/133713

I've tested this on a Windows host targeting a physical Android device.

c05dc3e6