1. 22 Mar, 2019 1 commit
  2. 15 Mar, 2019 1 commit
    • Justin McCandless's avatar
      Text field height attempt 2 (#29250) · 6d8f5399
      Justin McCandless authored
      Adds the `minLines` and `expands` parameters for controlling text height.  The original PR was reverted, so this one contains a few extra fixes for the tests that were broken.
      6d8f5399
  3. 09 Mar, 2019 1 commit
  4. 08 Mar, 2019 1 commit
    • Justin McCandless's avatar
      Fix TextField height issues (#27205) · 9e9f48da
      Justin McCandless authored
      * Create new TextField attribute to control maxLength behaviour
      
      * Create test case for maxLinesIncrementalHeight
      
      * fix maxLinesIncrementalHeight set method
      
      * fix editable_test.dart
      
      * Just introducing some proposed API additions, renaming to expands
      
      * Pass minLines and expands through to child widgets and validate
      
      * minLines can't be null, and expands can't be true when maxLines is 1
      
      * Implement minLines and maxLines height sizing logic
      
      * Simplify minLines validation logic
      
      * expands parameter proof of concept
      
      * min/max mixup bug fix, and tests work with expands false
      
      * Test expands=true cases, and fix textPainter.height being out of date
      
      * Test all behavior matrix cases
      
      * min/max assertion more strict, can't be equal
      
      * Tests work that were missing expands serialization
      
      * Action sheet tests no longer fail due to rounding error
      
      * TextFieldFocus test no longer mysteriously fails
      
      * TODOs for making expands nullable. Will depend on how Expanded wrapping works
      
      * Expanded growth happens when expanded is true and maxLines is null
      
      * Test Expanded wrapper
      
      * No more overflow when wrapped in Expanded
      
      * Docs improvements
      
      * expands can be null
      
      * Simplify error cases to support existing behavior
      
      * Docs examples and other docs cleanup
      
      * Expansion up to perfectly meet the parent size
      
      * Fix analyze null error
      
      * Fix test after move to nullable expands
      
      * minLines defaults to null
      
      * expands is now exclusively for expanding to parent height and not growth between min and max
      
      * _layout rewritten to handle max height. Need to fix prefix tests and
      reenable expands
      
      * Tests for textfield overflowing parent
      
      * layoutLineBox is documented and private
      
      * expands works in new _layout
      
      * _layout return numbers seem to perfectly match original _layout
      
      * inputWidth comment after trying it out and failing tests
      
      * Fix analyze errors
      
      * WIP prefix/suffix do affect height
      
      * Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original
      
      * Tall prefix test that verifies pixel perfect layout
      
      * Fix overflowing edge case and test it
      
      * Clean up comments, old code, and todos
      
      * Changing _expands causes relayout. Wasnt able to figure out how to test though...
      
      * Clean up code review comments
      
      * Fix misalignment when tall prefix and border, and clean up related test
      
      * Simple code review cleanup
      
      * Bring back inputWidth to _layout method
      
      * Fix rounding errors showing up in mac tests
      
      * Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine.
      
      * Fix more rounding error mac tests
      9e9f48da
  5. 01 Mar, 2019 2 commits
  6. 28 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Fix spelling errors. (#28657) · ccdd5057
      Greg Spencer authored
      Fix the spelling errors in the dartdocs for the framework.
      
      There are no functionality changes here, just documentation fixes.
      ccdd5057
  7. 27 Feb, 2019 1 commit
  8. 25 Feb, 2019 2 commits
  9. 23 Feb, 2019 1 commit
  10. 21 Feb, 2019 1 commit
  11. 20 Feb, 2019 1 commit
  12. 13 Feb, 2019 1 commit
  13. 12 Feb, 2019 1 commit
  14. 08 Feb, 2019 1 commit
  15. 06 Feb, 2019 1 commit
  16. 01 Feb, 2019 1 commit
  17. 29 Jan, 2019 1 commit
  18. 18 Jan, 2019 1 commit
  19. 17 Jan, 2019 1 commit
  20. 14 Jan, 2019 2 commits
    • Justin McCandless's avatar
      InputDecorator Count Widget (#25095) · de2470ff
      Justin McCandless authored
      * Allow a widget to be specified for the textfield count, and allow no count at all
      
      * Test all possible states for counter and counterText
      
      * Docs for counter
      
      * counter is a function that generates a widget
      
      * Tests use counter as function
      
      * Fix analyze error in docs
      
      * InputDecoration has counter widget, TextField has buildCounter function
      
      * InputDecorator tests expect counter to be widget again and include
      buildCounter
      
      * counter widget example that might actually fit
      
      * Clarify accessiblity concerns in docs
      
      * Include isFocused param for accessibility
      
      * Fix analyze error
      
      * Improve docs per code review
      
      * Rearrange getEffectiveDecoration a bit for clarity
      
      * Fix analyze error about hashValues params
      
      * Clean up docs and redundant code per code review
      
      * Code review doc improvement
      
      * Automatically wrap buildCounter widget in a Semantics widget for accessibility
      de2470ff
    • jslavitz's avatar
      Selects a word on force tap (#25683) · 43770838
      jslavitz authored
      * adds force press select word functionality
      43770838
  21. 09 Jan, 2019 1 commit
  22. 08 Jan, 2019 1 commit
  23. 07 Jan, 2019 1 commit
  24. 04 Jan, 2019 1 commit
  25. 21 Dec, 2018 1 commit
  26. 18 Dec, 2018 3 commits
  27. 17 Dec, 2018 1 commit
    • Justin McCandless's avatar
      Revert "Revert "obscureText and enableInteractiveSelection defaults"" (#25342) · a039b2ca
      Justin McCandless authored
      * Revert "Add imports section to sample code templates, and more docs. (#25184)"
      
      This reverts commit 95b01247.
      
      * Revert "Use stderr instead of stdout to contain errors in flutter attach test (#25305)"
      
      This reverts commit 2b819dd2.
      
      * Revert "Allow detection of taps on TabBar (#23919)"
      
      This reverts commit 01694ab6.
      
      * Revert "a549981da Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter/engine#7211) (#25333)"
      
      This reverts commit a37099f3.
      
      * Revert "Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)"
      
      This reverts commit c5457068.
      
      * Password fields are no longer selectable nor copiable
      a039b2ca
  28. 14 Dec, 2018 4 commits
  29. 13 Dec, 2018 3 commits
  30. 12 Dec, 2018 1 commit