- 22 Mar, 2019 1 commit
-
-
Mouad Debbar authored
-
- 15 Mar, 2019 1 commit
-
-
Justin McCandless authored
Adds the `minLines` and `expands` parameters for controlling text height. The original PR was reverted, so this one contains a few extra fixes for the tests that were broken.
-
- 09 Mar, 2019 1 commit
-
-
Todd Volkert authored
This reverts commit 9e9f48da.
-
- 08 Mar, 2019 1 commit
-
-
Justin McCandless authored
* Create new TextField attribute to control maxLength behaviour * Create test case for maxLinesIncrementalHeight * fix maxLinesIncrementalHeight set method * fix editable_test.dart * Just introducing some proposed API additions, renaming to expands * Pass minLines and expands through to child widgets and validate * minLines can't be null, and expands can't be true when maxLines is 1 * Implement minLines and maxLines height sizing logic * Simplify minLines validation logic * expands parameter proof of concept * min/max mixup bug fix, and tests work with expands false * Test expands=true cases, and fix textPainter.height being out of date * Test all behavior matrix cases * min/max assertion more strict, can't be equal * Tests work that were missing expands serialization * Action sheet tests no longer fail due to rounding error * TextFieldFocus test no longer mysteriously fails * TODOs for making expands nullable. Will depend on how Expanded wrapping works * Expanded growth happens when expanded is true and maxLines is null * Test Expanded wrapper * No more overflow when wrapped in Expanded * Docs improvements * expands can be null * Simplify error cases to support existing behavior * Docs examples and other docs cleanup * Expansion up to perfectly meet the parent size * Fix analyze null error * Fix test after move to nullable expands * minLines defaults to null * expands is now exclusively for expanding to parent height and not growth between min and max * _layout rewritten to handle max height. Need to fix prefix tests and reenable expands * Tests for textfield overflowing parent * layoutLineBox is documented and private * expands works in new _layout * _layout return numbers seem to perfectly match original _layout * inputWidth comment after trying it out and failing tests * Fix analyze errors * WIP prefix/suffix do affect height * Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original * Tall prefix test that verifies pixel perfect layout * Fix overflowing edge case and test it * Clean up comments, old code, and todos * Changing _expands causes relayout. Wasnt able to figure out how to test though... * Clean up code review comments * Fix misalignment when tall prefix and border, and clean up related test * Simple code review cleanup * Bring back inputWidth to _layout method * Fix rounding errors showing up in mac tests * Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine. * Fix more rounding error mac tests
-
- 01 Mar, 2019 2 commits
-
-
Mouad Debbar authored
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 28 Feb, 2019 1 commit
-
-
Greg Spencer authored
Fix the spelling errors in the dartdocs for the framework. There are no functionality changes here, just documentation fixes.
-
- 27 Feb, 2019 1 commit
-
-
Kate Lovett authored
* Added code snippet for TextField class. ref:#21136 * Errant semicolon
-
- 25 Feb, 2019 2 commits
-
-
xster authored
-
jslavitz authored
Breaks the moveBy call from drag and dragFrom into two separate calls and changes the default behavior of DragStartBehavior to DragStartBehavior.start (#26438) * Breaking change which sets the default DragStartBehavior to DragStartBehavior.start and changes WidgetTester.drag and WidgetTester.dragFrom by breaking the moveBy function call into multiple pieces.
-
- 23 Feb, 2019 1 commit
-
-
Gary Qian authored
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Feb, 2019 1 commit
-
-
xster authored
-
- 13 Feb, 2019 1 commit
-
-
jslavitz authored
* Fixes offset and unblocks roll
-
- 12 Feb, 2019 1 commit
-
-
xster authored
-
- 08 Feb, 2019 1 commit
-
-
Hans Muller authored
-
- 06 Feb, 2019 1 commit
-
-
xster authored
-
- 01 Feb, 2019 1 commit
-
-
MhdHejazi authored
-
- 29 Jan, 2019 1 commit
-
-
jslavitz authored
* Fixes cursor on iOS devices
-
- 18 Jan, 2019 1 commit
-
-
jslavitz authored
-
- 17 Jan, 2019 1 commit
-
-
Ian Hickson authored
* Fixes Android keyboard bug
-
- 14 Jan, 2019 2 commits
-
-
Justin McCandless authored
* Allow a widget to be specified for the textfield count, and allow no count at all * Test all possible states for counter and counterText * Docs for counter * counter is a function that generates a widget * Tests use counter as function * Fix analyze error in docs * InputDecoration has counter widget, TextField has buildCounter function * InputDecorator tests expect counter to be widget again and include buildCounter * counter widget example that might actually fit * Clarify accessiblity concerns in docs * Include isFocused param for accessibility * Fix analyze error * Improve docs per code review * Rearrange getEffectiveDecoration a bit for clarity * Fix analyze error about hashValues params * Clean up docs and redundant code per code review * Code review doc improvement * Automatically wrap buildCounter widget in a Semantics widget for accessibility
-
jslavitz authored
* adds force press select word functionality
-
- 09 Jan, 2019 1 commit
-
-
jslavitz authored
* the onStart callback will report the location of the pointer where it wins the gesture arena by default instead of the pointer down location. Fixes all tests related to changing this default value.
-
- 08 Jan, 2019 1 commit
-
- 07 Jan, 2019 1 commit
-
-
jslavitz authored
* Adds start behavior option to the drag gesture recognizer and makes it the default option when a drag gesture recognizer is created. Also fixes all the tests to work correctly with the new default behavior.
-
- 04 Jan, 2019 1 commit
-
-
Hans Muller authored
-
- 21 Dec, 2018 1 commit
-
-
xster authored
-
- 18 Dec, 2018 3 commits
-
-
Alexandre Ardhuin authored
-
Gary Qian authored
-
Hans Muller authored
-
- 17 Dec, 2018 1 commit
-
-
Justin McCandless authored
* Revert "Add imports section to sample code templates, and more docs. (#25184)" This reverts commit 95b01247. * Revert "Use stderr instead of stdout to contain errors in flutter attach test (#25305)" This reverts commit 2b819dd2. * Revert "Allow detection of taps on TabBar (#23919)" This reverts commit 01694ab6. * Revert "a549981da Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter/engine#7211) (#25333)" This reverts commit a37099f3. * Revert "Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)" This reverts commit c5457068. * Password fields are no longer selectable nor copiable
-
- 14 Dec, 2018 4 commits
-
-
jslavitz authored
* Adds support for floating cursor.
-
S McDowall authored
-
Jonah Williams authored
This reverts commit 46878d84.
-
jslavitz authored
* Adds support for floating cursor!
-
- 13 Dec, 2018 3 commits
-
-
Justin McCandless authored
This reverts commit f8f5953d.
-
Justin McCandless authored
* obscureText true defaults to disabling selection * Tests and comments for selectable text field * Improve selection docs * Refactor so that all enableInteractiveSelection params are null by default, delegate to selectionEnabled * Fix selection param macros
-
Justin McCandless authored
* Merge TextField style with global style so that style changes don't override unspecified fields * Test that a style param is merged with the theme * Test a few more style properties * Analysis fix
-
- 12 Dec, 2018 1 commit
-
-
Justin McCandless authored
* Validate style in TextField * Fix analyze problems * Use assert and move to top * Simplified assertion
-