- 28 Feb, 2024 15 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/91898e397261...c9381fb8ef4c 2024-02-28 dnfield@google.com Revert "Bump everything to Android 21" (flutter/engine#51056) 2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 0c294ee206e8 to 93f245da0097 (2 revisions) (flutter/engine#51055) 2024-02-28 jonahwilliams@google.com [Android] update fallback and rendering state to combine impeller + android backend. (flutter/engine#51008) 2024-02-28 bdero@google.com [Impeller] Fix GL depth state. (flutter/engine#51040) 2024-02-28 chris@bracken.jp Roll buildroot to 7b537de78ac2239982ace130d1845374e5dcf113 (flutter/engine#51053) 2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d935943bedcd to 0c294ee206e8 (3 revisions) (flutter/engine#51051) 2024-02-28 zanderso@users.noreply.github.com When run_tests.py is in --quiet mode, write verbose logs to a file (flutter/engine#51029) 2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from fe34002ee826 to d935943bedcd (1 revision) (flutter/engine#51049) 2024-02-28 dnfield@google.com Bump everything to Android 21 (flutter/engine#51032) 2024-02-28 jiahaog@users.noreply.github.com Add flutter prefix to import (flutter/engine#51042) 2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d591703635b0 to fe34002ee826 (1 revision) (flutter/engine#51048) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
Reland https://github.com/flutter/flutter/pull/143244. It was reverted due to https://github.com/flutter/flutter/issues/144251, which is fixed by https://github.com/flutter/engine/pull/51023.
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/143010. This is intended to be cherrypicked into the 3.19 and 3.20 releases. Long-term, we should deprecate this feature: https://github.com/flutter/flutter/issues/144191
-
🛡 Alex Li authoredPartial resolution for #63559 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes
-
Zachary Anderson authored
91898e3972 Process FlutterMacOS.framework before creating xcframework (https://github.com/flutter/engine/pull/51023) c873ade1f1 Roll Skia from a55a65d65378 to d591703635b0 (1 revision) (https://github.com/flutter/engine/pull/51046) 3feed45f0b Roll Skia from cce35b54379c to a55a65d65378 (3 revisions) (https://github.com/flutter/engine/pull/51045) 886ff23042 Roll Dart SDK from 44af84628b90 to 7896a944fe67 (1 revision) (https://github.com/flutter/engine/pull/51043) fa691b8cee Roll Skia from a673ab63fccc to cce35b54379c (3 revisions) (https://github.com/flutter/engine/pull/51036)
-
Zachary Anderson authored
8acc96d405 Roll Dart SDK from 1e6b559fae88 to 44af84628b90 (1 revision) (https://github.com/flutter/engine/pull/51035) 632f9d742d Roll Skia from 84c60d70fbbd to a673ab63fccc (1 revision) (https://github.com/flutter/engine/pull/51034) 5c09604bd6 Null-assert the value given to a Completer expecting a non-null value (https://github.com/flutter/engine/pull/49053) 055ede728c Roll Dart SDK from a0e3c16eea3e to 1e6b559fae88 (1 revision) (https://github.com/flutter/engine/pull/51025) d6bca2a382 [Windows] Reduce log level of unsupported accessibility event message (https://github.com/flutter/engine/pull/51024) 8fa1141b46 Roll Skia from c8703c91675e to 84c60d70fbbd (4 revisions) (https://github.com/flutter/engine/pull/51021)
-
Zachary Anderson authored
64a375de9c [Windows] Make the engine own a map of views (https://github.com/flutter/engine/pull/51017) 73480bf11d Rename some classes in the engine_build_configs package (https://github.com/flutter/engine/pull/51016) 2756f14a46 Remove rewrapper prefix from compiler commands for clang-tidy (https://github.com/flutter/engine/pull/51001) 0f727a5b31 Improve, test, and fix a bug related to `adb logcat` filtering. (https://github.com/flutter/engine/pull/51012) ab4d6db3f1 Move vulkan-deps to //flutter/third_party/vulkan-deps (https://github.com/flutter/engine/pull/51013)
-
auto-submit[bot] authored
Reverts flutter/flutter#144207 Initiated by: CaseyHillers Reason for reverting: b/327301206 - Breaking a customer test Original PR Author: LongCatIsLooong Reviewed By: {gspencergoog} This change reverts the following previous change: Original Description: `FocusNode.canRequestFocus` was doing a double traversal if no ancestor disallows focus. The last for loop only has to reach as far as the enclosing scope. Also this caches the `FocusNode.enclosingScope` since the getter access happens much more frequently than node reparenting.
-
Zachary Anderson authored
c79117b706 [Windows] Remove TODONE (https://github.com/flutter/engine/pull/51005) 24c7b03ef0 [Windows] Introduce an accessibility plugin (https://github.com/flutter/engine/pull/50975) c805e43957 Roll Skia from 1beae57ea0dd to c8703c91675e (1 revision) (https://github.com/flutter/engine/pull/51014) 17dff87ef3 [Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error (https://github.com/flutter/engine/pull/50951) 8457d10473 Roll Dart SDK from be6be2b9ba6e to a0e3c16eea3e (3 revisions) (https://github.com/flutter/engine/pull/51015)
-
Zachary Anderson authored
2461280c38 Roll Fuchsia Linux SDK from JCdhkDSFXzHyPuP4I... to T1xAi_ww_mWEiDkVN... (https://github.com/flutter/engine/pull/51011) 8940ea0887 Code consistency fixes in FlScrollingManager (https://github.com/flutter/engine/pull/50959) 21474ee4a4 [macOS] Use CVDisplayLink to drive repaint (https://github.com/flutter/engine/pull/49159) 6f7b939568 Fail lazily when 1+ Skia gold comparions fail. (https://github.com/flutter/engine/pull/51010) 249daf5512 Adjust Android emulator test timeouts (https://github.com/flutter/engine/pull/51004)
-
Zachary Anderson authored
5e0d9ba35d Roll Skia from 636e136b0da9 to 1beae57ea0dd (3 revisions) (https://github.com/flutter/engine/pull/51007) 63b6117514 [skwasm] Clip pictures if they go beyond the bounds of the window. (https://github.com/flutter/engine/pull/50887) cd57dc9b4c GLES for scenario_app tests using Impeller (https://github.com/flutter/engine/pull/51000) ef4c205239 Roll Skia from d5ca52bc7739 to 636e136b0da9 (8 revisions) (https://github.com/flutter/engine/pull/51006) 8b240244ef [Fuchsia] Use shared gn-sdk from chromium (https://github.com/flutter/engine/pull/50855)
-
Zachary Anderson authored
fe7ea6d9c3 Reland "Implement Frame Timing callbacks in Skwasm" (#50987) 1a5c26421b Move protobuf to //flutter/third_party (#50997) 1f9224056c Roll Skia from 2f2a718b27f7 to d5ca52bc7739 (3 revisions) (#51003) 5403c24990 Roll Dart SDK from 67b2a250747b to be6be2b9ba6e (1 revision) (#51002) 4addb6a07c Actually use Impeller in scenario_app tests (#50977)
-
Polina Cherkasova authored
-
Taha Tesser authored
This a test utility class for `tabs_test.dart` to prepare the class for Material 3 tests updates. More info in https://github.com/flutter/flutter/issues/139076
-
Qun Cheng authored
This PR is to remove deprecated ThemeData.bottomAppBarColor. These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162. Part of https://github.com/flutter/flutter/pull/111080
-
- 27 Feb, 2024 18 commits
-
-
ufolux authored
*Fixed the issue with abnormal Chinese punctuation marks.*
-
Elias Yishak authored
Fixes: - https://github.com/dart-lang/tools/issues/234 Bumps the version for package:unified_analytics and removes TODOs and lint ignores
-
hangyu authored
Reland #143334
-
LongCatIsLooong authored
It was deprecated in https://github.com/flutter/flutter/pull/110616. Deprecated in https://github.com/flutter/flutter/pull/110616
-
Chris Bracken authored
This applies minor cosmetic cleanups noticed while landing fix/tests in another patch. Renames `incrementLabel` to `countLabel` and `setIncrementLabel` to `updateCountLabel`, since it's not setting it to a specific value but rather updating itself based on the current state of the `count` ivar. No tests since this patch introduces no semantic changes. Related: https://github.com/flutter/flutter/pull/132028
-
auto-submit[bot] authored
Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (#144262) Reverts flutter/flutter#144001 Initiated by: Piinks Reason for reverting: Failing goldens at the tip of tree Original PR Author: QuncCccccc Reviewed By: {HansMuller} This change reverts the following previous change: Original Description: Reverts flutter/flutter#143973 This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
-
auto-submit[bot] authored
Reverts flutter/flutter#143244 Initiated by: vashworth Reason for reverting: Increased `flutter_framework_uncompressed_bytes` - see https://github.com/flutter/flutter/issues/144251 Original PR Author: vashworth Reviewed By: {jmagman} This change reverts the following previous change: Original Description: Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`. Part of https://github.com/flutter/flutter/issues/126016.
-
Martin Kustermann authored
So far `flutter build web --wasm` was always stripping wasm symbols except if `--no-strip-wasm` is passed. => Ensure that in profile mode we also keep the symbols
-
Qun Cheng authored
Reverts flutter/flutter#143973 This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
-
Roger authored
In the `examples/platform_view` example, which demonstrates transitioning from a Flutter view to a general iOS UIView and back, as well as using channels to communicate between the two, the Flutter view renders correctly, but in the iOS UIView, the FAB equivalent button in the lower-right corner is rendered without the '+' icon. This is because no binding as declared for the add icon in the storyboard. This adds the missing binding. Further, this eliminates the use of the deprecated [UIButtonTypeRoundedRect](https://developer.apple.com/documentation/uikit/uibuttontype/uibuttontyperoundedrect?language=objc), falling back to the default instead. --------- Co-authored-by: Chris Bracken <chris@bracken.jp>
-
LongCatIsLooong authored
`FocusNode.canRequestFocus` was doing a double traversal if no ancestor disallows focus. The last for loop only has to reach as far as the enclosing scope. Also this caches the `FocusNode.enclosingScope` since the getter access happens much more frequently than node reparenting.
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/142969. G3fix: cl/610790040
-
Victoria Ashworth authored
Now that all tests are on Xcode 15 and iOS 17, we no longer need to force test Xcode debug workflow. Related https://github.com/flutter/flutter/issues/144020.
-
-
Victoria Ashworth authored
Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`. Part of https://github.com/flutter/flutter/issues/126016.
-
Jonah Williams authored
The issues in flutter/flutter#144115 should be fixed with the removal of the incorrect render pass caching behavior in https://github.com/flutter/engine/pull/50976
-
Jia Hao authored
When the daemon throws an exception, the receiving client is unable to surface stack traces from the daemon. This is because it is sent with the `trace` key here: https://github.com/flutter/flutter/blob/1e8dd1e4d6d70c5e06525bea3fb164a03d7a6c1d/packages/flutter_tools/lib/src/daemon.dart#L308 But the client tries to read it with the `stackTrace` key here: https://github.com/flutter/flutter/blob/1e8dd1e4d6d70c5e06525bea3fb164a03d7a6c1d/packages/flutter_tools/lib/src/daemon.dart#L343 Thanks to @mraleph for spotting this! *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* b/326825892
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/04ff2868ce80...0bc21ea7bc92 2024-02-27 matanlurey@users.noreply.github.com Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989) 2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter/engine#50998) 2024-02-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996) 2024-02-27 matanlurey@users.noreply.github.com Fix usage of `--out-dir` with a relative path. (flutter/engine#50992) 2024-02-27 jason-simmons@users.noreply.github.com Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter/engine#50991) 2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate Android `scenario_app` to the `SurfaceProducer` API (#50993)" (flutter/engine#50995) 2024-02-27 matanlurey@users.noreply.github.com Migrate Android `scenario_app` to the `SurfaceProducer` API (flutter/engine#50993) 2024-02-27 dkwingsmt@users.noreply.github.com Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985) 2024-02-26 matanlurey@users.noreply.github.com Refactor args parsing/environment constructor for `scenario_app` (flutter/engine#50980) 2024-02-26 jonahwilliams@google.com [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981) 2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983) 2024-02-26 skia-flutter-autoroll@skia.org Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979) 2024-02-26 zanderso@users.noreply.github.com Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327) 2024-02-26 jonahwilliams@google.com [Impeller] disble render pass caches. (flutter/engine#50976) 2024-02-26 john@johnmccutchan.com Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971) 2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883) 2024-02-26 matanlurey@users.noreply.github.com Better filtering for Android `scenario_app` runner. (flutter/engine#50937) 2024-02-26 jacksongardner@google.com Make sure to call `setHeightOverride` as well on TextStyle and StrutStyle (flutter/engine#50920) 2024-02-26 jacksongardner@google.com Correctly offset the cull rect of the opacity layer. (flutter/engine#50928) 2024-02-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kLvCWEgbL1VT to JCdhkDSFXzHy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 26 Feb, 2024 7 commits
-
-
Polina Cherkasova authored
Contributes to https://github.com/dart-lang/leak_tracker/issues/218
-
Nate authored
This is a very small change that fixes #143664.
-
-
Gustl22 authored
Part of #137040 and #80374 - Differentiate pubspec and resolution errors - Rename platform to platformKey - Add TODO for rework logic of flag [throwOnPluginPubspecError] - Swap for loop: handle by platform and then by plugin
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/34a8b9bdaaac...04ff2868ce80 2024-02-26 zanderso@users.noreply.github.com [et] Improve the logger for the ninja build, adds a spinner (flutter/engine#50952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Nate authored
This pull request is part of the effort to solve issue #136139. The previous [`switch` expressions PR](https://github.com/flutter/flutter/pull/143496) was comprised of many simple changes throughout `flutter/lib/src/`, but due to some more in-depth refactoring in `flutter/lib/src/rendering/`, I decided to submit the changes to this directory as a separate pull request. There was really just one function that I changed significantly; I'll add a comment for explanation.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7a573c21a4ad...34a8b9bdaaac 2024-02-26 109111084+yaakovschectman@users.noreply.github.com Add Platform View Manager to Windows shell (flutter/engine#50598) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-